Attention is currently required from: Thomas Heijligen, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60110 )
Change subject: hwaccess: move x86 port I/O related code into own files
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/60110/comment/4ffd3f35_d89a2fa8
PS5, Line 786: x86
Should we guard this by ARCH,x86 right away? Then we wouldn't need
the x86 checks inside the file, which would better match the name.
(removing the checks could be a follow-up)
--
To view, visit https://review.coreboot.org/c/flashrom/+/60110
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I372b4a409f036da766c42bc406b596bc41b0f75a
Gerrit-Change-Number: 60110
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Tue, 21 Dec 2021 17:05:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60107 )
Change subject: Makefile: merge compiler, hwlibs, features targets into config target
......................................................................
Patch Set 2:
(3 comments)
File Makefile:
https://review.coreboot.org/c/flashrom/+/60107/comment/58b56aaa_94339182
PS2, Line 918: %.o: %.c config
: $(CC) -MMD $(CFLAGS) $(CPPFLAGS) $(FLASHROM_CFLAGS) $(FEATURE_CFLAGS) $(SCMDEF) -o $@ -c $<
:
:
: $(PROGRAM)$(EXEC_SUFFIX): $(OBJS)
: $(CC) -o $(PROGRAM)$(EXEC_SUFFIX) $(OBJS) $(LDFLAGS)
:
: libflashrom.a: $(LIBFLASHROM_OBJS)
: $(AR) rcs $@ $^
: $(RANLIB) $@
:
: # TAROPTIONS reduces information leakage from the packager's system.
: # If other tar programs support command line arguments for setting uid/gid of
: # stored files, they can be handled here as well.
: TAROPTIONS = $(shell LC_ALL=C tar --version|grep -q GNU && echo "--owner=root --group=root")
:
:
: # Make sure to add all names of generated binaries here.
: # This includes all frontends and libflashrom.
: # We don't use EXEC_SUFFIX here because we want to clean everything.
: clean:
: rm -f $(PROGRAM) $(PROGRAM).exe libflashrom.a $(filter-out Makefile.d, $(wildcard *.d *.o)) $(PROGRAM).8 $(PROGRAM).8.html $(BUILD_DETAILS_FILE)
: @+$(MAKE) -C util/ich_descriptors_tool/ clean
:
: distclean: clean
: rm -f .libdeps
:
: strip: $(PROGRAM)$(EXEC_SUFFIX)
: $(STRIP) $(STRIP_ARGS) $(PROGRAM)$(EXEC_SUFFIX)
> This looks like it all just moved without changes. Could it be done in a […]
Ack
https://review.coreboot.org/c/flashrom/+/60107/comment/6a85e796_a6d177db
PS2, Line 948: # to define test programs we use verbatim variables, which get exported
: # to environment variables and are referenced with $$<varname> later
> Is this still true?
I think this is obsolete by now.
https://review.coreboot.org/c/flashrom/+/60107/comment/894c72a9_d6a2839c
PS2, Line 953:
> Also, two empty lines should be enough :)
Ack
--
To view, visit https://review.coreboot.org/c/flashrom/+/60107
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic76f923bca2beb6f95b8ea0cced4569b07e9b9ba
Gerrit-Change-Number: 60107
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Tue, 21 Dec 2021 17:01:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Attention is currently required from: Thomas Heijligen.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60107 )
Change subject: Makefile: merge compiler, hwlibs, features targets into config target
......................................................................
Patch Set 2: Code-Review+1
(4 comments)
Patchset:
PS2:
Looks good but would probably be easier to verify as separate commits.
File Makefile:
https://review.coreboot.org/c/flashrom/+/60107/comment/88a727d7_71828992
PS2, Line 918: %.o: %.c config
: $(CC) -MMD $(CFLAGS) $(CPPFLAGS) $(FLASHROM_CFLAGS) $(FEATURE_CFLAGS) $(SCMDEF) -o $@ -c $<
:
:
: $(PROGRAM)$(EXEC_SUFFIX): $(OBJS)
: $(CC) -o $(PROGRAM)$(EXEC_SUFFIX) $(OBJS) $(LDFLAGS)
:
: libflashrom.a: $(LIBFLASHROM_OBJS)
: $(AR) rcs $@ $^
: $(RANLIB) $@
:
: # TAROPTIONS reduces information leakage from the packager's system.
: # If other tar programs support command line arguments for setting uid/gid of
: # stored files, they can be handled here as well.
: TAROPTIONS = $(shell LC_ALL=C tar --version|grep -q GNU && echo "--owner=root --group=root")
:
:
: # Make sure to add all names of generated binaries here.
: # This includes all frontends and libflashrom.
: # We don't use EXEC_SUFFIX here because we want to clean everything.
: clean:
: rm -f $(PROGRAM) $(PROGRAM).exe libflashrom.a $(filter-out Makefile.d, $(wildcard *.d *.o)) $(PROGRAM).8 $(PROGRAM).8.html $(BUILD_DETAILS_FILE)
: @+$(MAKE) -C util/ich_descriptors_tool/ clean
:
: distclean: clean
: rm -f .libdeps
:
: strip: $(PROGRAM)$(EXEC_SUFFIX)
: $(STRIP) $(STRIP_ARGS) $(PROGRAM)$(EXEC_SUFFIX)
This looks like it all just moved without changes. Could it be done in a
separate commit?
https://review.coreboot.org/c/flashrom/+/60107/comment/9ccff5f4_8b4fbdba
PS2, Line 948: # to define test programs we use verbatim variables, which get exported
: # to environment variables and are referenced with $$<varname> later
Is this still true?
https://review.coreboot.org/c/flashrom/+/60107/comment/e71bf83f_b28076d6
PS2, Line 953:
Also, two empty lines should be enough :)
--
To view, visit https://review.coreboot.org/c/flashrom/+/60107
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic76f923bca2beb6f95b8ea0cced4569b07e9b9ba
Gerrit-Change-Number: 60107
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Comment-Date: Tue, 21 Dec 2021 16:54:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59230 )
Change subject: Makefile: cleanup
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/flashrom/+/59230
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1c9e869377677d624469af1ee9ece9a28fc3b559
Gerrit-Change-Number: 59230
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Tue, 21 Dec 2021 16:53:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59048 )
Change subject: Makefile: Make pkg-config mandatory to find libjaylink
......................................................................
Patch Set 12:
(1 comment)
Patchset:
PS11:
> NB. We could update Manibuilder tests that don't need an explicit […]
I've an idea for this and would implement it on top of this series.
--
To view, visit https://review.coreboot.org/c/flashrom/+/59048
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I99df547046bb9820ab502f89f6d4452c1bc0cfd4
Gerrit-Change-Number: 59048
Gerrit-PatchSet: 12
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Tue, 21 Dec 2021 16:51:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Attention is currently required from: Thomas Heijligen.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59050 )
Change subject: Makefile: Make pkg-config mandatory to find libpci
......................................................................
Patch Set 13: Code-Review+1
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/59050/comment/7e673cd1_494e8e3e
PS7, Line 772: # This is a dirty hack, but it saves us from checking all PCI drivers and all platforms manually.
: # libpci may need raw memory, MSR or PCI port I/O on some platforms.
: # Individual drivers might have the same needs as well.
> We should split pci programmers to DEPENDS_ON_IO_PORTS, DEPENDS_ON_RAW_MEM_ACCESS, DEPENDS_ON_X86_MS […]
Yes, eventually, but for now I would just keep the comment above
`USE_RAW_ACCESS := yes`.
--
To view, visit https://review.coreboot.org/c/flashrom/+/59050
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I21b4a261b34b7e688635fc6e20b7beebfa64c7ed
Gerrit-Change-Number: 59050
Gerrit-PatchSet: 13
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Comment-Date: Tue, 21 Dec 2021 16:42:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de>
Gerrit-MessageType: comment
Attention is currently required from: Thomas Heijligen.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58623 )
Change subject: Makefile: Make pkg-config mandatory to find libftdi1
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
File Makefile.include:
https://review.coreboot.org/c/flashrom/+/58623/comment/575e4981_83a81da5
PS5, Line 40: 2>/dev/null
> I've replaced $(shell ...) by $(call debug_shell, ...) to get this upstream. But I'm not a fan of this.
Thank you, I was about to propose this. I also hope it won't stay long.
Once we do everything in a recipe, I guess, we won't have to hide stderr
anymore. Because then the output of any probing command can be
synchronized with our reporting of tested features.
--
To view, visit https://review.coreboot.org/c/flashrom/+/58623
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I41f5186d9f3e063c12c8c6eea888d0b0bf534259
Gerrit-Change-Number: 58623
Gerrit-PatchSet: 9
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Comment-Date: Tue, 21 Dec 2021 16:16:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Nico Huber, Edward O'Callaghan, Anastasia Klimchuk, Nikolai Artemiev.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58735 )
Change subject: ichspi: Split very long init function into two
......................................................................
Patch Set 2: Code-Review+1
(4 comments)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/58735/comment/25bc9f2d_f4921a3a
PS1, Line 1836: arg);
> Another unnecessary line break.
This is addressed in the follow-up commit, can we leave this as-is in this commit?
https://review.coreboot.org/c/flashrom/+/58735/comment/36f5fd9e_2234312c
PS1, Line 1917: );
> Drop line break?
yeah, the line break before `);` looks really odd.
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/58735/comment/3c66b125_d75e4ae8
PS2, Line 1822: arg = extract_programmer_param("ich_spi_mode");
I use a very stupid trick to minimise diffstat noise when reindenting blocks of code during refactoring: I change the indentation in a separate, reproducible commit, so that the diffstat of the non-reproducible part is much smaller.
I've done this several times when refactoring coreboot code. For example, I wanted to refactor some chipset code, but all mainboards would need to be adapted. I started with CB:46702 CB:46703 CB:46704 CB:46705 to do nearly all changes to mainboard code reproducibly. I also had to make CB:46769 to ensure things would work properly, and CB:46700 did the actual refactoring.
Another example of how I break down refactoring changes to hopefully ease review: CB:49398 changes behavior but is very small, CB:49399 is not reproducible but doesn't change behavior, and CB:49400 is quite large but reproducible.
There's no need to change this commit, it's just that it reminded me of similar situations I've encountered, and I wanted to describe an approach I came up with. However, if you think this idea might make this change easier to review, feel free to use it. 😊
https://review.coreboot.org/c/flashrom/+/58735/comment/cb90c5df_4fc78b53
PS2, Line 1769:
I'd normally complain about unrelated whitespace changes (this seems accidental), but addressing this would mean having to manually rebase the follow-up change as well. If you don't mind, I'd appreciate if you could undo this.
--
To view, visit https://review.coreboot.org/c/flashrom/+/58735
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6789bc456a4878e6555831ae0b80ecbdbf62938b
Gerrit-Change-Number: 58735
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Tue, 21 Dec 2021 10:55:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment