Attention is currently required from: Nico Huber, Thomas Heijligen, Paul Menzel, Edward O'Callaghan.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61194 )
Change subject: hwaccess: fix build on non-x86 targets
......................................................................
Patch Set 7:
(1 comment)
File hwaccess_x86_msr.h:
https://review.coreboot.org/c/flashrom/+/61194/comment/24a99ef6_04bfb602
PS6, Line 53:
> While this is a fix, it's unrelated to this change now.
Reverted.
--
To view, visit https://review.coreboot.org/c/flashrom/+/61194
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I20f122679c30340b2c73afd7419e79644ddc3c4e
Gerrit-Change-Number: 61194
Gerrit-PatchSet: 7
Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Comment-Date: Mon, 24 Jan 2022 02:03:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Attention is currently required from: Thomas Heijligen, Paul Menzel, Edward O'Callaghan, Peter Marheine.
Hello build bot (Jenkins), Nico Huber, Thomas Heijligen, Edward O'Callaghan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/61194
to look at the new patch set (#7).
Change subject: hwaccess: fix build on non-x86 targets
......................................................................
hwaccess: fix build on non-x86 targets
The changes to hwaccess in commit 49d758698a0dd166679c48b1a2785e50e9b0cc83
cause build failure on non-x86 systems because the hwaccess_x86_*
headers are included in some files that are built for all platforms
(particularly those in the internal programmer) and those headers in
turn include <sys/io.h> which only exists on x86.
This change makes the hwaccess_x86 headers a nop on non-x86 platforms so
the internal programmer can be built without errors.
The comment on the stub implementation of rget_io_perms() is also
modified to remove references to non-x86 platforms, since that file is
only built on x86 now.
BUG=None
TEST=meson build succeeds for both x86 and ARM targets
Signed-off-by: Peter Marheine <pmarheine(a)chromium.org>
Change-Id: I20f122679c30340b2c73afd7419e79644ddc3c4e
---
M board_enable.c
M chipset_enable.c
M hwaccess_x86_io.c
M internal.c
4 files changed, 16 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/94/61194/7
--
To view, visit https://review.coreboot.org/c/flashrom/+/61194
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I20f122679c30340b2c73afd7419e79644ddc3c4e
Gerrit-Change-Number: 61194
Gerrit-PatchSet: 7
Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nico Huber, Edward O'Callaghan.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60070 )
Change subject: flashrom.c: Move do_*() helpers into cli_classic.c
......................................................................
Patch Set 5:
(1 comment)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/60070/comment/1a697fd5_a906f3a4
PS2, Line 156:
: static
> cli_common is maybe a better place.
I like the idea of cli_common because cli_classic is already really large :\ I am not entirely sure what it is common with, because there is only one cli (only classic one, no alternatives), but maybe that's historical naming.
On the other hand, moving this to cli_common means includes in flash.h are needed again?
--
To view, visit https://review.coreboot.org/c/flashrom/+/60070
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If1112155e2421e0178fd73f847cbb80868387433
Gerrit-Change-Number: 60070
Gerrit-PatchSet: 5
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Comment-Date: Mon, 24 Jan 2022 02:00:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Thomas Heijligen.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61300 )
Change subject: Makeile: reenable internal programmer for mipsel
......................................................................
Patch Set 3:
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/61300/comment/840926d1_0da99e44
PS3, Line 332: # Disable the internal programmer on unsupported architectures (everything but x86 and mipsel)
> (mark_unsupported) works fine, it's just hard to understand what it does.
I see; it doesn't do what I thought it did, but makes some amount of sense.
> it only happened to work ... when using Meson
I don't understand why it worked, but I believe builds were using internal on ARM even before Meson support existed. I see from history that Meson support wasn't added until years after the change to mark other architectures as unsupported for internal, so it was still being built somehow.
> We can change that behavior of course, as I depicted earlier. I think we should just do that.
I agree, assumming I've understood you correctly. There are now users depending on the MTD delegation in internal, so it should be made to build on all (Linux with MTD support) systems.
--
To view, visit https://review.coreboot.org/c/flashrom/+/61300
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia607ea60c3d7d15fe231fa412595992dadc535ad
Gerrit-Change-Number: 61300
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Comment-Date: Mon, 24 Jan 2022 01:59:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de>
Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Thomas Heijligen, Peter Marheine.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61300 )
Change subject: Makeile: reenable internal programmer for mipsel
......................................................................
Patch Set 3:
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/61300/comment/3254e3d1_f8b535ad
PS3, Line 332: # Disable the internal programmer on unsupported architectures (everything but x86 and mipsel)
> Uff, so on x86 platform which have an mtd driver the original internal programmer is broken when CONFIG_LINUX_MTD is compiled in?
No, not broken. It would just prefer a useable MTD interface (i.e.
a kernel driver) over flashrom's own drivers.
> mark_unsupported sets the CONFIG option with an override to no and prevents the build at the end of the config target.
No, it does either one of these. If a CONFIG option is explicitly set
to yes, e.g. on the command line, it would fail with the unsupported
message. But if it's not explicitly set to `yes`, it's set to `no`.
(it's an if/else, easy to miss the comma that starts the else :-/)
--
To view, visit https://review.coreboot.org/c/flashrom/+/61300
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia607ea60c3d7d15fe231fa412595992dadc535ad
Gerrit-Change-Number: 61300
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Comment-Date: Mon, 24 Jan 2022 01:50:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de>
Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Peter Marheine.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61300 )
Change subject: Makeile: reenable internal programmer for mipsel
......................................................................
Patch Set 3:
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/61300/comment/b04ed988_cdd1142c
PS3, Line 332: # Disable the internal programmer on unsupported architectures (everything but x86 and mipsel)
> processor_flash_enable() is only called after try_mtd() on line 255, which will skip the rest of the […]
Uff, so on x86 platform which have an mtd driver the original internal programmer is broken when CONFIG_LINUX_MTD is compiled in?
mark_unsupported sets the CONFIG option with an override to no and prevents the build at the end of the config target.
--
To view, visit https://review.coreboot.org/c/flashrom/+/61300
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia607ea60c3d7d15fe231fa412595992dadc535ad
Gerrit-Change-Number: 61300
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Comment-Date: Mon, 24 Jan 2022 01:42:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de>
Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Edward O'Callaghan, Daniel Campello, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60069 )
Change subject: flashrom.c: Make {read,write}_buf_from_include_args() public
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File flash.h:
https://review.coreboot.org/c/flashrom/+/60069/comment/78d9552e_c6b7a131
PS3, Line 353: read_buf_from_include_args
> The layout/flashrom refactor would look something like this https://review.coreboot. […]
Ok, I can see the point about public API
--
To view, visit https://review.coreboot.org/c/flashrom/+/60069
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia0abec655a682ca449d0e8ba620886a2d616b86d
Gerrit-Change-Number: 60069
Gerrit-PatchSet: 5
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Daniel Campello <campello(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Mon, 24 Jan 2022 01:31:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org>
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Thomas Heijligen, Paul Menzel, Edward O'Callaghan, Peter Marheine.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61194 )
Change subject: hwaccess: fix build on non-x86 targets
......................................................................
Patch Set 6: Code-Review+1
(2 comments)
Patchset:
PS1:
> I've moved the inclusions of the x86 headers around to fit in existing guards where possible, though […]
Thanks.
File hwaccess_x86_msr.h:
https://review.coreboot.org/c/flashrom/+/61194/comment/7379a411_201b0a7d
PS6, Line 53:
While this is a fix, it's unrelated to this change now.
--
To view, visit https://review.coreboot.org/c/flashrom/+/61194
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I20f122679c30340b2c73afd7419e79644ddc3c4e
Gerrit-Change-Number: 61194
Gerrit-PatchSet: 6
Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Comment-Date: Mon, 24 Jan 2022 01:29:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de>
Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Thomas Heijligen, Peter Marheine.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61300 )
Change subject: Makeile: reenable internal programmer for mipsel
......................................................................
Patch Set 3:
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/61300/comment/1c2596df_125fa598
PS3, Line 332: # Disable the internal programmer on unsupported architectures (everything but x86 and mipsel)
> mark_unsupported only works as expected if CONFIG_INTERNAL is explicitly set.
It works fine, it's just hard to understand what it does. Traditionally,
we only complain about something unsupported if the user requested it
explicitly. If they didn't, mark_unsupported sets it to `no` silently.
The default later in this file isn't applied then.
> CONFIG_INTERNAL is defaulted to yes further down the file, so it looks like the internal programmer can still be built as long as it's not explicitly enabled even with this change. I'm guessing nobody noticed that this conflicted with the MTD support because this disablement didn't work, with the end result that this mark_unsupported is now incorrect because internal is meant to work on other platforms when MTD is available.
>
No idea what you are talking about. The internal programmer is not meant
to work on other platforms, it only happened to work since the MTD intro-
duction and when using Meson. I just checked some ARM builds using `make`
and `internal` is disabled automatically as it should be. Given that there
were build errors with Meson, it's obvious: Build tests with the Makefile
would have failed too. We can change that behavior of course, as I depicted
earlier. I think we should just do that. If it builds for MIPSEL, it should
build for other architectures too. So we only have to treat x86 specially.
--
To view, visit https://review.coreboot.org/c/flashrom/+/61300
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia607ea60c3d7d15fe231fa412595992dadc535ad
Gerrit-Change-Number: 61300
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Comment-Date: Mon, 24 Jan 2022 01:25:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de>
Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Edward O'Callaghan.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61286 )
Change subject: flashrom.c: Move {read,write}_buf_from_include_args() to layout
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Yes, but it is something Anastasia wanted to see what it looked like in CB:60069 . […]
Yes I asked because I noticed the rest of xxx_include_args functionality lives in layout.h. Maybe all of that belongs to CLI, but currently it is here.
Looking for example at `register_include_arg` , it is parsing command line - but it lives here?
--
To view, visit https://review.coreboot.org/c/flashrom/+/61286
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I61d4460ea26e07b67c99baeae5cb3840c25cb913
Gerrit-Change-Number: 61286
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Comment-Date: Mon, 24 Jan 2022 01:24:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: comment