Attention is currently required from: Nico Huber, Thomas Heijligen, Paul Menzel, Edward O'Callaghan, Peter Marheine.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61194 )
Change subject: hwaccess: fix build on non-x86 targets
......................................................................
Patch Set 7:
(1 comment)
File hwaccess_x86_io.c:
https://review.coreboot.org/c/flashrom/+/61194/comment/8b25fe85_756c6d6d
PS7, Line 82: /* PCI port I/O support is unimplemented on PPC/MIPS and unavailable on ARM. */
Where did this go?
--
To view, visit https://review.coreboot.org/c/flashrom/+/61194
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I20f122679c30340b2c73afd7419e79644ddc3c4e
Gerrit-Change-Number: 61194
Gerrit-PatchSet: 7
Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Comment-Date: Mon, 24 Jan 2022 12:38:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60711 )
Change subject: Add Elkhart Lake support
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/60711/comment/961cf5ae_2cd98383
PS2, Line 15: TEST=Read and flash complete flash on Siemens MC EHL1
> Some tests with --ifd and writing only specific regions would be nice […]
I have tried writing just the BIOS region with
flashrom -p internal --ifd -i bios -w coreboot.rom
and it went all smooth so far.
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/60711/comment/15832eed_b802c7ef
PS1, Line 1033: return CHIPSET_500_SERIES_TIGER_POINT;
> Please also test if it detects the right platform. Should be easy […]
You nailed it, Nico.
I have tried 'util/ich_descriptors_tool/ich_descriptors_tool -f coreboot.rom' with my latest mc_ehl1 coreboot image and got:
Unknown flash descriptor, assuming 500 series compatibility.
Assuming chipset '500 series Tiger Point'.
A closer look showed that neither FLMAP1 nor FLMAP2 matches the documented settings in the SPI guide (especially the "Set to xx" comment in the register description). This is true for at least two different FIT versions I have tested as well as for the UEFI release for the Elkhart Lake CRB.
I will reach out to Intel to clarify the discrepancy so that we have a chance to make it right. Will report any update here.
--
To view, visit https://review.coreboot.org/c/flashrom/+/60711
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I711e39a3ec9cd7098389231eaa1cb864d615a475
Gerrit-Change-Number: 60711
Gerrit-PatchSet: 2
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Mon, 24 Jan 2022 07:14:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Neill Corlett.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61288 )
Change subject: Add mediatek_i2c_spi interface.
......................................................................
Patch Set 1:
(5 comments)
Patchset:
PS1:
Thank you for well written the patch and contribution Neill ! Could you add a man page entry as well? I made some short comments inline
File mediatek_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/61288/comment/0f998c2e_f0bcce69
PS1, Line 66: d
with ret value so we know how the ioctl actually failed.
https://review.coreboot.org/c/flashrom/+/61288/comment/28679258_83228c63
PS1, Line 96: args.data->block
args.data->block[1] ?
https://review.coreboot.org/c/flashrom/+/61288/comment/40e430ca_b819fd5f
PS1, Line 96: args.data->block[0]
just 'len' here, avoids needing to do that indirection there to check we are in fact memcpy to a heap with enough space at all times.
https://review.coreboot.org/c/flashrom/+/61288/comment/f29d3c3b_d59cbb1a
PS1, Line 242: GPIO line
Is this board depended? Should this perhaps become a programmer parameter if so? i.e., which gpio line to use.
--
To view, visit https://review.coreboot.org/c/flashrom/+/61288
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I24adb14e7b4f7160e1c3ff941774064d5a81e820
Gerrit-Change-Number: 61288
Gerrit-PatchSet: 1
Gerrit-Owner: Neill Corlett <corlett(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Neill Corlett <corlett(a)google.com>
Gerrit-Comment-Date: Mon, 24 Jan 2022 04:30:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61286 )
Change subject: flashrom.c: Move {read,write}_buf_from_include_args() to layout
......................................................................
Patch Set 1: Code-Review-2
(1 comment)
Patchset:
PS1:
> Yes I asked because I noticed the rest of xxx_include_args functionality lives in layout.h. […]
These two functions are best situated within cli_common once read_flash_to_file() has been eliminated from flashrom.c
--
To view, visit https://review.coreboot.org/c/flashrom/+/61286
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I61d4460ea26e07b67c99baeae5cb3840c25cb913
Gerrit-Change-Number: 61286
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Mon, 24 Jan 2022 04:15:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org>
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60070 )
Change subject: flashrom.c: Move do_*() helpers into cli_classic.c
......................................................................
Patch Set 5:
(1 comment)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/60070/comment/eb5d6f99_6d2dac9d
PS2, Line 156:
: static
> I like the idea of cli_common because cli_classic is already really large :\ I am not entirely sure […]
Yes the symbols would not be static any more and there is only one call site so it probably doesn't actually make sense.
--
To view, visit https://review.coreboot.org/c/flashrom/+/60070
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If1112155e2421e0178fd73f847cbb80868387433
Gerrit-Change-Number: 60070
Gerrit-PatchSet: 5
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Mon, 24 Jan 2022 03:04:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org>
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment