- flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: writeprotect: print chip range truth table for debugging
by Nikolai Artemiev (Code Review) 17 Feb '22

17 Feb '22

Nikolai Artemiev has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/59909 ) Change subject: writeprotect: print chip range truth table for debugging ...................................................................... Abandoned Squashed into CB:58481 -- To view, visit https://review.coreboot.org/c/flashrom/+/59909 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2cda441229ffdcabff27906f7804efba82baa6bc Gerrit-Change-Number: 59909 Gerrit-PatchSet: 26 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

Change in flashrom[master]: libflashrom/fmap: Don't use off_t for flash offsets
by Julius Werner (Code Review) 17 Feb '22

17 Feb '22

Attention is currently required from: Nico Huber, David Hendricks, Angel Pons, Arthur Heymans. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61943 ) Change subject: libflashrom/fmap: Don't use off_t for flash offsets ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Well, I think we both agree that the difference is miniscule, I just like to err on fixed width as t […] ...okay, I tried to look into adding a global typedef for this (of any kind) but it quickly gets complicated. There's offsets and flash sizes and flash sizes but in kilobytes and block sizes and sizes of structures on the flash and all sorts of stuff, and it's not super clear to me what things should have the same type. Furthermore, using a signed type for a flash offset really doesn't seem to make a lot of sense the more I consider it. It really just needs to be that way because fmap_lsearch() wants to use the same type to return errors with negative values, which probably means that the function should be fixed rather than defining the type wrong for the whole rest of the repo. But I haven't really worked in flashrom before and don't have the experience with the code to make all those decisions. Would you mind if we just merge this patch as is to get rid of the off_t problem for now? You guys can keep discussing how to clean this up long term and decide to make it all long or unsigned long or whatever if you want. I'm really just here to make sure nobody else needs to spend hours to figure out why their compilers all collectively decided to produce code that doesn't fit together. -- To view, visit https://review.coreboot.org/c/flashrom/+/61943 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I68a386973f79ea634f63dfcd7d95a63400e1fdee Gerrit-Change-Number: 61943 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 17 Feb 2022 02:26:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: libflashrom/fmap: Don't use off_t for flash offsets
by Julius Werner (Code Review) 17 Feb '22

17 Feb '22

Attention is currently required from: Nico Huber, David Hendricks, Angel Pons, Arthur Heymans. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61943 ) Change subject: libflashrom/fmap: Don't use off_t for flash offsets ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > It seems you are burdening yourself with too much knowledge :) I generally like […] Well, I think we both agree that the difference is miniscule, I just like to err on fixed width as the default unless reason to do otherwise (<stdint.h> is also "standard C", after all). If all we care about is that it can hold -2^31 to 2^31-1, then I think that means exactly that int32_t should be the right size, and not long. If you're worried about 32Gbit not being enough, then I think that would make long an even worse choice, because then whether a certain flash chip works or breaks depends on what environment flashrom is running under, which is not a good situation to be in. In that case, int64_t would be the right type to use. (I don't think it's necessary to go there yet but I'm happy to compromise on that if people think otherwise.) -- To view, visit https://review.coreboot.org/c/flashrom/+/61943 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I68a386973f79ea634f63dfcd7d95a63400e1fdee Gerrit-Change-Number: 61943 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 17 Feb 2022 01:57:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: libflashrom/fmap: Don't use off_t for flash offsets
by Edward O'Callaghan (Code Review) 17 Feb '22

17 Feb '22

Attention is currently required from: David Hendricks, Julius Werner, Angel Pons, Arthur Heymans. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61943 ) Change subject: libflashrom/fmap: Don't use off_t for flash offsets ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/61943 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I68a386973f79ea634f63dfcd7d95a63400e1fdee Gerrit-Change-Number: 61943 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 17 Feb 2022 01:46:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: remove CPPFLAGS and LDFLAGS to default directories
by Nico Huber (Code Review) 16 Feb '22

16 Feb '22

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/61526 ) Change subject: Makefile: remove CPPFLAGS and LDFLAGS to default directories ...................................................................... Makefile: remove CPPFLAGS and LDFLAGS to default directories All CPPFLAGS and LDFLAGS for dependencies are handled by pkg-config Change-Id: Ib7c11a0c8a7918562256480c4be0c95355f981c5 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/61526 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M Makefile 1 file changed, 0 insertions(+), 15 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/Makefile b/Makefile index 66a6995..7628142 100644 --- a/Makefile +++ b/Makefile @@ -243,21 +243,6 @@ HAS_LINUX_SPI := $(call c_compile_test, Makefile.d/linux_spi_test.c) HAS_LINUX_I2C := $(call c_compile_test, Makefile.d/linux_i2c_test.c) -ifeq ($(TARGET_OS), $(filter $(TARGET_OS), FreeBSD OpenBSD DragonFlyBSD)) -override CPPFLAGS += -I/usr/local/include -override LDFLAGS += -L/usr/local/lib -endif - -ifeq ($(TARGET_OS), Darwin) -override CPPFLAGS += -I/opt/local/include -I/usr/local/include -override LDFLAGS += -L/opt/local/lib -L/usr/local/lib -endif - -ifeq ($(TARGET_OS), NetBSD) -override CPPFLAGS += -I/usr/pkg/include -override LDFLAGS += -L/usr/pkg/lib -endif - ifeq ($(TARGET_OS), DOS) EXEC_SUFFIX := .exe # DJGPP has odd uint*_t definitions which cause lots of format string warnings. -- To view, visit https://review.coreboot.org/c/flashrom/+/61526 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib7c11a0c8a7918562256480c4be0c95355f981c5 Gerrit-Change-Number: 61526 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: hwaccess_x86_io: clean header concept
by Thomas Heijligen (Code Review) 16 Feb '22

16 Feb '22

Attention is currently required from: Nico Huber, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61276 ) Change subject: hwaccess_x86_io: clean header concept ...................................................................... Patch Set 9: (3 comments) File hwaccess_x86_io.c: https://review.coreboot.org/c/flashrom/+/61276/comment/ca4794cd_cd98a1e3 PS6, Line 30: * - X86_IO_USE_LIBC : * - X86_IO_USE_SWAPPED > How about more accurate names, e.g. […] Yes, more accurate naming would be good. Working on it. File hwaccess_x86_io.c: https://review.coreboot.org/c/flashrom/+/61276/comment/80e280c4_846f77c9 PS7, Line 36: * functions. `platform_get_io_perms()` is called to get > Please drop the trailing whitespace that Gerrit marks so keenly. Done https://review.coreboot.org/c/flashrom/+/61276/comment/995489cf_b5b6275b PS7, Line 352: a > ass*e*mbly Done -- To view, visit https://review.coreboot.org/c/flashrom/+/61276 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1400704e9ac5fed00c096796536108d5bfb875e3 Gerrit-Change-Number: 61276 Gerrit-PatchSet: 9 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 16 Feb 2022 11:59:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: hwaccess_x86_io: clean header concept
by Thomas Heijligen (Code Review) 16 Feb '22

16 Feb '22

Attention is currently required from: Thomas Heijligen, Angel Pons. Hello build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/61276 to look at the new patch set (#9). Change subject: hwaccess_x86_io: clean header concept ...................................................................... hwaccess_x86_io: clean header concept Move all function implementations into the .c file Change-Id: I1400704e9ac5fed00c096796536108d5bfb875e3 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile M hwaccess_x86_io.c M hwaccess_x86_io.h M meson.build 4 files changed, 293 insertions(+), 188 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/76/61276/9 -- To view, visit https://review.coreboot.org/c/flashrom/+/61276 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1400704e9ac5fed00c096796536108d5bfb875e3 Gerrit-Change-Number: 61276 Gerrit-PatchSet: 9 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: hwaccess_x86_io: refactor rget_io_perms()
by Thomas Heijligen (Code Review) 16 Feb '22

16 Feb '22

Attention is currently required from: Thomas Heijligen, Angel Pons. Hello build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/61275 to look at the new patch set (#5). Change subject: hwaccess_x86_io: refactor rget_io_perms() ...................................................................... hwaccess_x86_io: refactor rget_io_perms() Abstract the different I/O Port permission methods in own functions. Change-Id: If4b2f8c2532f3732086ee1d479da6ae6693f9a42 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M hwaccess_x86_io.c 1 file changed, 97 insertions(+), 50 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/75/61275/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/61275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If4b2f8c2532f3732086ee1d479da6ae6693f9a42 Gerrit-Change-Number: 61275 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: hwaccess_x86_io: clean header concept
by Thomas Heijligen (Code Review) 16 Feb '22

16 Feb '22

Attention is currently required from: Thomas Heijligen, Angel Pons. Hello build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/61276 to look at the new patch set (#8). Change subject: hwaccess_x86_io: clean header concept ...................................................................... hwaccess_x86_io: clean header concept Move all function implementations into the .c file Change-Id: I1400704e9ac5fed00c096796536108d5bfb875e3 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile M hwaccess_x86_io.c M hwaccess_x86_io.h M meson.build 4 files changed, 294 insertions(+), 190 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/76/61276/8 -- To view, visit https://review.coreboot.org/c/flashrom/+/61276 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1400704e9ac5fed00c096796536108d5bfb875e3 Gerrit-Change-Number: 61276 Gerrit-PatchSet: 8 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: libflashrom/fmap: Don't use off_t for flash offsets
by Nico Huber (Code Review) 16 Feb '22

16 Feb '22

Attention is currently required from: David Hendricks, Edward O'Callaghan, Julius Werner, Angel Pons, Arthur Heymans. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61943 ) Change subject: libflashrom/fmap: Don't use off_t for flash offsets ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Yeah I noticed layout.h but I wasn't sure if it was okay to pull that into libflashrom. […] It seems you are burdening yourself with too much knowledge :) I generally like too keep things simple, in this case standard C. No need to care what choices OS's make wrt. the size of `long`. All we need to know is that it can represent numbers from -2^32 to 2^31-1. Actually I'm not sure about flash chip sizes, 32Gbit doesn't seem too far away anymore. Maybe we should aim higher right away? or risk an API change later? -- To view, visit https://review.coreboot.org/c/flashrom/+/61943 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I68a386973f79ea634f63dfcd7d95a63400e1fdee Gerrit-Change-Number: 61943 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 16 Feb 2022 10:53:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit