- flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: meson.build: Don't depend on getrevision.sh
by Angel Pons (Code Review) 17 Feb '22

17 Feb '22

Attention is currently required from: Nico Huber, powpowd(a)gmail.com. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62061 ) Change subject: meson.build: Don't depend on getrevision.sh ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/62061/comment/0784532a_60bc2525 PS3, Line 9: (including : GitHub's auto-generated tarballs and ZIPs) Why would anyone use those? We have signed release tarballs (e.g. https://www.flashrom.org/Latest_release for the latest release) and non-release builds should be done using a `git clone` so that the version is properly reported (e.g. `v1.2-422-g529dc1e`). -- To view, visit https://review.coreboot.org/c/flashrom/+/62061 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id8601155b35f0299200c27d0278606127410ff16 Gerrit-Change-Number: 62061 Gerrit-PatchSet: 3 Gerrit-Owner: powpowd(a)gmail.com Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: powpowd(a)gmail.com Gerrit-Comment-Date: Thu, 17 Feb 2022 14:59:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson.build: Don't depend on getrevision.sh
by Angel Pons (Code Review) 17 Feb '22

17 Feb '22

Attention is currently required from: Nico Huber, powpowd(a)gmail.com. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62061 ) Change subject: meson.build: Don't depend on getrevision.sh ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File meson.build: https://review.coreboot.org/c/flashrom/+/62061/comment/88c3ffb6_c858c2cf PS3, Line 2: version : run_command('util/getversion.sh', '--version').stdout().strip(), Is this change intentional? -- To view, visit https://review.coreboot.org/c/flashrom/+/62061 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id8601155b35f0299200c27d0278606127410ff16 Gerrit-Change-Number: 62061 Gerrit-PatchSet: 3 Gerrit-Owner: powpowd(a)gmail.com Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: powpowd(a)gmail.com Gerrit-Comment-Date: Thu, 17 Feb 2022 14:55:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: libflashrom/fmap: Don't use off_t for flash offsets
by Angel Pons (Code Review) 17 Feb '22

17 Feb '22

Attention is currently required from: Nico Huber, David Hendricks, Julius Werner, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61943 ) Change subject: libflashrom/fmap: Don't use off_t for flash offsets ...................................................................... Patch Set 1: (2 comments) File fmap.c: https://review.coreboot.org/c/flashrom/+/61943/comment/39d746f6_f2156261 PS1, Line 94: int32_t Thoughts on using `ssize_t` instead? File libflashrom.h: https://review.coreboot.org/c/flashrom/+/61943/comment/57cf4bb7_41074515 PS1, Line 112: uint32_t > Would be nice to use `size_t` like done in other APIs. +1 -- To view, visit https://review.coreboot.org/c/flashrom/+/61943 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I68a386973f79ea634f63dfcd7d95a63400e1fdee Gerrit-Change-Number: 61943 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 17 Feb 2022 14:48:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: libflashrom/fmap: Don't use off_t for flash offsets
by Nico Huber (Code Review) 17 Feb '22

17 Feb '22

Attention is currently required from: David Hendricks, Julius Werner, Angel Pons, Arthur Heymans. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61943 ) Change subject: libflashrom/fmap: Don't use off_t for flash offsets ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: > ... […] Right, doesn't need to happen now. Also, I didn't have any invasive changes in mind, just the libflashrom API (I hope that is free from KiB?). Regarding fmap_lsearch(), isn't that what ssize_t is there for? File libflashrom.h: https://review.coreboot.org/c/flashrom/+/61943/comment/124bc1a5_d8367759 PS1, Line 112: uint32_t Would be nice to use `size_t` like done in other APIs. -- To view, visit https://review.coreboot.org/c/flashrom/+/61943 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I68a386973f79ea634f63dfcd7d95a63400e1fdee Gerrit-Change-Number: 61943 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 17 Feb 2022 14:04:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: writeprotect, cli_classic: delete old writeprotect code
by Nikolai Artemiev (Code Review) 17 Feb '22

17 Feb '22

Attention is currently required from: Nico Huber, Sergii Dmytruk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58474 ) Change subject: writeprotect, cli_classic: delete old writeprotect code ...................................................................... Patch Set 16: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/58474/comment/46b5b136_9b963786 PS16, Line 6: : writeprotect, cli_classic: delete old writeprotect code : I think we're ready to start submitting these patches now. If we submit the patches up to and including CB:58482 the new WP implementation will be usable through the libflashrom interface. -- To view, visit https://review.coreboot.org/c/flashrom/+/58474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I67e9b31f86465e5a8f7d3def637198671ee818a8 Gerrit-Change-Number: 58474 Gerrit-PatchSet: 16 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Thu, 17 Feb 2022 08:49:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson.build: Don't depend on getrevision.sh
by Name of user not set (Code Review) 17 Feb '22

17 Feb '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62061 to look at the new patch set (#3). Change subject: meson.build: Don't depend on getrevision.sh ...................................................................... meson.build: Don't depend on getrevision.sh `getrevision.sh` isn't included in exported source code (including GitHub's auto-generated tarballs and ZIPs). Per issue #95, the build shouldn't depend on getrevision.sh for this reason. Previously, however, Flashrom would not build from exported source using Meson due to it requiring `getrevision.sh`. This patch has Meson use the intended `getversion.sh` instead. Signed-off-by: Samuel R. Messner <powpowd(a)gmail.com> Change-Id: Id8601155b35f0299200c27d0278606127410ff16 --- M meson.build 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/61/62061/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/62061 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id8601155b35f0299200c27d0278606127410ff16 Gerrit-Change-Number: 62061 Gerrit-PatchSet: 3 Gerrit-Owner: powpowd(a)gmail.com Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: meson.build: Don't depend on getrevision.sh
by Name of user not set (Code Review) 17 Feb '22

17 Feb '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/62061 to look at the new patch set (#2). Change subject: meson.build: Don't depend on getrevision.sh ...................................................................... meson.build: Don't depend on getrevision.sh `getrevision.sh` isn't included in exported source code (including GitHub's auto-generated tarballs and ZIPs). Per issue #95, the build shouldn't depend on getrevision.sh for this reason. Previously, however, Flashrom would not build from exported source using Meson due to it requiring `getrevision.sh`. This patch has Meson use the intended getversion.sh instead. Signed-off-by: Samuel R. Messner <powpowd(a)gmail.com> Change-Id: Id8601155b35f0299200c27d0278606127410ff16 --- M meson.build 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/61/62061/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/62061 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id8601155b35f0299200c27d0278606127410ff16 Gerrit-Change-Number: 62061 Gerrit-PatchSet: 2 Gerrit-Owner: powpowd(a)gmail.com Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: meson.build: Don't depend on getrevision.sh
by Name of user not set (Code Review) 17 Feb '22

17 Feb '22

powpowd(a)gmail.com has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/62061 ) Change subject: meson.build: Don't depend on getrevision.sh ...................................................................... meson.build: Don't depend on getrevision.sh `getrevision.sh` isn't included in exported source code (including GitHub's auto-generated tarballs and ZIPs). Per issue #95, the build shouldn't depend on getrevision.sh for this reason. Previously, however, Flashrom would not build from exported source using Meson due to it requiring `getrevision.sh`. This patch has Meson use the intended getversion.sh instead. Worth mentioning is that Flashrom still does not build on my system for unrelated reasons (see issue #243), so I haven't been able to confirm that this commit completes building - but the changes don't affect the rest of the build process, so it's nigh-certainly fine. Signed-off-by: Samuel R. Messner <powpowd(a)gmail.com> Change-Id: Id8601155b35f0299200c27d0278606127410ff16 --- M meson.build 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/61/62061/1 diff --git a/meson.build b/meson.build index cd9f9fb..367c48a 100644 --- a/meson.build +++ b/meson.build @@ -1,5 +1,5 @@ project('flashromutils', 'c', - version : run_command('util/getversion.sh', '-v').stdout().strip(), + version : run_command('util/getversion.sh', '--version').stdout().strip(), license : 'GPL-2.0', meson_version : '>=0.50.0', default_options : ['warning_level=2', 'c_std=c99'], @@ -469,7 +469,7 @@ ) conf.set('VERSION', version) -conf.set('MAN_DATE', run_command('util/getrevision.sh', '--date', 'flashrom.8.tmpl').stdout().strip()) +conf.set('MAN_DATE', run_command('util/getversion.sh', '--man-date').stdout().strip()) configure_file( input : 'flashrom.8.tmpl', output : 'flashrom.8', -- To view, visit https://review.coreboot.org/c/flashrom/+/62061 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id8601155b35f0299200c27d0278606127410ff16 Gerrit-Change-Number: 62061 Gerrit-PatchSet: 1 Gerrit-Owner: powpowd(a)gmail.com Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: internal.c: Seperate out get_params() from internal_init()
by Edward O'Callaghan (Code Review) 17 Feb '22

17 Feb '22

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/61578 ) Change subject: internal.c: Seperate out get_params() from internal_init() ...................................................................... internal.c: Seperate out get_params() from internal_init() Move all programmer parameter wrangling into its own function. BUG=none TEST=`flashrom -p internal` on dooly DUT. Change-Id: I66bb370eb0466c5c838621762a6ba825c44567d4 Tested-by: Nikolai Artemiev <nartemiev(a)google.com> Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/61578 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M internal.c 1 file changed, 35 insertions(+), 15 deletions(-) Approvals: build bot (Jenkins): Verified Nikolai Artemiev: Looks good to me, but someone else must approve Anastasia Klimchuk: Looks good to me, approved diff --git a/internal.c b/internal.c index b8e0564..995290e 100644 --- a/internal.c +++ b/internal.c @@ -174,22 +174,21 @@ .chip_writen = fallback_chip_writen, }; -static int internal_init(void) +static int get_params(int *boardenable, int *boardmismatch, + int *force_laptop, int *not_a_laptop, + char **board_vendor, char **board_model) { - int ret = 0; - int force_laptop = 0; - int not_a_laptop = 0; - char *board_vendor = NULL; - char *board_model = NULL; -#if defined(__i386__) || defined(__x86_64__) - const char *cb_vendor = NULL; - const char *cb_model = NULL; -#endif char *arg; + /* default values. */ + *force_laptop = 0; + *not_a_laptop = 0; + *board_vendor = NULL; + *board_model = NULL; + arg = extract_programmer_param("boardenable"); if (arg && !strcmp(arg,"force")) { - force_boardenable = 1; + *boardenable = 1; } else if (arg && !strlen(arg)) { msg_perr("Missing argument for boardenable.\n"); free(arg); @@ -203,7 +202,7 @@ arg = extract_programmer_param("boardmismatch"); if (arg && !strcmp(arg,"force")) { - force_boardmismatch = 1; + *boardmismatch = 1; } else if (arg && !strlen(arg)) { msg_perr("Missing argument for boardmismatch.\n"); free(arg); @@ -217,9 +216,9 @@ arg = extract_programmer_param("laptop"); if (arg && !strcmp(arg, "force_I_want_a_brick")) - force_laptop = 1; + *force_laptop = 1; else if (arg && !strcmp(arg, "this_is_not_a_laptop")) - not_a_laptop = 1; + *not_a_laptop = 1; else if (arg && !strlen(arg)) { msg_perr("Missing argument for laptop.\n"); free(arg); @@ -233,7 +232,7 @@ arg = extract_programmer_param("mainboard"); if (arg && strlen(arg)) { - if (board_parse_parameter(arg, &board_vendor, &board_model)) { + if (board_parse_parameter(arg, board_vendor, board_model)) { free(arg); return 1; } @@ -244,6 +243,27 @@ } free(arg); + return 0; +} + +static int internal_init(void) +{ + int ret = 0; + int force_laptop; + int not_a_laptop; + char *board_vendor; + char *board_model; +#if defined(__i386__) || defined(__x86_64__) + const char *cb_vendor = NULL; + const char *cb_model = NULL; +#endif + + ret = get_params(&force_boardenable, &force_boardmismatch, + &force_laptop, &not_a_laptop, + &board_vendor, &board_model); + if (ret) + return ret; + /* Default to Parallel/LPC/FWH flash devices. If a known host controller * is found, the host controller init routine sets the * internal_buses_supported bitfield. 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/flashrom/+/61578 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I66bb370eb0466c5c838621762a6ba825c44567d4 Gerrit-Change-Number: 61578 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: libflashrom,writeprotect: add flashrom_wp_get_available_ranges()
by Nikolai Artemiev (Code Review) 17 Feb '22

17 Feb '22

Attention is currently required from: Nico Huber, Angel Pons, Sergii Dmytruk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58481 ) Change subject: libflashrom,writeprotect: add flashrom_wp_get_available_ranges() ...................................................................... Patch Set 40: (1 comment) File writeprotect.c: https://review.coreboot.org/c/flashrom/+/58481/comment/b1fb739c_f5303df8 PS23, Line 254: (1 << bit_count) > Looks like parentheses still here, in the latest patchset Done -- To view, visit https://review.coreboot.org/c/flashrom/+/58481 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id51f038f03305c8536d80313e52f77d27835f34d Gerrit-Change-Number: 58481 Gerrit-PatchSet: 40 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Thu, 17 Feb 2022 02:41:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit