February 2025 - flashrom-gerrit

[XS] Change in flashrom[main]: doc: Point to correct kernel coding style
by Anastasia Klimchuk (Code Review) 21 Feb '25

21 Feb '25

Attention is currently required from: Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Stefan Reinauer. ( https://review.coreboot.org/c/flashrom/+/86545?usp=email ) Change subject: doc: Point to correct kernel coding style ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/86545?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib52de1312419cc48478fb965ccb104bdb0dea9b6 Gerrit-Change-Number: 86545 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 21 Feb 2025 07:11:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in flashrom[main]: doc: Remove reference to coreboot dev guidelines
by Stefan Reinauer (Code Review) 21 Feb '25

21 Feb '25

Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/86547?usp=email ) Change subject: doc: Remove reference to coreboot dev guidelines ...................................................................... doc: Remove reference to coreboot dev guidelines The guidelines are fully specified on flashrom.org, no need to reference them. Change-Id: If5fbcf1f4dc00dd1a9c48e9fad6c99d646954bfb Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M doc/dev_guide/development_guide.rst 1 file changed, 0 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/86547/1 diff --git a/doc/dev_guide/development_guide.rst b/doc/dev_guide/development_guide.rst index e063192..85ad29c 100644 --- a/doc/dev_guide/development_guide.rst +++ b/doc/dev_guide/development_guide.rst @@ -142,12 +142,6 @@ * Tables are the only exception to the hard limit and may be as long as needed for practical purposes. -Our guidelines borrow heavily from `coreboot coding style -<https://doc.coreboot.org/contributing/coding_style.html>`_ and `coreboot Gerrit -guidelines <https://doc.coreboot.org/contributing/gerrit_guidelines.html>`_, -and most of them apply to flashrom as well. The really important part is about -the :ref:`sign-off procedure <sign-off>`. - We try to **reuse as much code as possible** and create new files only if absolutely needed, so if you find a function somewhere in the tree which already does what you want, please use it. -- To view, visit https://review.coreboot.org/c/flashrom/+/86547?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If5fbcf1f4dc00dd1a9c48e9fad6c99d646954bfb Gerrit-Change-Number: 86547 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: doc: Point to web page instead of Wiki for Laptops page
by Stefan Reinauer (Code Review) 21 Feb '25

21 Feb '25

Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/86546?usp=email ) Change subject: doc: Point to web page instead of Wiki for Laptops page ...................................................................... doc: Point to web page instead of Wiki for Laptops page There were three occurences pointing to the retired wiki instead of the web page https://flashrom.org/contrib_howtos/laptops_and_ec.html Change-Id: I62950e1099183171dd3b94200014034b0616a4b4 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M doc/classic_cli_manpage.rst M internal.c 2 files changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/46/86546/1 diff --git a/doc/classic_cli_manpage.rst b/doc/classic_cli_manpage.rst index 4f2e68e..af897a0 100644 --- a/doc/classic_cli_manpage.rst +++ b/doc/classic_cli_manpage.rst @@ -624,7 +624,7 @@ **Laptops** Using **flashrom** on older laptops that don't boot from the SPI bus is dangerous and may easily make your hardware unusable (see also the **BUGS** section). The embedded controller (EC) in some machines may interact badly with flashing. - More information is `in the wiki <https://flashrom.org/Laptops>`_. + More information is at :doc:`/contrib_howtos/laptops_and_ec`. Problems occur when the flash chip is shared between BIOS and EC firmware, and the latter does not expect **flashrom** to access the chip. While **flashrom** tries to change the contents of that memory the EC might need to fetch new instructions or data from it and could stop working correctly. Probing for and reading from the chip may also irritate @@ -1538,7 +1538,7 @@ Using **flashrom** on older laptops is dangerous and may easily make your hardware unusable. **flashrom** will attempt to detect if it is running on a susceptible laptop and restrict flash-chip probing for safety reasons. Please see the detailed discussion of this topic and associated **flashrom** options in the **Laptops** paragraph in the **internal programmer** -subsection of the **PROGRAMMER-SPECIFIC INFORMATION** section and the information `in our wiki <https://flashrom.org/Laptops>`_. +subsection of the **PROGRAMMER-SPECIFIC INFORMATION** section and the information at :doc:`/contrib_howtos/laptops_and_ec`. One-time programmable (OTP) memory and unique IDs diff --git a/internal.c b/internal.c index faeb463..1753c44 100644 --- a/internal.c +++ b/internal.c @@ -129,7 +129,8 @@ msg_perr("Laptops, notebooks and netbooks are difficult to support and we\n" "recommend to use the vendor flashing utility. The embedded controller\n" "(EC) in these machines often interacts badly with flashing.\n" - "See the manpage and https://flashrom.org/Laptops for details.\n\n" + "See the manpage and https://flashrom.org/contrib_howtos/laptops_and_ec.html\n" + "for details.\n\n" "If flash is shared with the EC, erase is guaranteed to brick your laptop\n" "and write may brick your laptop.\n" "Read and probe may irritate your EC and cause fan failure, backlight\n" -- To view, visit https://review.coreboot.org/c/flashrom/+/86546?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I62950e1099183171dd3b94200014034b0616a4b4 Gerrit-Change-Number: 86546 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: doc: Point to correct kernel coding style
by Stefan Reinauer (Code Review) 21 Feb '25

21 Feb '25

Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/86545?usp=email ) Change subject: doc: Point to correct kernel coding style ...................................................................... doc: Point to correct kernel coding style Right now it points to the source of the page instead of the actual page. Change-Id: Ib52de1312419cc48478fb965ccb104bdb0dea9b6 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M doc/dev_guide/development_guide.rst 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/45/86545/1 diff --git a/doc/dev_guide/development_guide.rst b/doc/dev_guide/development_guide.rst index aac3a6c..e063192 100644 --- a/doc/dev_guide/development_guide.rst +++ b/doc/dev_guide/development_guide.rst @@ -130,7 +130,7 @@ ------------ Flashrom generally follows Linux kernel style: -https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst +https://docs.kernel.org/process/coding-style.html The notable exception is line length limit. Our guidelines are: -- To view, visit https://review.coreboot.org/c/flashrom/+/86545?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib52de1312419cc48478fb965ccb104bdb0dea9b6 Gerrit-Change-Number: 86545 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: doc: Add useful links to README
by Stefan Reinauer (Code Review) 21 Feb '25

21 Feb '25

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk. Stefan Reinauer has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86430?usp=email ) Change subject: doc: Add useful links to README ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/86430?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib231150acd8aa911d534f67ff1ce937c6963812c Gerrit-Change-Number: 86430 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 21 Feb 2025 00:02:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in flashrom[main]: doc: Add missing step in the beginning of building from source doc
by Stefan Reinauer (Code Review) 21 Feb '25

21 Feb '25

Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk. Stefan Reinauer has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86429?usp=email ) Change subject: doc: Add missing step in the beginning of building from source doc ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/86429?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id834d3de69c038f3cc1aee3c59c3607f42fd5b49 Gerrit-Change-Number: 86429 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 21 Feb 2025 00:01:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in flashrom[main]: flashchips/winbond: Update test status for Winbond W25Q128.W
by Matt DeVillier (Code Review) 20 Feb '25

20 Feb '25

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/86544?usp=email ) Change subject: flashchips/winbond: Update test status for Winbond W25Q128.W ...................................................................... flashchips/winbond: Update test status for Winbond W25Q128.W Tested probe, read, erase, write, and WP operations on a Winbond W25Q128.W chip using internal and ch341a_spi programmers. Change-Id: Ia1f2a5f4942a4f1956405afa5b56c9e38101f2be Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M flashchips/winbond.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/44/86544/1 diff --git a/flashchips/winbond.c b/flashchips/winbond.c index 9709e78..48fdc94 100644 --- a/flashchips/winbond.c +++ b/flashchips/winbond.c @@ -216,7 +216,7 @@ /* supports SFDP */ /* OTP: 1024B total, 256B reserved; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI | FEATURE_WRSR2, - .tested = TEST_OK_PREW, + .tested = TEST_OK_PREWB, .probe = PROBE_SPI_RDID, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/c/flashrom/+/86544?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia1f2a5f4942a4f1956405afa5b56c9e38101f2be Gerrit-Change-Number: 86544 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[L] Change in flashrom[main]: spidriver: Add support for the Excamera Labs SPIDriver programmer
by Anastasia Klimchuk (Code Review) 20 Feb '25

20 Feb '25

Attention is currently required from: Peter Marheine, Simon Arlott. Anastasia Klimchuk has posted comments on this change by Simon Arlott. ( https://review.coreboot.org/c/flashrom/+/86411?usp=email ) Change subject: spidriver: Add support for the Excamera Labs SPIDriver programmer ...................................................................... Patch Set 2: (1 comment) File doc/classic_cli_manpage.rst: https://review.coreboot.org/c/flashrom/+/86411/comment/40614faf_048c5bc2?us… : PS2, Line 359: spidriver > I agree that it seems pretty generic at first glance, but I think `spidriver` is okay. […] Alright, I agree! -- To view, visit https://review.coreboot.org/c/flashrom/+/86411?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I07b23c1146d4ad3606b54a1e8dc8030cf4ebf57b Gerrit-Change-Number: 86411 Gerrit-PatchSet: 2 Gerrit-Owner: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Simon Arlott <flashrom.simon(a)arlott.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Thu, 20 Feb 2025 10:23:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[L] Change in flashrom[main]: doc: autogenerate a list of authors and hall of fame
by Peter Marheine (Code Review) 20 Feb '25

20 Feb '25

Attention is currently required from: Anastasia Klimchuk. Peter Marheine has posted comments on this change by Peter Marheine. ( https://review.coreboot.org/c/flashrom/+/86350?usp=email ) Change subject: doc: autogenerate a list of authors and hall of fame ...................................................................... Patch Set 11: (2 comments) File doc/about_flashrom/hall_of_fame.rst: https://review.coreboot.org/c/flashrom/+/86350/comment/6837761c_04c1ab88?us… : PS5, Line 1: This page lists all past contributors to Flashrom. Specifically, it lists : everybody who is named in the git history as having authored, co-authored, : or reviewed at least one change in alphabetical order. > Two comments here, not to forget […] Done File doc/collect-authors.sh: https://review.coreboot.org/c/flashrom/+/86350/comment/49267754_b79a6d2c?us… : PS5, Line 22: git --no-pager shortlog --summary \ : --group=author --group="trailer:Co-Authored-by" --group="trailer:Reviewed-by" > I have two thoughts, if it's possible to do: […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/86350?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I1e9634a90e84262aafd80590deba9875f4b71a3c Gerrit-Change-Number: 86350 Gerrit-PatchSet: 11 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 20 Feb 2025 05:57:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[L] Change in flashrom[main]: doc: autogenerate a list of authors and hall of fame
by Peter Marheine (Code Review) 20 Feb '25

20 Feb '25

Attention is currently required from: Peter Marheine. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86350?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: doc: autogenerate a list of authors and hall of fame ...................................................................... doc: autogenerate a list of authors and hall of fame This adds a build-time option to automatically generate a list of authors from git history, and includes it in the documentation by reading the output from git in a Sphinx extension. When git isn't available or the project source doesn't appear to be a git checkout, the list is not generated and gracefully replaced with a message explaining its absence. Change-Id: I1e9634a90e84262aafd80590deba9875f4b71a3c Signed-off-by: Peter Marheine <pmarheine(a)chromium.org> --- A doc/_ext/flashrom_authors.py A doc/about_flashrom/hall_of_fame.rst M doc/about_flashrom/index.rst A doc/collect-authors.sh M doc/conf.py M doc/dev_guide/building_from_source.rst M doc/how_to_support_flashrom.rst M doc/meson.build M meson_options.txt 9 files changed, 253 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/50/86350/11 -- To view, visit https://review.coreboot.org/c/flashrom/+/86350?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I1e9634a90e84262aafd80590deba9875f4b71a3c Gerrit-Change-Number: 86350 Gerrit-PatchSet: 11 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit February 2025