February 2025 - flashrom-gerrit

[L] Change in flashrom[main]: doc: autogenerate a list of authors and hall of fame
by Anastasia Klimchuk (Code Review) 24 Feb '25

24 Feb '25

Attention is currently required from: Patrick Georgi, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Peter Marheine. ( https://review.coreboot.org/c/flashrom/+/86350?usp=email ) Change subject: doc: autogenerate a list of authors and hall of fame ...................................................................... Patch Set 12: (3 comments) Patchset: PS5: > Adding a comment so that not to forget: the hard-coded list of authors on the bottom of the manpage […] I think this can be in this patch too? Patchset: PS12: I noticed when I downloaded the patch and built it locally, I got this as untracked: ``` Untracked files: (use "git add <file>..." to include in what will be committed) doc/_ext/__pycache__/ ``` and inside ``` $ ls doc/_ext/__pycache__/ flashrom_authors.cpython-312.pyc ``` Should this be added to git ignore? File doc/about_flashrom/hall_of_fame.rst: https://review.coreboot.org/c/flashrom/+/86350/comment/1f26d8ec_70232dde?us… : PS12, Line 23: as : in ``Co-authored-by`` A finishing touch: you need to add inside the brackets "or Co-developed-by" since the script is counting that too now -- To view, visit https://review.coreboot.org/c/flashrom/+/86350?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I1e9634a90e84262aafd80590deba9875f4b71a3c Gerrit-Change-Number: 86350 Gerrit-PatchSet: 12 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Mon, 24 Feb 2025 07:22:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: doc: Add useful links to README
by Anastasia Klimchuk (Code Review) 24 Feb '25

24 Feb '25

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/86430?usp=email ) Change subject: doc: Add useful links to README ...................................................................... doc: Add useful links to README Change-Id: Ib231150acd8aa911d534f67ff1ce937c6963812c Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/86430 Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M README.rst 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved diff --git a/README.rst b/README.rst index 2900517..a0ed3e8 100644 --- a/README.rst +++ b/README.rst @@ -19,6 +19,9 @@ Please see the flashrom(8) manpage :doc:`classic_cli_manpage`. +The list of platforms that package flashrom can be found on `repology.org <https://repology.org/project/flashrom/versions>`_. + +Information about recent releases can be found in :doc:`/release_notes/index`. Building / installing / packaging --------------------------------- @@ -33,7 +36,9 @@ meson install -C builddir For full detailed instructions, follow the information in -:doc:`dev_guide/building_from_source` +:doc:`dev_guide/building_from_source`. + +If you are interested in development, have a look at :doc:`dev_guide/development_guide`. Contact ------- -- To view, visit https://review.coreboot.org/c/flashrom/+/86430?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib231150acd8aa911d534f67ff1ce937c6963812c Gerrit-Change-Number: 86430 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: doc: Add missing step in the beginning of building from source doc
by Anastasia Klimchuk (Code Review) 24 Feb '25

24 Feb '25

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/86429?usp=email ) Change subject: doc: Add missing step in the beginning of building from source doc ...................................................................... doc: Add missing step in the beginning of building from source doc Change-Id: Id834d3de69c038f3cc1aee3c59c3607f42fd5b49 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/86429 Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M doc/dev_guide/building_from_source.rst M doc/dev_guide/development_guide.rst 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Stefan Reinauer: Looks good to me, approved build bot (Jenkins): Verified diff --git a/doc/dev_guide/building_from_source.rst b/doc/dev_guide/building_from_source.rst index 73f5c2b..a8521ce 100644 --- a/doc/dev_guide/building_from_source.rst +++ b/doc/dev_guide/building_from_source.rst @@ -1,6 +1,9 @@ Building from source ==================== +First thing, clone git repository for yourself (if you haven't done it already), +see :ref:`git repo setup`. + You're going to need the following tools to get started: * gcc or clang diff --git a/doc/dev_guide/development_guide.rst b/doc/dev_guide/development_guide.rst index 85ad29c..8c7ef67 100644 --- a/doc/dev_guide/development_guide.rst +++ b/doc/dev_guide/development_guide.rst @@ -15,6 +15,8 @@ You can `look at the latest flashrom development efforts in Gerrit <https://review.coreboot.org/q/project:flashrom>`_. +.. _git repo setup: + Set up the git repository and dev environment ============================================= -- To view, visit https://review.coreboot.org/c/flashrom/+/86429?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Id834d3de69c038f3cc1aee3c59c3607f42fd5b49 Gerrit-Change-Number: 86429 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: doc: Remove reference to coreboot dev guidelines
by Anastasia Klimchuk (Code Review) 24 Feb '25

24 Feb '25

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/86547?usp=email ) Change subject: doc: Remove reference to coreboot dev guidelines ...................................................................... doc: Remove reference to coreboot dev guidelines The guidelines are fully specified on flashrom.org, no need to reference them. Change-Id: If5fbcf1f4dc00dd1a9c48e9fad6c99d646954bfb Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/86547 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-by: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com> --- M doc/dev_guide/development_guide.rst 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Andy Ebrahiem: Looks good to me, but someone else must approve Anastasia Klimchuk: Looks good to me, approved diff --git a/doc/dev_guide/development_guide.rst b/doc/dev_guide/development_guide.rst index e063192..85ad29c 100644 --- a/doc/dev_guide/development_guide.rst +++ b/doc/dev_guide/development_guide.rst @@ -142,12 +142,6 @@ * Tables are the only exception to the hard limit and may be as long as needed for practical purposes. -Our guidelines borrow heavily from `coreboot coding style -<https://doc.coreboot.org/contributing/coding_style.html>`_ and `coreboot Gerrit -guidelines <https://doc.coreboot.org/contributing/gerrit_guidelines.html>`_, -and most of them apply to flashrom as well. The really important part is about -the :ref:`sign-off procedure <sign-off>`. - We try to **reuse as much code as possible** and create new files only if absolutely needed, so if you find a function somewhere in the tree which already does what you want, please use it. -- To view, visit https://review.coreboot.org/c/flashrom/+/86547?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If5fbcf1f4dc00dd1a9c48e9fad6c99d646954bfb Gerrit-Change-Number: 86547 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: doc: Point to web page instead of Wiki for Laptops page
by Anastasia Klimchuk (Code Review) 24 Feb '25

24 Feb '25

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/86546?usp=email ) Change subject: doc: Point to web page instead of Wiki for Laptops page ...................................................................... doc: Point to web page instead of Wiki for Laptops page There were three occurences pointing to the retired wiki instead of the web page https://flashrom.org/contrib_howtos/laptops_and_ec.html Change-Id: I62950e1099183171dd3b94200014034b0616a4b4 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/86546 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-by: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com> --- M doc/classic_cli_manpage.rst M internal.c 2 files changed, 4 insertions(+), 3 deletions(-) Approvals: Andy Ebrahiem: Looks good to me, but someone else must approve build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/doc/classic_cli_manpage.rst b/doc/classic_cli_manpage.rst index 4f2e68e..af897a0 100644 --- a/doc/classic_cli_manpage.rst +++ b/doc/classic_cli_manpage.rst @@ -624,7 +624,7 @@ **Laptops** Using **flashrom** on older laptops that don't boot from the SPI bus is dangerous and may easily make your hardware unusable (see also the **BUGS** section). The embedded controller (EC) in some machines may interact badly with flashing. - More information is `in the wiki <https://flashrom.org/Laptops>`_. + More information is at :doc:`/contrib_howtos/laptops_and_ec`. Problems occur when the flash chip is shared between BIOS and EC firmware, and the latter does not expect **flashrom** to access the chip. While **flashrom** tries to change the contents of that memory the EC might need to fetch new instructions or data from it and could stop working correctly. Probing for and reading from the chip may also irritate @@ -1538,7 +1538,7 @@ Using **flashrom** on older laptops is dangerous and may easily make your hardware unusable. **flashrom** will attempt to detect if it is running on a susceptible laptop and restrict flash-chip probing for safety reasons. Please see the detailed discussion of this topic and associated **flashrom** options in the **Laptops** paragraph in the **internal programmer** -subsection of the **PROGRAMMER-SPECIFIC INFORMATION** section and the information `in our wiki <https://flashrom.org/Laptops>`_. +subsection of the **PROGRAMMER-SPECIFIC INFORMATION** section and the information at :doc:`/contrib_howtos/laptops_and_ec`. One-time programmable (OTP) memory and unique IDs diff --git a/internal.c b/internal.c index faeb463..1753c44 100644 --- a/internal.c +++ b/internal.c @@ -129,7 +129,8 @@ msg_perr("Laptops, notebooks and netbooks are difficult to support and we\n" "recommend to use the vendor flashing utility. The embedded controller\n" "(EC) in these machines often interacts badly with flashing.\n" - "See the manpage and https://flashrom.org/Laptops for details.\n\n" + "See the manpage and https://flashrom.org/contrib_howtos/laptops_and_ec.html\n" + "for details.\n\n" "If flash is shared with the EC, erase is guaranteed to brick your laptop\n" "and write may brick your laptop.\n" "Read and probe may irritate your EC and cause fan failure, backlight\n" -- To view, visit https://review.coreboot.org/c/flashrom/+/86546?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I62950e1099183171dd3b94200014034b0616a4b4 Gerrit-Change-Number: 86546 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: doc: Point to correct kernel coding style
by Anastasia Klimchuk (Code Review) 24 Feb '25

24 Feb '25

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/86545?usp=email ) Change subject: doc: Point to correct kernel coding style ...................................................................... doc: Point to correct kernel coding style Right now it points to the source of the page instead of the actual page. Change-Id: Ib52de1312419cc48478fb965ccb104bdb0dea9b6 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/86545 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M doc/dev_guide/development_guide.rst 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Andy Ebrahiem: Looks good to me, but someone else must approve Anastasia Klimchuk: Looks good to me, approved build bot (Jenkins): Verified diff --git a/doc/dev_guide/development_guide.rst b/doc/dev_guide/development_guide.rst index aac3a6c..e063192 100644 --- a/doc/dev_guide/development_guide.rst +++ b/doc/dev_guide/development_guide.rst @@ -130,7 +130,7 @@ ------------ Flashrom generally follows Linux kernel style: -https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst +https://docs.kernel.org/process/coding-style.html The notable exception is line length limit. Our guidelines are: -- To view, visit https://review.coreboot.org/c/flashrom/+/86545?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib52de1312419cc48478fb965ccb104bdb0dea9b6 Gerrit-Change-Number: 86545 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: flashchips/winbond: Update test status for Winbond W25Q128.W
by Anastasia Klimchuk (Code Review) 24 Feb '25

24 Feb '25

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/86544?usp=email ) Change subject: flashchips/winbond: Update test status for Winbond W25Q128.W ...................................................................... flashchips/winbond: Update test status for Winbond W25Q128.W Tested probe, read, erase, write, and WP operations on a Winbond W25Q128.W chip using internal and ch341a_spi programmers. Change-Id: Ia1f2a5f4942a4f1956405afa5b56c9e38101f2be Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/86544 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M flashchips/winbond.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/flashchips/winbond.c b/flashchips/winbond.c index 9709e78..48fdc94 100644 --- a/flashchips/winbond.c +++ b/flashchips/winbond.c @@ -216,7 +216,7 @@ /* supports SFDP */ /* OTP: 1024B total, 256B reserved; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI | FEATURE_WRSR2, - .tested = TEST_OK_PREW, + .tested = TEST_OK_PREWB, .probe = PROBE_SPI_RDID, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/c/flashrom/+/86544?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia1f2a5f4942a4f1956405afa5b56c9e38101f2be Gerrit-Change-Number: 86544 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[L] Change in flashrom[main]: doc: autogenerate a list of authors and hall of fame
by Peter Marheine (Code Review) 23 Feb '25

23 Feb '25

Attention is currently required from: Anastasia Klimchuk, Patrick Georgi. Peter Marheine has posted comments on this change by Peter Marheine. ( https://review.coreboot.org/c/flashrom/+/86350?usp=email ) Change subject: doc: autogenerate a list of authors and hall of fame ...................................................................... Patch Set 12: (5 comments) Patchset: PS11: > This is going great! I am so so so happy 😊 […] Done File doc/about_flashrom/hall_of_fame.rst: https://review.coreboot.org/c/flashrom/+/86350/comment/937eab22_31c6c9c8?us… : PS11, Line 9: code reviewers > maybe let's just say "reviewers" ? one word for each section Done https://review.coreboot.org/c/flashrom/+/86350/comment/1e9d7715_485934f1?us… : PS11, Line 21: ======= > I am curious, this is 7 chars, and in the same situation on the Contact page we had to add one more […] It seems to notice if I have that in a diff, but seems fine to have that in a commit. If I `git reset --mixed` to the parent then `git diff --check`, it sees that as a conflict marker. Since there's no issue in actually including that in a commit, it seems fine. File doc/about_flashrom/index.rst: https://review.coreboot.org/c/flashrom/+/86350/comment/bae13166_42b63286?us… : PS11, Line 10: hall_of_fame > I would put it #2 in the list, after Team […] Done File doc/collect-authors.sh: https://review.coreboot.org/c/flashrom/+/86350/comment/aff71eef_dc73e173?us… : PS11, Line 11: Co-Authored-by > Can we also add `Co-developed-by` ? in addition to `Co-Authored-by` […] Sure; `Co-developed-by` has 14 items, whereas `Co-authored-by` has 8. -- To view, visit https://review.coreboot.org/c/flashrom/+/86350?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I1e9634a90e84262aafd80590deba9875f4b71a3c Gerrit-Change-Number: 86350 Gerrit-PatchSet: 12 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 23 Feb 2025 23:33:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[L] Change in flashrom[main]: doc: autogenerate a list of authors and hall of fame
by Peter Marheine (Code Review) 23 Feb '25

23 Feb '25

Attention is currently required from: Patrick Georgi, Peter Marheine. Hello Anastasia Klimchuk, Patrick Georgi, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86350?usp=email to look at the new patch set (#12). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: doc: autogenerate a list of authors and hall of fame ...................................................................... doc: autogenerate a list of authors and hall of fame This adds a build-time option to automatically generate a list of authors from git history, and includes it in the documentation by reading the output from git in a Sphinx extension. When git isn't available or the project source doesn't appear to be a git checkout, the list is not generated and gracefully replaced with a message explaining its absence. Change-Id: I1e9634a90e84262aafd80590deba9875f4b71a3c Signed-off-by: Peter Marheine <pmarheine(a)chromium.org> --- A doc/_ext/flashrom_authors.py A doc/about_flashrom/hall_of_fame.rst M doc/about_flashrom/index.rst A doc/collect-authors.sh M doc/conf.py M doc/dev_guide/building_from_source.rst M doc/how_to_support_flashrom.rst M doc/meson.build M doc/release_notes/devel.rst M meson_options.txt 10 files changed, 269 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/50/86350/12 -- To view, visit https://review.coreboot.org/c/flashrom/+/86350?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I1e9634a90e84262aafd80590deba9875f4b71a3c Gerrit-Change-Number: 86350 Gerrit-PatchSet: 12 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for progress callback
by Peter Marheine (Code Review) 23 Feb '25

23 Feb '25

Attention is currently required from: Anastasia Klimchuk, Richard Hughes, Sergii Dmytruk. Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86031?usp=email ) Change subject: libflashrom: Update the API for progress callback ...................................................................... Patch Set 9: (1 comment) File include/flash.h: https://review.coreboot.org/c/flashrom/+/86031/comment/206931c0_9fd7b81d?us… : PS8, Line 624: flashrom_progress_callback_v2 *progress_callback; : struct flashrom_progress progress_state; : struct stage_progress stage_progress[FLASHROM_PROGRESS_NR]; : /* deprecated, do not use */ : flashrom_progress_callback *deprecated_progress_callback; : struct flashrom_progress *deprecated_progress_state; > There is one important detail in current implementation which I think won't work with the union. […] That makes sense, but I think that means the old function is currently inconsistent in its behavior because it's sensitive to the order in which callbacks are initialized: doing the old one first will register both, but the new one first will only register the new one. It's plausible that a library user might mix the old and new APIs on a single flash context, where it would be confusing to be sensitive to initialization order. I think either mixing them should be forbidden, or `flashrom_set_progress_callback` needs to always work. -- To view, visit https://review.coreboot.org/c/flashrom/+/86031?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia8cc0461c449b7e65888a64cdc594c55b81eae7a Gerrit-Change-Number: 86031 Gerrit-PatchSet: 9 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Sun, 23 Feb 2025 22:52:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit February 2025