January 2025 - flashrom-gerrit

[M] Change in flashrom[main]: libflashrom: Update the API for progress callback
by Anastasia Klimchuk (Code Review) 25 Jan '25

25 Jan '25

Attention is currently required from: Anastasia Klimchuk, Richard Hughes, Sergii Dmytruk. Hello Peter Marheine, Richard Hughes, Sergii Dmytruk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86031?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: libflashrom: Update the API for progress callback ...................................................................... libflashrom: Update the API for progress callback The initial version of API for progress callback would require the callback function to make a second call to get the needed data about progress state (current, total etc). This patch changes the callback API, so that callback function gets all needed data straight away as parameters, and with this, callback has all the data to do its job. Since the initial version was submitted and it was in the tree for a while, the change needs to add a _v1 suffix for new thing and deprecated attribute for old thing. Testing: both unit tests and cli are libflashrom clients. All unit tests run successfully, for the cli all scenarios from commit 75dc0655b95dde91f1426a7e5aecfc04d7b8d631 run successfully. Change-Id: Ia8cc0461c449b7e65888a64cdc594c55b81eae7a Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M cli_classic.c M cli_output.c M include/cli_output.h M include/flash.h M include/libflashrom.h M libflashrom.c M libflashrom.map M tests/chip.c M tests/spi25.c 9 files changed, 69 insertions(+), 68 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/86031/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/86031?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia8cc0461c449b7e65888a64cdc594c55b81eae7a Gerrit-Change-Number: 86031 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>

1 0

[S] Change in flashrom[main]: flashchips.c: Add reg_bits for W25Q256JW
by Anastasia Klimchuk (Code Review) 25 Jan '25

25 Jan '25

Attention is currently required from: Hsuan Ting Chen, Kapil Porwal. Anastasia Klimchuk has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/flashrom/+/85323?usp=email ) Change subject: flashchips.c: Add reg_bits for W25Q256JW ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Kapil, the patch CB:83307 is submitted, so you can go ahead. […] Kapil, just checking, is everything alright? To finish this patch, there is one action item on your side, see my previous comments. If you have questions, please tell me! -- To view, visit https://review.coreboot.org/c/flashrom/+/85323?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I050754b28a90911a50f891869297524ce9a6720e Gerrit-Change-Number: 85323 Gerrit-PatchSet: 2 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Sat, 25 Jan 2025 06:43:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: Add more delay time for jlink power on feature to stabilize the LDO a...
by Anastasia Klimchuk (Code Review) 24 Jan '25

24 Jan '25

Attention is currently required from: attila-v. Anastasia Klimchuk has posted comments on this change by attila-v. ( https://review.coreboot.org/c/flashrom/+/86085?usp=email ) Change subject: Add more delay time for jlink power on feature to stabilize the LDO and the decoupling capacitors ...................................................................... Patch Set 2: (3 comments) Patchset: PS2: Hello Atilla, thank you for the patch! I added few comments (below). About `-1` from a buildbot: I can see you updated commit message and it now has sign-off line, so all good. The only thing is, build does not re-run when only commit message is changed. The usual workaround is to rebase the patch and upload new patchset, this triggers the re-run of the buildbot. Commit Message: https://review.coreboot.org/c/flashrom/+/86085/comment/92268d44_adda3d17?us… : PS2, Line 7: Add more delay time for jlink power on feature to stabilize the LDO and the decoupling capacitors We wrap lines in commit message by 72 chars (see here https://flashrom.org/dev_guide/development_guide.html#commit-message-1) Which means, you need limit first line (commit title) as 72 chars, but then you can write longer commit description, you can write multiple paragraphs, just wrap them by 72 chars. I understand that you wanted to provide some details and that's why this line is long, and this is a very good idea to provide details and context. Please keep all that, and you can add more details - just re-write so that you have title as first line and then longer description. Thanks! File jlink_spi.c: https://review.coreboot.org/c/flashrom/+/86085/comment/1764f1e9_ae70c4e5?us… : PS2, Line 469: internal_sleep(100000); I have a question: is this longer delay needed unconditionally (always, for any environment), or only for some environments? -- To view, visit https://review.coreboot.org/c/flashrom/+/86085?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ic2dd94e99ac6ffa17a009b8488ce027698ae2c28 Gerrit-Change-Number: 86085 Gerrit-PatchSet: 2 Gerrit-Owner: attila-v Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: attila-v Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: attila-v Gerrit-Comment-Date: Fri, 24 Jan 2025 05:30:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for progress callback
by Peter Marheine (Code Review) 24 Jan '25

24 Jan '25

Attention is currently required from: Anastasia Klimchuk, Richard Hughes, Sergii Dmytruk. Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86031?usp=email ) Change subject: libflashrom: Update the API for progress callback ...................................................................... Patch Set 1: (1 comment) File include/libflashrom.h: https://review.coreboot.org/c/flashrom/+/86031/comment/e2721600_738a07fa?us… : PS1, Line 93: __attribute__((deprecated("Use flashrom_set_progress_callback_v1 instead"))); This might need some preprocessor guards for platforms where the compiler doesn't support this attribute. Looks like gcc added support for this [around 2009](https://gcc.gnu.org/pipermail/gcc-patches/2009-May/261308.html), but there are probably still some platforms we support where the usual compilers don't understand this. Apparently `[[deprecated]]` is standard since C23 as well, but is probably much too new to use right now. -- To view, visit https://review.coreboot.org/c/flashrom/+/86031?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia8cc0461c449b7e65888a64cdc594c55b81eae7a Gerrit-Change-Number: 86031 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Thu, 23 Jan 2025 23:26:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: doc: Add recent entries into Recent development doc
by Anastasia Klimchuk (Code Review) 24 Jan '25

24 Jan '25

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/86060?usp=email ) Change subject: doc: Add recent entries into Recent development doc ...................................................................... doc: Add recent entries into Recent development doc Normally the info would be added in the same patch, but these efforts were ongoing in parallel with release prep, which makes it hard to modify devel.rst at the same time. Change-Id: Ic852df125c9740d95dc1b9ad8ad97bfd56d40211 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/86060 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M doc/release_notes/devel.rst 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Peter Marheine: Looks good to me, approved Matt DeVillier: Looks good to me, but someone else must approve build bot (Jenkins): Verified diff --git a/doc/release_notes/devel.rst b/doc/release_notes/devel.rst index bb2b73d..05fe4a0 100644 --- a/doc/release_notes/devel.rst +++ b/doc/release_notes/devel.rst @@ -16,3 +16,22 @@ not currently supported. https://ticket.coreboot.org/issues/370 + +flashchips.c split into separate files by vendor +================================================ + +``flashchips.c`` file was split into separate files per vendor. flashchips.c still exists in the source +code but it is much smaller and only contain "generic" chip entries. + +With this, instead of one file ``flashchips.c`` we now have a ``flashchips/`` directory which contains +all the files. + +There are no changes to the usage, and everything that's supported stays the same. + +New features +============ + +-r/-w/-v argument is optional when using -i +------------------------------------------- + +See :doc:`/classic_cli_manpage` for details. -- To view, visit https://review.coreboot.org/c/flashrom/+/86060?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ic852df125c9740d95dc1b9ad8ad97bfd56d40211 Gerrit-Change-Number: 86060 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: Add more delay time for jlink power on feature to stabilize the LDO a...
by attila-v (Code Review) 23 Jan '25

23 Jan '25

attila-v has posted comments on this change by attila-v. ( https://review.coreboot.org/c/flashrom/+/86085?usp=email ) Change subject: Add more delay time for jlink power on feature to stabilize the LDO and the decoupling capacitors ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/86085?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ic2dd94e99ac6ffa17a009b8488ce027698ae2c28 Gerrit-Change-Number: 86085 Gerrit-PatchSet: 2 Gerrit-Owner: attila-v Gerrit-Reviewer: attila-v Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 23 Jan 2025 08:20:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in flashrom[main]: Add more delay time for jlink power on feature to stabilize the LDO a...
by attila-v (Code Review) 22 Jan '25

22 Jan '25

Attention is currently required from: attila-v. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86085?usp=email to look at the new patch set (#2). Change subject: Add more delay time for jlink power on feature to stabilize the LDO and the decoupling capacitors ...................................................................... Add more delay time for jlink power on feature to stabilize the LDO and the decoupling capacitors Change-Id: Ic2dd94e99ac6ffa17a009b8488ce027698ae2c28 Signed-off-by: Attila Veghelyi <aveghelyi(a)dension.com> --- M jlink_spi.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/85/86085/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/86085?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ic2dd94e99ac6ffa17a009b8488ce027698ae2c28 Gerrit-Change-Number: 86085 Gerrit-PatchSet: 2 Gerrit-Owner: attila-v Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: attila-v

1 0

[XS] Change in flashrom[main]: Add more delay time for jlink power on feature to stabilize the LDO a...
by attila-v (Code Review) 21 Jan '25

21 Jan '25

attila-v has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/86085?usp=email ) Change subject: Add more delay time for jlink power on feature to stabilize the LDO and the decoupling capacitors ...................................................................... Add more delay time for jlink power on feature to stabilize the LDO and the decoupling capacitors Change-Id: Ic2dd94e99ac6ffa17a009b8488ce027698ae2c28 --- M jlink_spi.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/85/86085/1 diff --git a/jlink_spi.c b/jlink_spi.c index 447629c..7558676 100644 --- a/jlink_spi.c +++ b/jlink_spi.c @@ -466,7 +466,7 @@ } /* Wait some time until the target is powered up. */ - internal_sleep(10000); + internal_sleep(100000); } struct jaylink_hardware_status hwstat; -- To view, visit https://review.coreboot.org/c/flashrom/+/86085?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ic2dd94e99ac6ffa17a009b8488ce027698ae2c28 Gerrit-Change-Number: 86085 Gerrit-PatchSet: 1 Gerrit-Owner: attila-v

1 0

[S] Change in flashrom[main]: doc: Add recent entries into Recent development doc
by Peter Marheine (Code Review) 20 Jan '25

20 Jan '25

Attention is currently required from: Anastasia Klimchuk. Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86060?usp=email ) Change subject: doc: Add recent entries into Recent development doc ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/86060?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ic852df125c9740d95dc1b9ad8ad97bfd56d40211 Gerrit-Change-Number: 86060 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 20 Jan 2025 21:31:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: doc: Add recent entries into Recent development doc
by Matt DeVillier (Code Review) 20 Jan '25

20 Jan '25

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Matt DeVillier has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86060?usp=email ) Change subject: doc: Add recent entries into Recent development doc ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/86060?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ic852df125c9740d95dc1b9ad8ad97bfd56d40211 Gerrit-Change-Number: 86060 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Mon, 20 Jan 2025 14:47:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit January 2025