July 2024 - flashrom-gerrit - mail.coreboot.org

[XS] Change in flashrom[main]: libflashrom.map: remove non-existent functions
by Fabian Groffen (Code Review) 02 Jul '24

02 Jul '24

Fabian Groffen has posted comments on this change by Fabian Groffen. ( https://review.coreboot.org/c/flashrom/+/83261?usp=email ) Change subject: libflashrom.map: remove non-existent functions ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: > Fabian I also noticed, from the bug you linked, what does it mean flashrom-1.3.0-r2 ? […] -r2 is just a Gentoo (distro-specific) revision, you can ignore it. I made this fix on HEAD, searching for the functions there. I didn't use the 1.3.0 codebase. I just backported the patch for Gentoo. I'm waiting for 1.4.0 release to package it in Gentoo. Commit Message: https://review.coreboot.org/c/flashrom/+/83261/comment/58abf05f_a5f00dba?us… : PS1, Line 7: non-existant > non-existent (typo) Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83261?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I30bab842d9cbd2daaa9902fd3223f47145cb0e7f Gerrit-Change-Number: 83261 Gerrit-PatchSet: 2 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Jul 2024 17:19:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XL] Change in flashrom[main]: [RFC] flashchips: Begin splitting flashchips by vendor
by Angel Pons (Code Review) 02 Jul '24

02 Jul '24

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/83307?usp=email ) Change subject: [RFC] flashchips: Begin splitting flashchips by vendor ...................................................................... [RFC] flashchips: Begin splitting flashchips by vendor To make the flashchips "database" easier to manage, split it by vendor into several smaller files. This commit transfers the bulk of the data to separate files and includes them from `flashchips.c`. Although this is ugly (.c includes are usually frowned upon), it is a necessary evil to make this commit reproducible. TODO: Test reproducibility. Change-Id: I3a9ebb0575e2700c5871d16875495d9c8943b30b Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c A flashchips/amd.c A flashchips/amic.c A flashchips/atmel.c A flashchips/boya_bohong.c A flashchips/bright.c A flashchips/catalyst.c A flashchips/ene.c A flashchips/eon.c A flashchips/esi.c A flashchips/esmt.c A flashchips/fudan.c A flashchips/fujitsu.c A flashchips/gigadevice.c A flashchips/hyundai.c A flashchips/intel.c A flashchips/issi.c A flashchips/macronix.c A flashchips/micron.c A flashchips/micron_numonyx_st.c A flashchips/mosel_vitelic.c A flashchips/nantronics.c A flashchips/pmc.c A flashchips/puya.c A flashchips/sanyo.c A flashchips/sharp.c A flashchips/spansion.c A flashchips/sst.c A flashchips/st.c A flashchips/syncmos_mosel_vitelic.c A flashchips/ti.c A flashchips/winbond.c A flashchips/xmc.c A flashchips/xtx.c A flashchips/zetta.c 35 files changed, 23,174 insertions(+), 22,490 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/07/83307/1 -- To view, visit https://review.coreboot.org/c/flashrom/+/83307?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I3a9ebb0575e2700c5871d16875495d9c8943b30b Gerrit-Change-Number: 83307 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

[XS] Change in flashrom[main]: dummyflasher: assign address of function for LLVM
by Fabian Groffen (Code Review) 02 Jul '24

02 Jul '24

Fabian Groffen has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/83262?usp=email ) Change subject: dummyflasher: assign address of function for LLVM ...................................................................... Abandoned This is invalid. I took over from previous maintainer, and didn't notice a backport of https://review.coreboot.org/c/flashrom/+/70264 (https://github.com/flashrom/flashrom/commit/e1f30bbce7a603d518ecec9d7e68857…) which changed the definition from non-const to const. Because the previous commit changing this all to const is missing in 1.3.0 release, this caused this incompatibility and really is a backport bug on our part. When I tested this on the git sources, I didn't get the warning because the current sources have this all sorted out correctly offcourse. Apologies for the noise on this one. -- To view, visit https://review.coreboot.org/c/flashrom/+/83262?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8e5c9ea014d40a2e9e0621b25f8c404e80a79952 Gerrit-Change-Number: 83262 Gerrit-PatchSet: 1 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: libflashrom.map: remove non-existent functions
by Anastasia Klimchuk (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Fabian Groffen. Anastasia Klimchuk has posted comments on this change by Fabian Groffen. ( https://review.coreboot.org/c/flashrom/+/83261?usp=email ) Change subject: libflashrom.map: remove non-existent functions ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: Fabian I also noticed, from the bug you linked, what does it mean flashrom-1.3.0-r2 ? We are currently at v1.4.0-rc1. Which tag you synced, or HEAD ? -- To view, visit https://review.coreboot.org/c/flashrom/+/83261?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I30bab842d9cbd2daaa9902fd3223f47145cb0e7f Gerrit-Change-Number: 83261 Gerrit-PatchSet: 2 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Comment-Date: Tue, 02 Jul 2024 13:39:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in flashrom[main]: dummyflasher: assign address of function for LLVM
by Fabian Groffen (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Fabian Groffen has posted comments on this change by Fabian Groffen. ( https://review.coreboot.org/c/flashrom/+/83262?usp=email ) Change subject: dummyflasher: assign address of function for LLVM ...................................................................... Patch Set 1: (1 comment) File dummyflasher.c: https://review.coreboot.org/c/flashrom/+/83262/comment/fdca1c36_2fa2d9a5?us… : PS1, Line 972: & > I agree this is odd; I'm not able to reproduce using Clang 16 in what looks like it should be a mini […] I'm a tool. The problem is the const. Not sure what I've been testing. -- To view, visit https://review.coreboot.org/c/flashrom/+/83262?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8e5c9ea014d40a2e9e0621b25f8c404e80a79952 Gerrit-Change-Number: 83262 Gerrit-PatchSet: 1 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Tue, 02 Jul 2024 12:52:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[XS] Change in flashrom[main]: libflashrom.map: remove non-existent functions
by Fabian Groffen (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Fabian Groffen. Hello Anastasia Klimchuk, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/83261?usp=email to look at the new patch set (#2). Change subject: libflashrom.map: remove non-existent functions ...................................................................... libflashrom.map: remove non-existent functions Remove symbol names from the map that do not exist in the code. https://bugs.gentoo.org/928955 Change-Id: I30bab842d9cbd2daaa9902fd3223f47145cb0e7f Signed-off-by: Fabian Groffen <grobian(a)gentoo.org> --- M libflashrom.map 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/61/83261/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/83261?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I30bab842d9cbd2daaa9902fd3223f47145cb0e7f Gerrit-Change-Number: 83261 Gerrit-PatchSet: 2 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Fabian Groffen <grobian(a)gentoo.org>

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QU16C
by Anastasia Klimchuk (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83234?usp=email ) Change subject: flashchips: Add Support for XMC XM25QU16C ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Kan, as I mentioned in other comment, we can submit the patch after tag v1.4.0, which is estimated as 26 July. But meanwhile, I can gradually go through your other patches and review, and so we can get everything nice and ready by the end of July! -- To view, visit https://review.coreboot.org/c/flashrom/+/83234?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0989b5dd239dd32f93e1a338a70e5d7279127d8d Gerrit-Change-Number: 83234 Gerrit-PatchSet: 1 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 02 Jul 2024 07:00:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QU16C
by Anastasia Klimchuk (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83234?usp=email ) Change subject: flashchips: Add Support for XMC XM25QU16C ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Wait until the tag v1.4.0 done and after that the patch can be submitted. ETA 26 July. https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/UUDQ… -- To view, visit https://review.coreboot.org/c/flashrom/+/83234?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0989b5dd239dd32f93e1a338a70e5d7279127d8d Gerrit-Change-Number: 83234 Gerrit-PatchSet: 1 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 02 Jul 2024 06:57:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in flashrom[main]: flashchips: Add chip models GD25LB256F/GD25LR256F
by Anastasia Klimchuk (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Victor Lim. Anastasia Klimchuk has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/83254?usp=email ) Change subject: flashchips: Add chip models GD25LB256F/GD25LR256F ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/83254/comment/0018a6ed_77d3bc72?us… : PS1, Line 13: https://www.gigadevice.com/message-board?cid=39&id=3171&file_type=Datasheet… I went by the link, but it opens "Contact Us" page, not the datasheet? (first link opens datasheet) -- To view, visit https://review.coreboot.org/c/flashrom/+/83254?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0fbd270a57999d4131816c48470588bb7ec22d37 Gerrit-Change-Number: 83254 Gerrit-PatchSet: 1 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Victor Lim <vlim(a)gigadevice.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 02 Jul 2024 06:30:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in flashrom[main]: dummyflasher: assign address of function for LLVM
by Peter Marheine (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Anastasia Klimchuk, Fabian Groffen. Peter Marheine has posted comments on this change by Fabian Groffen. ( https://review.coreboot.org/c/flashrom/+/83262?usp=email ) Change subject: dummyflasher: assign address of function for LLVM ...................................................................... Patch Set 1: (1 comment) File dummyflasher.c: https://review.coreboot.org/c/flashrom/+/83262/comment/46a93416_bbbd9702?us… : PS1, Line 972: & > Why this is not needed for all other function pointers? (I feel like I am missing something. […] I agree this is odd; I'm not able to reproduce using Clang 16 in what looks like it should be a minimal reproducer: https://godbolt.org/z/Tcbd4bvz9 It's possible there's a detail I'm not capturing, or the compiler raising this is broken somehow. -- To view, visit https://review.coreboot.org/c/flashrom/+/83262?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8e5c9ea014d40a2e9e0621b25f8c404e80a79952 Gerrit-Change-Number: 83262 Gerrit-PatchSet: 1 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Comment-Date: Tue, 02 Jul 2024 04:38:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit July 2024