Attention is currently required from: Anastasia Klimchuk, Thomas Heijligen.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81606?usp=email )
Change subject: Make sleep threshold for delays configurable
......................................................................
Patch Set 3:
(3 comments)
File Makefile:
https://review.coreboot.org/c/flashrom/+/81606/comment/7d6bd934_c2352815 :
PS2, Line 545: CONFIG_DELAY_MINIMUM_SLEEP_US ?= 100000
> meson_options. […]
Done
File tests/udelay.c:
https://review.coreboot.org/c/flashrom/+/81606/comment/559241cb_26a68d48 :
PS2, Line 45: udelay_test_short
> For completeness, it would be good to build and run unit tests with few different settings: […]
Done, also needed to change the code a little to not generate spurious errors when it's set to zero.
https://review.coreboot.org/c/flashrom/+/81606/comment/f6d76b38_3abb2884 :
PS2, Line 52: if (delay_us >= CONFIG_DELAY_MINIMUM_SLEEP_US)
> why this condition is needed? […]
The test always takes at least as long to run as the chosen delay time, so 0.1ms seemed like a reasonable tradeoff between a meaninful delay and not wasting a lot of time running the test.
1ms still seems like an okay maximum if you wanted one that's more than the current value, though.
--
To view, visit https://review.coreboot.org/c/flashrom/+/81606?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ida96e0816ac914ed69d6fd82ad90ebe89cdef1cc
Gerrit-Change-Number: 81606
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Mon, 29 Apr 2024 01:17:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Peter Marheine, Thomas Heijligen.
Hello Anastasia Klimchuk, Thomas Heijligen, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/81606?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: Make sleep threshold for delays configurable
......................................................................
Make sleep threshold for delays configurable
This allows the minimum time that default_delay() will choose to sleep
for instead of polling to be configured at build-time. The default
remains unchanged at 100 milliseconds for now.
The test's correctness has been checked by testing with minimum sleep
time left at its default and set to a non-default value smaller than 100
microseconds (both pass without sleeping, verified with strace) and with
the minimum sleep time set to 0 (causing the test to be skipped). The
configured value from the macro needs to be stored in a const to avoid
-Werror=type-limits errors when configured to be zero.
Change-Id: Ida96e0816ac914ed69d6fd82ad90ebe89cdef1cc
Signed-off-by: Peter Marheine <pmarheine(a)chromium.org>
---
M Makefile
M meson.build
M meson_options.txt
M tests/udelay.c
M udelay.c
M udelay_dos.c
6 files changed, 36 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/81606/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/81606?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ida96e0816ac914ed69d6fd82ad90ebe89cdef1cc
Gerrit-Change-Number: 81606
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-MessageType: newpatchset
Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/49599?usp=email )
Change subject: flashrom.c: automatic generated programmer_enum.h
......................................................................
Abandoned
programmer_enum has been deleted in the other patch
--
To view, visit https://review.coreboot.org/c/flashrom/+/49599?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I3f4370ccae2b64da3c4178243b192700d3d205d2
Gerrit-Change-Number: 49599
Gerrit-PatchSet: 6
Gerrit-Owner: Xiang W <wxjstz(a)126.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Sam McNally <sammc(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org>
Gerrit-MessageType: abandon
Attention is currently required from: J. Neuschäfer, Riku Viitanen, Swift Geek (Sebastian Grzywna), Sydney, Thomas Heijligen, Urja Rannikko.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82018?usp=email )
Change subject: doc: Convert serprog docs to rst and add to doc directory
......................................................................
Patch Set 3:
(1 comment)
File doc/supported_hw/supported_prog/serprog/overview.rst:
https://review.coreboot.org/c/flashrom/+/82018/comment/7914f1c5_c234b85f :
PS1, Line 83: See `the github page <https://github.com/dword1511/serprog-stm32vcp#serprog-stm32vcp>`_ for further details, source code etc.
> Somewhat. […]
Your suggestion is really good, and I replaced existing paragraph with your words.
--
To view, visit https://review.coreboot.org/c/flashrom/+/82018?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ie52f1e051ed215d61d5fb535e3eddeac71f64d13
Gerrit-Change-Number: 82018
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com>
Gerrit-Reviewer: Sydney <git(a)funkeleinhorn.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: J. Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Attention: Urja Rannikko <urjaman(a)gmail.com>
Gerrit-Attention: J. Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Sydney <git(a)funkeleinhorn.com>
Gerrit-Attention: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com>
Gerrit-Comment-Date: Sat, 27 Apr 2024 09:39:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: J. Neuschäfer <j.neuschaefer(a)gmx.net>
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Anastasia Klimchuk, Riku Viitanen, Swift Geek (Sebastian Grzywna), Sydney, Thomas Heijligen, Urja Rannikko.
Hello Riku Viitanen, Swift Geek (Sebastian Grzywna), Sydney, Thomas Heijligen, Urja Rannikko, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/82018?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: doc: Convert serprog docs to rst and add to doc directory
......................................................................
doc: Convert serprog docs to rst and add to doc directory
Change-Id: Ie52f1e051ed215d61d5fb535e3eddeac71f64d13
Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org>
---
D Documentation/serprog-protocol.txt
M doc/classic_cli_manpage.rst
M doc/index.rst
A doc/supported_hw/index.rst
A doc/supported_hw/supported_prog/index.rst
A doc/supported_hw/supported_prog/serprog/166px-Serprogduino_v2.jpeg
A doc/supported_hw/supported_prog/serprog/250px-Arduino_5V_lpc_spi_shield.jpg
A doc/supported_hw/supported_prog/serprog/250px-Arduino_lpcspi_shield_render.png
A doc/supported_hw/supported_prog/serprog/300px-AtmegaXXu2-flasher.jpg
A doc/supported_hw/supported_prog/serprog/300px-Avr_rs232_programmer.jpg
A doc/supported_hw/supported_prog/serprog/300px-HydraFW_Default_PinAssignment.png
A doc/supported_hw/supported_prog/serprog/300px-Serprog_0001.jpeg
A doc/supported_hw/supported_prog/serprog/300px-Teensy31_lpcspi_flasher.jpg
A doc/supported_hw/supported_prog/serprog/P1v1_arduino328.png
A doc/supported_hw/supported_prog/serprog/P1v2_arduino1280.png
A doc/supported_hw/supported_prog/serprog/P2v1_resdivider.png
A doc/supported_hw/supported_prog/serprog/P2v2_oc_cs.png
A doc/supported_hw/supported_prog/serprog/P2v3_buffer4050.png
A doc/supported_hw/supported_prog/serprog/P3v1_dil8_so8_spi.png
A doc/supported_hw/supported_prog/serprog/P3v2_so16_spi.png
A doc/supported_hw/supported_prog/serprog/arduino_flasher.rst
A doc/supported_hw/supported_prog/serprog/arduino_flasher_3.3v.rst
A doc/supported_hw/supported_prog/serprog/index.rst
A doc/supported_hw/supported_prog/serprog/overview.rst
A doc/supported_hw/supported_prog/serprog/serprog-protocol.rst
A doc/supported_hw/supported_prog/serprog/teensy_3_1.rst
26 files changed, 806 insertions(+), 124 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/18/82018/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/82018?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ie52f1e051ed215d61d5fb535e3eddeac71f64d13
Gerrit-Change-Number: 82018
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com>
Gerrit-Reviewer: Sydney <git(a)funkeleinhorn.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: J. Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Attention: Urja Rannikko <urjaman(a)gmail.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Sydney <git(a)funkeleinhorn.com>
Gerrit-Attention: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com>
Gerrit-MessageType: newpatchset