flashrom-gerrit February 2024

flashrom-gerrit@flashrom.org

1 participants
52 discussions

[S] Change in flashrom[main]: flashchips: Add Macronix MX25R1635F
by ra1nb0w (Code Review) 02 Feb '24

02 Feb '24

Attention is currently required from: ra1nb0w. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/69678?usp=email to look at the new patch set (#2). Change subject: flashchips: Add Macronix MX25R1635F ...................................................................... flashchips: Add Macronix MX25R1635F 16Mbit (2MiB) [x1/x2/x4] Wide Voltage Range (VCC 1.65V-3.6V). It is similar to the already-supported MX25R3235F, but the total size is halved. Tested probe, read, erase, write and verify with buspirate. Datasheet: https://www.mxic.com.tw/Lists/Datasheet/Attachments/8702/MX25R1635F,%20Wide… Change-Id: Idce301ed90d6742b56e928068d201e5c3a2e5aee Signed-off-by: Davide Gerhard <rainbow(a)irh.it> --- M flashchips.c M include/flashchips.h 2 files changed, 40 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/69678/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/69678?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Idce301ed90d6742b56e928068d201e5c3a2e5aee Gerrit-Change-Number: 69678 Gerrit-PatchSet: 2 Gerrit-Owner: ra1nb0w <rainbow(a)irh.it> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: ra1nb0w <rainbow(a)irh.it> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[main]: flashchips: Remove Macronix MX25U25635F from chip list
by Anastasia Klimchuk (Code Review) 02 Feb '24

02 Feb '24

Attention is currently required from: Daniel, Nikolai Artemiev, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79633?usp=email ) Change subject: flashchips: Remove Macronix MX25U25635F from chip list ...................................................................... Patch Set 1: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/79633/comment/39a8999d_cac946ee : PS1, Line 10310: .wps = {SECURITY, 7, OTP}, /* This bit is set by WPSEL command */ > Hi, if WPSEL command is issued for MX25U25635F (older chip), it will be ignored. In general, what Nikolai is saying is the right approach, and also it's a future-proof approach. I understand this situation happens for the first time? (the situation being two chips of the same model ID, and the customer only wants the newest one). But realistically, it is likely to happen again. And next time two chips may have more differences than just one .wps reg bit. As an upstream project, we maintain all the chips (and older too) and removing the chip definition is something extremely rare (to the extent that I have never seen this happening). There are lots of users, and you never know which chips people are using. Specifically to your customer situation, if the customer has a fork of flashrom, they can introduce a local list of chips to ignore, and add old models there. This way they don't need to change automatic test flow, and also it's a future-proof solution as any more old chips like that can be added to the list. In terms of how hard it is to implement, Chrome OS flashrom is also open source, and they implemented this solution, so the code can be used as an inspiration. If you are interested, I can try to find links to relevant code. I don't know how your communication with customer is set up, but if it is fine, you are welcome to share with them the link to this patch (so that they can see the discussion), and you can even add them to this patch (if there is an engineer from customer side who can create a Gerrit account). What do you think about it? -- To view, visit https://review.coreboot.org/c/flashrom/+/79633?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ief3fd7641bed817066692c4abffff6d3b0df16b9 Gerrit-Change-Number: 79633 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Daniel Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 02 Feb 2024 09:27:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Daniel Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit February 2024