February 2024 - flashrom-gerrit

[L] Change in flashrom[main]: Add initial CH347T SPI programmer
by Anastasia Klimchuk (Code Review) 23 Feb '24

23 Feb '24

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/70529?usp=email ) Change subject: Add initial CH347T SPI programmer ...................................................................... Abandoned merged as CB:70573 -- To view, visit https://review.coreboot.org/c/flashrom/+/70529?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I6da5e308af76693e60308c8165349128e517e09a Gerrit-Change-Number: 70529 Gerrit-PatchSet: 9 Gerrit-Owner: qianfan <qianfanguijin(a)163.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in flashrom[main]: doc: Clarify that adding docs follows dev process and add into howtos
by Anastasia Klimchuk (Code Review) 23 Feb '24

23 Feb '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/80631?usp=email ) Change subject: doc: Clarify that adding docs follows dev process and add into howtos ...................................................................... doc: Clarify that adding docs follows dev process and add into howtos Also add link to "How to add new doc" into a collection of Contributors howtos. The doc stays in root of docs, and also in the main left-side menu on the website, so that it is very easy to discover. Everyone who has even the slightest motivation to update the docs, should be able to find instructions easily. Change-Id: I882de0614ab76b8e83b0fafa67296526fecd8a16 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/80631 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M doc/contrib_howtos/index.rst M doc/how_to_add_docs.rst 2 files changed, 6 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved diff --git a/doc/contrib_howtos/index.rst b/doc/contrib_howtos/index.rst index 59326cd..b33482d 100644 --- a/doc/contrib_howtos/index.rst +++ b/doc/contrib_howtos/index.rst @@ -7,3 +7,4 @@ how_to_add_new_chip how_to_mark_chip_tested how_to_add_unit_test + ../how_to_add_docs diff --git a/doc/how_to_add_docs.rst b/doc/how_to_add_docs.rst index 0b32acb..ee99ce7 100644 --- a/doc/how_to_add_docs.rst +++ b/doc/how_to_add_docs.rst @@ -1,6 +1,11 @@ How to add or update docs ========================= +Documentation files live in ``/doc`` directory in the source tree, so +adding or updating documentation follows the same process as changing +the code. If you've never done it before, start by carefully +reading the :doc:`/dev_guide/development_guide`. + To add or update a documentation page, you need to create or modify an ``.rst`` file in the ``/doc`` directory and send a patch for review. -- To view, visit https://review.coreboot.org/c/flashrom/+/80631?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I882de0614ab76b8e83b0fafa67296526fecd8a16 Gerrit-Change-Number: 80631 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in flashrom[main]: Makefile: Fix version string for non-Git builds
by Anastasia Klimchuk (Code Review) 22 Feb '24

22 Feb '24

Attention is currently required from: Anton Samsonov, Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79152?usp=email ) Change subject: Makefile: Fix version string for non-Git builds ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/79152?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8694e618878823a9e96b1f2bcfa63f6c71d3c2ed Gerrit-Change-Number: 79152 Gerrit-PatchSet: 6 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-CC: Anton Samsonov <contact-launchpad(a)zxlab.ru> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Comment-Date: Thu, 22 Feb 2024 09:56:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: Makefile: Fix version string for non-Git builds
by Anton Samsonov (Code Review) 21 Feb '24

21 Feb '24

Attention is currently required from: Anastasia Klimchuk, Anton Samsonov, Thomas Heijligen. Anton Samsonov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79152?usp=email ) Change subject: Makefile: Fix version string for non-Git builds ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/79152/comment/a8cacba5_0f9cb20b : PS5, Line 7: non-Git builds > How do you get the repo without Git? This patch applies to standalone source trees produced by GitHub snapshot (“Download ZIP” form of repo cloning), as well as `git archive`, and perhaps future releases. In fact, meson.build already behaves as expected in both Git- and non-Git scenarios — I just mirrored this behavior to Makefile. -- To view, visit https://review.coreboot.org/c/flashrom/+/79152?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8694e618878823a9e96b1f2bcfa63f6c71d3c2ed Gerrit-Change-Number: 79152 Gerrit-PatchSet: 6 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-CC: Anton Samsonov <contact-launchpad(a)zxlab.ru> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Comment-Date: Wed, 21 Feb 2024 17:57:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: Makefile: Fix version string for non-Git builds
by Anton Samsonov (Code Review) 21 Feb '24

21 Feb '24

Attention is currently required from: Anastasia Klimchuk, Anton Samsonov, Thomas Heijligen. Hello Anastasia Klimchuk, Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/79152?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by Anastasia Klimchuk, Verified+1 by build bot (Jenkins) Change subject: Makefile: Fix version string for non-Git builds ...................................................................... Makefile: Fix version string for non-Git builds Match the version string for `make` builds to that of `meson` builds from both Git- and non-Git (release or current snapshot) source trees. Change-Id: I8694e618878823a9e96b1f2bcfa63f6c71d3c2ed Signed-off-by: Anton Samsonov <devel(a)zxlab.ru> --- M Makefile 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/52/79152/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/79152?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I8694e618878823a9e96b1f2bcfa63f6c71d3c2ed Gerrit-Change-Number: 79152 Gerrit-PatchSet: 6 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Anton Samsonov <contact-launchpad(a)zxlab.ru> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[main]: Makefile,meson.build: Add support for Sphinx versions prior to 4.x
by Anastasia Klimchuk (Code Review) 21 Feb '24

21 Feb '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/77778?usp=email ) Change subject: Makefile,meson.build: Add support for Sphinx versions prior to 4.x ...................................................................... Makefile,meson.build: Add support for Sphinx versions prior to 4.x As of version 3.x, `sphinx-build` outputs man pages to "8" directory instead of "man8" expected by Makefile and doc/meson.build. See: https://github.com/sphinx-doc/sphinx/issues/7996 https://github.com/sphinx-doc/sphinx/issues/9217 Current solution is to rename "8" to "man8" after documentation build. That enables successful build and installation, as well as dependency tracking at build-system level, but not on `sphinx-build` own level upon which `meson` build blindly relies. Change-Id: I9cd280551a1ba4d17edb2e857d56f80431b61e1b Signed-off-by: Anton Samsonov <devel(a)zxlab.ru> Reviewed-on: https://review.coreboot.org/c/flashrom/+/77778 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> --- M Makefile M doc/meson.build A doc/sphinx-wrapper.sh 3 files changed, 51 insertions(+), 2 deletions(-) Approvals: Anastasia Klimchuk: Looks good to me, approved build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved diff --git a/Makefile b/Makefile index 7b1312d..a36e575 100644 --- a/Makefile +++ b/Makefile @@ -228,6 +228,10 @@ CONFIG_LIBPCI_CFLAGS := $(call dependency_cflags, libpci) CONFIG_LIBPCI_LDFLAGS := $(call dependency_ldflags, libpci) +CONFIG_SPHINXBUILD_VERSION := +CONFIG_SPHINXBUILD_MAJOR := 0 + + # Determine the destination OS, architecture and endian # IMPORTANT: The following lines must be placed before TARGET_OS, ARCH or ENDIAN # is ever used (of course), but should come after any lines setting CC because @@ -958,6 +962,11 @@ OBJS = $(CHIP_OBJS) $(PROGRAMMER_OBJS) $(LIB_OBJS) +ifeq ($(HAS_SPHINXBUILD), yes) +override CONFIG_SPHINXBUILD_VERSION := $(shell $(SPHINXBUILD) --version | cut -d' ' -f2 ) +override CONFIG_SPHINXBUILD_MAJOR := $(shell echo "$(CONFIG_SPHINXBUILD_VERSION)" | cut -d'.' -f1 ) +endif + all: $(PROGRAM)$(EXEC_SUFFIX) $(call has_dependency, $(HAS_SPHINXBUILD), man8/$(PROGRAM).8) ifeq ($(ARCH), x86) @@ -1022,7 +1031,7 @@ echo "The following features are unavailable on your machine: $(UNSUPPORTED_FEATURES)" \ exit 1; \ fi - @echo "Checking for program \"sphinx-build\": $(HAS_SPHINXBUILD)" + @echo "Checking for program \"sphinx-build\": $(HAS_SPHINXBUILD) $(CONFIG_SPHINXBUILD_VERSION)" %.o: %.c | config $(CC) -MMD $(CFLAGS) $(CPPFLAGS) $(FLASHROM_CFLAGS) $(FEATURE_FLAGS) -D'FLASHROM_VERSION=$(VERSION)' -o $@ -c $< @@ -1035,8 +1044,18 @@ $(RANLIB) $@ man8/$(PROGRAM).8: doc/* +# When using sphinx-build prior to version 4.x, man pages are output +# to a directory named "8" instead of expected "man8". We fix that +# by renaming "8" to "man8" and creating symlink "8" pointing to "man8". @if [ "$(HAS_SPHINXBUILD)" = "yes" ]; then \ $(SPHINXBUILD) -Drelease=$(VERSION) -b man doc .; \ + if [ "$(CONFIG_SPHINXBUILD_MAJOR)" -lt 4 ]; then \ + if [ -d 8 -a ! -L 8 ]; then \ + rm -rf man8; \ + mv 8 man8; \ + ln -s man8 8; \ + fi \ + fi \ else \ echo "$(SPHINXBUILD) not found. Can't build man-page"; \ exit 1; \ diff --git a/doc/meson.build b/doc/meson.build index aca73d8..5bc57b9 100644 --- a/doc/meson.build +++ b/doc/meson.build @@ -1,5 +1,6 @@ sphinx = find_program('sphinx-build', native : true, required : get_option('man-pages').enabled() or get_option('documentation').enabled()) +sphinx_wrapper = meson.current_source_dir() / 'sphinx-wrapper.sh' man_pages = [ 'flashrom.8' @@ -14,7 +15,7 @@ custom_target( 'man-pages', - command : [sphinx, '-b', 'man', '-q', '-d', '@PRIVATE_DIR@', '-Drelease=' + flashrom_version,'@CURRENT_SOURCE_DIR@', '@OUTDIR@'], + command : [sphinx_wrapper, '@OUTDIR@', ' '.join(man_outputs), sphinx, '-b', 'man', '-q', '-d', '@PRIVATE_DIR@', '-Drelease=' + flashrom_version, '@CURRENT_SOURCE_DIR@', '@OUTDIR@'], build_always_stale : true, # sphinx handles rebuilds output : man_outputs, install : true, diff --git a/doc/sphinx-wrapper.sh b/doc/sphinx-wrapper.sh new file mode 100755 index 0000000..5569638 --- /dev/null +++ b/doc/sphinx-wrapper.sh @@ -0,0 +1,29 @@ +#!/bin/sh + +OUTPUT_HOME="$1" +MAN_OUTPUTS="$2" +SPHINXBUILD="$3" +shift 3 + +"${SPHINXBUILD}" "$@" || exit $? + +SPHINXBUILD_MAJOR="$("${SPHINXBUILD}" --version | cut -d' ' -f2 | cut -d'.' -f1)" +if [ "${SPHINXBUILD_MAJOR}" -ge 4 ]; then + exit 0 +fi + +# sphinx-build 3.x outputs man pages to "8" directory instead of expected "man8". +# The following block checks for "man8" (and other output paths in ${MAN_OUTPUTS}) +# and, if that is missing, but "8" dir exists instead, it renames "8" to "man8" +# and creates a symlink named "8" that points to "man8", so that anyone is happy +# during the rest of current build and subsequent builds as well. + +for MAN_OUTPUT in ${MAN_OUTPUTS}; do + PATH_TARGET="${OUTPUT_HOME}/${MAN_OUTPUT}" + PATH_ACTUAL="${OUTPUT_HOME}/${MAN_OUTPUT#man}" + if [ -d "${PATH_ACTUAL}" -a ! -L "${PATH_ACTUAL}" ]; then + rm -rf "${PATH_TARGET}" + mv "${PATH_ACTUAL}" "${PATH_TARGET}" + ln -s "${MAN_OUTPUT}" "${PATH_ACTUAL}" + fi +done -- To view, visit https://review.coreboot.org/c/flashrom/+/77778?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I9cd280551a1ba4d17edb2e857d56f80431b61e1b Gerrit-Change-Number: 77778 Gerrit-PatchSet: 8 Gerrit-Owner: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in flashrom[main]: doc: Clarify that adding docs follows dev process and add into howtos
by Stefan Reinauer (Code Review) 20 Feb '24

20 Feb '24

Attention is currently required from: Anastasia Klimchuk, Thomas Heijligen. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/80631?usp=email ) Change subject: doc: Clarify that adding docs follows dev process and add into howtos ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/80631?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I882de0614ab76b8e83b0fafa67296526fecd8a16 Gerrit-Change-Number: 80631 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 20 Feb 2024 00:55:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: doc: Clarify that adding docs follows dev process and add into howtos
by Anastasia Klimchuk (Code Review) 19 Feb '24

19 Feb '24

Attention is currently required from: Thomas Heijligen. Hello Thomas Heijligen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/80631?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: doc: Clarify that adding docs follows dev process and add into howtos ...................................................................... doc: Clarify that adding docs follows dev process and add into howtos Also add link to "How to add new doc" into a collection of Contributors howtos. The doc stays in root of docs, and also in the main left-side menu on the website, so that it is very easy to discover. Everyone who has even the slightest motivation to update the docs, should be able to find instructions easily. Change-Id: I882de0614ab76b8e83b0fafa67296526fecd8a16 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/contrib_howtos/index.rst M doc/how_to_add_docs.rst 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/80631/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/80631?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I882de0614ab76b8e83b0fafa67296526fecd8a16 Gerrit-Change-Number: 80631 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

[XS] Change in flashrom[main]: doc: Clarify that adding docs follows dev process
by Anastasia Klimchuk (Code Review) 19 Feb '24

19 Feb '24

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/80631?usp=email ) Change subject: doc: Clarify that adding docs follows dev process ...................................................................... doc: Clarify that adding docs follows dev process Change-Id: I882de0614ab76b8e83b0fafa67296526fecd8a16 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/how_to_add_docs.rst 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/80631/1 diff --git a/doc/how_to_add_docs.rst b/doc/how_to_add_docs.rst index 0b32acb..ee99ce7 100644 --- a/doc/how_to_add_docs.rst +++ b/doc/how_to_add_docs.rst @@ -1,6 +1,11 @@ How to add or update docs ========================= +Documentation files live in ``/doc`` directory in the source tree, so +adding or updating documentation follows the same process as changing +the code. If you've never done it before, start by carefully +reading the :doc:`/dev_guide/development_guide`. + To add or update a documentation page, you need to create or modify an ``.rst`` file in the ``/doc`` directory and send a patch for review. -- To view, visit https://review.coreboot.org/c/flashrom/+/80631?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I882de0614ab76b8e83b0fafa67296526fecd8a16 Gerrit-Change-Number: 80631 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[main]: serprog: clean up documentation
by Anastasia Klimchuk (Code Review) 18 Feb '24

18 Feb '24

Attention is currently required from: Riku Viitanen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/80499?usp=email ) Change subject: serprog: clean up documentation ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/80499/comment/f03725b2_df58cabc : PS1, Line 14: Reviewed-on: https://review.sourcearcade.org/c/flashprog/+/52 : Reviewed-by: Nico Huber <nico.h(a)gmx.de> : Tested-by: Nico Huber <nico.h(a)gmx.de> These tags seem to come from another project, you don't need to copy them here, just remove. At the end of review, Gerrit will add the info with the user(s) who done review in the repo. The only thing which can be useful to keep, is the link to another code review. You can add it in commit message without a tag, like you did in your other patch. This way if anyone is interested, they can click the link and see the info. Patchset: PS1: Thank you so much for clean up documentation! There are few more things that I wanted to say about it. I am happy for this patch to get finished and merged (see my other two small comments). But the next thing I would do is create a serprog page in the actual documentation directory, `/doc`. We are in process of moving documentation from wiki to `/doc` in the tree, so that's very relevant. I can do the boring part of converting content of this txt file into rst format, adding page to index etc. Would you review the page? Thank you! It would be the same content as it is txt file now (and txt file will be deleted after that). The only thing I am still deciding, where is the best place for Programmers docs, whether it's inside Users documentation or separate item in the root menu. What do you think, which place better? :) All docs are generated into htmls and displayed here https://www.flashrom.org/index.html so you can see how it will look eventually. File Documentation/serprog-protocol.txt: https://review.coreboot.org/c/flashrom/+/80499/comment/97e95cbc_1a229adf : PS1, Line 106: serprog.h Maybe change to `serprog.c` ? Since .h does not exist, more info is in the source code itself. -- To view, visit https://review.coreboot.org/c/flashrom/+/80499?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ic83e7fd80840f2db0b006935a964721da0388068 Gerrit-Change-Number: 80499 Gerrit-PatchSet: 1 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Comment-Date: Sun, 18 Feb 2024 12:46:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit February 2024