November 2024 - flashrom-gerrit

[S] Change in flashrom[main]: Extract cli_output declarations to a separate header.
by Antonio Vázquez Blanco (Code Review) 14 Nov '24

14 Nov '24

Attention is currently required from: Anastasia Klimchuk. Antonio Vázquez Blanco has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/84985?usp=email ) Change subject: Extract cli_output declarations to a separate header. ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > The same comment as on the CB:84983 , but also, one more thing. […] Got it, made the requested changes but unable to update this ticket and accidentally created a new one at https://review.coreboot.org/c/flashrom/+/85134. -- To view, visit https://review.coreboot.org/c/flashrom/+/84985?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I45d62bd219bdbed919788ae17a64aeb119a8aac4 Gerrit-Change-Number: 84985 Gerrit-PatchSet: 2 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 14 Nov 2024 08:37:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: Extract cli_output declarations to a separate header.
by Antonio Vázquez Blanco (Code Review) 14 Nov '24

14 Nov '24

Antonio Vázquez Blanco has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/85134?usp=email ) Change subject: Extract cli_output declarations to a separate header. ...................................................................... Extract cli_output declarations to a separate header. This is a simple refactor that aims to simplify maintenance and to clarify file dependency inside the project. Currently, many declarations reside in flash.h making it difficult to really understand file dependency. Change-Id: I4209d5ed205ca14c39e83aa923e103b7282a7059 Signed-off-by: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> --- M cli_classic.c M cli_output.c A include/cli_output.h M include/flash.h 4 files changed, 26 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/34/85134/1 diff --git a/cli_classic.c b/cli_classic.c index 8f37019..e99230c 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -26,6 +26,7 @@ #include <stdlib.h> #include <stdint.h> #include <cli_getopt.h> +#include <cli_output.h> #include "flash.h" #include "flashchips.h" #include "fmap.h" diff --git a/cli_output.c b/cli_output.c index 20295b8..a8b8d7c 100644 --- a/cli_output.c +++ b/cli_output.c @@ -15,11 +15,12 @@ * GNU General Public License for more details. */ +#include <cli_output.h> + #include <stdio.h> #include <stdarg.h> #include <string.h> #include <errno.h> -#include "flash.h" enum flashrom_log_level verbose_screen = FLASHROM_MSG_INFO; enum flashrom_log_level verbose_logfile = FLASHROM_MSG_DEBUG2; diff --git a/include/cli_output.h b/include/cli_output.h new file mode 100644 index 0000000..70d8590 --- /dev/null +++ b/include/cli_output.h @@ -0,0 +1,22 @@ +/* + * This file is part of the flashrom project. + * + * SPDX-FileCopyrightText: 2024 Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#ifndef __CLI_OUTPUT_H__ +#define __CLI_OUTPUT_H__ + +#include <stdarg.h> +#include <flash.h> + +extern enum flashrom_log_level verbose_screen; +extern enum flashrom_log_level verbose_logfile; +int open_logfile(const char * const filename); +int close_logfile(void); +void start_logging(void); +int flashrom_print_cb(enum flashrom_log_level level, const char *fmt, va_list ap); +void flashrom_progress_cb(struct flashrom_flashctx *flashctx); + +#endif /* __CLI_OUTPUT_H__ */ diff --git a/include/flash.h b/include/flash.h index a1f1551..629ef3a 100644 --- a/include/flash.h +++ b/include/flash.h @@ -726,14 +726,7 @@ /* cli_common.c */ void print_chip_support_status(const struct flashchip *chip); -/* cli_output.c */ -extern enum flashrom_log_level verbose_screen; -extern enum flashrom_log_level verbose_logfile; -int open_logfile(const char * const filename); -int close_logfile(void); -void start_logging(void); -int flashrom_print_cb(enum flashrom_log_level level, const char *fmt, va_list ap); -void flashrom_progress_cb(struct flashrom_flashctx *flashctx); +/* libflashrom.c */ /* Let gcc and clang check for correct printf-style format strings. */ int print(enum flashrom_log_level level, const char *fmt, ...) #ifdef __MINGW32__ -- To view, visit https://review.coreboot.org/c/flashrom/+/85134?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I4209d5ed205ca14c39e83aa923e103b7282a7059 Gerrit-Change-Number: 85134 Gerrit-PatchSet: 1 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com>

1 0

[XS] Change in flashrom[main]: VERSION: Update version to v1.5.0-rc1
by Anastasia Klimchuk (Code Review) 14 Nov '24

14 Nov '24

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/85132?usp=email ) Change subject: VERSION: Update version to v1.5.0-rc1 ...................................................................... VERSION: Update version to v1.5.0-rc1 Change-Id: I946526f3ee08f4c85cdc3ea3d589de9f2c2ef8ce Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M VERSION 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/85132/1 diff --git a/VERSION b/VERSION index bd033f4..fcd141d 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -v1.5.0-devel +v1.5.0-rc1 -- To view, visit https://review.coreboot.org/c/flashrom/+/85132?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I946526f3ee08f4c85cdc3ea3d589de9f2c2ef8ce Gerrit-Change-Number: 85132 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: Rename cli_classic.h to a more adequate cli_getop.h
by Anastasia Klimchuk (Code Review) 14 Nov '24

14 Nov '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/85072?usp=email ) Change subject: Rename cli_classic.h to a more adequate cli_getop.h ...................................................................... Rename cli_classic.h to a more adequate cli_getop.h The header only defines getop related stuff so it seems more intuitive this way. Change-Id: Iaceeabedc26e93147d8122376d88e730aad1e355 Signed-off-by: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/85072 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M cli_classic.c M cli_getopt.c R include/cli_getopt.h 3 files changed, 11 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/cli_classic.c b/cli_classic.c index 2fe9324..8f37019 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -25,7 +25,7 @@ #include <stdbool.h> #include <stdlib.h> #include <stdint.h> -#include <cli_classic.h> +#include <cli_getopt.h> #include "flash.h" #include "flashchips.h" #include "fmap.h" diff --git a/cli_getopt.c b/cli_getopt.c index fc51fcf..2112b8a 100644 --- a/cli_getopt.c +++ b/cli_getopt.c @@ -25,12 +25,13 @@ * SOFTWARE. */ +#include <cli_getopt.h> + #include <unistd.h> #include <wchar.h> #include <string.h> #include <limits.h> #include <stdlib.h> -#include "cli_classic.h" #include "flash.h" char *optarg; diff --git a/include/cli_classic.h b/include/cli_getopt.h similarity index 84% rename from include/cli_classic.h rename to include/cli_getopt.h index eb1f0fe..670bd24 100644 --- a/include/cli_classic.h +++ b/include/cli_getopt.h @@ -12,8 +12,13 @@ * GNU General Public License for more details. */ -#ifndef CLI_CLASSIC_H -#define CLI_CLASSIC_H +#ifndef __CLI_GETOPT_H__ +#define __CLI_GETOPT_H__ + +/** + * This header is responsible for either including a standard getop + * implementation header or to provide a compatible one. + */ #ifdef HAVE_GETOPT_H #include <getopt.h> @@ -40,4 +45,4 @@ const struct option *longopts, int *longind); #endif /* HAVE_GETOPT_H */ -#endif /* CLI_CLASSIC_H */ +#endif /* __CLI_GETOPT_H__ */ -- To view, visit https://review.coreboot.org/c/flashrom/+/85072?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iaceeabedc26e93147d8122376d88e730aad1e355 Gerrit-Change-Number: 85072 Gerrit-PatchSet: 4 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: build script: Add rpmc option to always be enabled on Jenkins
by Anastasia Klimchuk (Code Review) 14 Nov '24

14 Nov '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/85097?usp=email ) Change subject: build script: Add rpmc option to always be enabled on Jenkins ...................................................................... build script: Add rpmc option to always be enabled on Jenkins This needs libcrypto dependency to be present on CI container. Change-Id: Ib736386a34d184f696a47272957b665c8fe26c06 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/85097 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M test_build.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Stefan Reinauer: Looks good to me, approved build bot (Jenkins): Verified diff --git a/test_build.sh b/test_build.sh index 8c041f0..968f259 100755 --- a/test_build.sh +++ b/test_build.sh @@ -26,7 +26,7 @@ build_meson () { build_dir=out - meson_opts="-Dtests=enabled -Dman-pages=enabled -Ddocumentation=enabled" + meson_opts="-Dtests=enabled -Drpmc=enabled -Dman-pages=enabled -Ddocumentation=enabled" ninja_opts="-j $(nproc)" rm -rf ${build_dir} -- To view, visit https://review.coreboot.org/c/flashrom/+/85097?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib736386a34d184f696a47272957b665c8fe26c06 Gerrit-Change-Number: 85097 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matti Finder <matti.finder(a)gmail.com>

1 0

[S] Change in flashrom[main]: sfdp: Update the message shown when SFDP-capable chip is detected
by Anastasia Klimchuk (Code Review) 14 Nov '24

14 Nov '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/85092?usp=email ) Change subject: sfdp: Update the message shown when SFDP-capable chip is detected ...................................................................... sfdp: Update the message shown when SFDP-capable chip is detected Testing: flashrom -p dummy:emulate=MX25L6436 -c "SFDP-capable chip" Change-Id: If1a480ae78f158cc4626e345149ea9025443f8a7 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/85092 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> Reviewed-by: Matti Finder <matti.finder(a)gmail.com> --- M flashrom.c 1 file changed, 7 insertions(+), 14 deletions(-) Approvals: build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved Matti Finder: Looks good to me, approved diff --git a/flashrom.c b/flashrom.c index 4ae9390..8daad74 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1159,25 +1159,18 @@ * been found on this interface. */ if (startchip == 0 && flash->chip->model_id == SFDP_DEVICE_ID) { - msg_cinfo("===\n" - "SFDP has autodetected a flash chip which is " - "not natively supported by flashrom yet.\n"); + msg_cinfo("===\nSFDP has autodetected a flash chip.\n"); if (count_usable_erasers(flash) == 0) msg_cinfo("The standard operations read and " - "verify should work, but to support " - "erase, write and all other " - "possible features"); + "verify should work, but support for " + "erase and write needs to be added manually.\n"); else msg_cinfo("All standard operations (read, " - "verify, erase and write) should " - "work, but to support all possible " - "features"); + "verify, erase and write) should work.\n"); - msg_cinfo(" we need to add them manually.\n" - "You can help us by mailing us the output of the following command to " - "flashrom@flashrom.org:\n" - "'flashrom -VV [plus the -p/--programmer parameter]'\n" - "Thanks for your help!\n" + msg_cinfo("Additionally, flashrom supports RPMC commands via SFDP autodetection.\n" + "We may add support for more features via SFDP in future.\n" + "If you are interested, join us on the mailing list https://flashrom.org/contact.html#mailing-list-1\n" "===\n"); } -- To view, visit https://review.coreboot.org/c/flashrom/+/85092?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If1a480ae78f158cc4626e345149ea9025443f8a7 Gerrit-Change-Number: 85092 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: flashchips: Skip "WP untested" message for SFDP-capable chip
by Anastasia Klimchuk (Code Review) 14 Nov '24

14 Nov '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/85075?usp=email ) Change subject: flashchips: Skip "WP untested" message for SFDP-capable chip ...................................................................... flashchips: Skip "WP untested" message for SFDP-capable chip This entry in the flashchips represent a "SFDP-capable chip" and it doesn't make sense to show the message "WP operation has status untested, please report this". The entry can cover any generic SFDP chip and what would you report? Secondly, the entry "SFDP-capable chip" does not currently support WP operations anyway. Going further, we will be working with SFDP way more, so this area needs to be gradually upgraded. Testing: flashrom -p dummy:emulate=MX25L6436 -c "SFDP-capable chip" -r dump.rom Change-Id: I7e945389895a8042df3aaae72bccf73405be8651 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/85075 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Reviewed-by: Matti Finder <matti.finder(a)gmail.com> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Matti Finder: Looks good to me, approved Sergii Dmytruk: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 73b4036..0e83200 100644 --- a/flashchips.c +++ b/flashchips.c @@ -23522,7 +23522,7 @@ /* We present our own "report this" text hence we do not */ /* want the default "This flash part has status UNTESTED..." */ /* text to be printed. */ - .tested = TEST_OK_PREW, + .tested = { .probe = OK, .read = OK, .erase = OK, .write = OK, .wp = NA }, .probe = PROBE_SPI_SFDP, .block_erasers = {}, /* set by probing function */ .unlock = SPI_DISABLE_BLOCKPROTECT, /* is this safe? */ -- To view, visit https://review.coreboot.org/c/flashrom/+/85075?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7e945389895a8042df3aaae72bccf73405be8651 Gerrit-Change-Number: 85075 Gerrit-PatchSet: 5 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>

1 0

[XS] Change in flashrom[main]: chipset_enable.c: Add TGL chipset detection based on SPI PCI ID
by Michał Żygowski (Code Review) 13 Nov '24

13 Nov '24

Michał Żygowski has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/flashrom/+/84987?usp=email ) Change subject: chipset_enable.c: Add TGL chipset detection based on SPI PCI ID ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > I didn't find a datasheet, but at least I found IDs 0xa0a4 and 0x43a4 on the internet as of being in […] 0x43a4 can be found here: https://cdrdv2-public.intel.com/635218/635218-008.pdf 0xa0a4 can be found here: https://www.intel.com/content/www/us/en/content-details/631119/intel-500-se… -- To view, visit https://review.coreboot.org/c/flashrom/+/84987?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ie6859d81157760ca03fe34ba5ac311eba5a7c46b Gerrit-Change-Number: 84987 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 13 Nov 2024 11:35:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: libflashrom: Allow getting the progress_state from the flashctx
by Anastasia Klimchuk (Code Review) 13 Nov '24

13 Nov '24

Attention is currently required from: Daniel Campello, Edward O'Callaghan, Nico Huber, Peter Marheine, Richard Hughes. Anastasia Klimchuk has posted comments on this change by Richard Hughes. ( https://review.coreboot.org/c/flashrom/+/64663?usp=email ) Change subject: libflashrom: Allow getting the progress_state from the flashctx ...................................................................... Patch Set 6: (1 comment) File tests/chip.c: https://review.coreboot.org/c/flashrom/+/64663/comment/e5b42e6a_606b99ea?us… : PS6, Line 86: struct progress_user_data *progress_user_data = progress_state->user_data; > I don't think we can change the API without either doing a whole ABI break (increment the soname or […] Thanks heaps for all details! Very useful. I thought of one more reason, apart of the question of mutability. In the current code, we provide a parameter into progress callback, but then this value is not actually usable by external clients without one more API call? We know that callback needs progress state and user data, we can (should) give that as parameters straight away. I guess this detail was missed when progress callback was introduced initially (at least I missed this), because our code, specifically tests and cli, can look into flash context. First paragraph of commit message explains the situation well. So yes, I am going to try with progress callback v1 (this signature `void(flashrom_progress_callback)(enum flashrom_progress stage, size_t, size_t, void*)`) and then `flashrom_get_progress_state` won't be needed anymore. -- To view, visit https://review.coreboot.org/c/flashrom/+/64663?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I322bf56ff92f7b4d0ffc92768e9f0cdf7cb82010 Gerrit-Change-Number: 64663 Gerrit-PatchSet: 6 Gerrit-Owner: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Wed, 13 Nov 2024 01:03:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[XS] Change in flashrom[main]: flashchips: Skip "WP untested" message for SFDP-capable chip
by Matti Finder (Code Review) 12 Nov '24

12 Nov '24

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Matti Finder has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85075?usp=email ) Change subject: flashchips: Skip "WP untested" message for SFDP-capable chip ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/85075?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7e945389895a8042df3aaae72bccf73405be8651 Gerrit-Change-Number: 85075 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 12 Nov 2024 16:31:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit November 2024