November 2024 - flashrom-gerrit

[L] Change in flashrom[main]: cli_client: Add rpmc command support
by Matti Finder (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Matti Finder has posted comments on this change by Matti Finder. ( https://review.coreboot.org/c/flashrom/+/84840?usp=email ) Change subject: cli_client: Add rpmc command support ...................................................................... Patch Set 11: (2 comments) Patchset: PS10: > Two more things to mention, we would need two more commits after this: […] 2) I think that change still fits quite well to into this commit. I have started the change. But im not quite sure how to handle the install dependency commands, I have added some information for the distros I use. But other ones might want to use libressl and then just trying to install openssl as a catchall might be not wanted by the user. Also some form libcrypto is probably already preinstalled for most operating systems. Do you think still adding install information for openssl for other distros is necessary? File doc/classic_cli_manpage.rst: https://review.coreboot.org/c/flashrom/+/84840/comment/ee79be53_60943149?us… : PS10, Line 369: > The last thing I want to ask you to add: a few examples at the end of RPMC section in the manpage, o […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/84840?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I36c823bbee65f256eb6edabe6f058321c9a0cfa1 Gerrit-Change-Number: 84840 Gerrit-PatchSet: 11 Gerrit-Owner: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Wed, 06 Nov 2024 16:32:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[L] Change in flashrom[main]: rpmc: add rpmc commands feature
by Matti Finder (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Matti Finder, Peter Marheine. Hello Anastasia Klimchuk, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/84934?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: rpmc: add rpmc commands feature ...................................................................... rpmc: add rpmc commands feature Added optional support for all the commands specified in JESD260. Added a new optional dependency to openssls libcrypto. Added parsing for the rpmc parameter sfdp table. Added necessary rpmc parameter information to flashchips struct and the flash hardening feature to enable rpmc commands. Enables future use of these commands in the cli_client and also libflashrom. Change-Id: I6ab3d0446e9fd674b20550fdbfaf499b8d4a9b38 Signed-off-by: Matti Finder <matti.finder(a)gmail.com> --- M MAINTAINERS M include/flash.h A include/rpmc.h M meson.build M meson_options.txt A rpmc.c M sfdp.c 7 files changed, 822 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/34/84934/7 -- To view, visit https://review.coreboot.org/c/flashrom/+/84934?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I6ab3d0446e9fd674b20550fdbfaf499b8d4a9b38 Gerrit-Change-Number: 84934 Gerrit-PatchSet: 7 Gerrit-Owner: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matti Finder <matti.finder(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>

1 0

[L] Change in flashrom[main]: cli_client: Add rpmc command support
by Matti Finder (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Matti Finder, Peter Marheine. Hello Anastasia Klimchuk, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/84840?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: cli_client: Add rpmc command support ...................................................................... cli_client: Add rpmc command support This commit adds uses the new rpmc command implementation to add them as a new feature to the cli_client. Also adds the necessary documentation for this new feature. Tested on the Winbond W25R128JV as a 'SFDP-capable chip'. This patch was done to add rpmc command support to flashrom. This enables users to write root keys to their flash chips while they flash data on the chip. This might become useful in the future as rpmc support is extended in coreboot. Also adds debug tools to flashrom, which might be useful in implementing coreboots rpmc support. Change-Id: I36c823bbee65f256eb6edabe6f058321c9a0cfa1 Signed-off-by: Matti Finder <matti.finder(a)gmail.com> --- M cli_classic.c M doc/classic_cli_manpage.rst M doc/dev_guide/building_from_source.rst M doc/release_notes/devel.rst 4 files changed, 307 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/40/84840/11 -- To view, visit https://review.coreboot.org/c/flashrom/+/84840?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I36c823bbee65f256eb6edabe6f058321c9a0cfa1 Gerrit-Change-Number: 84840 Gerrit-PatchSet: 11 Gerrit-Owner: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matti Finder <matti.finder(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>

1 0

[XS] Change in flashrom[main]: flashchips: Update test status for Spansion S25FL256L
by Anton Samsonov (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Anton Samsonov has removed Anton Samsonov from this change. ( https://review.coreboot.org/c/flashrom/+/85004?usp=email ) Change subject: flashchips: Update test status for Spansion S25FL256L ...................................................................... Removed reviewer Anton Samsonov <devel(a)zxlab.ru>. -- To view, visit https://review.coreboot.org/c/flashrom/+/85004?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: deleteReviewer Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I9e934791cd8d96c2cb926fd310ec48ec2ab2d1e3 Gerrit-Change-Number: 85004 Gerrit-PatchSet: 1 Gerrit-Owner: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>

1 0

[S] Change in flashrom[main]: flashchips: add Winbond W25R512NW / W74M51NW
by Anastasia Klimchuk (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Alexandru Stan, Nikolai Artemiev, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Alexandru Stan. ( https://review.coreboot.org/c/flashrom/+/84752?usp=email ) Change subject: flashchips: add Winbond W25R512NW / W74M51NW ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/84752/comment/5cd55c88_58ec7511?us… : PS2, Line 20269: .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, : .unlock = SPI_DISABLE_BLOCKPROTECT, : > Sorry Nikolai. I'm not an expert at WPing and I very rarely even connect my programmer to a chip. […] I think it's fine to add without WP support, especially if you haven't used or tested it. Nikolai, I hope it's fine for you? Maybe someone (who would be using WP) will add support later. -- To view, visit https://review.coreboot.org/c/flashrom/+/84752?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ibf670e4014a22e4636789768b759cb51f75cd046 Gerrit-Change-Number: 84752 Gerrit-PatchSet: 3 Gerrit-Owner: Alexandru Stan <ams(a)frame.work> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alexandru Stan <ams(a)frame.work> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 06 Nov 2024 06:09:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Alexandru Stan <ams(a)frame.work> Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[L] Change in flashrom[main]: cli_client: Add rpmc command support
by Anastasia Klimchuk (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Matti Finder, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Matti Finder. ( https://review.coreboot.org/c/flashrom/+/84840?usp=email ) Change subject: cli_client: Add rpmc command support ...................................................................... Patch Set 10: (4 comments) Patchset: PS10: Two more things to mention, we would need two more commits after this: 1) add the new code to be building on CI It currently doesn't because libcrypto is not installed, and the option is auto. I will look into this 2) update the `doc/dev_guide/building_from_source.rst` which is this page https://flashrom.org/dev_guide/building_from_source.html , for the same reason as there is now new optional library. Can be a separate commit, there are a bunch of sections in the doc File cli_classic.c: https://review.coreboot.org/c/flashrom/+/84840/comment/91389774_b6714461?us… : PS8, Line 1272: any_rpmc_op > Before your question the `cli_classic_validate_singleop(&operation_specified);` before any of the op […] Oh great, I am glad that my question turned out to be useful. Yes, I agree with your idea to allow multiple commands chained together. File doc/classic_cli_manpage.rst: https://review.coreboot.org/c/flashrom/+/84840/comment/d5c0fff5_a4a6cc84?us… : PS8, Line 334: If your chip is detected correctly but the feature is not enabled, try using : ``-c "SFDP-capable chip"`` for automatic feature detection. > I have added a quote to the error message, this should make it better to understand. […] Yes I am also thinking on the background, what internal improvements we can make. I think as long as cli API will stay the same (and will keep working), we can change internal implementation. As for the manpage intro: let's keep this one. Once people start using the feature, it will soon be clear whether any more clarification is needed, or maybe it's clear already. File doc/classic_cli_manpage.rst: https://review.coreboot.org/c/flashrom/+/84840/comment/a582eca3_67db22cc?us… : PS10, Line 369: The last thing I want to ask you to add: a few examples at the end of RPMC section in the manpage, of how full command line call would look like. Just a few, which ones would be in your opinion the most common usages. Since you made it possible to run multiple commands in the same call, maybe also 1-2 examples with multiple commands. Thank you! -- To view, visit https://review.coreboot.org/c/flashrom/+/84840?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I36c823bbee65f256eb6edabe6f058321c9a0cfa1 Gerrit-Change-Number: 84840 Gerrit-PatchSet: 10 Gerrit-Owner: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matti Finder <matti.finder(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Wed, 06 Nov 2024 06:01:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Matti Finder <matti.finder(a)gmail.com>

1 0

[L] Change in flashrom[main]: rpmc: add rpmc commands feature
by Anastasia Klimchuk (Code Review) 06 Nov '24

06 Nov '24

Attention is currently required from: Matti Finder, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Matti Finder. ( https://review.coreboot.org/c/flashrom/+/84934?usp=email ) Change subject: rpmc: add rpmc commands feature ...................................................................... Patch Set 6: (4 comments) Patchset: PS4: Thank you so much for testing! > I used the dummy programmer with dummy:emulate=MX25L6436 which can then be handled as a "SFDP-capable chip" This is great, I didn't realise that dummyflasher can handle SFDP chips, but yes indeed! I will write a test for this (not right now, but later in a separate commit) File sfdp.c: https://review.coreboot.org/c/flashrom/+/84934/comment/9be49bc7_41322878?us… : PS4, Line 457: if (sfdp_fill_flash(flash->chip, tbuf, len) == 0) { : ret = 1; : } > Maybe this should return error straight away I said that, but I forgot about freeing the memory :\ and now remembered. Added two more comments (sorry), but that should be the last, everything else is done in this patch. File sfdp.c: https://review.coreboot.org/c/flashrom/+/84934/comment/7797f3ef_4c65e1aa?us… : PS6, Line 457: return 0; We still need to free the buffers, so I think this should be ``` ret = 0; goto cleanup_hdrs; ``` https://review.coreboot.org/c/flashrom/+/84934/comment/31c6385c_629ede2c?us… : PS6, Line 482: return 1; I think let's keep the previous line (`return ret`), since `goto cleanup_hdrs` is called a few times in the existing code. -- To view, visit https://review.coreboot.org/c/flashrom/+/84934?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I6ab3d0446e9fd674b20550fdbfaf499b8d4a9b38 Gerrit-Change-Number: 84934 Gerrit-PatchSet: 6 Gerrit-Owner: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matti Finder <matti.finder(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Wed, 06 Nov 2024 05:23:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Matti Finder <matti.finder(a)gmail.com>

1 0

[S] Change in flashrom[main]: flashchips: add Winbond W25R512NW / W74M51NW
by Alexandru Stan (Code Review) 05 Nov '24

05 Nov '24

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Alexandru Stan has posted comments on this change by Alexandru Stan. ( https://review.coreboot.org/c/flashrom/+/84752?usp=email ) Change subject: flashchips: add Winbond W25R512NW / W74M51NW ...................................................................... Patch Set 3: (5 comments) Patchset: PS3: PTAL File flashchips.c: https://review.coreboot.org/c/flashrom/+/84752/comment/e23ab8cb_f53609eb?us… : PS1, Line 20271: 1650 > ah, but you already updated the voltage according to datasheet. I am resolving this. Yeah, the copied voltages from the other chip were not matching the datasheet, so that's what my comment meant. I updated it to follow the datasheet now. File flashchips.c: https://review.coreboot.org/c/flashrom/+/84752/comment/82432dc3_a9da36ff?us… : PS2, Line 20230: W25R512NW > The situation you described in the following two lines, we do the following: […] Done https://review.coreboot.org/c/flashrom/+/84752/comment/0bf4684b_91da46ae?us… : PS2, Line 20239: 1024B total, 256B reserved > I have something! Another developer kindly explained to me about OTP (in another patch CB:84827), an […] Done https://review.coreboot.org/c/flashrom/+/84752/comment/d6eb7120_0bd348b8?us… : PS2, Line 20269: .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, : .unlock = SPI_DISABLE_BLOCKPROTECT, : > It'd be nice to add full WP support, reusing the values from `W25Q512NW-IM` should work here. […] Sorry Nikolai. I'm not an expert at WPing and I very rarely even connect my programmer to a chip. Feel free to make a follow up patch. -- To view, visit https://review.coreboot.org/c/flashrom/+/84752?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ibf670e4014a22e4636789768b759cb51f75cd046 Gerrit-Change-Number: 84752 Gerrit-PatchSet: 3 Gerrit-Owner: Alexandru Stan <ams(a)frame.work> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 05 Nov 2024 23:45:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Alexandru Stan <ams(a)frame.work> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com>

1 0

[S] Change in flashrom[main]: flashchips: add Winbond W25R512NW / W74M51NW
by Alexandru Stan (Code Review) 05 Nov '24

05 Nov '24

Attention is currently required from: Alexandru Stan, Nikolai Artemiev, Stefan Reinauer. Hello Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/84752?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by Nikolai Artemiev, Verified+1 by build bot (Jenkins) Change subject: flashchips: add Winbond W25R512NW / W74M51NW ...................................................................... flashchips: add Winbond W25R512NW / W74M51NW I used W25Q256JW as a template and just increased every erase size calculation. Datasheet can be found by form contact only via https://www.winbond.com/hq/product/code-storage-flash-memory/serial-nor-fla… I tested it by running: dd if=/dev/urandom of=/tmp/random.bin bs=1M count=64 sudo /tmp/flashrom/build/flashrom -p ft2232_spi:type=2232H -w /tmp/random.bin --progress sudo /tmp/flashrom/build/flashrom -p ft2232_spi:type=2232H -v /tmp/random.bin And I saw "Verifying flash... VERIFIED." Change-Id: Ibf670e4014a22e4636789768b759cb51f75cd046 Signed-off-by: Alexandru M Stan <ams(a)frame.work> --- M flashchips.c M include/flashchips.h 2 files changed, 47 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/52/84752/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/84752?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ibf670e4014a22e4636789768b759cb51f75cd046 Gerrit-Change-Number: 84752 Gerrit-PatchSet: 3 Gerrit-Owner: Alexandru Stan <ams(a)frame.work> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alexandru Stan <ams(a)frame.work> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>

1 0

[L] Change in flashrom[main]: rpmc: add rpmc commands feature
by Matti Finder (Code Review) 05 Nov '24

05 Nov '24

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Matti Finder has posted comments on this change by Matti Finder. ( https://review.coreboot.org/c/flashrom/+/84934?usp=email ) Change subject: rpmc: add rpmc commands feature ...................................................................... Patch Set 6: (2 comments) Patchset: PS4: > Matti, thank you so much for your patience! I made another round of comments, but probably the last […] As I don't currently own a second non spi cabable chip, that can also work as a SFDP-capable chip, I used the dummy programmer with `dummy:emulate=MX25L6436` which can then be handled as a "SFDP-capable chip". At least for read write and verify all operations work as expected. Read write and verify also still work when using the W25R chip through the ft2232_spi programmer. Also while other rpmc operations are ran in the same call. File rpmc.c: https://review.coreboot.org/c/flashrom/+/84934/comment/ac584c2e_e11b40f4?us… : PS4, Line 117: usleep(flash->chip->rpmc_ctx.polling_long_delay_write_counter_us) > `programmer_delay` seems like the right choice here, since we have a flashctx. Done -- To view, visit https://review.coreboot.org/c/flashrom/+/84934?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I6ab3d0446e9fd674b20550fdbfaf499b8d4a9b38 Gerrit-Change-Number: 84934 Gerrit-PatchSet: 6 Gerrit-Owner: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Tue, 05 Nov 2024 16:21:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit November 2024