November 2024 - flashrom-gerrit

[M] Change in flashrom[main]: Rename cli_classic.h to a more adequate cli_getop.h
by Antonio Vázquez Blanco (Code Review) 09 Nov '24

09 Nov '24

Attention is currently required from: Anastasia Klimchuk. Antonio Vázquez Blanco has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/84983?usp=email ) Change subject: Rename cli_classic.h to a more adequate cli_getop.h ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I agree with renaming cli_classic.h to cli_getop.h. […] That fully makes sense. Thanks for the feedback. While trying to do so, I have opened multiple new review tickets accidentally. I am still trying to get a hold on how gerrit works. I will close this ticket in favour of https://review.coreboot.org/c/flashrom/+/85072. Sorry for the mess... -- To view, visit https://review.coreboot.org/c/flashrom/+/84983?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I5986828f3bdec583af6f7b02cbe1a9c45ed2000f Gerrit-Change-Number: 84983 Gerrit-PatchSet: 2 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 09 Nov 2024 10:50:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: Use SPDX in cli_getop files
by Antonio Vázquez Blanco (Code Review) 09 Nov '24

09 Nov '24

Antonio Vázquez Blanco has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/85073?usp=email ) Change subject: Use SPDX in cli_getop files ...................................................................... Use SPDX in cli_getop files Change-Id: Ie523cf5b26a29de8e9e9efb56efe04a5ff86a59c Signed-off-by: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> --- M cli_getopt.c M include/cli_getopt.h 2 files changed, 7 insertions(+), 31 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/73/85073/1 diff --git a/cli_getopt.c b/cli_getopt.c index 8d799e3..8e5a330 100644 --- a/cli_getopt.c +++ b/cli_getopt.c @@ -1,28 +1,11 @@ /* * This file is part of the flashrom project. - * It comes originally from the musl libc project and is licensed under the - * terms of the MIT license. + * It comes originally from the musl libc project. * - * Copyringht (C) 2023 Rich Felker and the musl authors - * Adjusted for flashrom by Thomas Heijligen<thomas.heijligen(a)secunet.com> - * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to deal - * in the Software without restriction, including without limitation the rights - * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell - * copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in - * all copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, - * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE - * SOFTWARE. + * SPDX-FileCopyrightText: 2023 Rich Felker and the musl authors + * SPDX-FileCopyrightText: Thomas Heijligen <thomas.heijligen(a)secunet.com> + * SPDX-FileCopyrightText: 2024 Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> + * SPDX-License-Identifier: MIT */ #include "cli_getopt.h" diff --git a/include/cli_getopt.h b/include/cli_getopt.h index 670bd24..5c84828 100644 --- a/include/cli_getopt.h +++ b/include/cli_getopt.h @@ -1,15 +1,8 @@ /* * This file is part of the flashrom project. * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. + * SPDX-FileCopyrightText: 2024 Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> + * SPDX-License-Identifier: GPL-2.0-or-later */ #ifndef __CLI_GETOPT_H__ -- To view, visit https://review.coreboot.org/c/flashrom/+/85073?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ie523cf5b26a29de8e9e9efb56efe04a5ff86a59c Gerrit-Change-Number: 85073 Gerrit-PatchSet: 1 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com>

1 0

[S] Change in flashrom[main]: Rename cli_classic.h to a more adequate cli_getop.h
by Antonio Vázquez Blanco (Code Review) 09 Nov '24

09 Nov '24

Antonio Vázquez Blanco has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/85072?usp=email ) Change subject: Rename cli_classic.h to a more adequate cli_getop.h ...................................................................... Rename cli_classic.h to a more adequate cli_getop.h The header only defines getop related stuff so it seems more intuitive this way. Change-Id: Iaceeabedc26e93147d8122376d88e730aad1e355 Signed-off-by: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> --- M cli_classic.c M cli_getopt.c R include/cli_getopt.h 3 files changed, 12 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/72/85072/1 diff --git a/cli_classic.c b/cli_classic.c index 896c167..f21e477 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -24,7 +24,7 @@ #include <string.h> #include <stdbool.h> #include <stdlib.h> -#include <cli_classic.h> +#include "cli_getopt.h" #include "flash.h" #include "flashchips.h" #include "fmap.h" diff --git a/cli_getopt.c b/cli_getopt.c index fc51fcf..8d799e3 100644 --- a/cli_getopt.c +++ b/cli_getopt.c @@ -25,13 +25,14 @@ * SOFTWARE. */ +#include "cli_getopt.h" + #include <unistd.h> #include <wchar.h> #include <string.h> #include <limits.h> #include <stdlib.h> -#include "cli_classic.h" -#include "flash.h" +#include "flash.h" // msg_gerr char *optarg; int optind=1, opterr=1, optopt, optpos; diff --git a/include/cli_classic.h b/include/cli_getopt.h similarity index 84% rename from include/cli_classic.h rename to include/cli_getopt.h index eb1f0fe..670bd24 100644 --- a/include/cli_classic.h +++ b/include/cli_getopt.h @@ -12,8 +12,13 @@ * GNU General Public License for more details. */ -#ifndef CLI_CLASSIC_H -#define CLI_CLASSIC_H +#ifndef __CLI_GETOPT_H__ +#define __CLI_GETOPT_H__ + +/** + * This header is responsible for either including a standard getop + * implementation header or to provide a compatible one. + */ #ifdef HAVE_GETOPT_H #include <getopt.h> @@ -40,4 +45,4 @@ const struct option *longopts, int *longind); #endif /* HAVE_GETOPT_H */ -#endif /* CLI_CLASSIC_H */ +#endif /* __CLI_GETOPT_H__ */ -- To view, visit https://review.coreboot.org/c/flashrom/+/85072?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iaceeabedc26e93147d8122376d88e730aad1e355 Gerrit-Change-Number: 85072 Gerrit-PatchSet: 1 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com>

1 0

[S] Change in flashrom[main]: libflashrom: Allow getting the progress_state from the flashctx
by Anastasia Klimchuk (Code Review) 09 Nov '24

09 Nov '24

Attention is currently required from: Angel Pons, Daniel Campello, Edward O'Callaghan, Nico Huber, Richard Hughes. Anastasia Klimchuk has posted comments on this change by Richard Hughes. ( https://review.coreboot.org/c/flashrom/+/64663?usp=email ) Change subject: libflashrom: Allow getting the progress_state from the flashctx ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Patchset: PS5: I rebased, and changed the test to also use new function from libflashrom API. In addition to unit tests, I ran two tests locally to test the cli, all successful: > flashrom -p dummy:emulate=W25Q128FV,freq=64mhz -r dump.rom --progress > flashrom -p dummy:emulate=W25Q128FV,freq=64mhz -E --progress I approve, but also I might go around ask another pair of eyes to have a look (since now I am a co-developer of this patch :) ). -- To view, visit https://review.coreboot.org/c/flashrom/+/64663?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I322bf56ff92f7b4d0ffc92768e9f0cdf7cb82010 Gerrit-Change-Number: 64663 Gerrit-PatchSet: 5 Gerrit-Owner: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Comment-Date: Sat, 09 Nov 2024 08:19:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: libflashrom: Allow getting the progress_state from the flashctx
by Anastasia Klimchuk (Code Review) 09 Nov '24

09 Nov '24

Attention is currently required from: Angel Pons, Daniel Campello, Edward O'Callaghan, Nico Huber, Richard Hughes. Anastasia Klimchuk has posted comments on this change by Richard Hughes. ( https://review.coreboot.org/c/flashrom/+/64663?usp=email ) Change subject: libflashrom: Allow getting the progress_state from the flashctx ...................................................................... Patch Set 5: (1 comment) File include/libflashrom.h: https://review.coreboot.org/c/flashrom/+/64663/comment/f502e699_6d1630a7?us… : PS3, Line 106: @progress_callback set in flashrom_set_progress_callback() > return flashrom_progress current progress of current running operation […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/64663?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I322bf56ff92f7b4d0ffc92768e9f0cdf7cb82010 Gerrit-Change-Number: 64663 Gerrit-PatchSet: 5 Gerrit-Owner: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Comment-Date: Sat, 09 Nov 2024 08:06:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: libflashrom: Allow getting the progress_state from the flashctx
by Anastasia Klimchuk (Code Review) 09 Nov '24

09 Nov '24

Attention is currently required from: Angel Pons, Daniel Campello, Edward O'Callaghan, Nico Huber, Richard Hughes. Anastasia Klimchuk has uploaded a new patch set (#5) to the change originally created by Richard Hughes. ( https://review.coreboot.org/c/flashrom/+/64663?usp=email ) The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: libflashrom: Allow getting the progress_state from the flashctx ...................................................................... libflashrom: Allow getting the progress_state from the flashctx External users of the libflashrom API cannot peek into the abstract flashrom_flashctx structure, unlike the local CLI. Provide some API to get the flashrom_progress struct from a flashrom_flashctx. This allows fwupd to use the new flashrom_set_progress_callback() API without using a global variable with the callback data. Tested with fwupd in https://github.com/fwupd/fwupd/pull/4675 Change-Id: I322bf56ff92f7b4d0ffc92768e9f0cdf7cb82010 Signed-off-by: Richard Hughes <richard(a)hughsie.com> Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M cli_output.c M include/libflashrom.h M libflashrom.c M libflashrom.map M tests/chip.c 5 files changed, 20 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/63/64663/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/64663?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I322bf56ff92f7b4d0ffc92768e9f0cdf7cb82010 Gerrit-Change-Number: 64663 Gerrit-PatchSet: 5 Gerrit-Owner: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Daniel Campello <campello(a)chromium.org>

1 0

[S] Change in flashrom[main]: libflashrom: Allow getting the progress_state from the flashctx
by Anastasia Klimchuk (Code Review) 09 Nov '24

09 Nov '24

Attention is currently required from: Angel Pons, Daniel Campello, Edward O'Callaghan, Nico Huber, Richard Hughes. Anastasia Klimchuk has uploaded a new patch set (#4) to the change originally created by Richard Hughes. ( https://review.coreboot.org/c/flashrom/+/64663?usp=email ) Change subject: libflashrom: Allow getting the progress_state from the flashctx ...................................................................... libflashrom: Allow getting the progress_state from the flashctx External users of the libflashrom API cannot peek into the abstract flashrom_flashctx structure, unlike the local CLI. Provide some API to get the flashrom_progress struct from a flashrom_flashctx. This allows fwupd to use the new flashrom_set_progress_callback() API without using a global variable with the callback data. Tested with fwupd in https://github.com/fwupd/fwupd/pull/4675 Change-Id: I322bf56ff92f7b4d0ffc92768e9f0cdf7cb82010 Signed-off-by: Richard Hughes <richard(a)hughsie.com> Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M cli_output.c M include/libflashrom.h M libflashrom.c M libflashrom.map 4 files changed, 17 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/63/64663/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/64663?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I322bf56ff92f7b4d0ffc92768e9f0cdf7cb82010 Gerrit-Change-Number: 64663 Gerrit-PatchSet: 4 Gerrit-Owner: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Daniel Campello <campello(a)chromium.org>

1 0

[S] Change in flashrom[main]: libflashrom: Allow getting the progress_state from the flashctx
by Anastasia Klimchuk (Code Review) 09 Nov '24

09 Nov '24

Attention is currently required from: Angel Pons, Daniel Campello, Edward O'Callaghan, Nico Huber, Richard Hughes. Anastasia Klimchuk has posted comments on this change by Richard Hughes. ( https://review.coreboot.org/c/flashrom/+/64663?usp=email ) Change subject: libflashrom: Allow getting the progress_state from the flashctx ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > [Our response is in a new thread, so as not to hijack the original intent of this comment thread any […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/64663?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I322bf56ff92f7b4d0ffc92768e9f0cdf7cb82010 Gerrit-Change-Number: 64663 Gerrit-PatchSet: 3 Gerrit-Owner: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Comment-Date: Sat, 09 Nov 2024 07:42:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Daniel Campello <campello(a)chromium.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: libflashrom: Allow getting the progress_state from the flashctx
by Anastasia Klimchuk (Code Review) 09 Nov '24

09 Nov '24

Attention is currently required from: Angel Pons, Daniel Campello, Edward O'Callaghan, Nico Huber, Richard Hughes. Anastasia Klimchuk has posted comments on this change by Richard Hughes. ( https://review.coreboot.org/c/flashrom/+/64663?usp=email ) Change subject: libflashrom: Allow getting the progress_state from the flashctx ...................................................................... Patch Set 3: (1 comment) File include/libflashrom.h: https://review.coreboot.org/c/flashrom/+/64663/comment/9db9a3db_a35207d5?us… : PS3, Line 106: @progress_callback set in flashrom_set_progress_callback() return flashrom_progress current progress of current running operation (it said returns callback) -- To view, visit https://review.coreboot.org/c/flashrom/+/64663?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I322bf56ff92f7b4d0ffc92768e9f0cdf7cb82010 Gerrit-Change-Number: 64663 Gerrit-PatchSet: 3 Gerrit-Owner: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Comment-Date: Sat, 09 Nov 2024 07:41:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: flashchips: add Winbond W25R512NW / W74M51NW
by Anastasia Klimchuk (Code Review) 09 Nov '24

09 Nov '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/84752?usp=email ) Change subject: flashchips: add Winbond W25R512NW / W74M51NW ...................................................................... flashchips: add Winbond W25R512NW / W74M51NW I used W25Q256JW as a template and just increased every erase size calculation. Datasheet can be found by form contact only via https://www.winbond.com/hq/product/code-storage-flash-memory/serial-nor-fla… I tested it by running: dd if=/dev/urandom of=/tmp/random.bin bs=1M count=64 sudo /tmp/flashrom/build/flashrom -p ft2232_spi:type=2232H -w /tmp/random.bin --progress sudo /tmp/flashrom/build/flashrom -p ft2232_spi:type=2232H -v /tmp/random.bin And I saw "Verifying flash... VERIFIED." Change-Id: Ibf670e4014a22e4636789768b759cb51f75cd046 Signed-off-by: Alexandru M Stan <ams(a)frame.work> Reviewed-on: https://review.coreboot.org/c/flashrom/+/84752 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M flashchips.c M include/flashchips.h 2 files changed, 47 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index c32159d..742e017 100644 --- a/flashchips.c +++ b/flashchips.c @@ -20374,6 +20374,52 @@ { .vendor = "Winbond", + .name = "W25R512NW/W74M51NW", + .bustype = BUS_SPI, + .manufacture_id = WINBOND_NEX_ID, + .model_id = WINBOND_NEX_W25R512NW, + .total_size = 65536, + .page_size = 256, + /* supports SFDP */ + /* OTP: 3X256B; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA, + .tested = TEST_OK_PREW, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 16384} }, + .block_erase = SPI_BLOCK_ERASE_21, + }, { + .eraseblocks = { {4 * 1024, 16384} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 2048} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 1024} }, + .block_erase = SPI_BLOCK_ERASE_DC, + }, { + .eraseblocks = { {64 * 1024, 1024} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {64 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {64 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, + .unlock = SPI_DISABLE_BLOCKPROTECT, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {1700, 1950}, + }, + + { + .vendor = "Winbond", .name = "W25Q256JW_DTR", .bustype = BUS_SPI, .manufacture_id = WINBOND_NEX_ID, diff --git a/include/flashchips.h b/include/flashchips.h index 719486e..0fea690 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -1027,6 +1027,7 @@ #define WINBOND_NEX_W25Q64_W 0x6017 /* W25Q64DW; W25Q64FV in QPI mode */ #define WINBOND_NEX_W25Q128_W 0x6018 /* W25Q128FW; W25Q128FV in QPI mode */ #define WINBOND_NEX_W25Q256_W 0x6019 /* W25Q256JW */ +#define WINBOND_NEX_W25R512NW 0x6020 /* W25R512NW/W74M51NW */ #define WINBOND_NEX_W25Q16JV_M 0x7015 /* W25Q16JV_M (QE=0) */ #define WINBOND_NEX_W25Q32JV_M 0x7016 /* W25Q32JV_M (QE=0) */ #define WINBOND_NEX_W25Q64JV 0x7017 /* W25Q64JV */ -- To view, visit https://review.coreboot.org/c/flashrom/+/84752?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ibf670e4014a22e4636789768b759cb51f75cd046 Gerrit-Change-Number: 84752 Gerrit-PatchSet: 4 Gerrit-Owner: Alexandru Stan <ams(a)frame.work> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit November 2024