May 2023 - flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[master]: meson: use mesons configuration_data for to evaluate cflags
by Thomas Heijligen (Code Review) 06 May '23

06 May '23

Thomas Heijligen has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/72656 ) Change subject: meson: use mesons configuration_data for to evaluate cflags ...................................................................... Abandoned This requires meson >= 0.57.0 Drop it for now. make we can even do it better. -- To view, visit https://review.coreboot.org/c/flashrom/+/72656 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie91b4e1377b9d6d347511d4727c0a26a314b1e57 Gerrit-Change-Number: 72656 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[L] Change in flashrom[master]: meson make: use VERSION file
by Thomas Heijligen (Code Review) 06 May '23

06 May '23

Attention is currently required from: Anastasia Klimchuk, Alexander Goncharov. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72657 ) Change subject: meson make: use VERSION file ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/72657/comment/8d860e24_b2177a0b PS6, Line 19: flashrom 1.4.0-devel (git:v1.2-1172-g7f186838) > It is a bit odd to have 1.4.0 and at the same time v1. […] The problem is that since 1.2, we have no tags on the master branch. From the moment of the first 1.4 rc this looks like ``1.4.0-rc1 (git:v1.4.0-rc1-2-g7f186838)`` I just started with 1.4.0-devel to get some entry here since we are working on 1.4 and are not on the 1.3 branch. -- To view, visit https://review.coreboot.org/c/flashrom/+/72657 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idc17eadb397b3c579bddfbf9ae6bf1b171f5dfb7 Gerrit-Change-Number: 72657 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Sat, 06 May 2023 10:48:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: Makefile: Build man-page only when sphinx is available
by Thomas Heijligen (Code Review) 06 May '23

06 May '23

Attention is currently required from: Anastasia Klimchuk, Alexander Goncharov. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74519 ) Change subject: Makefile: Build man-page only when sphinx is available ...................................................................... Patch Set 2: (6 comments) File Makefile: https://review.coreboot.org/c/flashrom/+/74519/comment/b84827cd_a416e37a PS1, Line 963: $(if $(findstring $(HAS_SPHINXBUILD),yes), man8/$(PROGRAM).8) > `$(call has_dependency,$(HAS_SPHINXBUILD),man8/$(PROGRAM). […] Done https://review.coreboot.org/c/flashrom/+/74519/comment/1a109290_c71076ef PS1, Line 1024: @echo "Found \"sphinx-build\" to generate man-pages: $(HAS_SPHINXBUILD)" > The previous lines have the pattern of message […] Done https://review.coreboot.org/c/flashrom/+/74519/comment/296f3fec_5eeee010 PS1, Line 1036: man8/$(PROGRAM).8: doc/* > There is a ticket reported for this bit: https://ticket.coreboot. […] This target is now only called if sphinx-build is found. If you try to call it manually and don't have sphinx-build installed, it trows an error. https://review.coreboot.org/c/flashrom/+/74519/comment/f9081e9a_3181c53e PS1, Line 1059: $(call install-man) > `$(call has_dependency,$(HAS_SPHINXBUILD),install-man)` The patch has changes. Not needed any more https://review.coreboot.org/c/flashrom/+/74519/comment/19092642_3b8db480 PS1, Line 1058: : install: install-bin install-bash $(call install-man) : : install-bin: $(PROGRAM)$(EXEC_SUFFIX) : mkdir -p $(DESTDIR)$(PREFIX)/sbin : $(INSTALL) -m 0755 $(PROGRAM)$(EXEC_SUFFIX) $(DESTDIR)$(PREFIX)/sbin : : install-bash: $(PROGRAM).bash : mkdir -p $(DESTDIR)$(BASHCOMPDIR) : $(INSTALL) -m 0644 $(PROGRAM).bash $(DESTDIR)$(BASHCOMPDIR) : : install-man: man8/$(PROGRAM).8 : mkdir -p $(DESTDIR)$(MANDIR)/man8 : $(INSTALL) -m 0644 man8/$(PROGRAM).8 $(DESTDIR)$(MANDIR)/man8 : : install-lib: libflashrom.a include/libflashrom.h : mkdir -p $(DESTDIR)$(PREFIX)/lib : $(INSTALL) -m 0644 libflashrom.a $(DESTDIR)$(PREFIX)/lib : mkdir -p $(DESTDIR)$(PREFIX)/include : $(INSTALL) -m 0644 include/libflashrom.h $(DESTDIR)$(PREFIX)/include : : libinstall: install-lib > How about doing these changes as a separate patch? Because it looks like a refactoring and not an es […] I throw my first attempt on the garbage. This one is much cleaner. File Makefile.include: https://review.coreboot.org/c/flashrom/+/74519/comment/ea1dd889_547bceb7 PS1, Line 54: : define install-man : $(if $(findstring $(HAS_SPHINXBUILD),yes), install-man) : endef > You can make this macro/fun more universal, e.g: […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/74519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If1b81d9bc25ecac19d493b44b00a7c42d0643fe6 Gerrit-Change-Number: 74519 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Sat, 06 May 2023 10:32:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: Makefile: Build man-page only when sphinx is available
by Thomas Heijligen (Code Review) 06 May '23

06 May '23

Attention is currently required from: Thomas Heijligen. Hello build bot (Jenkins), Anastasia Klimchuk, Alexander Goncharov, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/74519 to look at the new patch set (#2). Change subject: Makefile: Build man-page only when sphinx is available ...................................................................... Makefile: Build man-page only when sphinx is available Currently, it's not possible to compile the upstream branch using the `make' command without sphinx beeing installed. Check if sphinx-build is installed and only then build or install the man-page. The problem was noticed from commit f4f2f3dd19784efa26fd5619b7a44b4cdf14b04c move manpage to sphinx. Change-Id: If1b81d9bc25ecac19d493b44b00a7c42d0643fe6 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile M Makefile.include 2 files changed, 39 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/19/74519/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/74519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If1b81d9bc25ecac19d493b44b00a7c42d0643fe6 Gerrit-Change-Number: 74519 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: flashrom: rename sb600spi.c to amd_spi.c
by Anastasia Klimchuk (Code Review) 06 May '23

06 May '23

Attention is currently required from: Martin L Roth, Thomas Heijligen, Arthur Heymans. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74952 ) Change subject: flashrom: rename sb600spi.c to amd_spi.c ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > The promontary support works well in that patch series linked. That's good to know! Would you be able to test it here if I port the patches? I am also wondering maybe Martin you have some long-term plans for this programmer (besides renaming)? -- To view, visit https://review.coreboot.org/c/flashrom/+/74952 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I13859de27e602cc6496684e6cb66b2dc2e21531a Gerrit-Change-Number: 74952 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 06 May 2023 08:51:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashrom: Use WP-based unlocking on opaque masters
by Sergii Dmytruk (Code Review) 05 May '23

05 May '23

Attention is currently required from: Nikolai Artemiev, Anastasia Klimchuk. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74930 ) Change subject: flashrom: Use WP-based unlocking on opaque masters ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/74930 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1774ad64d82ae47cd085df6045e17e283855c01f Gerrit-Change-Number: 74930 Gerrit-PatchSet: 4 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 05 May 2023 11:58:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: doc: Add doc how to add docs
by Anastasia Klimchuk (Code Review) 05 May '23

05 May '23

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Alexander Goncharov. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74225 ) Change subject: doc: Add doc how to add docs ...................................................................... Patch Set 6: (1 comment) Patchset: PS5: > I understand that this is only an initial version of the document, but I think that it's important t […] I added more info , hopefully it looks better now? -- To view, visit https://review.coreboot.org/c/flashrom/+/74225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I356a286ad2f3334392efadda366b0ca0f8042752 Gerrit-Change-Number: 74225 Gerrit-PatchSet: 6 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 05 May 2023 11:38:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: doc: Convert README to sphinx
by Anastasia Klimchuk (Code Review) 05 May '23

05 May '23

Attention is currently required from: Thomas Heijligen, Stefan Reinauer, Edward O'Callaghan, Alexander Goncharov. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74216 ) Change subject: doc: Convert README to sphinx ...................................................................... Patch Set 6: (19 comments) Patchset: PS5: > The "Build Instructions" section looks like a wall of text. It's difficult to read and navigate. […] Thank you so much for your thorough review, and for attention to details! This is so important! I fixed all the comments. Would you like to add yourself as maintainer for doc directory? If yes, please send a patch! That would be three people for doc directory, and I think it's great. It doesn't mean that all three need to approve, one is enough. But it means higher chance one of us have time to review the patch, if we get contributors for docs. File README.rst: https://review.coreboot.org/c/flashrom/+/74216/comment/44500077_ada69c9f PS5, Line 26: flashrom supports building with make and meson. > ``` […] Done https://review.coreboot.org/c/flashrom/+/74216/comment/56f9990e_d7f979ca PS5, Line 38: To build flashrom you need to install the following software: > ``` […] Done https://review.coreboot.org/c/flashrom/+/74216/comment/293b7695_03fb984b PS5, Line 48: Linux et al: > ``` […] Done https://review.coreboot.org/c/flashrom/+/74216/comment/ba83eae3_aa1675bb PS5, Line 54: On FreeBSD, you need the following ports: > ``` […] Done https://review.coreboot.org/c/flashrom/+/74216/comment/efb2f6b7_4c160625 PS5, Line 59: On OpenBSD, you need the following ports: > ``` […] Done https://review.coreboot.org/c/flashrom/+/74216/comment/3f10b623_3ec4b5c2 PS5, Line 64: To compile on Linux, use:: > ``` […] Done https://review.coreboot.org/c/flashrom/+/74216/comment/d875eee8_a5942dbc PS5, Line 68: To compile on FreeBSD, OpenBSD or DragonFly BSD, use:: > ``` […] Done https://review.coreboot.org/c/flashrom/+/74216/comment/5372191e_9c17717b PS5, Line 72: To compile on Nexenta, use:: > ``` […] Done https://review.coreboot.org/c/flashrom/+/74216/comment/c4e19970_ef2fb1d0 PS5, Line 76: To compile on Solaris, use:: > ``` […] Done https://review.coreboot.org/c/flashrom/+/74216/comment/b9511e72_e1e9b259 PS5, Line 80: To compile on NetBSD (with pciutils, libftdi, libusb installed in /usr/pkg/), use:: > ``` […] Done https://review.coreboot.org/c/flashrom/+/74216/comment/09574ff6_ff028c9a PS5, Line 84: To compile and run on Darwin/Mac OS X: > ``` […] Done https://review.coreboot.org/c/flashrom/+/74216/comment/6b57f962_6dfbd388 PS5, Line 89: To cross-compile on Linux for DOS: > ``` […] Done https://review.coreboot.org/c/flashrom/+/74216/comment/4e33c473_a0385945 PS5, Line 138: To cross-compile on Linux for Windows: > ``` […] Done https://review.coreboot.org/c/flashrom/+/74216/comment/6bbf6cf4_77b1ca84 PS5, Line 152: Processor architecture dependent features: > ``` […] Done https://review.coreboot.org/c/flashrom/+/74216/comment/3a76eaf6_8af4bd6e PS5, Line 158: Compiler quirks: > ``` […] Done https://review.coreboot.org/c/flashrom/+/74216/comment/57e2e3bd_9fd6f030 PS5, Line 164: Bindings: > ``` […] Done https://review.coreboot.org/c/flashrom/+/74216/comment/5126bc3c_9ef6498e PS5, Line 197: 'make export' > ``` […] Done https://review.coreboot.org/c/flashrom/+/74216/comment/e5143ef6_d54fa34a PS5, Line 203: 'make tarball' > ``` […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/74216 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6e0debc0e15a9c4866f6d16fb010cd3f13171ff3 Gerrit-Change-Number: 74216 Gerrit-PatchSet: 6 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 05 May 2023 11:36:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: doc: Add doc how to add docs
by Anastasia Klimchuk (Code Review) 05 May '23

05 May '23

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk. Hello build bot (Jenkins), Thomas Heijligen, Edward O'Callaghan, Alexander Goncharov, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/74225 to look at the new patch set (#6). Change subject: doc: Add doc how to add docs ...................................................................... doc: Add doc how to add docs Change-Id: I356a286ad2f3334392efadda366b0ca0f8042752 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- A doc/how_to_add_docs.rst M doc/index.rst 2 files changed, 46 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/25/74225/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/74225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I356a286ad2f3334392efadda366b0ca0f8042752 Gerrit-Change-Number: 74225 Gerrit-PatchSet: 6 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[L] Change in flashrom[master]: doc: Convert README to sphinx
by Anastasia Klimchuk (Code Review) 05 May '23

05 May '23

Attention is currently required from: Thomas Heijligen, Stefan Reinauer, Edward O'Callaghan, Anastasia Klimchuk. Hello build bot (Jenkins), Thomas Heijligen, Stefan Reinauer, Edward O'Callaghan, Alexander Goncharov, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/74216 to look at the new patch set (#6). Change subject: doc: Convert README to sphinx ...................................................................... doc: Convert README to sphinx This patch also includes small changes to README file that were agreed earlier: changing all links to https re-ordering of sections as Build instructions, Installations, Packaging, Contact Change-Id: I6e0debc0e15a9c4866f6d16fb010cd3f13171ff3 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- D README A README.rst M doc/index.rst 3 files changed, 238 insertions(+), 211 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/16/74216/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/74216 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6e0debc0e15a9c4866f6d16fb010cd3f13171ff3 Gerrit-Change-Number: 74216 Gerrit-PatchSet: 6 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2023