March 2023 - flashrom-gerrit - mail.coreboot.org

[L] Change in flashrom[master]: doc: Add build instructions
by Thomas Heijligen (Code Review) 08 Mar '23

08 Mar '23

Attention is currently required from: Thomas Heijligen, Stefan Reinauer, Anastasia Klimchuk, Peter Marheine. Hello build bot (Jenkins), Anastasia Klimchuk, Peter Marheine, Alexander Goncharov, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/73359 to look at the new patch set (#5). Change subject: doc: Add build instructions ...................................................................... doc: Add build instructions Those build instructions are mostly based on `Documentation/building.md` and the wiki. The `.. todo::` sections are non essential parts that will complete or improve the documentation. Either the content is not yet there or the sphinx-plugins to generate or improve them musst be first written. Change-Id: I96771e98b313a6d26dd2be940ff37998d4124324 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- D Documentation/building.md M doc/conf.py A doc/dev_guide/building_from_source.rst A doc/dev_guide/index.rst M doc/index.rst 5 files changed, 287 insertions(+), 148 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/59/73359/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/73359 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I96771e98b313a6d26dd2be940ff37998d4124324 Gerrit-Change-Number: 73359 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: flashchips: Add support for Boya BY25D80A
by Thomas Heijligen (Code Review) 08 Mar '23

08 Mar '23

Attention is currently required from: Edward O'Callaghan, Piotr Halama, Peter Marheine. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73513 ) Change subject: flashchips: Add support for Boya BY25D80A ...................................................................... Patch Set 2: (4 comments) File flashchips.c: https://review.coreboot.org/c/flashrom/+/73513/comment/03b9c0f3_8b28646a PS2, Line 3533: . Why the dot? Same for the `model_id` leaving the `Y` out https://review.coreboot.org/c/flashrom/+/73513/comment/04924545_24657104 PS2, Line 3546: {2 * 1024, 512 The datasheet says: `{4 * 1024, 256}` for the first eraser. https://review.coreboot.org/c/flashrom/+/73513/comment/5966a0f4_55390cbb PS2, Line 3549: 16 * 1024, 64 The Datasheet says {32 * 1024, 32} for the `52` block eraser. https://review.coreboot.org/c/flashrom/+/73513/comment/a5ebdd9f_5b6976f7 PS2, Line 3552: {32 * 1024, 32} The datasheet says `{64 * 1024. 16}` for the `D8` block eraser. -- To view, visit https://review.coreboot.org/c/flashrom/+/73513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I586f3455d925132bbda3fccdad00f0b1e22c2ea7 Gerrit-Change-Number: 73513 Gerrit-PatchSet: 2 Gerrit-Owner: Piotr Halama <skrzynka(a)halamix2.pl> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Piotr Halama <skrzynka(a)halamix2.pl> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Wed, 08 Mar 2023 20:32:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: chipset_enable: Mark Intel H97 as test_state OK
by Angel Pons (Code Review) 08 Mar '23

08 Mar '23

Attention is currently required from: Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73581 ) Change subject: chipset_enable: Mark Intel H97 as test_state OK ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File chipset_enable.c: https://review.coreboot.org/c/flashrom/+/73581/comment/d7a91253_afad1015 PS2, Line 2023: OK DEP, see CB:28817 for example. -- To view, visit https://review.coreboot.org/c/flashrom/+/73581 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iebf83b5b226d961bd5a6b5f53693dbc5f8884898 Gerrit-Change-Number: 73581 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 08 Mar 2023 19:25:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: MAINTAINERS: Add Jean THOMAS for DirtyJTAG
by Jean THOMAS (Code Review) 08 Mar '23

08 Mar '23

Attention is currently required from: Felix Singer, Anastasia Klimchuk. Jean THOMAS has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73552 ) Change subject: MAINTAINERS: Add Jean THOMAS for DirtyJTAG ...................................................................... Patch Set 3: (1 comment) Patchset: PS1: > You forgot to upload the latest patchset probably? :) […] Yes, it seems like I messed up ^^ This time it is (really) fixed! -- To view, visit https://review.coreboot.org/c/flashrom/+/73552 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0d45b9c634dd6f7509e366723e7fe727f0d087cd Gerrit-Change-Number: 73552 Gerrit-PatchSet: 3 Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 08 Mar 2023 19:15:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: fmap: ignore areas with zero size
by Thomas Heijligen (Code Review) 08 Mar '23

08 Mar '23

Attention is currently required from: Edward O'Callaghan, Peter Marheine. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73571 ) Change subject: fmap: ignore areas with zero size ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/73571 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie20971f779acece7a0b3b8f38796fff128ce689a Gerrit-Change-Number: 73571 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Wed, 08 Mar 2023 19:14:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: MAINTAINERS: Add Jean THOMAS for DirtyJTAG
by Jean THOMAS (Code Review) 08 Mar '23

08 Mar '23

Attention is currently required from: Felix Singer, Jean THOMAS. Hello Felix Singer, build bot (Jenkins), Thomas Heijligen, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/73552 to look at the new patch set (#3). Change subject: MAINTAINERS: Add Jean THOMAS for DirtyJTAG ...................................................................... MAINTAINERS: Add Jean THOMAS for DirtyJTAG Signed-off-by: Jean THOMAS <virgule(a)jeanthomas.me> Change-Id: I0d45b9c634dd6f7509e366723e7fe727f0d087cd --- M MAINTAINERS 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/52/73552/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/73552 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0d45b9c634dd6f7509e366723e7fe727f0d087cd Gerrit-Change-Number: 73552 Gerrit-PatchSet: 3 Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: MAINTAINERS: Add Jean THOMAS for DirtyJTAG
by Thomas Heijligen (Code Review) 08 Mar '23

08 Mar '23

Attention is currently required from: Felix Singer, Jean THOMAS. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73552 ) Change subject: MAINTAINERS: Add Jean THOMAS for DirtyJTAG ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/73552 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0d45b9c634dd6f7509e366723e7fe727f0d087cd Gerrit-Change-Number: 73552 Gerrit-PatchSet: 2 Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-Comment-Date: Wed, 08 Mar 2023 19:04:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: chipset_enable: Mark Intel H97 as test_state OK
by Thomas Heijligen (Code Review) 08 Mar '23

08 Mar '23

Thomas Heijligen has uploaded a new patch set (#2). ( https://review.coreboot.org/c/flashrom/+/73581 ) Change subject: chipset_enable: Mark Intel H97 as test_state OK ...................................................................... chipset_enable: Mark Intel H97 as test_state OK An user reported on the mailing list [0] a successfull update of an MSI MS-7850 mainboard with an Intel H97 chipset. [0] https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/message/MYU… Change-Id: Iebf83b5b226d961bd5a6b5f53693dbc5f8884898 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M chipset_enable.c 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/73581/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/73581 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iebf83b5b226d961bd5a6b5f53693dbc5f8884898 Gerrit-Change-Number: 73581 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: chipset_enable: Mark Intel H97 as test_state OK
by Thomas Heijligen (Code Review) 08 Mar '23

08 Mar '23

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/73581 ) Change subject: chipset_enable: Mark Intel H97 as test_state OK ...................................................................... chipset_enable: Mark Intel H97 as test_state OK An user reported on the mailing list a successfull update of an MSI MS-7850 mainboard with an Intel H97 chipset. Change-Id: Iebf83b5b226d961bd5a6b5f53693dbc5f8884898 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M chipset_enable.c 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/73581/1 diff --git a/chipset_enable.c b/chipset_enable.c index e1dd6a3..545996c 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -2020,7 +2020,7 @@ {0x8086, 0x8cc2, B_FS, NT, "Intel", "9 Series Engineering Sample", enable_flash_pch9}, {0x8086, 0x8cc3, B_FS, NT, "Intel", "9 Series", enable_flash_pch9}, {0x8086, 0x8cc4, B_FS, DEP, "Intel", "Z97", enable_flash_pch9}, - {0x8086, 0x8cc6, B_FS, NT, "Intel", "H97", enable_flash_pch9}, + {0x8086, 0x8cc6, B_FS, OK, "Intel", "H97", enable_flash_pch9}, {0x8086, 0x8d40, B_FS, NT, "Intel", "C610/X99 (Wellsburg)", enable_flash_pch8_wb}, {0x8086, 0x8d41, B_FS, NT, "Intel", "C610/X99 (Wellsburg)", enable_flash_pch8_wb}, {0x8086, 0x8d42, B_FS, NT, "Intel", "C610/X99 (Wellsburg)", enable_flash_pch8_wb}, -- To view, visit https://review.coreboot.org/c/flashrom/+/73581 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iebf83b5b226d961bd5a6b5f53693dbc5f8884898 Gerrit-Change-Number: 73581 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: include/pci.h: Use __has_include() macro to test pci.h path
by Angel Pons (Code Review) 08 Mar '23

08 Mar '23

Attention is currently required from: Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73292 ) Change subject: include/pci.h: Use __has_include() macro to test pci.h path ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/73292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib20de6bffede910b89937f554b4d56f4799f0762 Gerrit-Change-Number: 73292 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 08 Mar 2023 13:53:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2023