March 2023 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: MAINTAINERS: Add Jean THOMAS for DirtyJTAG
by Anastasia Klimchuk (Code Review) 10 Mar '23

10 Mar '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/73552 ) Change subject: MAINTAINERS: Add Jean THOMAS for DirtyJTAG ...................................................................... MAINTAINERS: Add Jean THOMAS for DirtyJTAG Signed-off-by: Jean THOMAS <virgule(a)jeanthomas.me> Change-Id: I0d45b9c634dd6f7509e366723e7fe727f0d087cd Reviewed-on: https://review.coreboot.org/c/flashrom/+/73552 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Thomas Heijligen <src(a)posteo.de> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M MAINTAINERS 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Thomas Heijligen: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved diff --git a/MAINTAINERS b/MAINTAINERS index 03f12b8..141c5be 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -127,6 +127,11 @@ S: Maintained F: ch347_spi.c +DirtyJTAG +M: Jean THOMAS <virgule(a)jeanthomas.me> +S: Maintained +F: dirtyjtag_spi.c + I2C PROGRAMMERS M: Peter Marheine <pmarheine(a)chromium.org> S: Supported -- To view, visit https://review.coreboot.org/c/flashrom/+/73552 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0d45b9c634dd6f7509e366723e7fe727f0d087cd Gerrit-Change-Number: 73552 Gerrit-PatchSet: 4 Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[L] Change in flashrom[master]: doc: Add build instructions
by Anastasia Klimchuk (Code Review) 10 Mar '23

10 Mar '23

Attention is currently required from: Thomas Heijligen, Stefan Reinauer, Alexander Goncharov. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73359 ) Change subject: doc: Add build instructions ...................................................................... Patch Set 5: Code-Review+1 (4 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/73359/comment/fd23e724_612bb159 PS5, Line 7: Add build instructions Convert build documentation to sphinx https://review.coreboot.org/c/flashrom/+/73359/comment/fab00c9d_439f53fb PS5, Line 9: Those These https://review.coreboot.org/c/flashrom/+/73359/comment/e60f5e6a_d992f999 PS5, Line 11: The `.. todo::` sections are non essential parts that will complete or : improve the documentation. Either the content is not yet there or the : sphinx-plugins to generate or improve them musst be first written. There are some `.. todo::` sections still present in the documentation. They will be completed later. For some of the todos content needs to be written, some others require custom sphinx-plugins to be implemented. File doc/building_from_source.rst: https://review.coreboot.org/c/flashrom/+/73359/comment/9e0b7797_b1c471bf PS1, Line 206: To get a code coverage report > I've updated to be close to the old one. […] Okay I am resolving this, thanks! -- To view, visit https://review.coreboot.org/c/flashrom/+/73359 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I96771e98b313a6d26dd2be940ff37998d4124324 Gerrit-Change-Number: 73359 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 10 Mar 2023 07:58:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashrom.c: Add wrapper function to use the erase algorithm
by Aarya (Code Review) 10 Mar '23

10 Mar '23

Aarya has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/66104 ) Change subject: flashrom.c: Add wrapper function to use the erase algorithm ...................................................................... Abandoned Squashed into CB:65844 -- To view, visit https://review.coreboot.org/c/flashrom/+/66104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8 Gerrit-Change-Number: 66104 Gerrit-PatchSet: 100 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[master]: flashrom.c:Add function to get a flattened view of the chip erase blocks
by Aarya (Code Review) 10 Mar '23

10 Mar '23

Aarya has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/65879 ) Change subject: flashrom.c:Add function to get a flattened view of the chip erase blocks ...................................................................... Abandoned Squashed into CB:65844 -- To view, visit https://review.coreboot.org/c/flashrom/+/65879 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iafe78de00daa55f7114bd4ce09465dd88074ece4 Gerrit-Change-Number: 65879 Gerrit-PatchSet: 56 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: flashrom.c:Add function to align region to sector boundaries
by Aarya (Code Review) 10 Mar '23

10 Mar '23

Aarya has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/65642 ) Change subject: flashrom.c:Add function to align region to sector boundaries ...................................................................... Abandoned Squashed into CB:65844 -- To view, visit https://review.coreboot.org/c/flashrom/+/65642 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I215ea4986aa23360fc65ff761f4e49c6069160ac Gerrit-Change-Number: 65642 Gerrit-PatchSet: 76 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: MAINTAINERS: Add Aarya Chaumal for erasure_layout
by Aarya (Code Review) 10 Mar '23

10 Mar '23

Aarya has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/73642 ) Change subject: MAINTAINERS: Add Aarya Chaumal for erasure_layout ...................................................................... MAINTAINERS: Add Aarya Chaumal for erasure_layout Change-Id: Id0188add883336f2fb494e4169a668e8b502682f Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> --- M MAINTAINERS 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/42/73642/1 diff --git a/MAINTAINERS b/MAINTAINERS index 03f12b8..6d4b01a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -103,6 +103,12 @@ F: writeprotect* F: include/writeprotect* +ERASE SELECTION +M: Aarya Chaumal <aarya.chaumal(a)gmail.com> +S: Maintained +F: erasure_layout* +F: include/erasure_layout* + ################################################################################ # DOCUMENTATION ################################################################################ -- To view, visit https://review.coreboot.org/c/flashrom/+/73642 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id0188add883336f2fb494e4169a668e8b502682f Gerrit-Change-Number: 73642 Gerrit-PatchSet: 1 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[master]: ch341a_spi: Refactor singleton states into reentrant pattern
by Anastasia Klimchuk (Code Review) 10 Mar '23

10 Mar '23

Attention is currently required from: Alexander Goncharov. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72807 ) Change subject: ch341a_spi: Refactor singleton states into reentrant pattern ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Patchset: PS4: Joursoir, if you could rebase would be great. Otherwise the patch is ready. -- To view, visit https://review.coreboot.org/c/flashrom/+/72807 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9fe72bff88b7f8778c1199bdab8ba43bf32e1c8c Gerrit-Change-Number: 72807 Gerrit-PatchSet: 4 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 10 Mar 2023 03:10:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashchips: Add support for Boya BY25D80A
by Piotr Halama (Code Review) 09 Mar '23

09 Mar '23

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Peter Marheine. Piotr Halama has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73513 ) Change subject: flashchips: Add support for Boya BY25D80A ...................................................................... Patch Set 5: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/73513/comment/76b5b226_9a03eb34 PS2, Line 3552: {32 * 1024, 32} > Shouldn't it be `{16 * 1024. 64}`? I've updated `D8` to `{16 * 1024. […] Ah, sorry, `{64 * 1024, 16}` does make more sense, updated -- To view, visit https://review.coreboot.org/c/flashrom/+/73513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I586f3455d925132bbda3fccdad00f0b1e22c2ea7 Gerrit-Change-Number: 73513 Gerrit-PatchSet: 5 Gerrit-Owner: Piotr Halama <skrzynka(a)halamix2.pl> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Thu, 09 Mar 2023 20:48:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Piotr Halama <skrzynka(a)halamix2.pl> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashchips: Add support for Boya BY25D80A
by Piotr Halama (Code Review) 09 Mar '23

09 Mar '23

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Peter Marheine. Hello build bot (Jenkins), Thomas Heijligen, Edward O'Callaghan, Peter Marheine, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/73513 to look at the new patch set (#6). Change subject: flashchips: Add support for Boya BY25D80A ...................................................................... flashchips: Add support for Boya BY25D80A Read tested on Raspberry Pico with pico-serprog Change-Id: I586f3455d925132bbda3fccdad00f0b1e22c2ea7 Signed-off-by: Piotr Halama <skrzynka(a)halamix2.pl> --- M flashchips.c M include/flashchips.h 2 files changed, 51 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/13/73513/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/73513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I586f3455d925132bbda3fccdad00f0b1e22c2ea7 Gerrit-Change-Number: 73513 Gerrit-PatchSet: 6 Gerrit-Owner: Piotr Halama <skrzynka(a)halamix2.pl> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: flashchips: Add support for Boya BY25D80A
by Piotr Halama (Code Review) 09 Mar '23

09 Mar '23

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Peter Marheine. Piotr Halama has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73513 ) Change subject: flashchips: Add support for Boya BY25D80A ...................................................................... Patch Set 5: (4 comments) File flashchips.c: https://review.coreboot.org/c/flashrom/+/73513/comment/9c2c8699_e01da067 PS2, Line 3533: . > Ack, thanks for catching. […] Done https://review.coreboot.org/c/flashrom/+/73513/comment/03021e31_960be4b0 PS2, Line 3546: {2 * 1024, 512 > The datasheet says: `{4 * 1024, 256}` for the first eraser. Done https://review.coreboot.org/c/flashrom/+/73513/comment/9f57d8f0_73abe214 PS2, Line 3549: 16 * 1024, 64 > The Datasheet says {32 * 1024, 32} for the `52` block eraser. Done https://review.coreboot.org/c/flashrom/+/73513/comment/94520833_a1f9644f PS2, Line 3552: {32 * 1024, 32} > The datasheet says `{64 * 1024. 16}` for the `D8` block eraser. Shouldn't it be `{16 * 1024. 64}`? I've updated `D8` to `{16 * 1024. 64}` -- To view, visit https://review.coreboot.org/c/flashrom/+/73513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I586f3455d925132bbda3fccdad00f0b1e22c2ea7 Gerrit-Change-Number: 73513 Gerrit-PatchSet: 5 Gerrit-Owner: Piotr Halama <skrzynka(a)halamix2.pl> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Thu, 09 Mar 2023 20:37:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2023