Attention is currently required from: Felix Singer, Evan Benn.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73175 )
Change subject: MAINTAINERS: flashrom_tester: Change email
......................................................................
Patch Set 1:
(1 comment)
File MAINTAINERS:
https://review.coreboot.org/c/flashrom/+/73175/comment/de666795_bf974f83
PS1, Line 173: S: Supported
> I have no idea yet, certainly there is no obligation upon Evan. […]
Sounds good :) I am resolving. In any case, that would be a separate patch.
--
To view, visit https://review.coreboot.org/c/flashrom/+/73175
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic1a53ddbc38e7d63f7b15aa2b31c63a5b65746f9
Gerrit-Change-Number: 73175
Gerrit-PatchSet: 1
Gerrit-Owner: Evan Benn <evanbenn(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Evan Benn <evanbenn(a)gmail.com>
Gerrit-Comment-Date: Sun, 26 Feb 2023 12:02:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Evan Benn <evanbenn(a)gmail.com>
Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org>
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Thomas Heijligen has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/73263 )
Change subject: meson: find libftdi1 also as libftdi with pkg-config
......................................................................
Abandoned
Debian packaging is confusing
--
To view, visit https://review.coreboot.org/c/flashrom/+/73263
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I48d72f06c6a43e27c7370207f111292fe2ba63f9
Gerrit-Change-Number: 73263
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Attention is currently required from: Nikolai Artemiev.
Hello build bot (Jenkins), Nikolai Artemiev,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/73286
to look at the new patch set (#2).
Change subject: libflashrom: Provide flashrom_flash_getname() API
......................................................................
libflashrom: Provide flashrom_flash_getname() API
The libflashom API exposes a API to get the flash size however
not the flash name.
Change-Id: I3dc32e261e6d54230d93f06b91f723811792112a
Signed-off-by: Edward O'Callaghan <quasisec(a)google.com>
---
M include/libflashrom.h
M libflashrom.c
2 files changed, 36 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/86/73286/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/73286
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3dc32e261e6d54230d93f06b91f723811792112a
Gerrit-Change-Number: 73286
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-MessageType: newpatchset
Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/73263 )
Change subject: meson: find libftdi1 also as libftdi with pkg-config
......................................................................
meson: find libftdi1 also as libftdi with pkg-config
On some systems the libftdi1 is known only as libftdi. Extend the meson
dependency call so that it searches for libftdi1 and libftdi. Add a
minimum required version to not get the original libftdi, which was
version 0.2 at highest.
The update to meson >=0.60.0 is required to use multiple names for a
dependency.
https://mesonbuild.com/Reference-manual_functions.html#dependency
Change-Id: I48d72f06c6a43e27c7370207f111292fe2ba63f9
Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com>
---
M meson.build
1 file changed, 21 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/63/73263/1
diff --git a/meson.build b/meson.build
index baa1084..1796a4e 100644
--- a/meson.build
+++ b/meson.build
@@ -1,7 +1,7 @@
project('flashromutils', 'c',
version : run_command('util/getversion.sh', '--version', check : true).stdout().strip(),
license : 'GPL-2.0',
- meson_version : '>=0.53.0',
+ meson_version : '>=0.60.0',
default_options : [
'warning_level=2',
'c_std=c99',
@@ -126,7 +126,7 @@
libpci = dependency('libpci', required : group_pci, static : (host_machine.system() == 'openbsd' ? true : false)) # On openbsd a static version of libpci is needed to get also -libz
libusb1 = dependency('libusb-1.0', required : group_usb)
-libftdi1 = dependency('libftdi1', required : group_ftdi)
+libftdi1 = dependency('libftdi1', 'libftdi', version : '>=1.0', required : group_ftdi)
libjaylink = dependency('libjaylink', required : group_jlink)
subdir('platform')
--
To view, visit https://review.coreboot.org/c/flashrom/+/73263
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I48d72f06c6a43e27c7370207f111292fe2ba63f9
Gerrit-Change-Number: 73263
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-MessageType: newchange
Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/73286 )
Change subject: libflashrom: Provide flashrom_flash_getname() API
......................................................................
libflashrom: Provide flashrom_flash_getname() API
The libflashom API exposes a API to get the flash size however
not the flash name.
Change-Id: I3dc32e261e6d54230d93f06b91f723811792112a
Signed-off-by: Edward O'Callaghan <quasisec(a)google.com>
---
M include/libflashrom.h
M libflashrom.c
2 files changed, 31 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/86/73286/1
diff --git a/include/libflashrom.h b/include/libflashrom.h
index 490ef03..fc8dd0e 100644
--- a/include/libflashrom.h
+++ b/include/libflashrom.h
@@ -230,6 +230,13 @@
*/
size_t flashrom_flash_getsize(const struct flashrom_flashctx *flashctx);
/**
+ * @brief Returns the name of the specified flash chip.
+ *
+ * @param flashctx The queried flash context.
+ * @param[out] allocated with a copy of the flash name string.
+ */
+void flashrom_flash_getname(const struct flashrom_flashctx *const flashctx, char **name);
+/**
* @brief Erase the specified ROM chip.
*
* If a layout is set in the given flash context, only included regions
diff --git a/libflashrom.c b/libflashrom.c
index 2e89fe5..50a7a0e 100644
--- a/libflashrom.c
+++ b/libflashrom.c
@@ -251,6 +251,17 @@
return flashctx->chip->total_size * 1024;
}
+void flashrom_flash_getname(const struct flashrom_flashctx *const flashctx, char **name)
+{
+ const char *chip_name = flashctx->chip->name;
+ const size_t len = strlen(chip_name) + 1;
+
+ if (!name) return;
+
+ *name = calloc(1, len);
+ strcpy(*name, chip_name);
+}
+
void flashrom_flash_release(struct flashrom_flashctx *const flashctx)
{
if (!flashctx)
--
To view, visit https://review.coreboot.org/c/flashrom/+/73286
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3dc32e261e6d54230d93f06b91f723811792112a
Gerrit-Change-Number: 73286
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: newchange
Attention is currently required from: Felix Singer, Evan Benn, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73175 )
Change subject: MAINTAINERS: flashrom_tester: Change email
......................................................................
Patch Set 1:
(1 comment)
File MAINTAINERS:
https://review.coreboot.org/c/flashrom/+/73175/comment/8ce5842b_84752a2b
PS1, Line 173: S: Supported
> Edward, do you think someone else can take this? Thank you!
I have no idea yet, certainly there is no obligation upon Evan. I am glad none the less to still be able to contact him to catch up for a drink sometime!
--
To view, visit https://review.coreboot.org/c/flashrom/+/73175
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic1a53ddbc38e7d63f7b15aa2b31c63a5b65746f9
Gerrit-Change-Number: 73175
Gerrit-PatchSet: 1
Gerrit-Owner: Evan Benn <evanbenn(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Evan Benn <evanbenn(a)gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Sun, 26 Feb 2023 10:18:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Evan Benn <evanbenn(a)gmail.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment