September 2022 - flashrom-gerrit

[S] Change in flashrom[master]: jlink_spi.c: Move serial number vars to struct `jlink_spi_parameters`
by Felix Singer (Code Review) 27 Sep '22

27 Sep '22

Felix Singer has uploaded a new patch set (#2). ( https://review.coreboot.org/c/flashrom/+/67887 ) Change subject: jlink_spi.c: Move serial number vars to struct `jlink_spi_parameters` ...................................................................... jlink_spi.c: Move serial number vars to struct `jlink_spi_parameters` Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Ib22224cca4c02f82a643488c118b88cba6b6a50a --- M jlink_spi.c 1 file changed, 19 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/87/67887/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67887 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib22224cca4c02f82a643488c118b88cba6b6a50a Gerrit-Change-Number: 67887 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: jlink_spi.c: Move serial number vars to struct `jlink_spi_parameters`
by Felix Singer (Code Review) 27 Sep '22

27 Sep '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/67887 ) Change subject: jlink_spi.c: Move serial number vars to struct `jlink_spi_parameters` ...................................................................... jlink_spi.c: Move serial number vars to struct `jlink_spi_parameters` Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Ib22224cca4c02f82a643488c118b88cba6b6a50a --- M jlink_spi.c 1 file changed, 19 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/87/67887/1 diff --git a/jlink_spi.c b/jlink_spi.c index e7e5913..c93b084 100644 --- a/jlink_spi.c +++ b/jlink_spi.c @@ -195,6 +195,8 @@ struct jlink_spi_parameters { unsigned long speed; + uint32_t serial_number; + bool use_serial_number; }; static int jlink_spi_init(const struct programmer_cfg *cfg) @@ -229,8 +231,6 @@ } int ret; - bool use_serial_number = false; - uint32_t serial_number; param_str = extract_programmer_param_str(cfg, "serial"); @@ -241,7 +241,7 @@ return 1; } - ret = jaylink_parse_serial_number(param_str, &serial_number); + ret = jaylink_parse_serial_number(param_str, &parameters.serial_number); if (ret == JAYLINK_ERR) { msg_perr("Invalid serial number specified: %s.\n", param_str); @@ -253,7 +253,7 @@ return 1; } - use_serial_number = true; + parameters.use_serial_number = true; free(param_str); } @@ -315,7 +315,7 @@ goto init_err; } - if (!use_serial_number) + if (!parameters.use_serial_number) msg_pdbg("No device selected, using first device.\n"); size_t i; @@ -323,7 +323,7 @@ bool device_found = false; for (i = 0; devs[i]; i++) { - if (use_serial_number) { + if (parameters.use_serial_number) { uint32_t tmp; ret = jaylink_device_get_serial_number(devs[i], &tmp); @@ -336,7 +336,7 @@ continue; } - if (serial_number != tmp) + if (parameters.serial_number != tmp) continue; } @@ -371,10 +371,10 @@ free(firmware_version); } - ret = jaylink_device_get_serial_number(dev, &serial_number); + ret = jaylink_device_get_serial_number(dev, &parameters.serial_number); if (ret == JAYLINK_OK) { - msg_pdbg("S/N: %" PRIu32 "\n", serial_number); + msg_pdbg("S/N: %" PRIu32 "\n", parameters.serial_number); } else if (ret == JAYLINK_ERR_NOT_AVAILABLE) { msg_pdbg("S/N: N/A\n"); } else { -- To view, visit https://review.coreboot.org/c/flashrom/+/67887 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib22224cca4c02f82a643488c118b88cba6b6a50a Gerrit-Change-Number: 67887 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: [WIP] test_build.sh: Fix if compound statement
by Felix Singer (Code Review) 27 Sep '22

27 Sep '22

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67268 ) Change subject: [WIP] test_build.sh: Fix if compound statement ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67268 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6fe21c8f5bc91c67fd95746859e875b1c119c8f0 Gerrit-Change-Number: 67268 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: jlink_spi.c: Move variable `speed` into struct `jlink_spi_parameters`
by Felix Singer (Code Review) 27 Sep '22

27 Sep '22

Felix Singer has uploaded a new patch set (#2). ( https://review.coreboot.org/c/flashrom/+/67886 ) Change subject: jlink_spi.c: Move variable `speed` into struct `jlink_spi_parameters` ...................................................................... jlink_spi.c: Move variable `speed` into struct `jlink_spi_parameters` Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I7af29e4bd107bfcda929155bbe603798d092fa79 --- M jlink_spi.c 1 file changed, 24 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/86/67886/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67886 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7af29e4bd107bfcda929155bbe603798d092fa79 Gerrit-Change-Number: 67886 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: jlink_spi.c: Move variable `speed` into struct `jlink_spi_parameters`
by Felix Singer (Code Review) 27 Sep '22

27 Sep '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/67886 ) Change subject: jlink_spi.c: Move variable `speed` into struct `jlink_spi_parameters` ...................................................................... jlink_spi.c: Move variable `speed` into struct `jlink_spi_parameters` Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I7af29e4bd107bfcda929155bbe603798d092fa79 --- M jlink_spi.c 1 file changed, 24 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/86/67886/1 diff --git a/jlink_spi.c b/jlink_spi.c index 2c9e6cc..fbe3223 100644 --- a/jlink_spi.c +++ b/jlink_spi.c @@ -193,14 +193,18 @@ .probe_opcode = default_spi_probe_opcode, }; +struct jlink_spi_parameters { + unsigned long speed; +}; + static int jlink_spi_init(const struct programmer_cfg *cfg) { char *param_str; - unsigned long speed = 0; struct jaylink_context *jaylink_ctx = NULL; struct jaylink_device_handle *jaylink_devh = NULL; bool reset_cs; struct jlink_spi_data *jlink_data = NULL; + struct jlink_spi_parameters parameters = { 0 }; bool enable_target_power; param_str = extract_programmer_param_str(cfg, "spispeed"); @@ -209,7 +213,7 @@ char *endptr; errno = 0; - speed = strtoul(param_str, &endptr, 10); + parameters.speed = strtoul(param_str, &endptr, 10); if (*endptr != '\0' || errno != 0) { msg_perr("Invalid SPI speed specified: %s.\n", param_str); @@ -217,7 +221,7 @@ return 1; } - if (speed < 1) { + if (parameters.speed < 1) { msg_perr("SPI speed must be at least 1 kHz.\n"); free(param_str); return 1; @@ -473,25 +477,25 @@ msg_pdbg("Maximum SPI speed: %" PRIu32 " kHz\n", device_speeds.freq / device_speeds.div); - if (!speed) { - speed = device_speeds.freq / device_speeds.div; - msg_pdbg("SPI speed not specified, using %lu kHz.\n", speed); + if (!parameters.speed) { + parameters.speed = device_speeds.freq / device_speeds.div; + msg_pdbg("SPI speed not specified, using %lu kHz.\n", parameters.speed); } - if (speed > (device_speeds.freq / device_speeds.div)) { - msg_perr("Specified SPI speed of %lu kHz is too high. Maximum is %" PRIu32 " kHz.\n", speed, + if (parameters.speed > (device_speeds.freq / device_speeds.div)) { + msg_perr("Specified SPI speed of %lu kHz is too high. Maximum is %" PRIu32 " kHz.\n", parameters.speed, device_speeds.freq / device_speeds.div); goto init_err; } - ret = jaylink_set_speed(jaylink_devh, speed); + ret = jaylink_set_speed(jaylink_devh, parameters.speed); if (ret != JAYLINK_OK) { msg_perr("jaylink_set_speed() failed: %s.\n", jaylink_strerror(ret)); goto init_err; } - msg_pdbg("SPI speed: %lu kHz\n", speed); + msg_pdbg("SPI speed: %lu kHz\n", parameters.speed); jlink_data = calloc(1, sizeof(*jlink_data)); if (!jlink_data) { -- To view, visit https://review.coreboot.org/c/flashrom/+/67886 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7af29e4bd107bfcda929155bbe603798d092fa79 Gerrit-Change-Number: 67886 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: jlink_spi.c: Call free() on a pointer only if it's not NULL
by Felix Singer (Code Review) 27 Sep '22

27 Sep '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/67885 ) Change subject: jlink_spi.c: Call free() on a pointer only if it's not NULL ...................................................................... jlink_spi.c: Call free() on a pointer only if it's not NULL Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: If3c15b72b44fb94a6c9015fd057867e6fe2ef1ba --- M jlink_spi.c 1 file changed, 14 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/85/67885/1 diff --git a/jlink_spi.c b/jlink_spi.c index 2a76a4a..2c9e6cc 100644 --- a/jlink_spi.c +++ b/jlink_spi.c @@ -222,10 +222,9 @@ free(param_str); return 1; } + free(param_str); } - free(param_str); - int ret; bool use_serial_number = false; uint32_t serial_number; @@ -252,10 +251,9 @@ } use_serial_number = true; + free(param_str); } - free(param_str); - reset_cs = true; param_str = extract_programmer_param_str(cfg, "cs"); @@ -269,10 +267,9 @@ free(param_str); return 1; } + free(param_str); } - free(param_str); - if (reset_cs) msg_pdbg("Using RESET as chip select signal.\n"); else @@ -289,10 +286,9 @@ free(param_str); return 1; } + free(param_str); } - free(param_str); - ret = jaylink_init(&jaylink_ctx); if (ret != JAYLINK_OK) { -- To view, visit https://review.coreboot.org/c/flashrom/+/67885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If3c15b72b44fb94a6c9015fd057867e6fe2ef1ba Gerrit-Change-Number: 67885 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: flashrom.c: create is_internal_programmer() helper
by Felix Singer (Code Review) 27 Sep '22

27 Sep '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66684 ) Change subject: flashrom.c: create is_internal_programmer() helper ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/66684 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I43243b990192077583a9a3a95d35844923d9c158 Gerrit-Change-Number: 66684 Gerrit-PatchSet: 8 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Tue, 27 Sep 2022 03:14:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: Add WP settings for Flash Chip `W25Q512NW`
by Subrata Banik (Code Review) 27 Sep '22

27 Sep '22

Attention is currently required from: Nikolai Artemiev, Anastasia Klimchuk. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67827 ) Change subject: flashchips: Add WP settings for Flash Chip `W25Q512NW` ...................................................................... Patch Set 2: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/67827/comment/7e4fc030_db0c9569 PS1, Line 18198: .cmp = {STATUS2, 6, RW}, > Add a line with `. […] Ack -- To view, visit https://review.coreboot.org/c/flashrom/+/67827 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic5148f71404466dcf7772e3eb6e1800eb8666696 Gerrit-Change-Number: 67827 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 27 Sep 2022 03:10:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips: Add WP settings for Flash Chip `W25Q512NW`
by Subrata Banik (Code Review) 27 Sep '22

27 Sep '22

Attention is currently required from: Nikolai Artemiev, Anastasia Klimchuk. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67827 ) Change subject: flashchips: Add WP settings for Flash Chip `W25Q512NW` ...................................................................... Patch Set 1: (2 comments) File flashchips.c: https://review.coreboot.org/c/flashrom/+/67827/comment/ba4dea32_5a39c9b0 PS1, Line 18159: , > | FEATURE_WRSR2 | FEATURE_WRSR3, Ack https://review.coreboot.org/c/flashrom/+/67827/comment/eb3280fc_e9d8450b PS1, Line 18198: .cmp = {STATUS2, 6, RW}, > Add a line with `. […] Ack -- To view, visit https://review.coreboot.org/c/flashrom/+/67827 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic5148f71404466dcf7772e3eb6e1800eb8666696 Gerrit-Change-Number: 67827 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 27 Sep 2022 03:10:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[1.2.x]: linux_mtd: Disable buffering on the mtd device
by Hung-Te Lin (Code Review) 27 Sep '22

27 Sep '22

Attention is currently required from: Nico Huber, Douglas Anderson, Angel Pons, Patrick Rudolph. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67871 ) Change subject: linux_mtd: Disable buffering on the mtd device ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.2.x Gerrit-Change-Id: I989afd83a33013b2756a0090d6b08245613215c6 Gerrit-Change-Number: 67871 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Douglas Anderson <dianders(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 27 Sep 2022 02:40:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2022