September 2022 - flashrom-gerrit

[S] Change in flashrom[1.1.x]: pickit2_spi: Fix "dead" assignment
by Elyes Haouas (Code Review) 27 Sep '22

27 Sep '22

Attention is currently required from: Nico Huber. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67846 ) Change subject: pickit2_spi: Fix "dead" assignment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67846 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.1.x Gerrit-Change-Id: I4aac5e1f3bd0604b079e1fdd9b7f09f1f4fc2d7f Gerrit-Change-Number: 67846 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 27 Sep 2022 11:24:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[1.2.x]: test_build.sh: Move build test procedure to repository
by Nico Huber (Code Review) 27 Sep '22

27 Sep '22

Attention is currently required from: Patrick Georgi, Edward O'Callaghan, Angel Pons. Nico Huber has removed a vote from this change. ( https://review.coreboot.org/c/flashrom/+/67860 ) Change subject: test_build.sh: Move build test procedure to repository ...................................................................... Removed Verified-1 by build bot (Jenkins) <no-reply(a)coreboot.org> -- To view, visit https://review.coreboot.org/c/flashrom/+/67860 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.2.x Gerrit-Change-Id: I37a8e925d1b283c3b8f87cb3d0f1ed8920f2cf95 Gerrit-Change-Number: 67860 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: deleteVote

1 0

[S] Change in flashrom[1.2.x]: test_build.sh: Move build test procedure to repository
by Nico Huber (Code Review) 27 Sep '22

27 Sep '22

Attention is currently required from: Patrick Georgi, Edward O'Callaghan, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67860 ) Change subject: test_build.sh: Move build test procedure to repository ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Why can't we submit CB:67861 first? Because there is no build script that gets executed? Yes, IIRC, Jenkins fails if the script is not there. -- To view, visit https://review.coreboot.org/c/flashrom/+/67860 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.2.x Gerrit-Change-Id: I37a8e925d1b283c3b8f87cb3d0f1ed8920f2cf95 Gerrit-Change-Number: 67860 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 27 Sep 2022 11:15:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[1.2.x]: libflashrom.c: Use casts on enum conversions
by Elyes Haouas (Code Review) 27 Sep '22

27 Sep '22

Attention is currently required from: Nico Huber, Angel Pons. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67861 ) Change subject: libflashrom.c: Use casts on enum conversions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.2.x Gerrit-Change-Id: I2166cdf3681452631ef8e980face2924e9a6c81a Gerrit-Change-Number: 67861 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 27 Sep 2022 11:02:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[1.2.x]: chipset_enable.c: Disable SPI on ICH7 if booted from LPC
by Elyes Haouas (Code Review) 27 Sep '22

27 Sep '22

Attention is currently required from: Nico Huber, Angel Pons. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67863 ) Change subject: chipset_enable.c: Disable SPI on ICH7 if booted from LPC ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67863 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.2.x Gerrit-Change-Id: I5e59e66a2dd16b07f2dca410997fce38ab9c8fd1 Gerrit-Change-Number: 67863 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 27 Sep 2022 11:00:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: dirtyjtag: Add DirtyJTAG programmer
by Thomas Heijligen (Code Review) 27 Sep '22

27 Sep '22

Attention is currently required from: Jean THOMAS. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67878 ) Change subject: dirtyjtag: Add DirtyJTAG programmer ...................................................................... Patch Set 2: (1 comment) File dirtyjtag_spi.c: https://review.coreboot.org/c/flashrom/+/67878/comment/d2d8b0d0_588d2317 PS1, Line 214: ret = libusb_set_auto_detach_kernel_driver(handle, 1); > Do you mean this one? https://review.coreboot.org/c/flashrom/+/57889/6/ch341a_spi. […] I mean CB:67071 -- To view, visit https://review.coreboot.org/c/flashrom/+/67878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic43e9a014ed7d04e429e73b30c9dcfdde1a78913 Gerrit-Change-Number: 67878 Gerrit-PatchSet: 2 Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-Comment-Date: Tue, 27 Sep 2022 06:24:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: dirtyjtag: Add DirtyJTAG programmer
by Jean THOMAS (Code Review) 27 Sep '22

27 Sep '22

Attention is currently required from: Thomas Heijligen. Jean THOMAS has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67878 ) Change subject: dirtyjtag: Add DirtyJTAG programmer ...................................................................... Patch Set 2: (4 comments) Patchset: PS2: Hi and thanks for your review. I was able to fix two of your suggestions, but I'm exactly sure about what you mean for the kernel detach bit? File dirtyjtag_spi.c: https://review.coreboot.org/c/flashrom/+/67878/comment/fc892d1f_cf68d84e PS1, Line 108: static int dirtyjtag_spi_shutdown(void *data) > the usb interface should also be released Done https://review.coreboot.org/c/flashrom/+/67878/comment/6455e80e_dd515317 PS1, Line 194: int ret = libusb_init(NULL); > please use an own libusb_contest and not the default ine (NULL), even if other programmera do so. […] Done https://review.coreboot.org/c/flashrom/+/67878/comment/87725d0a_f822ac89 PS1, Line 214: ret = libusb_set_auto_detach_kernel_driver(handle, 1); > this function is only available on new libusb versions. […] Do you mean this one? https://review.coreboot.org/c/flashrom/+/57889/6/ch341a_spi.c -- To view, visit https://review.coreboot.org/c/flashrom/+/67878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic43e9a014ed7d04e429e73b30c9dcfdde1a78913 Gerrit-Change-Number: 67878 Gerrit-PatchSet: 2 Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Tue, 27 Sep 2022 06:10:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: dirtyjtag: Add DirtyJTAG programmer
by Jean THOMAS (Code Review) 27 Sep '22

27 Sep '22

Attention is currently required from: Jean THOMAS. Hello build bot (Jenkins), Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67878 to look at the new patch set (#2). Change subject: dirtyjtag: Add DirtyJTAG programmer ...................................................................... dirtyjtag: Add DirtyJTAG programmer Add a new programmer driver for the DirtyJTAG project (a USB-JTAG firmware for STM32 MCUs). Successfully tested with DirtyJTAG 1.4 running on an Olimex STM32-H103 development board and a SST25VF020B SPI flash chip. Change-Id: Ic43e9a014ed7d04e429e73b30c9dcfdde1a78913 Signed-off-by: Jean THOMAS <virgule(a)jeanthomas.me> --- M Makefile A dirtyjtag_spi.c M flashrom.8.tmpl M include/programmer.h M meson.build M meson_options.txt M programmer_table.c 7 files changed, 372 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/67878/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic43e9a014ed7d04e429e73b30c9dcfdde1a78913 Gerrit-Change-Number: 67878 Gerrit-PatchSet: 2 Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: dirtyjtag: Release claimed USB interface
by Jean THOMAS (Code Review) 27 Sep '22

27 Sep '22

Jean THOMAS has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67899 ) Change subject: dirtyjtag: Release claimed USB interface ...................................................................... Abandoned I'm learning how to use Gerrit, I was indenting on pushing this commit to 67878 -- To view, visit https://review.coreboot.org/c/flashrom/+/67899 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2cafade0ee215f8154867c595af0e9af47a32823 Gerrit-Change-Number: 67899 Gerrit-PatchSet: 1 Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: dirtyjtag: Use owned libusb context
by Jean THOMAS (Code Review) 27 Sep '22

27 Sep '22

Jean THOMAS has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67898 ) Change subject: dirtyjtag: Use owned libusb context ...................................................................... Abandoned I'm learning how to use Gerrit, I was indenting on pushing this commit to 67878 -- To view, visit https://review.coreboot.org/c/flashrom/+/67898 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I940646d8454bc4ea6cfe263c87ce1f150642988d Gerrit-Change-Number: 67898 Gerrit-PatchSet: 1 Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-MessageType: abandon

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2022