September 2022 - flashrom-gerrit

[M] Change in flashrom[master]: [WIP] util/builder/flashrom-sdk: Add Docker image for building flashrom
by Felix Singer (Code Review) 01 Sep '22

01 Sep '22

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67267 ) Change subject: [WIP] util/builder/flashrom-sdk: Add Docker image for building flashrom ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/67267 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I616f263b058fda6afc93ce0e926d9a9fff7a0c4b Gerrit-Change-Number: 67267 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[master]: [WIP] util/builder/flashrom-sdk: Add Docker image for building flashrom
by Felix Singer (Code Review) 01 Sep '22

01 Sep '22

Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons, Anastasia Klimchuk. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67267 ) Change subject: [WIP] util/builder/flashrom-sdk: Add Docker image for building flashrom ...................................................................... Patch Set 6: (1 comment) File util/builder/flashrom-sdk/Dockerfile: https://review.coreboot.org/c/flashrom/+/67267/comment/8fc18339_5eeef230 PS6, Line 1: archlinux > As much as I love Arch Linux, it's rolling release and bleeding-edge: the only version Arch has is ` […] It's useless anyway. Our Jenkins is not able to handle multiple sorts of containers for historical reasons. We have to wait until CB:67272 is in and the new container is rolled out. So I will abandon this. -- To view, visit https://review.coreboot.org/c/flashrom/+/67267 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I616f263b058fda6afc93ce0e926d9a9fff7a0c4b Gerrit-Change-Number: 67267 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Sep 2022 23:44:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: meson: Build the classic cli / flashrom cli executable as feature
by Felix Singer (Code Review) 01 Sep '22

01 Sep '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66705 ) Change subject: meson: Build the classic cli / flashrom cli executable as feature ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/66705/comment/b84e5570_2f3fa4a9 PS5, Line 10: build buil*t* -- To view, visit https://review.coreboot.org/c/flashrom/+/66705 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If39981ad0b3281edd6fc7e220362d2938dddf814 Gerrit-Change-Number: 66705 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Sep 2022 23:24:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: Documentation: Add build instructions for meson
by Anastasia Klimchuk (Code Review) 01 Sep '22

01 Sep '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66862 ) Change subject: Documentation: Add build instructions for meson ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/66862 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3476f17fa274cd71e3e0e84f791d547d08165ecb Gerrit-Change-Number: 66862 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Sep 2022 23:10:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: [WIP] util/builder/flashrom-sdk: Add Docker image for building flashrom
by Thomas Heijligen (Code Review) 01 Sep '22

01 Sep '22

Attention is currently required from: Felix Singer, Nico Huber, Angel Pons, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67267 ) Change subject: [WIP] util/builder/flashrom-sdk: Add Docker image for building flashrom ...................................................................... Patch Set 6: (1 comment) File util/builder/flashrom-sdk/Dockerfile: https://review.coreboot.org/c/flashrom/+/67267/comment/0e687487_0b82a2b1 PS6, Line 1: archlinux > As much as I love Arch Linux, it's rolling release and bleeding-edge: the only version Arch has is ` […] +1 for a stable and common distribution with proper tagged docker images. There are distributions like ubuntu or fedora with a half year release cycle. That may be a good compromise. -- To view, visit https://review.coreboot.org/c/flashrom/+/67267 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I616f263b058fda6afc93ce0e926d9a9fff7a0c4b Gerrit-Change-Number: 67267 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Sep 2022 21:02:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashrom.c: Plumb 'all_skipped' global state into func param
by Thomas Heijligen (Code Review) 01 Sep '22

01 Sep '22

Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67093 ) Change subject: flashrom.c: Plumb 'all_skipped' global state into func param ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Aarya is currently working on code touching this, too. Please have a look that it is not getting an issue. Thanks -- To view, visit https://review.coreboot.org/c/flashrom/+/67093 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2346c869c47b48604360b0facf9313aae086c8dd Gerrit-Change-Number: 67093 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 01 Sep 2022 20:38:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: layout.c: Cast argument of isspace() to unsigned char
by Thomas Heijligen (Code Review) 01 Sep '22

01 Sep '22

Thomas Heijligen has submitted this change. ( https://review.coreboot.org/c/flashrom/+/66548 ) Change subject: layout.c: Cast argument of isspace() to unsigned char ...................................................................... layout.c: Cast argument of isspace() to unsigned char These functions [isspace, etc] check whether c [(the argument)], which must have the value of an unsigned char or EOF, falls into a certain character class according to the current locale. Cast the argument from `char` to `unsigned char` to guarantee that we don't pass illegal negative values. Some implementations actually provide a warning to get heads up[1]. [1] https://man.netbsd.org/ctype.3#CAVEATS TEST=Builds on Cygwin (Windows 10, amd64, gcc 11.3.0) Change-Id: Ia48d5a19b0964bc28e5360edf06bdf287dad5945 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/66548 Reviewed-by: Nico Huber <nico.h(a)gmx.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M layout.c 1 file changed, 28 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Angel Pons: Looks good to me, but someone else must approve Anastasia Klimchuk: Looks good to me, approved diff --git a/layout.c b/layout.c index 39f504a..5916d66 100644 --- a/layout.c +++ b/layout.c @@ -312,7 +312,7 @@ entry->file = strdup(entry->name); for (i = 0; entry->file[i]; ++i) { - if (isspace(entry->file[i])) + if (isspace((unsigned char)entry->file[i])) entry->file[i] = '_'; } } -- To view, visit https://review.coreboot.org/c/flashrom/+/66548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia48d5a19b0964bc28e5360edf06bdf287dad5945 Gerrit-Change-Number: 66548 Gerrit-PatchSet: 8 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Evan Benn <evanbenn(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: usb_device.c: detach/attach usb kernel driver explicitly
by Thomas Heijligen (Code Review) 01 Sep '22

01 Sep '22

Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67073 ) Change subject: usb_device.c: detach/attach usb kernel driver explicitly ...................................................................... Patch Set 3: (1 comment) File usb_device.c: https://review.coreboot.org/c/flashrom/+/67073/comment/619bcf43_14668ba7 PS2, Line 349: libusb_error_name(ret)); > Is the behavioral change intended? The important step is the claiming of the interface. The detaching of a possible kernel driver is only a step to make it more likely to succeed. Now it should be more precise. If the detachment is successful or there was no kernel driver attached or the detachment is not supported it will continue. *The last past is true on FreeBSD for example. -- To view, visit https://review.coreboot.org/c/flashrom/+/67073 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1363fea13368b7ac1e9a3829864d06d123c4e157 Gerrit-Change-Number: 67073 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Sep 2022 20:32:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: usb_device.c: release the usb interface on shutdown
by Thomas Heijligen (Code Review) 01 Sep '22

01 Sep '22

Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67072 ) Change subject: usb_device.c: release the usb interface on shutdown ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/67072/comment/b28bbc9c_7a9958fd PS2, Line 7: . > No period please Done https://review.coreboot.org/c/flashrom/+/67072/comment/80daf64d_0e350694 PS2, Line 10: handle.` > Where does this come from? I imagine it's from libusb documentation, so please mention it. Done -- To view, visit https://review.coreboot.org/c/flashrom/+/67072 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If916574314cd86fad3429065a11707da0a809e0d Gerrit-Change-Number: 67072 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Sep 2022 20:24:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: ch341a_spi: detach/attach kernel driver explicitly
by Thomas Heijligen (Code Review) 01 Sep '22

01 Sep '22

Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67071 ) Change subject: ch341a_spi: detach/attach kernel driver explicitly ...................................................................... Patch Set 3: (1 comment) File ch341a_spi.c: https://review.coreboot.org/c/flashrom/+/67071/comment/c4c052c7_b01c1f9d PS2, Line 454: usb > nit: USB Done -- To view, visit https://review.coreboot.org/c/flashrom/+/67071 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia649722e64cc97c6b689dd3b764e5c9145959f92 Gerrit-Change-Number: 67071 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Sep 2022 20:24:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2022