Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons.
Hello Felix Singer, build bot (Jenkins), Angel Pons, Anastasia Klimchuk, Nikolai Artemiev,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/66788
to look at the new patch set (#8).
Change subject: tree/: Convert flashchip read func ptr to enumerate
......................................................................
tree/: Convert flashchip read func ptr to enumerate
This forges the way for flashchips.c to be pure declarative
data and lookup functions for dispatch to be pure. This
means that the flashchips data could be extracted out to
be agnostic data of the flashrom code and algorithms.
Squash in,
flashchips.c: convert edi_chip_read()
flashchips.c: convert spi_chip_read()
flashchips.c: convert read_opaque()
flashchips.c: convert read_memmapped()
flashchips.c: convert spi_read_at45db_e8()
flashchips.c: convert spi_read_at45db()
flashchips.c: convert NULL cases
Change-Id: I612d46fefedf2b69e7e2064aa857fa0756efb4e7
Signed-off-by: Edward O'Callaghan <quasisec(a)google.com>
---
M flashchips.c
M flashrom.c
M fmap.c
M include/flash.h
M libflashrom.c
M tests/chip.c
M tests/chip_wp.c
7 files changed, 678 insertions(+), 607 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/88/66788/8
--
To view, visit https://review.coreboot.org/c/flashrom/+/66788
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I612d46fefedf2b69e7e2064aa857fa0756efb4e7
Gerrit-Change-Number: 66788
Gerrit-PatchSet: 8
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Edward O'Callaghan, Anastasia Klimchuk.
Hello Felix Singer, build bot (Jenkins), Nikolai Artemiev, Anastasia Klimchuk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/67240
to look at the new patch set (#5).
Change subject: tree/: Convert flashchip erase_block func ptr to enumerate
......................................................................
tree/: Convert flashchip erase_block func ptr to enumerate
This forges the way for flashchips.c to be pure declarative
data and lookup functions for dispatch to be pure. This
means that the flashchips data could be extracted out to
be agnostic data of the flashrom code and algorithms.
Change-Id: I58415a4f2589812b26d284c96876e88f8d9acf52
Signed-off-by: Edward O'Callaghan <quasisec(a)google.com>
---
M at45db.c
M atapromise.c
M flashchips.c
M flashrom.c
M include/chipdrivers.h
M include/flash.h
M sfdp.c
M spi25.c
M tests/chip.c
M tests/chip_wp.c
10 files changed, 2,103 insertions(+), 1,982 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/40/67240/5
--
To view, visit https://review.coreboot.org/c/flashrom/+/67240
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I58415a4f2589812b26d284c96876e88f8d9acf52
Gerrit-Change-Number: 67240
Gerrit-PatchSet: 5
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67269 )
Change subject: MAINTAINERS: Add Felix Singer for test_build.sh
......................................................................
Patch Set 3:
(1 comment)
File MAINTAINERS:
https://review.coreboot.org/c/flashrom/+/67269/comment/a035a859_fe3428ed
PS3, Line 145: TEST
What about we drop TEST from here? Just BUILD SCRIPT ? Or your previous version, CI BUILD SCRIPT, was also fine.
--
To view, visit https://review.coreboot.org/c/flashrom/+/67269
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I36267e6c080b14e90e820d3e26abaefe642f9c65
Gerrit-Change-Number: 67269
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Fri, 02 Sep 2022 00:17:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Anastasia Klimchuk.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67269 )
Change subject: MAINTAINERS: Add Felix Singer for test_build.sh
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS1:
> Why this is WIP? where is the trap? :)
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/67269
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I36267e6c080b14e90e820d3e26abaefe642f9c65
Gerrit-Change-Number: 67269
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Fri, 02 Sep 2022 00:10:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
Hello build bot (Jenkins), Angel Pons, Anastasia Klimchuk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/67269
to look at the new patch set (#3).
Change subject: MAINTAINERS: Add Felix Singer for test_build.sh
......................................................................
MAINTAINERS: Add Felix Singer for test_build.sh
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: I36267e6c080b14e90e820d3e26abaefe642f9c65
---
M MAINTAINERS
1 file changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/69/67269/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/67269
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I36267e6c080b14e90e820d3e26abaefe642f9c65
Gerrit-Change-Number: 67269
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer.
Hello build bot (Jenkins), Angel Pons, Anastasia Klimchuk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/67269
to look at the new patch set (#2).
Change subject: MAINTAINERS: Add Felix Singer for test_build.sh
......................................................................
MAINTAINERS: Add Felix Singer for test_build.sh
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: I36267e6c080b14e90e820d3e26abaefe642f9c65
---
M MAINTAINERS
1 file changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/69/67269/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/67269
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I36267e6c080b14e90e820d3e26abaefe642f9c65
Gerrit-Change-Number: 67269
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: newpatchset
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/67268
to look at the new patch set (#3).
Change subject: [WIP] test_build.sh: Fix if compound statement
......................................................................
[WIP] test_build.sh: Fix if compound statement
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: I6fe21c8f5bc91c67fd95746859e875b1c119c8f0
---
M test_build.sh
1 file changed, 11 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/68/67268/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/67268
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6fe21c8f5bc91c67fd95746859e875b1c119c8f0
Gerrit-Change-Number: 67268
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons, Anastasia Klimchuk.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67267 )
Change subject: [WIP] util/builder/flashrom-sdk: Add Docker image for building flashrom
......................................................................
Patch Set 6:
(1 comment)
File util/builder/flashrom-sdk/Dockerfile:
https://review.coreboot.org/c/flashrom/+/67267/comment/8fc18339_5eeef230
PS6, Line 1: archlinux
> As much as I love Arch Linux, it's rolling release and bleeding-edge: the only version Arch has is ` […]
It's useless anyway. Our Jenkins is not able to handle multiple sorts of containers for historical reasons. We have to wait until CB:67272 is in and the new container is rolled out. So I will abandon this.
--
To view, visit https://review.coreboot.org/c/flashrom/+/67267
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I616f263b058fda6afc93ce0e926d9a9fff7a0c4b
Gerrit-Change-Number: 67267
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Thu, 01 Sep 2022 23:44:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment