September 2022 - flashrom-gerrit

[S] Change in flashrom[master]: it87spi.c: Allow passing programmer_cfg directly
by Felix Singer (Code Review) 03 Sep '22

03 Sep '22

Attention is currently required from: Edward O'Callaghan. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66662 ) Change subject: it87spi.c: Allow passing programmer_cfg directly ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/66662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I598b1811c9734f41eee205d5a2b51ad8ac79e3ab Gerrit-Change-Number: 66662 Gerrit-PatchSet: 7 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Sat, 03 Sep 2022 07:56:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: chipset_enable.c: Change doit() and enable_flash_\S() signatures
by Edward O'Callaghan (Code Review) 03 Sep '22

03 Sep '22

Attention is currently required from: Felix Singer. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66672 ) Change subject: chipset_enable.c: Change doit() and enable_flash_\S() signatures ...................................................................... Patch Set 8: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/66672/comment/2989e7dd_561d2ef0 PS7, Line 7: doit() enable_flash_\S() > add an "and" in between Done https://review.coreboot.org/c/flashrom/+/66672/comment/7ade1251_7beb93d5 PS7, Line 16: Both, get_flashbase_sc520() and via_no_byte_merge() : should be renamed for consistency. > Doesn't have much to do with the rest of the commit. I would remove it. Done -- To view, visit https://review.coreboot.org/c/flashrom/+/66672 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I62c5d49a83ed4afb86ac3f0fae56defa1338ab4f Gerrit-Change-Number: 66672 Gerrit-PatchSet: 8 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Sat, 03 Sep 2022 04:35:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: tree: Fix drivers to pass programmer_cfg to pcidev_init()
by Edward O'Callaghan (Code Review) 03 Sep '22

03 Sep '22

Attention is currently required from: Felix Singer, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66671 ) Change subject: tree: Fix drivers to pass programmer_cfg to pcidev_init() ...................................................................... Patch Set 8: (1 comment) File include/programmer.h: https://review.coreboot.org/c/flashrom/+/66671/comment/7d6711c7_1a1366a5 PS3, Line 126: const char * > It would be consistent with the other commits and the lines below. Please do that. Fair fair. I fixed the other header too. Done. -- To view, visit https://review.coreboot.org/c/flashrom/+/66671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie0c9d1c0866d44f64d037c596f2e30547fcfd58f Gerrit-Change-Number: 66671 Gerrit-PatchSet: 8 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 03 Sep 2022 04:35:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: it87spi.c: Allow passing programmer_cfg directly
by Edward O'Callaghan (Code Review) 03 Sep '22

03 Sep '22

Attention is currently required from: Felix Singer. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66662 ) Change subject: it87spi.c: Allow passing programmer_cfg directly ...................................................................... Patch Set 7: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/66662/comment/392a3775_0dbf9ffd PS6, Line 14: init_superio_ite() probably should be renamed to superio_ite_init(). > I would remove that. Doesn't have much to do with the rest of the commit. Though, good point. Done -- To view, visit https://review.coreboot.org/c/flashrom/+/66662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I598b1811c9734f41eee205d5a2b51ad8ac79e3ab Gerrit-Change-Number: 66662 Gerrit-PatchSet: 7 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Sat, 03 Sep 2022 04:35:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: chipset_enable.c: plumb programmer_cfg into sb600 and ich init entry-...
by Edward O'Callaghan (Code Review) 03 Sep '22

03 Sep '22

Attention is currently required from: Edward O'Callaghan. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66674 to look at the new patch set (#8). Change subject: chipset_enable.c: plumb programmer_cfg into sb600 and ich init entry-points ...................................................................... chipset_enable.c: plumb programmer_cfg into sb600 and ich init entry-points Change-Id: Ic25014cbb983bda6e949bc62e30f2cca51f57a4c Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M chipset_enable.c 1 file changed, 15 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/74/66674/8 -- To view, visit https://review.coreboot.org/c/flashrom/+/66674 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic25014cbb983bda6e949bc62e30f2cca51f57a4c Gerrit-Change-Number: 66674 Gerrit-PatchSet: 8 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: tree: plumb programmer_cfg into chipset_flash_enable()
by Edward O'Callaghan (Code Review) 03 Sep '22

03 Sep '22

Attention is currently required from: Edward O'Callaghan. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66673 to look at the new patch set (#8). Change subject: tree: plumb programmer_cfg into chipset_flash_enable() ...................................................................... tree: plumb programmer_cfg into chipset_flash_enable() Change-Id: I963c674d212ce791ee155020fa97bcf26cefca0c Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M chipset_enable.c M include/programmer.h M internal.c 3 files changed, 14 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/73/66673/8 -- To view, visit https://review.coreboot.org/c/flashrom/+/66673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I963c674d212ce791ee155020fa97bcf26cefca0c Gerrit-Change-Number: 66673 Gerrit-PatchSet: 8 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: ichspi.c: Allow passing programmer_cfg directly
by Edward O'Callaghan (Code Review) 03 Sep '22

03 Sep '22

Attention is currently required from: Edward O'Callaghan. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66661 to look at the new patch set (#7). Change subject: ichspi.c: Allow passing programmer_cfg directly ...................................................................... ichspi.c: Allow passing programmer_cfg directly Modify the type signature of the programmer entry-point xxx_init() functions to allow for the consumption of the programmer parameterisation string data. Also plumb programmer_cfg though get_params. Change-Id: I480589bb50b47fdf5af259d068f49fedfce88ea5 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M chipset_enable.c M ichspi.c M include/programmer.h 3 files changed, 25 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/61/66661/7 -- To view, visit https://review.coreboot.org/c/flashrom/+/66661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I480589bb50b47fdf5af259d068f49fedfce88ea5 Gerrit-Change-Number: 66661 Gerrit-PatchSet: 7 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: chipset_enable.c: Change doit() and enable_flash_\S() signatures
by Edward O'Callaghan (Code Review) 03 Sep '22

03 Sep '22

Attention is currently required from: Edward O'Callaghan. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66672 to look at the new patch set (#8). Change subject: chipset_enable.c: Change doit() and enable_flash_\S() signatures ...................................................................... chipset_enable.c: Change doit() and enable_flash_\S() signatures Ran; ``` $ sed -Ei 's/int enable_flash_(\S+)\(/int enable_flash_\1(const char *prog_param, /g' chipset_enable.c $ sed -Ei 's/return enable_flash_(\S+)\(/return enable_flash_\1(cfg, /g' chipset_enable.c ``` and dealt with special cases manually. Change-Id: I62c5d49a83ed4afb86ac3f0fae56defa1338ab4f Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M chipset_enable.c M include/programmer.h 2 files changed, 129 insertions(+), 112 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/72/66672/8 -- To view, visit https://review.coreboot.org/c/flashrom/+/66672 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I62c5d49a83ed4afb86ac3f0fae56defa1338ab4f Gerrit-Change-Number: 66672 Gerrit-PatchSet: 8 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: tree: Fix drivers to pass programmer_cfg to pcidev_init()
by Edward O'Callaghan (Code Review) 03 Sep '22

03 Sep '22

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66671 to look at the new patch set (#8). Change subject: tree: Fix drivers to pass programmer_cfg to pcidev_init() ...................................................................... tree: Fix drivers to pass programmer_cfg to pcidev_init() Allow for programmer_cfg plumbing in pcidev.c The pci drivers impacted are plumbed here as well. Change-Id: Ie0c9d1c0866d44f64d037c596f2e30547fcfd58f Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M atahpt.c M atapromise.c M atavia.c M drkaiser.c M gfxnvidia.c M include/programmer.h M it8212.c M nic3com.c M nicintel.c M nicintel_eeprom.c M nicintel_spi.c M nicnatsemi.c M nicrealtek.c M ogp_spi.c M pcidev.c M satamv.c M satasii.c M tests/tests.c M tests/wraps.h 19 files changed, 35 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/71/66671/8 -- To view, visit https://review.coreboot.org/c/flashrom/+/66671 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie0c9d1c0866d44f64d037c596f2e30547fcfd58f Gerrit-Change-Number: 66671 Gerrit-PatchSet: 8 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: usb_device.c: Allow for programmer_cfg plumbing
by Edward O'Callaghan (Code Review) 03 Sep '22

03 Sep '22

Attention is currently required from: Edward O'Callaghan. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66670 to look at the new patch set (#8). Change subject: usb_device.c: Allow for programmer_cfg plumbing ...................................................................... usb_device.c: Allow for programmer_cfg plumbing The only driver impacted is raiden_debug_spi.c and so plumb state directly. Change-Id: I85ff3117de8743b0a548dad98875cc41f48cac93 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M include/usb_device.h M raiden_debug_spi.c M usb_device.c 3 files changed, 31 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/70/66670/8 -- To view, visit https://review.coreboot.org/c/flashrom/+/66670 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I85ff3117de8743b0a548dad98875cc41f48cac93 Gerrit-Change-Number: 66670 Gerrit-PatchSet: 8 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2022