September 2022 - flashrom-gerrit

[S] Change in flashrom[master]: tests: Guard Linux-specific linux/spidev.h header file
by Anastasia Klimchuk (Code Review) 04 Sep '22

04 Sep '22

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Peter Marheine. Hello Felix Singer, build bot (Jenkins), Thomas Heijligen, Angel Pons, Peter Marheine, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67311 to look at the new patch set (#2). Change subject: tests: Guard Linux-specific linux/spidev.h header file ...................................................................... tests: Guard Linux-specific linux/spidev.h header file This allows unit tests to build on non-Linux platforms. BUG=b:237606255 TEST=ninja test on two environments: 1) FreeBSD 13.1-RELEASE-p2 GENERIC amd64 2) Debian 5.17.11 x86_64 GNU/Linux Change-Id: Icdb1b0cb29c5d62187153788ad5e0e631e8d0b62 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> TICKET: https://ticket.coreboot.org/issues/411 --- M tests/lifecycle.h 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/67311/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67311 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icdb1b0cb29c5d62187153788ad5e0e631e8d0b62 Gerrit-Change-Number: 67311 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: tests: Use MOCK_FD instead of NON_ZERO for file operations
by Anastasia Klimchuk (Code Review) 04 Sep '22

04 Sep '22

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Peter Marheine. Hello Felix Singer, build bot (Jenkins), Thomas Heijligen, Angel Pons, Peter Marheine, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67310 to look at the new patch set (#2). Change subject: tests: Use MOCK_FD instead of NON_ZERO for file operations ...................................................................... tests: Use MOCK_FD instead of NON_ZERO for file operations NON_ZERO can be a negative number, so MOCK_FD is safer option to use as a mock file descriptor. Also it is more readable. BUG=b:237606255 TEST=ninja test on two environments: 1) FreeBSD 13.1-RELEASE-p2 GENERIC amd64 2) Debian 5.17.11 x86_64 GNU/Linux Change-Id: I097dd59f69c3fb532ac136796fcf5cae8839af7b Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> TICKET: https://ticket.coreboot.org/issues/411 --- M tests/tests.c 1 file changed, 22 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/10/67310/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67310 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I097dd59f69c3fb532ac136796fcf5cae8839af7b Gerrit-Change-Number: 67310 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: sb600spi.c: Allow passing programmer_cfg directly
by Felix Singer (Code Review) 04 Sep '22

04 Sep '22

Attention is currently required from: Edward O'Callaghan. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66660 ) Change subject: sb600spi.c: Allow passing programmer_cfg directly ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/66660 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I82f9ee75df90c582ef345c00a5487c687f28cdd5 Gerrit-Change-Number: 66660 Gerrit-PatchSet: 8 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Sun, 04 Sep 2022 02:42:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: sb600spi.c: Allow passing programmer_cfg directly
by Edward O'Callaghan (Code Review) 03 Sep '22

03 Sep '22

Attention is currently required from: Felix Singer. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66660 ) Change subject: sb600spi.c: Allow passing programmer_cfg directly ...................................................................... Patch Set 8: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/66660/comment/b0c963de_de1e9a80 PS7, Line 12: Also plumb programmer_cfg though get_params. > get_params does not exist. Yes, done. However we should make one. -- To view, visit https://review.coreboot.org/c/flashrom/+/66660 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I82f9ee75df90c582ef345c00a5487c687f28cdd5 Gerrit-Change-Number: 66660 Gerrit-PatchSet: 8 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Sat, 03 Sep 2022 23:52:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: it87spi.c: Allow passing programmer_cfg directly
by Edward O'Callaghan (Code Review) 03 Sep '22

03 Sep '22

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66662 ) Change subject: it87spi.c: Allow passing programmer_cfg directly ...................................................................... Patch Set 7: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/66662/comment/b2dcc3d3_f9bac7b3 PS7, Line 12: Also plumb programmer_cfg though get_params. > get_params does not exist. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/66662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I598b1811c9734f41eee205d5a2b51ad8ac79e3ab Gerrit-Change-Number: 66662 Gerrit-PatchSet: 7 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 03 Sep 2022 23:52:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: max_rom_decode packed into cfg WIP
by Edward O'Callaghan (Code Review) 03 Sep '22

03 Sep '22

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/67322 ) Change subject: max_rom_decode packed into cfg WIP ...................................................................... max_rom_decode packed into cfg WIP Change-Id: If1dd6013594d7e1a50658afb1fde8d1e191ee443 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M atapromise.c M chipset_enable.c M cli_classic.c M drkaiser.c M flashrom.c M include/programmer.h M it8212.c M nic3com.c M nicintel.c M nicnatsemi.c M satamv.c 11 files changed, 33 insertions(+), 25 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/22/67322/1 diff --git a/atapromise.c b/atapromise.c index 63463f5..08ce499 100644 --- a/atapromise.c +++ b/atapromise.c @@ -181,7 +181,7 @@ data->bar = bar; data->rom_size = rom_size; - max_rom_decode.parallel = rom_size; + cfg->max_rom_decode.parallel = rom_size; return register_par_master(&par_master_atapromise, BUS_PARALLEL, data); } diff --git a/chipset_enable.c b/chipset_enable.c index e205a83..3c62efe 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1238,18 +1238,18 @@ reg8 = pci_read_byte(dev, CS5530_RESET_CONTROL_REG); if (reg8 & CS5530_ISA_MASTER) { /* We have A0-A23 available. */ - max_rom_decode.parallel = 16 * 1024 * 1024; + cfg->max_rom_decode.parallel = 16 * 1024 * 1024; } else { reg8 = pci_read_byte(dev, CS5530_USB_SHADOW_REG); if (reg8 & CS5530_ENABLE_SA2320) { /* We have A0-19, A20-A23 available. */ - max_rom_decode.parallel = 16 * 1024 * 1024; + cfg->max_rom_decode.parallel = 16 * 1024 * 1024; } else if (reg8 & CS5530_ENABLE_SA20) { /* We have A0-19, A20 available. */ - max_rom_decode.parallel = 2 * 1024 * 1024; + cfg->max_rom_decode.parallel = 2 * 1024 * 1024; } else { /* A20 and above are not active. */ - max_rom_decode.parallel = 1024 * 1024; + cfg->max_rom_decode.parallel = 1024 * 1024; } } @@ -1355,14 +1355,14 @@ static int enable_flash_amd_768_8111(const struct programmer_cfg *cfg, struct pci_dev *dev, const char *name) { /* Enable decoding of 0xFFB00000 to 0xFFFFFFFF (5 MB). */ - max_rom_decode.lpc = 5 * 1024 * 1024; + cfg->max_rom_decode.lpc = 5 * 1024 * 1024; return enable_flash_amd_via(cfg, dev, name, 0xC0); } static int enable_flash_vt82c586(const struct programmer_cfg *cfg, struct pci_dev *dev, const char *name) { /* Enable decoding of 0xFFF80000 to 0xFFFFFFFF. (512 kB) */ - max_rom_decode.parallel = 512 * 1024; + cfg->max_rom_decode.parallel = 512 * 1024; return enable_flash_amd_via(cfg, dev, name, 0xC0); } @@ -1370,7 +1370,7 @@ static int enable_flash_vt82c596(const struct programmer_cfg *cfg, struct pci_dev *dev, const char *name) { /* Enable decoding of 0xFFF00000 to 0xFFFFFFFF. (1 MB) */ - max_rom_decode.parallel = 1024 * 1024; + cfg->max_rom_decode.parallel = 1024 * 1024; return enable_flash_amd_via(cfg, dev, name, 0xE0); } diff --git a/cli_classic.c b/cli_classic.c index bac31d1..91578d2 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -1014,7 +1014,7 @@ print_chip_support_status(fill_flash->chip); - unsigned int limitexceeded = count_max_decode_exceedings(fill_flash); + unsigned int limitexceeded = count_max_decode_exceedings(fill_flash); // XXX if (limitexceeded > 0 && !force) { enum chipbustype commonbuses = fill_flash->mst->buses_supported & fill_flash->chip->bustype; diff --git a/drkaiser.c b/drkaiser.c index b121eec..18eafea 100644 --- a/drkaiser.c +++ b/drkaiser.c @@ -112,7 +112,7 @@ data->flash_access = pci_read_word(dev, PCI_MAGIC_DRKAISER_ADDR); pci_write_word(dev, PCI_MAGIC_DRKAISER_ADDR, PCI_MAGIC_DRKAISER_VALUE); - max_rom_decode.parallel = 128 * 1024; + cfg->max_rom_decode.parallel = 128 * 1024; return register_par_master(&par_master_drkaiser, BUS_PARALLEL, data); } diff --git a/flashrom.c b/flashrom.c index 6c38e62..79b4f0c 100644 --- a/flashrom.c +++ b/flashrom.c @@ -38,12 +38,6 @@ static const struct programmer_entry *programmer = NULL; -/* - * Programmers supporting multiple buses can have differing size limits on - * each bus. Store the limits for each bus in a common struct. - */ -struct decode_sizes max_rom_decode; - /* If nonzero, used as the start address of bottom-aligned flash. */ unsigned long flashbase; @@ -67,6 +61,11 @@ struct programmer_cfg { char *params; + /* + * Programmers supporting multiple buses can have differing size limits on + * each bus. Store the limits for each bus in a common struct. + */ + struct decode_sizes max_rom_decode; }; /* Register a function to be executed on programmer shutdown. @@ -153,7 +152,7 @@ programmer = prog; /* Initialize all programmer specific data. */ /* Default to unlimited decode sizes. */ - max_rom_decode = (const struct decode_sizes) { + struct decode_sizes max_rom_decode = (const struct decode_sizes) { .parallel = 0xffffffff, .lpc = 0xffffffff, .fwh = 0xffffffff, @@ -167,7 +166,7 @@ programmer_may_write = 1; msg_pdbg("Initializing %s programmer\n", prog->name); - const struct programmer_cfg cfg = { .params = strdup(param) }; + const struct programmer_cfg cfg = { .params = strdup(param), .max_rom_decode = max_rom_decode }; int ret = prog->init(&cfg); ret = get_param_residue(cfg.params, ret); free(cfg.params); diff --git a/include/programmer.h b/include/programmer.h index 5331a12..0186399 100644 --- a/include/programmer.h +++ b/include/programmer.h @@ -284,7 +284,6 @@ uint32_t spi; }; // FIXME: These need to be local, not global -extern struct decode_sizes max_rom_decode; extern int programmer_may_write; extern unsigned long flashbase; unsigned int count_max_decode_exceedings(const struct flashctx *flash); diff --git a/it8212.c b/it8212.c index 18d1173..1adf9a9 100644 --- a/it8212.c +++ b/it8212.c @@ -103,7 +103,7 @@ data->decode_access = pci_read_long(dev, PCI_ROM_ADDRESS); pci_write_long(dev, PCI_ROM_ADDRESS, io_base_addr | 0x01); - max_rom_decode.parallel = IT8212_MEMMAP_SIZE; + cfg->max_rom_decode.parallel = IT8212_MEMMAP_SIZE; return register_par_master(&par_master_it8212, BUS_PARALLEL, data); } const struct programmer_entry programmer_it8212 = { diff --git a/nic3com.c b/nic3com.c index 44710ed..9fb0035 100644 --- a/nic3com.c +++ b/nic3com.c @@ -148,7 +148,7 @@ data->internal_conf = internal_conf; data->id = id; - max_rom_decode.parallel = 128 * 1024; + cfg->max_rom_decode.parallel = 128 * 1024; return register_par_master(&par_master_nic3com, BUS_PARALLEL, data); diff --git a/nicintel.c b/nicintel.c index 16cb5e4..ff47e56 100644 --- a/nicintel.c +++ b/nicintel.c @@ -124,7 +124,7 @@ data->nicintel_bar = bar; data->nicintel_control_bar = control_bar; - max_rom_decode.parallel = NICINTEL_MEMMAP_SIZE; + cfg->max_rom_decode.parallel = NICINTEL_MEMMAP_SIZE; return register_par_master(&par_master_nicintel, BUS_PARALLEL, data); } diff --git a/nicnatsemi.c b/nicnatsemi.c index 779fb33..44dfdd9 100644 --- a/nicnatsemi.c +++ b/nicnatsemi.c @@ -114,10 +114,10 @@ /* The datasheet shows address lines MA0-MA16 in one place and MA0-MA15 * in another. My NIC has MA16 connected to A16 on the boot ROM socket * so I'm assuming it is accessible. If not then next line wants to be - * max_rom_decode.parallel = 65536; and the mask in the read/write + * cfg->max_rom_decode.parallel = 65536; and the mask in the read/write * functions below wants to be 0x0000FFFF. */ - max_rom_decode.parallel = 131072; + cfg->max_rom_decode.parallel = 131072; return register_par_master(&par_master_nicnatsemi, BUS_PARALLEL, data); } diff --git a/satamv.c b/satamv.c index f886076..915d80f 100644 --- a/satamv.c +++ b/satamv.c @@ -202,7 +202,7 @@ /* 512 kByte with two 8-bit latches, and * 4 MByte with additional 3-bit latch. */ - max_rom_decode.parallel = 4 * 1024 * 1024; + cfg->max_rom_decode.parallel = 4 * 1024 * 1024; return register_par_master(&par_master_satamv, BUS_PARALLEL, data); } -- To view, visit https://review.coreboot.org/c/flashrom/+/67322 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If1dd6013594d7e1a50658afb1fde8d1e191ee443 Gerrit-Change-Number: 67322 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[master]: flashrom.c: Remove programmer_param global state
by Edward O'Callaghan (Code Review) 03 Sep '22

03 Sep '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan. Hello Felix Singer, build bot (Jenkins), Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66659 to look at the new patch set (#12). Change subject: flashrom.c: Remove programmer_param global state ...................................................................... flashrom.c: Remove programmer_param global state Change-Id: I778609e370e44ad2b63b8baa4984ac03ff4124d8 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M flashrom.c 1 file changed, 37 insertions(+), 25 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/59/66659/12 -- To view, visit https://review.coreboot.org/c/flashrom/+/66659 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I778609e370e44ad2b63b8baa4984ac03ff4124d8 Gerrit-Change-Number: 66659 Gerrit-PatchSet: 12 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: chipset_enable.c: plumb programmer_cfg into sb600 and ich init entry-...
by Edward O'Callaghan (Code Review) 03 Sep '22

03 Sep '22

Attention is currently required from: Edward O'Callaghan. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66674 to look at the new patch set (#9). Change subject: chipset_enable.c: plumb programmer_cfg into sb600 and ich init entry-points ...................................................................... chipset_enable.c: plumb programmer_cfg into sb600 and ich init entry-points Change-Id: Ic25014cbb983bda6e949bc62e30f2cca51f57a4c Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M chipset_enable.c 1 file changed, 15 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/74/66674/9 -- To view, visit https://review.coreboot.org/c/flashrom/+/66674 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic25014cbb983bda6e949bc62e30f2cca51f57a4c Gerrit-Change-Number: 66674 Gerrit-PatchSet: 9 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: tree: plumb programmer_cfg into chipset_flash_enable()
by Edward O'Callaghan (Code Review) 03 Sep '22

03 Sep '22

Attention is currently required from: Edward O'Callaghan. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66673 to look at the new patch set (#9). Change subject: tree: plumb programmer_cfg into chipset_flash_enable() ...................................................................... tree: plumb programmer_cfg into chipset_flash_enable() Change-Id: I963c674d212ce791ee155020fa97bcf26cefca0c Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M chipset_enable.c M include/programmer.h M internal.c 3 files changed, 14 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/73/66673/9 -- To view, visit https://review.coreboot.org/c/flashrom/+/66673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I963c674d212ce791ee155020fa97bcf26cefca0c Gerrit-Change-Number: 66673 Gerrit-PatchSet: 9 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: ichspi.c: Allow passing programmer_cfg directly
by Edward O'Callaghan (Code Review) 03 Sep '22

03 Sep '22

Attention is currently required from: Edward O'Callaghan. Hello build bot (Jenkins), Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66661 to look at the new patch set (#8). Change subject: ichspi.c: Allow passing programmer_cfg directly ...................................................................... ichspi.c: Allow passing programmer_cfg directly Modify the type signature of the programmer entry-point xxx_init() functions to allow for the consumption of the programmer parameterisation string data. Also plumb programmer_cfg though get_params. Change-Id: I480589bb50b47fdf5af259d068f49fedfce88ea5 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M chipset_enable.c M ichspi.c M include/programmer.h 3 files changed, 25 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/61/66661/8 -- To view, visit https://review.coreboot.org/c/flashrom/+/66661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I480589bb50b47fdf5af259d068f49fedfce88ea5 Gerrit-Change-Number: 66661 Gerrit-PatchSet: 8 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2022