Attention is currently required from: Peter Marheine.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64849 )
Change subject: flashrom_tester: Use Flashrom trait instead of struct FlashromCmd
......................................................................
Patch Set 1:
(1 comment)
File util/flashrom_tester/src/tester.rs:
https://review.coreboot.org/c/flashrom/+/64849/comment/1a9ea5a3_3e22d98e
PS1, Line 55: pub cmd: &'a dyn Flashrom,
The other option suggested by Peter is to take ownership here, with
`pub cmd: Box<dyn Flashrom>`
I had a go at this. I'm not expert in rust enough to make it work; many changes to the WriteProtectState lifetime annotations and 'Sized' trait compilation errors make it tricky.
--
To view, visit https://review.coreboot.org/c/flashrom/+/64849
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie2b4e7e91d69043fd50d1c57f6585fc9946fab10
Gerrit-Change-Number: 64849
Gerrit-PatchSet: 1
Gerrit-Owner: Evan Benn <evanbenn(a)google.com>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Comment-Date: Wed, 01 Jun 2022 03:15:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Peter Marheine.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64849 )
Change subject: flashrom_tester: Use Flashrom trait instead of struct FlashromCmd
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
There is some further WIP work based on this here: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/…
--
To view, visit https://review.coreboot.org/c/flashrom/+/64849
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie2b4e7e91d69043fd50d1c57f6585fc9946fab10
Gerrit-Change-Number: 64849
Gerrit-PatchSet: 1
Gerrit-Owner: Evan Benn <evanbenn(a)google.com>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Comment-Date: Wed, 01 Jun 2022 03:11:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Joursoir.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54890 )
Change subject: programmer: Introduce default shutdown function
......................................................................
Patch Set 6:
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/54890/comment/4a991178_7bcfd1f7
PS5, Line 104: function;
> Do I right understand that you mean checking in register_*_master() and not in
> register_shutdown()?
Actually I wasn't thinking which place (out of these two) is the best one. But we don't have to decide right now. The question was for future, when (and if) we decide that shutdown function needs to be required - at the moment it is not required.
It would be great to summarize this thread... Edward, what do you think about Angel's and my replies above? It was almost a year ago, but I still think in the same way :) There are few other comments, but that's essentially the same question.
--
To view, visit https://review.coreboot.org/c/flashrom/+/54890
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8b20717ba549e12edffbc5d1643ff064a4f0c517
Gerrit-Change-Number: 54890
Gerrit-PatchSet: 6
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Joursoir <chat(a)joursoir.net>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Joursoir <chat(a)joursoir.net>
Gerrit-Comment-Date: Wed, 01 Jun 2022 02:23:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Comment-In-Reply-To: Joursoir <chat(a)joursoir.net>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Angel Pons, Nikolai Artemiev.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64488 )
Change subject: dummyflasher: Wire variable size feature via opaque infra
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/64488/comment/174f2492_e8a1e301
PS2, Line 20: TEST
> A comment for myself: check with the users of "variable size" feature to make sure their stuff does […]
It's all good! So I am closing this comment.
Patchset:
PS4:
Testing done, and I rebased the patch on the latest. I also ran all the scenarios listed in commit message, and all of them work successfully.
So, ready! :)
--
To view, visit https://review.coreboot.org/c/flashrom/+/64488
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I76402bfdf8b1a75489e4509fec92c9a777d0cf58
Gerrit-Change-Number: 64488
Gerrit-PatchSet: 4
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Namyoon Woo <namyoon(a)google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 01:33:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment