Change in flashrom[master]: flashrom_tester: Use Flashrom trait instead of struct FlashromCmd

[Evan Benn (Code Review)]

Attention is currently required from: Peter Marheine.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64849 )

Change subject: flashrom_tester: Use Flashrom trait instead of struct FlashromCmd
......................................................................


Patch Set 1:

(1 comment)

File util/flashrom_tester/src/tester.rs:

https://review.coreboot.org/c/flashrom/+/64849/comment/1a9ea5a3_3e22d98e 
PS1, Line 55:     pub cmd: &'a dyn Flashrom,
The other option suggested by Peter is to take ownership here, with
`pub cmd: Box<dyn Flashrom>`

I had a go at this. I'm not expert in rust enough to make it work; many changes to the WriteProtectState lifetime annotations and 'Sized' trait compilation errors make it tricky.



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/64849
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie2b4e7e91d69043fd50d1c57f6585fc9946fab10
Gerrit-Change-Number: 64849
Gerrit-PatchSet: 1
Gerrit-Owner: Evan Benn <[e-mail]>
Gerrit-Reviewer: Peter Marheine <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Attention: Peter Marheine <[e-mail]>
Gerrit-Comment-Date: Wed, 01 Jun 2022 03:15:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment