May 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: libflashrom: Allow getting the progress_state from the flashctx
by Nico Huber (Code Review) 31 May '22

31 May '22

Attention is currently required from: Felix Singer, Richard Hughes, Edward O'Callaghan, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64663 ) Change subject: libflashrom: Allow getting the progress_state from the flashctx ...................................................................... Patch Set 2: (3 comments) Patchset: PS2: > > have you tested if the current implementation works? > > There is a testing information in commit message, I asked to add earlier. I meant if it works correctly in fwupd. > What would be a better way to wire update_progress into spi infra, what do you think? I'd start with a general rule, SPI is special though because more things go through the master. Maybe: "The chip read/write functions are generally resonsible for updating the progress state. If they simply wrap the functions of a master, the responsibility is delegated to those master functions." So for SPI this would mean whatever we set in `struct spi_master` should update the progress. However, I'm not convinced that this is even a good strategy for an overall progress indication. Counting individual interations inside the chip func- tions makes sense for a smooth advance but the only place where we actually know the grand total is at the core of flashrom.c, e.g. in walk_by_layout(). I couldn't test this because of the bugs in the current implementation (write progress just stayed at 0% in dummyflasher), but I imagine for a write it would just jump through a lot of 0..100% for erase/read/write multiple times. I'm not sure if this is intended. It would actually not provide more infor- mation to the user than a spinning wheel would. File include/libflashrom.h: https://review.coreboot.org/c/flashrom/+/64663/comment/9997d845_bbe8b4e3 PS2, Line 85: typedef void(flashrom_progress_callback)(struct flashrom_flashctx *flashctx); > I think I can answer this one. […] But struct flashrom_flashctx is opaque, so there's only one state effectively. I wonder why is there a flashctx argument at all? Any additional information the callee needs can be conveyed in `user_data`. So why not make things simple and pass `(progress_state, user_data)`? File libflashrom.c: https://review.coreboot.org/c/flashrom/+/64663/comment/47ca2976_e67c75a1 PS2, Line 70: return flashctx->progress_state; > We should create a patch that consistently introduces guards for parameter sanity. So far we guard when it's allowed to pass NULL. Everything else should probably be an assert()? -- To view, visit https://review.coreboot.org/c/flashrom/+/64663 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I322bf56ff92f7b4d0ffc92768e9f0cdf7cb82010 Gerrit-Change-Number: 64663 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 31 May 2022 12:28:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: libflashrom: Allow getting the progress_state from the flashctx
by Edward O'Callaghan (Code Review) 31 May '22

31 May '22

Attention is currently required from: Felix Singer, Nico Huber, Richard Hughes, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64663 ) Change subject: libflashrom: Allow getting the progress_state from the flashctx ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/64663 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I322bf56ff92f7b4d0ffc92768e9f0cdf7cb82010 Gerrit-Change-Number: 64663 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 31 May 2022 11:23:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: libflashrom: Allow getting the progress_state from the flashctx
by Edward O'Callaghan (Code Review) 31 May '22

31 May '22

Attention is currently required from: Felix Singer, Nico Huber, Richard Hughes, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64663 ) Change subject: libflashrom: Allow getting the progress_state from the flashctx ...................................................................... Patch Set 2: (1 comment) File libflashrom.c: https://review.coreboot.org/c/flashrom/+/64663/comment/8c23ef04_5041d233 PS2, Line 70: return flashctx->progress_state; > I read your comment and started thinking about this too. […] We should create a patch that consistently introduces guards for parameter sanity. -- To view, visit https://review.coreboot.org/c/flashrom/+/64663 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I322bf56ff92f7b4d0ffc92768e9f0cdf7cb82010 Gerrit-Change-Number: 64663 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 31 May 2022 11:23:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: test_build.sh: Allow WARNERROR to be overridden
by Nico Huber (Code Review) 31 May '22

31 May '22

Attention is currently required from: Felix Singer, Martin L Roth, Edward O'Callaghan, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62745 ) Change subject: test_build.sh: Allow WARNERROR to be overridden ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I think what Nico is trying to say is that the Makefile already enables WARNERROR by default and so this is redundant to it. We can just remove it from the shell script. Exactly this, thank you :) -- To view, visit https://review.coreboot.org/c/flashrom/+/62745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iea931e57f2a6992762566dc3dbaae8bb8df5b226 Gerrit-Change-Number: 62745 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 31 May 2022 11:06:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Martin L Roth <gaumless(a)tutanota.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: use files() for srcs list
by Thomas Heijligen (Code Review) 31 May '22

31 May '22

Thomas Heijligen has submitted this change. ( https://review.coreboot.org/c/flashrom/+/64384 ) Change subject: meson: use files() for srcs list ...................................................................... meson: use files() for srcs list Meson looks up if the file xyz.c exists when calling file('xyz.c'). Furthermore it keeps track of the directory of the file. This is handy when using multiple directories. Change-Id: I346b5468b4203f1521ec73a90f93ff3b13ebf43c Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/64384 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> --- M meson.build 1 file changed, 64 insertions(+), 61 deletions(-) Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved diff --git a/meson.build b/meson.build index cbce8c1..a8e5a7b 100644 --- a/meson.build +++ b/meson.build @@ -178,8 +178,7 @@ # some programmers require libusb if get_option('usb') - srcs += 'usbdev.c' - srcs += 'usb_device.c' + srcs += files('usbdev.c', 'usb_device.c') deps += dependency('libusb-1.0') elif need_libusb1 error('usb is disabled but one or more enabled programmer requires USB access') @@ -187,7 +186,7 @@ # some programmers require libpci if get_option('pciutils') - srcs += 'pcidev.c' + srcs += files('pcidev.c') deps += dependency('libpci') elif need_libpci error('pciutils is disabled but one or more enabled programmer requires PCI access') @@ -203,77 +202,81 @@ # set defines for configured programmers if config_atahpt - srcs += 'atahpt.c' + srcs += files('atahpt.c') cargs += '-DCONFIG_ATAHPT=1' endif if config_atapromise - srcs += 'atapromise.c' + srcs += files('atapromise.c') cargs += '-DCONFIG_ATAPROMISE=1' endif if config_atavia - srcs += 'atavia.c' + srcs += files('atavia.c') cargs += '-DCONFIG_ATAVIA=1' endif if config_buspirate_spi - srcs += 'buspirate_spi.c' + srcs += files('buspirate_spi.c') cargs += '-DCONFIG_BUSPIRATE_SPI=1' endif if config_ch341a_spi - srcs += 'ch341a_spi.c' + srcs += files('ch341a_spi.c') cargs += '-DCONFIG_CH341A_SPI=1' endif if config_dediprog - srcs += 'dediprog.c' + srcs += files('dediprog.c') cargs += '-DCONFIG_DEDIPROG=1' endif if config_developerbox_spi - srcs += 'developerbox_spi.c' + srcs += files('developerbox_spi.c') cargs += '-DCONFIG_DEVELOPERBOX_SPI=1' endif if config_digilent_spi - srcs += 'digilent_spi.c' + srcs += files('digilent_spi.c') cargs += '-DCONFIG_DIGILENT_SPI=1' endif if config_jlink_spi - srcs += 'jlink_spi.c' + srcs += files('jlink_spi.c') cargs += '-DCONFIG_JLINK_SPI=1' endif if config_drkaiser - srcs += 'drkaiser.c' + srcs += files('drkaiser.c') cargs += '-DCONFIG_DRKAISER=1' endif if config_dummy - srcs += 'dummyflasher.c' + srcs += files('dummyflasher.c') cargs += '-DCONFIG_DUMMY=1' endif if config_ft2232_spi - srcs += 'ft2232_spi.c' + srcs += files('ft2232_spi.c') cargs += '-DCONFIG_FT2232_SPI=1' cargs += '-DHAVE_FT232H=1' endif if config_gfxnvidia - srcs += 'gfxnvidia.c' + srcs += files('gfxnvidia.c') cargs += '-DCONFIG_GFXNVIDIA=1' endif if config_raiden_debug_spi - srcs += 'raiden_debug_spi.c' + srcs += files('raiden_debug_spi.c') cargs += '-DCONFIG_RAIDEN_DEBUG_SPI=1' endif if config_internal - srcs += 'board_enable.c' - srcs += 'cbtable.c' - srcs += 'chipset_enable.c' - srcs += 'internal.c' - srcs += 'processor_enable.c' + srcs += files( + 'board_enable.c', + 'cbtable.c', + 'chipset_enable.c', + 'internal.c', + 'processor_enable.c', + ) if host_is_x86 - srcs += 'amd_imc.c' - srcs += 'dmi.c' - srcs += 'ichspi.c' - srcs += 'it85spi.c' - srcs += 'it87spi.c' - srcs += 'mcp6x_spi.c' - srcs += 'sb600spi.c' - srcs += 'wbsio_spi.c' + srcs += files( + 'amd_imc.c', + 'dmi.c', + 'ichspi.c', + 'it85spi.c', + 'it87spi.c', + 'mcp6x_spi.c', + 'sb600spi.c', + 'wbsio_spi.c', + ) endif cargs += '-DCONFIG_INTERNAL=1' if get_option('config_internal_dmi') @@ -282,129 +285,129 @@ endif endif if config_it8212 - srcs += 'it8212.c' + srcs += files('it8212.c') cargs += '-DCONFIG_IT8212=1' endif if config_linux_mtd - srcs += 'linux_mtd.c' + srcs += files('linux_mtd.c') cargs += '-DCONFIG_LINUX_MTD=1' endif if config_linux_spi - srcs += 'linux_spi.c' + srcs += files('linux_spi.c') cargs += '-DCONFIG_LINUX_SPI=1' endif if config_mstarddc_spi - srcs += 'mstarddc_spi.c' + srcs += files('mstarddc_spi.c') cargs += '-DCONFIG_MSTARDDC_SPI=1' endif if config_nic3com - srcs += 'nic3com.c' + srcs += files('nic3com.c') cargs += '-DCONFIG_NIC3COM=1' endif if config_nicintel - srcs += 'nicintel.c' + srcs += files('nicintel.c') cargs += '-DCONFIG_NICINTEL=1' endif if config_nicintel_eeprom - srcs += 'nicintel_eeprom.c' + srcs += files('nicintel_eeprom.c') cargs += '-DCONFIG_NICINTEL_EEPROM=1' endif if config_nicintel_spi - srcs += 'nicintel_spi.c' + srcs += files('nicintel_spi.c') cargs += '-DCONFIG_NICINTEL_SPI=1' endif if config_nicnatsemi - srcs += 'nicnatsemi.c' + srcs += files('nicnatsemi.c') cargs += '-DCONFIG_NICNATSEMI=1' endif if config_nicrealtek - srcs += 'nicrealtek.c' + srcs += files('nicrealtek.c') cargs += '-DCONFIG_NICREALTEK=1' endif if config_ogp_spi - srcs += 'ogp_spi.c' + srcs += files('ogp_spi.c') cargs += '-DCONFIG_OGP_SPI=1' endif if config_pickit2_spi - srcs += 'pickit2_spi.c' + srcs += files('pickit2_spi.c') cargs += '-DCONFIG_PICKIT2_SPI=1' endif if config_pony_spi - srcs += 'pony_spi.c' + srcs += files('pony_spi.c') cargs += '-DCONFIG_PONY_SPI=1' endif if config_rayer_spi - srcs += 'rayer_spi.c' + srcs += files('rayer_spi.c') cargs += '-DCONFIG_RAYER_SPI=1' endif if config_satamv - srcs += 'satamv.c' + srcs += files('satamv.c') cargs += '-DCONFIG_SATAMV=1' endif if config_satasii - srcs += 'satasii.c' + srcs += files('satasii.c') cargs += '-DCONFIG_SATASII=1' endif if config_serprog - srcs += 'serprog.c' + srcs += files('serprog.c') cargs += '-DCONFIG_SERPROG=1' endif if config_usbblaster_spi - srcs += 'usbblaster_spi.c' + srcs += files('usbblaster_spi.c') cargs += '-DCONFIG_USBBLASTER_SPI=1' endif if config_stlinkv3_spi - srcs += 'stlinkv3_spi.c' + srcs += files('stlinkv3_spi.c') cargs += '-DCONFIG_STLINKV3_SPI=1' endif if config_lspcon_i2c_spi - srcs += 'lspcon_i2c_spi.c' + srcs += files('lspcon_i2c_spi.c') cargs += '-DCONFIG_LSPCON_I2C_SPI=1' endif if config_mediatek_i2c_spi - srcs += 'mediatek_i2c_spi.c' + srcs += files('mediatek_i2c_spi.c') cargs += '-DCONFIG_MEDIATEK_I2C_SPI=1' endif if config_realtek_mst_i2c_spi - srcs += 'realtek_mst_i2c_spi.c' + srcs += files('realtek_mst_i2c_spi.c') cargs += '-DCONFIG_REALTEK_MST_I2C_SPI=1' endif # bitbanging SPI infrastructure if need_bitbang_spi - srcs += 'bitbang_spi.c' + srcs += files('bitbang_spi.c') cargs += '-DCONFIG_BITBANG_SPI=1' endif if host_machine.system() == 'linux' - srcs += 'i2c_helper_linux.c' + srcs += files('i2c_helper_linux.c') endif if need_raw_mem_access - srcs += 'hwaccess_physmap.c' + srcs += files('hwaccess_physmap.c') endif if need_x86_port_io - srcs += 'hwaccess_x86_io.c' + srcs += files('hwaccess_x86_io.c') cargs += '-D__FLASHROM_HAVE_OUTB__=1' endif if need_x86_msr - srcs += 'hwaccess_x86_msr.c' + srcs += files('hwaccess_x86_msr.c') endif # raw serial IO if need_serial - srcs += 'serial.c' + srcs += files('serial.c') if host_machine.system() == 'linux' - srcs += 'custom_baud_linux.c' + srcs += files('custom_baud_linux.c') else - srcs += 'custom_baud.c' + srcs += files('custom_baud.c') endif endif if config_print_wiki - srcs += 'print_wiki.c' + srcs += files('print_wiki.c') cargs += '-DCONFIG_PRINT_WIKI=1' endif 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/flashrom/+/64384 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I346b5468b4203f1521ec73a90f93ff3b13ebf43c Gerrit-Change-Number: 64384 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: test_build.sh: Allow WARNERROR to be overridden
by Felix Singer (Code Review) 31 May '22

31 May '22

Attention is currently required from: Nico Huber, Martin L Roth, Edward O'Callaghan, Anastasia Klimchuk. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62745 ) Change subject: test_build.sh: Allow WARNERROR to be overridden ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Oh! So you mean the value of WARNERROR will propagate inside make even without explicitly adding […] Correct, because the make tool is aware of the environment variables. I think that's what Nico meant with "repeating". -- To view, visit https://review.coreboot.org/c/flashrom/+/62745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iea931e57f2a6992762566dc3dbaae8bb8df5b226 Gerrit-Change-Number: 62745 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 31 May 2022 05:48:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Martin L Roth <gaumless(a)tutanota.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: test_build.sh: Allow WARNERROR to be overridden
by Anastasia Klimchuk (Code Review) 31 May '22

31 May '22

Attention is currently required from: Felix Singer, Nico Huber, Martin L Roth, Edward O'Callaghan. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62745 ) Change subject: test_build.sh: Allow WARNERROR to be overridden ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I think what Nico is trying to say is that the Makefile already enables WARNERROR by default and so […] Oh! So you mean the value of WARNERROR will propagate inside make even without explicitly adding WARNERROR="${WARNERROR:-yes}" ? -- To view, visit https://review.coreboot.org/c/flashrom/+/62745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iea931e57f2a6992762566dc3dbaae8bb8df5b226 Gerrit-Change-Number: 62745 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Tue, 31 May 2022 05:35:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Martin L Roth <gaumless(a)tutanota.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: test_build.sh: Allow WARNERROR to be overridden
by Felix Singer (Code Review) 31 May '22

31 May '22

Attention is currently required from: Nico Huber, Martin L Roth, Edward O'Callaghan, Anastasia Klimchuk. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62745 ) Change subject: test_build.sh: Allow WARNERROR to be overridden ...................................................................... Patch Set 2: -Code-Review (1 comment) Patchset: PS2: > Yes this is also my understanding (as Martin explained): this patch gives a way to override "warning […] I think what Nico is trying to say is that the Makefile already enables WARNERROR by default and so this is redundant to it. We can just remove it from the shell script. So we can change the line to this: make CONFIG_EVERYTHING=yes And we can still configure WARNERROR: WARNERROR=no ./test_build.sh Tested on my system and it works. WARNERROR is set to "no" then. -- To view, visit https://review.coreboot.org/c/flashrom/+/62745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iea931e57f2a6992762566dc3dbaae8bb8df5b226 Gerrit-Change-Number: 62745 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 31 May 2022 03:55:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Martin L Roth <gaumless(a)tutanota.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: dummyflasher: Add emulation for S25FL128L
by Anastasia Klimchuk (Code Review) 31 May '22

31 May '22

Attention is currently required from: Nico Huber, Thomas Heijligen, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64748 ) Change subject: dummyflasher: Add emulation for S25FL128L ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/64748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic3cbea87218c973331b9b83e809e7d438407bc13 Gerrit-Change-Number: 64748 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 31 May 2022 01:40:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: test_build.sh: Allow WARNERROR to be overridden
by Anastasia Klimchuk (Code Review) 30 May '22

30 May '22

Attention is currently required from: Nico Huber, Martin L Roth, Edward O'Callaghan. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62745 ) Change subject: test_build.sh: Allow WARNERROR to be overridden ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: > I'm not sure I understand your question. […] Yes this is also my understanding (as Martin explained): this patch gives a way to override "warnings as errors" option. Not repeating Makefile, but rather using Makefile's feature? Makefile has a feature to allow "warnings as errors" to be overridden, and the script is using this feature. -- To view, visit https://review.coreboot.org/c/flashrom/+/62745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iea931e57f2a6992762566dc3dbaae8bb8df5b226 Gerrit-Change-Number: 62745 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)tutanota.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Mon, 30 May 2022 21:44:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Martin L Roth <gaumless(a)tutanota.com> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2022