May 2022 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: meson: use objects form libflashrom
by Anastasia Klimchuk (Code Review) 22 May '22

22 May '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64031 ) Change subject: meson: use objects form libflashrom ...................................................................... Patch Set 6: (1 comment) File meson.build: https://review.coreboot.org/c/flashrom/+/64031/comment/36ff1f01_21b57d20 PS6, Line 512: compile_args : [ : '-includestdlib.h', : '-includeunittest_env.h', : '-includehwaccess_x86_io_unittest.h' : ], Where these will live? I see they are removed from here... and not added anywhere? -- To view, visit https://review.coreboot.org/c/flashrom/+/64031 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If10ed70e3bf629a6eb7e2c5bef3318d1e259dadd Gerrit-Change-Number: 64031 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Sun, 22 May 2022 22:50:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: add "stdlib.h" to the default includes
by Anastasia Klimchuk (Code Review) 22 May '22

22 May '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64385 ) Change subject: tests: add "stdlib.h" to the default includes ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Just checking: why adding this header? Where it is used? In general, it makes sense to me to add this header as a "default include" if it is used.. is it? do you plan something for future? -- To view, visit https://review.coreboot.org/c/flashrom/+/64385 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I43fb02b2cff29d964e92556ad656cdda74a45ef2 Gerrit-Change-Number: 64385 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Sun, 22 May 2022 22:32:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: use files() for srcs list
by Anastasia Klimchuk (Code Review) 22 May '22

22 May '22

Attention is currently required from: Thomas Heijligen. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64384 ) Change subject: meson: use files() for srcs list ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/64384 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I346b5468b4203f1521ec73a90f93ff3b13ebf43c Gerrit-Change-Number: 64384 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sun, 22 May 2022 22:26:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: hwaccess: use __asm__ as it is done elsewhere
by Felix Singer (Code Review) 22 May '22

22 May '22

Attention is currently required from: Thomas Heijligen. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63487 ) Change subject: hwaccess: use __asm__ as it is done elsewhere ...................................................................... Patch Set 6: (1 comment) Patchset: PS4: > Maybe glibc uses some redefines. They use both, __asm__ and asm symbols internally. […] Hm, though a little bit unclear to me. However, I changed the commit message. I hope this is better. -- To view, visit https://review.coreboot.org/c/flashrom/+/63487 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I834fa6e171d2b20e1a5faa5a2e8f54caf107171a Gerrit-Change-Number: 63487 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sun, 22 May 2022 02:48:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: hwaccess: use __asm__ as it is done elsewhere
by Felix Singer (Code Review) 22 May '22

22 May '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Nico Huber, Thomas Heijligen, Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/63487 to look at the new patch set (#6). Change subject: hwaccess: use __asm__ as it is done elsewhere ...................................................................... hwaccess: use __asm__ as it is done elsewhere `asm()` doesn't work with musl libc. Thus, use `__asm__` as it is done elsewhere and fix compilation under non glibc. Change-Id: I834fa6e171d2b20e1a5faa5a2e8f54caf107171a Signed-off-by: Rosen Penev <rosenp(a)gmail.com> Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M hwaccess_physmap.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/87/63487/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/63487 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I834fa6e171d2b20e1a5faa5a2e8f54caf107171a Gerrit-Change-Number: 63487 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: cli_classic.c: Make -r/-w/-v argument optional
by Daniel Campello (Code Review) 20 May '22

20 May '22

Attention is currently required from: Nico Huber, David Hendricks, Daniel Campello, Angel Pons, Anastasia Klimchuk. Hello build bot (Jenkins), Nico Huber, David Hendricks, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/52362 to look at the new patch set (#23). Change subject: cli_classic.c: Make -r/-w/-v argument optional ...................................................................... cli_classic.c: Make -r/-w/-v argument optional Makes filename optional from -r/-w/-v since the -i parameter allows building the image to be written from multiple files, and regions to be read from flash and written to separate image files, Signed-off-by: Daniel Campello <campello(a)chromium.org> Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> Change-Id: I15384b92cb987a6ea1bb4369ef415488b9cf7f41 --- M cli_classic.c M flashrom.8.tmpl M include/layout.h M layout.c 4 files changed, 108 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/62/52362/23 -- To view, visit https://review.coreboot.org/c/flashrom/+/52362 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I15384b92cb987a6ea1bb4369ef415488b9cf7f41 Gerrit-Change-Number: 52362 Gerrit-PatchSet: 23 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: [RFC] dummyflasher: Wire variable size feature via opaque infra
by Nico Huber (Code Review) 20 May '22

20 May '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev, Peter Marheine. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64488 ) Change subject: [RFC] dummyflasher: Wire variable size feature via opaque infra ...................................................................... Patch Set 2: (1 comment) File dummyflasher.c: https://review.coreboot.org/c/flashrom/+/64488/comment/8cb5d49d_3c29eb50 PS1, Line 1269: rmst.spi = *s_mst; : rmst.opaque = *o_mst; > So... do you think it's too bad? :) I don't have another ideas at the moment :\ With the flashrom design in mind it's kind of undefined behavior. CB:50246 is not supposed to change behavior and I assume your current version wouldn't work without that patch. Building hacks on hacks is exactly why we need a bug tracker now. Maybe worth to share: When Edward started to push chromium code, I said sometimes it can save a lot of time to ignore the existing implementation, find the requirements and implement it from scratch instead. I made exactly that experience before when I tried to port things from chromium myself. I think it's the same with code on our master branch today. If I wanted to implement this, I'd probably checkout v1.2, implement what is needed and then port it forward. The master branch was in a better state to add new things back then. Anyway, you already made much progress, so I think such a stunt is not necessary. The only obstacle I see left is the usage of the spi read/ write/erase functions. So how about you try one version without them, i.e. memcpy()/memset() instead. Hmmm, looking at emulate_spi_chip_ response(), also setting `emu_modified` in case but that seems to be all to do. And then let the customer team test that? If it works, there is no need to discuss hacks. -- To view, visit https://review.coreboot.org/c/flashrom/+/64488 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I76402bfdf8b1a75489e4509fec92c9a777d0cf58 Gerrit-Change-Number: 64488 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Namyoon Woo <namyoon(a)google.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Fri, 20 May 2022 15:24:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ichspi.c: Implement read_write_status for wp
by Subrata Banik (Code Review) 20 May '22

20 May '22

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev, Sergii Dmytruk. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64540 ) Change subject: ichspi.c: Implement read_write_status for wp ...................................................................... Patch Set 2: (1 comment) File ichspi.c: https://review.coreboot.org/c/flashrom/+/64540/comment/e7f81b2d_550acf74 PS1, Line 122: FIXME(quasisec): Port to new macros? - Control bits > @Subrata, what did you suggest downstream to clean this up here? I don't think you need any of these new macro here. line #138 onwards should care of of everything. You just need two new macro as in below: #define HSFC_CYCLE_WR_STATUS HSFC_FCYCLE(7) #define HSFC_CYCLE_RD_STATUS HSFC_FCYCLE(8) and update the read/write status as https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/… -- To view, visit https://review.coreboot.org/c/flashrom/+/64540 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7ecbe8491ecea3697922c91af26ca62276e86317 Gerrit-Change-Number: 64540 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Fri, 20 May 2022 13:39:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [RFC] dummyflasher: Wire variable size feature via opaque infra
by Angel Pons (Code Review) 20 May '22

20 May '22

Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk, Nikolai Artemiev, Peter Marheine. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64488 ) Change subject: [RFC] dummyflasher: Wire variable size feature via opaque infra ...................................................................... Patch Set 2: (1 comment) File dummyflasher.c: https://review.coreboot.org/c/flashrom/+/64488/comment/7e756c7d_8b7f8197 PS1, Line 1269: rmst.spi = *s_mst; : rmst.opaque = *o_mst; > > It's not supposed to work like this. […] I'd suggest looking at ichspi.c function `init_ich_default()`, near the end it registers either a SPI master or an opaque master depending on the chosen mode (hardware/software sequencing). -- To view, visit https://review.coreboot.org/c/flashrom/+/64488 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I76402bfdf8b1a75489e4509fec92c9a777d0cf58 Gerrit-Change-Number: 64488 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Namyoon Woo <namyoon(a)google.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Fri, 20 May 2022 09:23:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [RFC] dummyflasher: Wire variable size feature via opaque infra
by Anastasia Klimchuk (Code Review) 20 May '22

20 May '22

Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan, Nikolai Artemiev, Peter Marheine. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64488 ) Change subject: [RFC] dummyflasher: Wire variable size feature via opaque infra ...................................................................... Patch Set 2: (6 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/64488/comment/6195146d_bdb43c4b PS2, Line 20: TEST A comment for myself: check with the users of "variable size" feature to make sure their stuff does not break (that's another team). File dummyflasher.c: https://review.coreboot.org/c/flashrom/+/64488/comment/a800a727_cdc59637 PS1, Line 129: return 0; > Seems unnecessary. […] I removed. Although I understand this is relevant to the conversation about spi vs opaque master, so may gets changed depending on what we decide. I will return back if needed. https://review.coreboot.org/c/flashrom/+/64488/comment/82ead7e9_82140c88 PS1, Line 133: * Once that happens, we need to have special hacks in functions: > For opaque masters this should never happen (they all have to fill the […] Oh yes I removed the comment. I should have done from the very beginning... I discovered that for spi infra flashctx is const and the only way the feature works is because `probe_variable_size` is linked at the very high level, directly into the chip. I did few attempts to wire the feature via spi infra, but I couldn't because spi assumes flashctx is const. https://review.coreboot.org/c/flashrom/+/64488/comment/8f591e84_129c56d5 PS1, Line 153: for (i = 0; i < NUM_ERASEFUNCTIONS; i++) { > There is only one by definition (opaque entry in flashchips.c). Thanks, I removed the loop, so now it updates that one block eraser. https://review.coreboot.org/c/flashrom/+/64488/comment/47d853ff_55432b2d PS1, Line 865: .read = default_spi_read, : .write = dummy_spi_write_256, : .erase = spi_block_erase_c7, > It might make reasoning about the code much simpler to not re-use […] I added dummy_opaque_read(), dummy_opaque_write(), dummy_opaque_erase() into the struct. However they call the same functions: default_spi_read, dummy_spi_write_256, spi_block_erase_c7. The reason is that I wanted to keep the behaviour. But this also depends on spi vs opaque conversation. https://review.coreboot.org/c/flashrom/+/64488/comment/8a642a7e_23b28025 PS1, Line 1269: rmst.spi = *s_mst; : rmst.opaque = *o_mst; > It's not supposed to work like this. Yes I admit this is a hack! :) I thought this is an improvement from current situation because it fixes the build with CONFIG_DUMMY=no, and also now hack is contained in dummy and not splashed around the code. I continue thinking if there is better solution, but I decided to send this patch so that we can discuss. I also wanted to explain why this double master is needed. First my attempt was to wire the feature as a spi master, but I couldn't make it compile: because spi infra expects flashctx to be const. Then I started trying to wire as opaque master, as only opaque (not double). Probing was working nicely, but read/write did not work. The problem was that functions in spi.c and spi25.c they all expect `flash->mst->spi` to be present. And I wanted to call all the same functions for read / write (the same as now). I mean right now read/write will go to dummy_spi_send_command, and I didn't want to re-write it. This is how I got to double master. It is really an opaque master, but also it has `flash->mst->spi` available. And as the end result, dummy is using opaque chip and spi send commands. So... do you think it's too bad? :) I don't have another ideas at the moment :\ I can see this needs to be wired as opaque master, that's for sure. But also I don't want to re-write existing dummy_spi_send_command... -- To view, visit https://review.coreboot.org/c/flashrom/+/64488 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I76402bfdf8b1a75489e4509fec92c9a777d0cf58 Gerrit-Change-Number: 64488 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Namyoon Woo <namyoon(a)google.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Fri, 20 May 2022 06:40:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2022