October 2022 - flashrom-gerrit

[M] Change in flashrom[master]: rayer_spi.c: Roll up programmer type search logic into func
by Angel Pons (Code Review) 09 Oct '22

09 Oct '22

Attention is currently required from: Felix Singer, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68238 ) Change subject: rayer_spi.c: Roll up programmer type search logic into func ...................................................................... Patch Set 4: Code-Review+2 (1 comment) File rayer_spi.c: https://review.coreboot.org/c/flashrom/+/68238/comment/0cfb3616_16350007 PS2, Line 264: *prog_type = strdup(arg); > CB:68239 does it Ack -- To view, visit https://review.coreboot.org/c/flashrom/+/68238 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id226ea61132ecc30fd8696e1d8ea50373e752cac Gerrit-Change-Number: 68238 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Sun, 09 Oct 2022 11:23:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: rayer_spi.c: Drop lpt_outbyte intermediate var
by Angel Pons (Code Review) 09 Oct '22

09 Oct '22

Attention is currently required from: Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68232 ) Change subject: rayer_spi.c: Drop lpt_outbyte intermediate var ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/68232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idedabb7b1c401d666b3b7e621e75704c7e765fd1 Gerrit-Change-Number: 68232 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Sun, 09 Oct 2022 11:22:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: rayer_spi.c: Move rget_io_perms() check to pre-amble
by Angel Pons (Code Review) 09 Oct '22

09 Oct '22

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68231 ) Change subject: rayer_spi.c: Move rget_io_perms() check to pre-amble ...................................................................... Patch Set 1: (1 comment) File rayer_spi.c: https://review.coreboot.org/c/flashrom/+/68231/comment/67611526_22ee2e7c PS1, Line 292: if (get_params(cfg, &lpt_iobase, &prog_type) < 0) > You are correct, great insight Angel. […] Thank you, issue created somewhere: https://ticket.coreboot.org/issues/418 -- To view, visit https://review.coreboot.org/c/flashrom/+/68231 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ieb0a494bd49f6986e9ac230b7b123329493a82bc Gerrit-Change-Number: 68231 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 09 Oct 2022 11:22:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: ichspi: Add Intel Idaville HCC support
by Felix Singer (Code Review) 09 Oct '22

09 Oct '22

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Kevin Yu. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67438 ) Change subject: ichspi: Add Intel Idaville HCC support ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/67438/comment/4427f378_6151976b PS4, Line 9: Add Cedar Fork PCH device IDs to enable flashrom on Idaville HCC platforms. Also, wrap at 72 chars at each line. -- To view, visit https://review.coreboot.org/c/flashrom/+/67438 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3d73b4796f610953d38506794eb20791871ec31f Gerrit-Change-Number: 67438 Gerrit-PatchSet: 4 Gerrit-Owner: Kevin Yu <ykevin(a)celestica.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Kevin Yu <ykevin(a)celestica.com> Gerrit-Comment-Date: Sun, 09 Oct 2022 09:18:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: ichspi: Add Intel Idaville HCC support
by Felix Singer (Code Review) 09 Oct '22

09 Oct '22

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Kevin Yu. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67438 ) Change subject: ichspi: Add Intel Idaville HCC support ...................................................................... Patch Set 4: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/67438/comment/6c3a6d62_37b96c47 PS3, Line 9: CDF PCH > What is CDF? Please write it out. Done Commit Message: https://review.coreboot.org/c/flashrom/+/67438/comment/f09de609_21bfe5db PS4, Line 9: IDs It's only one ID you are adding -- To view, visit https://review.coreboot.org/c/flashrom/+/67438 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3d73b4796f610953d38506794eb20791871ec31f Gerrit-Change-Number: 67438 Gerrit-PatchSet: 4 Gerrit-Owner: Kevin Yu <ykevin(a)celestica.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Kevin Yu <ykevin(a)celestica.com> Gerrit-Comment-Date: Sun, 09 Oct 2022 09:16:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: tree: provide flashrom context into programmer_delay()
by Alexander Goncharov (Code Review) 09 Oct '22

09 Oct '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66373 ) Change subject: tree: provide flashrom context into programmer_delay() ...................................................................... Patch Set 9: (2 comments) Patchset: PS8: > Please kindly rebase on HEAD. Done File pony_spi.c: https://review.coreboot.org/c/flashrom/+/66373/comment/5830f623_37515958 PS7, Line 247: flashctx not needed (NULL) because pony_spi does not : * use it in its delay function. > The parameter should be documented at the function declaration, not in the programmers code. It might be done in CB:67393 because that patch determines how the parameter will be used. -- To view, visit https://review.coreboot.org/c/flashrom/+/66373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibb0bce26ce2052853ee52158d7ba742967a9e229 Gerrit-Change-Number: 66373 Gerrit-PatchSet: 9 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 09 Oct 2022 08:48:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: tree: provide flashrom context into programmer_delay()
by Alexander Goncharov (Code Review) 09 Oct '22

09 Oct '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk, Alexander Goncharov. Hello Felix Singer, build bot (Jenkins), Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66373 to look at the new patch set (#9). Change subject: tree: provide flashrom context into programmer_delay() ...................................................................... tree: provide flashrom context into programmer_delay() Modify the `programmer_delay` function signature to allow passing the flashrom context. This is an important step to remove the global state. Programmers uses internal delay can provide NULL as a context. TOPIC=programmer_handle_global TEST=builds Change-Id: Ibb0bce26ce2052853ee52158d7ba742967a9e229 Signed-off-by: Alexander Goncharov <chat(a)joursoir.net> --- M 82802ab.c M amd_imc.c M at45db.c M atavia.c M bitbang_spi.c M cli_classic.c M dediprog.c M dummyflasher.c M edi.c M en29lv640b.c M flashrom.c M ichspi.c M include/flash.h M it87spi.c M jedec.c M nicintel_eeprom.c M pony_spi.c M raiden_debug_spi.c M s25f.c M spi25.c M spi25_statusreg.c M sst28sf040.c M stm50.c M w29ee011.c M w39.c M wbsio_spi.c 26 files changed, 126 insertions(+), 106 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/73/66373/9 -- To view, visit https://review.coreboot.org/c/flashrom/+/66373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibb0bce26ce2052853ee52158d7ba742967a9e229 Gerrit-Change-Number: 66373 Gerrit-PatchSet: 9 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: ichspi: Add Intel Idaville HCC support
by Kevin Yu (Code Review) 09 Oct '22

09 Oct '22

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk. Kevin Yu has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67438 ) Change subject: ichspi: Add Intel Idaville HCC support ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Hi Any other suggestions? Is it possible to merge operation? -- To view, visit https://review.coreboot.org/c/flashrom/+/67438 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3d73b4796f610953d38506794eb20791871ec31f Gerrit-Change-Number: 67438 Gerrit-PatchSet: 4 Gerrit-Owner: Kevin Yu <ykevin(a)celestica.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 09 Oct 2022 06:41:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: tree: provide flashrom context into programmer_delay()
by Edward O'Callaghan (Code Review) 09 Oct '22

09 Oct '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk, Alexander Goncharov. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66373 ) Change subject: tree: provide flashrom context into programmer_delay() ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: Please kindly rebase on HEAD. -- To view, visit https://review.coreboot.org/c/flashrom/+/66373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibb0bce26ce2052853ee52158d7ba742967a9e229 Gerrit-Change-Number: 66373 Gerrit-PatchSet: 8 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Sun, 09 Oct 2022 02:14:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: rayer_spi.c: Get rid of temporary `prog_type` string
by Edward O'Callaghan (Code Review) 09 Oct '22

09 Oct '22

Attention is currently required from: Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68239 ) Change subject: rayer_spi.c: Get rid of temporary `prog_type` string ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/68239 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I83e34382ee9814f224025e21e5099fdab73cee8c Gerrit-Change-Number: 68239 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 09 Oct 2022 02:11:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2022