October 2022 - flashrom-gerrit

[S] Change in flashrom[master]: layout.c: Use calloc() to ensure a zeroed layout
by Angel Pons (Code Review) 11 Oct '22

11 Oct '22

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68279 ) Change subject: layout.c: Use calloc() to ensure a zeroed layout ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/68279/comment/8fbd9295_1c8470d6 PS1, Line 9: DIY memset > Yea I saw that however looks like 'code for the future' so right now it is better to not have such c […] All good! Just wanted to point out the reasons why the code could have been written like that. -- To view, visit https://review.coreboot.org/c/flashrom/+/68279 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id6cf2c4591aec0620f15d8a39495d2bff6597f96 Gerrit-Change-Number: 68279 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 11 Oct 2022 09:47:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: flashchips.c: Add write protect support for W25Q16.V
by Edward O'Callaghan (Code Review) 11 Oct '22

11 Oct '22

Attention is currently required from: Khoa Hoang. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67713 ) Change subject: flashchips.c: Add write protect support for W25Q16.V ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67713 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6c0b35f82b47a1169bccfd08222e9e3b3be30d75 Gerrit-Change-Number: 67713 Gerrit-PatchSet: 4 Gerrit-Owner: Khoa Hoang <admin(a)khoahoang.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Khoa Hoang <admin(a)khoahoang.com> Gerrit-Comment-Date: Tue, 11 Oct 2022 09:44:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: layout.c: Use calloc() to ensure a zeroed layout
by Edward O'Callaghan (Code Review) 11 Oct '22

11 Oct '22

Attention is currently required from: Nikolai Artemiev. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68279 ) Change subject: layout.c: Use calloc() to ensure a zeroed layout ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/68279/comment/f2b2dac2_65866bda PS1, Line 9: DIY memset > This would be useful in case any layout fields have to be initialized to a non-zero value on an empt […] Yea I saw that however looks like 'code for the future' so right now it is better to not have such clever tricks. I agree also with the latter point you made too. -- To view, visit https://review.coreboot.org/c/flashrom/+/68279 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id6cf2c4591aec0620f15d8a39495d2bff6597f96 Gerrit-Change-Number: 68279 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 11 Oct 2022 09:41:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: flashrom.c: Add wrapper function to use the erase algorithm
by Aarya (Code Review) 11 Oct '22

11 Oct '22

Attention is currently required from: Simon Buhrow, Nico Huber, Thomas Heijligen. Aarya has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66104 ) Change subject: flashrom.c: Add wrapper function to use the erase algorithm ...................................................................... Patch Set 64: (1 comment) File flashrom.c: https://review.coreboot.org/c/flashrom/+/66104/comment/a7c5f886_7b4b8378 PS62, Line 1167: msg_cdbg("W(%x:%x)", start_here, start_here + len_here); > nits: As for the "E(... […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/66104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8 Gerrit-Change-Number: 66104 Gerrit-PatchSet: 64 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Tue, 11 Oct 2022 08:30:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Simon Buhrow Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: flashrom.c: Add wrapper function to use the erase algorithm
by Aarya (Code Review) 11 Oct '22

11 Oct '22

Attention is currently required from: Nico Huber, Thomas Heijligen, Aarya. Hello build bot (Jenkins), Simon Buhrow, Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66104 to look at the new patch set (#64). Change subject: flashrom.c: Add wrapper function to use the erase algorithm ...................................................................... flashrom.c: Add wrapper function to use the erase algorithm Add a function to call the erase algorithm. Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8 Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> --- M flashrom.c M tests/chip_wp.c 2 files changed, 144 insertions(+), 289 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/04/66104/64 -- To view, visit https://review.coreboot.org/c/flashrom/+/66104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8 Gerrit-Change-Number: 66104 Gerrit-PatchSet: 64 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: layout.c: Use calloc() to ensure a zeroed layout
by Angel Pons (Code Review) 11 Oct '22

11 Oct '22

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68279 ) Change subject: layout.c: Use calloc() to ensure a zeroed layout ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/68279/comment/39c5499c_e1b77ca7 PS1, Line 9: DIY memset This would be useful in case any layout fields have to be initialized to a non-zero value on an empty layout. However, it should be possible to design things in a way so that non-zero initial values aren't needed. -- To view, visit https://review.coreboot.org/c/flashrom/+/68279 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id6cf2c4591aec0620f15d8a39495d2bff6597f96 Gerrit-Change-Number: 68279 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Tue, 11 Oct 2022 08:26:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: flashrom.c: Add wrapper function to use the erase algorithm
by Aarya (Code Review) 11 Oct '22

11 Oct '22

Attention is currently required from: Nico Huber, Thomas Heijligen, Aarya. Hello build bot (Jenkins), Simon Buhrow, Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66104 to look at the new patch set (#63). Change subject: flashrom.c: Add wrapper function to use the erase algorithm ...................................................................... flashrom.c: Add wrapper function to use the erase algorithm Add a function to call the erase algorithm. Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8 Signed-off-by: Aarya Chaumal <aarya.chaumal(a)gmail.com> --- M flashrom.c M tests/chip_wp.c 2 files changed, 144 insertions(+), 289 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/04/66104/63 -- To view, visit https://review.coreboot.org/c/flashrom/+/66104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8 Gerrit-Change-Number: 66104 Gerrit-PatchSet: 63 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: flashrom.c: Use get_default_layout() consistently
by Edward O'Callaghan (Code Review) 11 Oct '22

11 Oct '22

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/68284 ) Change subject: flashrom.c: Use get_default_layout() consistently ...................................................................... flashrom.c: Use get_default_layout() consistently Change-Id: Ia1aa38029d5db3967f2705686bb5f45ca4a9a4e4 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M flashrom.c 1 file changed, 13 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/84/68284/1 diff --git a/flashrom.c b/flashrom.c index 088d804..3106ab3 100644 --- a/flashrom.c +++ b/flashrom.c @@ -850,10 +850,10 @@ return -1; /* Fill default layout covering the whole chip. */ - if (flashrom_layout_new(&flash->default_layout) || - flashrom_layout_add_region(flash->default_layout, + if (flashrom_layout_new(&get_default_layout(flash)) || + flashrom_layout_add_region(get_default_layout(flash), 0, flash->chip->total_size * 1024 - 1, "complete flash") || - flashrom_layout_include_region(flash->default_layout, "complete flash")) + flashrom_layout_include_region(get_default_layout(flash), "complete flash")) return -1; tmp = flashbuses_to_text(flash->chip->bustype); -- To view, visit https://review.coreboot.org/c/flashrom/+/68284 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia1aa38029d5db3967f2705686bb5f45ca4a9a4e4 Gerrit-Change-Number: 68284 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: flashrom.8.tmpl: document mediatek_i2c_spi programmer
by Felix Singer (Code Review) 11 Oct '22

11 Oct '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/67825 ) Change subject: flashrom.8.tmpl: document mediatek_i2c_spi programmer ...................................................................... flashrom.8.tmpl: document mediatek_i2c_spi programmer This adds a manpage section describing the mediatek_i2c_spi programmer, including some discussion of devices that are supported as well as which systems use them. Signed-off-by: Peter Marheine <pmarheine(a)chromium.org> Change-Id: Ia63df470170fbadcabadcdad8e5acc0cde3a274b Reviewed-on: https://review.coreboot.org/c/flashrom/+/67825 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M flashrom.8.tmpl 1 file changed, 42 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved diff --git a/flashrom.8.tmpl b/flashrom.8.tmpl index 2cf3a38..5579011 100644 --- a/flashrom.8.tmpl +++ b/flashrom.8.tmpl @@ -429,6 +429,8 @@ .sp .BR "* parade_lspcon" " (for SPI flash ROMs attached to Parade Technologies LSPCONs (PS175))" .sp +.BR "* mediatek_i2c_spi" " (for SPI flash ROMs attached to some Mediatek display devices accessible over I2C)" +.sp Some programmers have optional or mandatory parameters which are described in detail in the .B PROGRAMMER-SPECIFIC INFORMATION @@ -1521,7 +1523,7 @@ If the passed frequency is not supported by the adapter the nearest lower supported frequency will be used. .SS -.BR "realtek_mst_i2c_spi " and " parade_lspcon " programmers +.BR "realtek_mst_i2c_spi ", " parade_lspcon ", and " mediatek_i2c_spi " programmers .IP These programmers tunnel SPI commands through I2C-connected devices. The I2C bus over which communication occurs must be specified either by device path @@ -1575,6 +1577,27 @@ e.g. the PS175. Communication to the SPI flash is tunneled through the LSPCON over I2C. +.SS +.BR "mediatek_i2c_spi " programmer +.IP +This programmer supports SPI flash programming for chips attached to some +Mediatek display controllers, themselves accessed through I2C (tunneling +SPI flash commands through an I2C connection with the host). +.sp +The programmer is designed to support the TSUMOP82JUQ integrated display driver +and scaler as used in the Google Meet Series One Desk 27 (which runs a version +of ChromeOS and uses flashrom in its \fBtsum-scaler-updater\fP scripts that +ship with the OS). Other chips may use compatible protocols but have not been +tested with this programmer, and external chip IOs may need to be controlled +through other non-flashrom means to configure the chip in order for it to +operate as expected. +.sp +\fBdevpath\fP and \fBbus\fP options select the I2C bus to use, as described +previously. \fBallow_brick\fP defaults to no, and must explicitly be set to +"yes" in order for the programmer to operate. This is required because there is +no mechanism in the driver to positively identify that a given I2C bus is +actually connected to a supported device. + .SH EXAMPLES To back up and update your BIOS, run .sp -- To view, visit https://review.coreboot.org/c/flashrom/+/67825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia63df470170fbadcabadcdad8e5acc0cde3a274b Gerrit-Change-Number: 67825 Gerrit-PatchSet: 5 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: meson.build: Fix indentation of mstarddc_spi definition
by Felix Singer (Code Review) 11 Oct '22

11 Oct '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/68163 ) Change subject: meson.build: Fix indentation of mstarddc_spi definition ...................................................................... meson.build: Fix indentation of mstarddc_spi definition Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I064b50f87760fd7ad40b3629b3fa68552c8ddb46 Reviewed-on: https://review.coreboot.org/c/flashrom/+/68163 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Thomas Heijligen <src(a)posteo.de> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M meson.build 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Thomas Heijligen: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/meson.build b/meson.build index 56ab55c..050631d 100644 --- a/meson.build +++ b/meson.build @@ -304,7 +304,7 @@ 'flags' : [ '-DCONFIG_MEDIATEK_I2C_SPI=1' ], 'default' : false, }, - 'mstarddc_spi' : { + 'mstarddc_spi' : { 'systems' : [ 'linux' ], 'deps' : [ linux_headers ], 'groups' : [ group_i2c ], -- To view, visit https://review.coreboot.org/c/flashrom/+/68163 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I064b50f87760fd7ad40b3629b3fa68552c8ddb46 Gerrit-Change-Number: 68163 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2022