October 2022 - flashrom-gerrit

[M] Change in flashrom[master]: writeprotect.c: differentiate lack of WP from lack of implementation
by Sergii Dmytruk (Code Review) 14 Oct '22

14 Oct '22

Attention is currently required from: Nico Huber, Nikolai Artemiev, Sergii Dmytruk. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/68221 to look at the new patch set (#6). Change subject: writeprotect.c: differentiate lack of WP from lack of implementation ...................................................................... writeprotect.c: differentiate lack of WP from lack of implementation .tested.wp field allows telling these two cases apart, potentially preventing confusion on seeing the error. Change-Id: I6e75b124c21ccab51a9b5e1cd344b5310d384187 Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- M cli_classic.c M include/libflashrom.h M tests/chip_wp.c M tests/tests.c M tests/tests.h M writeprotect.c 6 files changed, 90 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/68221/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/68221 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6e75b124c21ccab51a9b5e1cd344b5310d384187 Gerrit-Change-Number: 68221 Gerrit-PatchSet: 6 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: flashchips.c: mark WP of 9 entries as tested
by Sergii Dmytruk (Code Review) 14 Oct '22

14 Oct '22

Attention is currently required from: Nico Huber, Kamil Pokornicki, Sergii Dmytruk. Hello build bot (Jenkins), Nico Huber, Maciej Pijanowski, Kamil Pokornicki, Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/68180 to look at the new patch set (#7). Change subject: flashchips.c: mark WP of 9 entries as tested ...................................................................... flashchips.c: mark WP of 9 entries as tested This is based on information from: * commit a850fd0aa8054a1125a9231fa3317428f15900f4 - GD25LQ128C/GD25LQ128D/GD25LQ128E - GD25LQ64(B) - GD25Q127C/GD25Q128C - GD25Q256D/GD25Q256E - GD25Q64(B) * commit a8204dd34d90ac9ab2783e1dd486ec781d4c0dba - GD25Q32(B) * commit 7b4c4f36113c4b7ed5c985d4cf51733639e69bf8 - W25Q64BV/W25Q64CV/W25Q64FV * https://github.com/Dasharo/dasharo-issues/issues/67 - W25Q128.V..M * https://github.com/Dasharo/flashrom/pull/8 - W25Q64.W Change-Id: I090188bad568885f78778e7fc7d8dbe20fb2445f Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Tested-by: Nikolai Artemiev <nartemiev(a)google.com> Tested-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Tested-by: Kamil Pokornicki <kamil.pokornicki(a)3mdeb.com> Tested-by: Przemyslaw Banasiak <przemyslaw.banasiak(a)3mdeb.com> Tested-by: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- M flashchips.c 1 file changed, 41 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/80/68180/7 -- To view, visit https://review.coreboot.org/c/flashrom/+/68180 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I090188bad568885f78778e7fc7d8dbe20fb2445f Gerrit-Change-Number: 68180 Gerrit-PatchSet: 7 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Kamil Pokornicki <kamil.pokornicki(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Kamil Pokornicki <kamil.pokornicki(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: flash.h: extend `struct tested` with .wp field
by Sergii Dmytruk (Code Review) 14 Oct '22

14 Oct '22

Attention is currently required from: Nico Huber, Sergii Dmytruk. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/68179 to look at the new patch set (#4). Change subject: flash.h: extend `struct tested` with .wp field ...................................................................... flash.h: extend `struct tested` with .wp field Using "B" letter for "block protection" in TEST_* macros. Ticket: https://ticket.coreboot.org/issues/377 Change-Id: I791400889159bc6f305fb05f3e2dd9a90dbe18a4 Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- M cli_common.c M include/flash.h M include/libflashrom.h 3 files changed, 36 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/79/68179/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/68179 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I791400889159bc6f305fb05f3e2dd9a90dbe18a4 Gerrit-Change-Number: 68179 Gerrit-PatchSet: 4 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: stlinkv3_spi: Bug fix, Initialize uninitialized pointers
by Angel Pons (Code Review) 14 Oct '22

14 Oct '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Shreeyash , Alexander Goncharov. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66225 ) Change subject: stlinkv3_spi: Bug fix, Initialize uninitialized pointers ...................................................................... Patch Set 2: (1 comment) File stlinkv3_spi.c: https://review.coreboot.org/c/flashrom/+/66225/comment/152dcb3e_99f53c15 PS1, Line 501: stlinkv3_handle = usb_dev_get_by_vid_pid_serial(usb_ctx, Hi Shreeyash, > @Angel Pons, Since I made this commit to understand the process of submitting a patch from start to finish, I would like to update my change. What exactly is the process though? The Process (i.e. the contribution/review process) is basically an infinite loop, and its main purpose is to improve things. It's not just about improving the code, as code reviews are (or should be) learning experiences for both the authors and the reviewers. Even people who aren't actively involved in the process can learn from reading Gerrit comments. Sorry if the pseudocode below is rather confusing. This is the general flow, with variations depending on the involved people. The usual process to getting changes submitted is, roughly: ``` void contribute_a_thing(idea_t idea) { /* The `idea` is what inspires one to change something. */ commit_t commit = create_new_commit_from(idea); change_t change = create_new_change_from(commit); /* * Review process starts, and will end once the * change is either submitted or abandoned. */ while (!is_submitted(change)) { /* Do something else while waiting for reviews. */ thread_sleep(); /* Read review comments and build bot results. */ feedback_t feedback = get_new_feedback_from(change); /* * No updates? Nothing to do but wait. It might be a good * idea to ping reviewers with a comment if a significant * amount of time has passed since last update. */ if (!have_new(feedback)) continue; /* Update (local) commit with received feedback. */ commit_t new_commit = update_commit_with(commit, feedback); /* * If feedback indicates that a change is not needed, then * it should be abandoned. For example, duplicated changes * and changes that are fundamentally wrong. It is rare. */ if (is_empty(new_commit)) { abandon(change); return; } /* Update change with new commit, if it's not the same. */ if (new_commit != commit) { upload_new_patchset(change, new_commit); commit = new_commit; } /* Respond to review comments. */ reply_to_review(change, feedback); } } ``` In the case of this change, the situation is a bit messy because there's CB:67700 that does the same. But the current feedback is "do what CB:67700 does in your commit, and push it here". > This is what I have to do: > 1. fetch current master > 2. rebase my branch > 3. this would result in merge conflicts, fix them. > 4. commit with a proper commit msg that reflects that this is not a bug fix > 5. push the changes > > Correct? Yes, something like this. To update a change (i.e. upload a new patchset), you'd amend the old commit with the feedback, while preserving the `Change-Id` line in the commit message. Gerrit uses the `Change-Id` to associate commits with changes. The exact procedure depends on how you organize yourself, e.g. do you use git branches, or are your commits on top of master? In any case, note that Gerrit does not use any merge commits: instead, commits are rebased, cherry-picked and amended. Sorry for the long-winded reply, hopefully it should answer your questions. If you have more questions, please don't hesitate to ask. 😊 -- To view, visit https://review.coreboot.org/c/flashrom/+/66225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7ce156a9f7455434ea461560320c84660c93c02f Gerrit-Change-Number: 66225 Gerrit-PatchSet: 2 Gerrit-Owner: Shreeyash <shreeyash335(a)gmail.com> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Shreeyash <shreeyash335(a)gmail.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 14 Oct 2022 11:40:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Shreeyash <shreeyash335(a)gmail.com> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: stlinkv3_spi: Bug fix, Initialize uninitialized pointers
by Felix Singer (Code Review) 14 Oct '22

14 Oct '22

Attention is currently required from: Thomas Heijligen, Angel Pons, Shreeyash , Alexander Goncharov. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66225 ) Change subject: stlinkv3_spi: Bug fix, Initialize uninitialized pointers ...................................................................... Patch Set 2: (1 comment) File stlinkv3_spi.c: https://review.coreboot.org/c/flashrom/+/66225/comment/8c788762_e9bc0d56 PS1, Line 501: stlinkv3_handle = usb_dev_get_by_vid_pid_serial(usb_ctx, > @Angel Pons, Since I made this commit to understand the process of submitting a patch from start to […] Sure, please update your change. Also, let us know which questions you have or if anything is unclear :) Your to do list seems good to me. There shouldn't be much (not any?) merge conflicts. Do you have any questions regarding how to update the commit? -- To view, visit https://review.coreboot.org/c/flashrom/+/66225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7ce156a9f7455434ea461560320c84660c93c02f Gerrit-Change-Number: 66225 Gerrit-PatchSet: 2 Gerrit-Owner: Shreeyash <shreeyash335(a)gmail.com> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Shreeyash <shreeyash335(a)gmail.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 14 Oct 2022 10:45:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Shreeyash <shreeyash335(a)gmail.com> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: stlinkv3_spi: Bug fix, Initialize uninitialized pointers
by Shreeyash (Code Review) 14 Oct '22

14 Oct '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons, Alexander Goncharov. Shreeyash has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66225 ) Change subject: stlinkv3_spi: Bug fix, Initialize uninitialized pointers ...................................................................... Patch Set 2: (1 comment) File stlinkv3_spi.c: https://review.coreboot.org/c/flashrom/+/66225/comment/428e6fe3_e01de4b8 PS1, Line 501: stlinkv3_handle = usb_dev_get_by_vid_pid_serial(usb_ctx, > This is what I have to do: […] @Angel Pons, Since I made this commit to understand the process of submitting a patch from start to finish, I would like to update my change. What exactly is the process though? -- To view, visit https://review.coreboot.org/c/flashrom/+/66225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7ce156a9f7455434ea461560320c84660c93c02f Gerrit-Change-Number: 66225 Gerrit-PatchSet: 2 Gerrit-Owner: Shreeyash <shreeyash335(a)gmail.com> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 14 Oct 2022 10:17:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Shreeyash <shreeyash335(a)gmail.com> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: stlinkv3_spi: Bug fix, Initialize uninitialized pointers
by Shreeyash (Code Review) 14 Oct '22

14 Oct '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Shreeyash , Alexander Goncharov. Shreeyash has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66225 ) Change subject: stlinkv3_spi: Bug fix, Initialize uninitialized pointers ...................................................................... Patch Set 2: (1 comment) File stlinkv3_spi.c: https://review.coreboot.org/c/flashrom/+/66225/comment/55475b31_b8fc86a8 PS1, Line 501: stlinkv3_handle = usb_dev_get_by_vid_pid_serial(usb_ctx, > Just to make it clear, I have to correct the file for corrections that Thomas, Felix and others ment […] This is what I have to do: 1. fetch current master 2. rebase my branch 3. this would result in merge conflicts, fix them. 4. commit with a proper commit msg that reflects that this is not a bug fix 5. push the changes Correct? -- To view, visit https://review.coreboot.org/c/flashrom/+/66225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7ce156a9f7455434ea461560320c84660c93c02f Gerrit-Change-Number: 66225 Gerrit-PatchSet: 2 Gerrit-Owner: Shreeyash <shreeyash335(a)gmail.com> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Shreeyash <shreeyash335(a)gmail.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 14 Oct 2022 10:14:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Shreeyash <shreeyash335(a)gmail.com> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: stlinkv3_spi: Bug fix, Initialize uninitialized pointers
by Angel Pons (Code Review) 14 Oct '22

14 Oct '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Shreeyash , Alexander Goncharov. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66225 ) Change subject: stlinkv3_spi: Bug fix, Initialize uninitialized pointers ...................................................................... Patch Set 2: (1 comment) File stlinkv3_spi.c: https://review.coreboot.org/c/flashrom/+/66225/comment/344c5ca9_7efda809 PS1, Line 501: stlinkv3_handle = usb_dev_get_by_vid_pid_serial(usb_ctx, > Just to make it clear, I have to correct the file for corrections that Thomas, Felix and others mentioned (also in https://review.coreboot.org/c/flashrom/+/67700/) and push the changes to this branch? Hmmm, the situation is a bit messy... Apologies if this is overwhelming for you. Both your change and CB:67700 intend to address the same issue. CB:67700 is pretty much ready to go, but Joursoir abandoned it because your change was pushed earlier. We (Angel) are not sure why it was done this way, but looks like deciding how to proceed is in your hands now. So, would you like to update your change (basically copy CB:67700), or would you prefer Joursoir to restore CB:67700 instead? If unsure, feel free to ask any questions. -- To view, visit https://review.coreboot.org/c/flashrom/+/66225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7ce156a9f7455434ea461560320c84660c93c02f Gerrit-Change-Number: 66225 Gerrit-PatchSet: 2 Gerrit-Owner: Shreeyash <shreeyash335(a)gmail.com> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Shreeyash <shreeyash335(a)gmail.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 14 Oct 2022 10:13:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Shreeyash <shreeyash335(a)gmail.com> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashchips: Add EON EN25T80 and EN25T80
by Angel Pons (Code Review) 14 Oct '22

14 Oct '22

Attention is currently required from: Felix Singer, Shreeyash . Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66438 ) Change subject: flashchips: Add EON EN25T80 and EN25T80 ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/66438/comment/22ea14c9_1d8829bf PS1, Line 9: My first chip definition, apologies for any mistakes. > Sorted in the order in which they appear in flashchips. […] Sorted as per CB:33931 -- To view, visit https://review.coreboot.org/c/flashrom/+/66438 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie62a08bed242b5b006e4bb2f86eb70c871bd5ed9 Gerrit-Change-Number: 66438 Gerrit-PatchSet: 1 Gerrit-Owner: Shreeyash <shreeyash335(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Shreeyash <shreeyash335(a)gmail.com> Gerrit-Comment-Date: Fri, 14 Oct 2022 09:49:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Shreeyash <shreeyash335(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: stlinkv3_spi: Bug fix, Initialize uninitialized pointers
by Shreeyash (Code Review) 14 Oct '22

14 Oct '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Alexander Goncharov. Shreeyash has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66225 ) Change subject: stlinkv3_spi: Bug fix, Initialize uninitialized pointers ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/66225/comment/766fba4f_81bcf339 PS2, Line 7: Bug fix, Initialize uninitialized pointers > How about `fix false-positive compiler error`? Sounds right, will do this. https://review.coreboot.org/c/flashrom/+/66225/comment/da1f47c5_d5ded0bb PS2, Line 9: on line 510 > After rebasing, the line number is not correct. I suggest deleting it. Ack -- To view, visit https://review.coreboot.org/c/flashrom/+/66225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7ce156a9f7455434ea461560320c84660c93c02f Gerrit-Change-Number: 66225 Gerrit-PatchSet: 2 Gerrit-Owner: Shreeyash <shreeyash335(a)gmail.com> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 14 Oct 2022 09:45:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2022