Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Alexander Goncharov.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66373 )
Change subject: tree: provide flashrom context into programmer_delay()
......................................................................
Patch Set 14: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/66373
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ibb0bce26ce2052853ee52158d7ba742967a9e229
Gerrit-Change-Number: 66373
Gerrit-PatchSet: 14
Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Comment-Date: Sun, 16 Oct 2022 23:05:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk, Alexander Goncharov.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66373 )
Change subject: tree: provide flashrom context into programmer_delay()
......................................................................
Patch Set 14: Code-Review+2
(1 comment)
File bitbang_spi.c:
https://review.coreboot.org/c/flashrom/+/66373/comment/ea433cf1_42cf4eed
PS11, Line 80: flash,
> Yeah, I agree. […]
Perfect thanks.
--
To view, visit https://review.coreboot.org/c/flashrom/+/66373
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ibb0bce26ce2052853ee52158d7ba742967a9e229
Gerrit-Change-Number: 66373
Gerrit-PatchSet: 14
Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Comment-Date: Sun, 16 Oct 2022 22:54:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org>
Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66373 )
Change subject: tree: provide flashrom context into programmer_delay()
......................................................................
Patch Set 14:
(1 comment)
File bitbang_spi.c:
https://review.coreboot.org/c/flashrom/+/66373/comment/d5043a11_91bfa312
PS11, Line 80: flash,
> A lot of lines changed in this patch with some plumbing actually don't need that much of a change, y […]
Yeah, I agree. Especially the situation where a programmer uses `flashctx` in one place and `NULL` in another just makes things more complicated.
So, I've deleted passing `flashctx` in programmers' files. Please mark as resolved if you're OK with the current patchset.
--
To view, visit https://review.coreboot.org/c/flashrom/+/66373
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ibb0bce26ce2052853ee52158d7ba742967a9e229
Gerrit-Change-Number: 66373
Gerrit-PatchSet: 14
Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Sun, 16 Oct 2022 12:06:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk, Alexander Goncharov.
Hello Felix Singer, build bot (Jenkins), Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/66373
to look at the new patch set (#14).
Change subject: tree: provide flashrom context into programmer_delay()
......................................................................
tree: provide flashrom context into programmer_delay()
Modify the `programmer_delay` function signature to allow passing
the flashrom context. Programmers that depend on internal delay
should provide NULL as a context. The use of this function parameter
will be introduced in CB:67393.
TOPIC=programmer_handle_global
TEST=builds
Change-Id: Ibb0bce26ce2052853ee52158d7ba742967a9e229
Signed-off-by: Alexander Goncharov <chat(a)joursoir.net>
---
M 82802ab.c
M amd_imc.c
M at45db.c
M atavia.c
M bitbang_spi.c
M cli_classic.c
M dediprog.c
M dummyflasher.c
M edi.c
M en29lv640b.c
M flashrom.c
M ichspi.c
M include/flash.h
M it87spi.c
M jedec.c
M nicintel_eeprom.c
M pony_spi.c
M raiden_debug_spi.c
M s25f.c
M spi25.c
M spi25_statusreg.c
M sst28sf040.c
M stm50.c
M w29ee011.c
M w39.c
M wbsio_spi.c
26 files changed, 115 insertions(+), 96 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/73/66373/14
--
To view, visit https://review.coreboot.org/c/flashrom/+/66373
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ibb0bce26ce2052853ee52158d7ba742967a9e229
Gerrit-Change-Number: 66373
Gerrit-PatchSet: 14
Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk, Alexander Goncharov.
Hello Felix Singer, build bot (Jenkins), Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/66373
to look at the new patch set (#12).
Change subject: tree: provide flashrom context into programmer_delay()
......................................................................
tree: provide flashrom context into programmer_delay()
Modify the `programmer_delay` function signature to allow passing
the flashrom context. Programmers that depend on internal delay
should provide NULL as a context. The use of this function parameter
will be introduced in CB:67393.
TOPIC=programmer_handle_global
TEST=builds
Change-Id: Ibb0bce26ce2052853ee52158d7ba742967a9e229
Signed-off-by: Alexander Goncharov <chat(a)joursoir.net>
---
M 82802ab.c
M amd_imc.c
M at45db.c
M atavia.c
M bitbang_spi.c
M cli_classic.c
M dediprog.c
M dummyflasher.c
M edi.c
M en29lv640b.c
M flashrom.c
M ichspi.c
M include/flash.h
M it87spi.c
M jedec.c
M nicintel_eeprom.c
M pony_spi.c
M raiden_debug_spi.c
M s25f.c
M spi25.c
M spi25_statusreg.c
M sst28sf040.c
M stm50.c
M w29ee011.c
M w39.c
M wbsio_spi.c
26 files changed, 117 insertions(+), 98 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/73/66373/12
--
To view, visit https://review.coreboot.org/c/flashrom/+/66373
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ibb0bce26ce2052853ee52158d7ba742967a9e229
Gerrit-Change-Number: 66373
Gerrit-PatchSet: 12
Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-MessageType: newpatchset
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/68249 )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: flashrom.c: Use programmer_init() func params over global
......................................................................
flashrom.c: Use programmer_init() func params over global
The 'programmer' intended to be used in the control flow
of 'programmer_init()' is a parameter to the function. Therefore
use that symbol directly over the global copy of it.
Change-Id: I71e61f0633bac2fc472971249910bf3bf57cd0eb
Signed-off-by: Edward O'Callaghan <quasisec(a)google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/68249
Reviewed-by: Angel Pons <th3fanbus(a)gmail.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M flashrom.c
1 file changed, 19 insertions(+), 2 deletions(-)
Approvals:
build bot (Jenkins): Verified
Angel Pons: Looks good to me, approved
diff --git a/flashrom.c b/flashrom.c
index 3575822..6dae5e3 100644
--- a/flashrom.c
+++ b/flashrom.c
@@ -161,8 +161,8 @@
cfg.params = NULL;
}
- msg_pdbg("Initializing %s programmer\n", programmer->name);
- ret = programmer->init(&cfg);
+ msg_pdbg("Initializing %s programmer\n", prog->name);
+ ret = prog->init(&cfg);
if (cfg.params && strlen(cfg.params)) {
if (ret != 0) {
/* It is quite possible that any unhandled programmer parameter would have been valid,
--
To view, visit https://review.coreboot.org/c/flashrom/+/68249
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I71e61f0633bac2fc472971249910bf3bf57cd0eb
Gerrit-Change-Number: 68249
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Edward O'Callaghan has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67401 )
Change subject: flashrom.c: Deconflate bad cfg validation from param residue check
......................................................................
Abandoned
all resolved in tree now.
--
To view, visit https://review.coreboot.org/c/flashrom/+/67401
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0fba6bbbe4b685b210d1cba17e7b5815c5c01a45
Gerrit-Change-Number: 67401
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-MessageType: abandon
Attention is currently required from: Khoa Hoang.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67713 )
Change subject: flashchips.c: Add write protect support for W25Q16.V
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/67713/comment/d2bbbdb2_38483c6a
PS4, Line 11:
Please add the release date and the revision of the datasheet you used to the commit message.
--
To view, visit https://review.coreboot.org/c/flashrom/+/67713
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6c0b35f82b47a1169bccfd08222e9e3b3be30d75
Gerrit-Change-Number: 67713
Gerrit-PatchSet: 4
Gerrit-Owner: Khoa Hoang <admin(a)khoahoang.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Khoa Hoang <admin(a)khoahoang.com>
Gerrit-Comment-Date: Sun, 16 Oct 2022 06:48:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68247 )
Change subject: util: add bash completion script
......................................................................
Patch Set 7:
(3 comments)
File Makefile:
https://review.coreboot.org/c/flashrom/+/68247/comment/4a0228aa_f85f727e
PS4, Line 33: bash-completion
> oops.. That comment should have gone to the other thread.
I mark it as resolved. Feel free to reopen =)
File meson.build:
https://review.coreboot.org/c/flashrom/+/68247/comment/6a8d82b5_02a85073
PS4, Line 611: share/bash-completion/completions
> > Do you want me to add an option for bash-completion/completions ? […]
I went through sources at the link that Thomas sent (btw many thanks). Getting the path from a pkgconfig variable is a really nice way. Would it be enough?
File meson.build:
https://review.coreboot.org/c/flashrom/+/68247/comment/616cbfe7_b6b07f6d
PS6, Line 607: if get_option('bash_completion').auto() or get_option('bash_completion').enabled()
> If `classic_cli` is disabled and this is enabled it should give an error. […]
Thanks, I forgot about that. Done.
--
To view, visit https://review.coreboot.org/c/flashrom/+/68247
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie68bc91c3cea4de2ffdbeffd07e48edd8d5590e1
Gerrit-Change-Number: 68247
Gerrit-PatchSet: 7
Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Sat, 15 Oct 2022 23:33:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de>
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-MessageType: comment