July 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: spi_master: Add default write_aai function to masters that have none
by Anastasia Klimchuk (Code Review) 09 Jul '21

09 Jul '21

Attention is currently required from: Nico Huber, Victor Ding, Thomas Heijligen, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56102 ) Change subject: spi_master: Add default write_aai function to masters that have none ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Sorry that I don't have a precise answer atm. […] Victor, thank you, if you could get this information that would be great! I saw those two were upstreamed last year (relatively recently), so I was assuming they are useful... I wrote tests for them :\ Actually, this is how I found out that write_aai is missing, because tests failed on the next patch CB:56103. It would be extremely ironic if the tests have found the problem, the solution to which is to remove the code and tests... but anyway if I've made a mistake I will fix it. -- To view, visit https://review.coreboot.org/c/flashrom/+/56102 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I712e74e11244e1f0ab8d8e245fcd5207ce211219 Gerrit-Change-Number: 56102 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Victor Ding <victording(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Victor Ding <victording(a)google.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 09 Jul 2021 09:35:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Victor Ding <victording(a)google.com> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: spi_master: Add default write_aai function to masters that have none
by Victor Ding (Code Review) 09 Jul '21

09 Jul '21

Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Victor Ding has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56102 ) Change subject: spi_master: Add default write_aai function to masters that have none ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Potentially yes. […] Sorry that I don't have a precise answer atm. The two programmers are used by some chromebooks released in the late 2000s or early 2010s. Let me figure out a list of such devices and check if any reached EoL. -- To view, visit https://review.coreboot.org/c/flashrom/+/56102 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I712e74e11244e1f0ab8d8e245fcd5207ce211219 Gerrit-Change-Number: 56102 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Victor Ding <victording(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 09 Jul 2021 03:42:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: hwaccess.c: Fix PowerPC memory barrier
by Stefan Reinauer (Code Review) 09 Jul '21

09 Jul '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Arthur Heymans. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52470 ) Change subject: hwaccess.c: Fix PowerPC memory barrier ...................................................................... Patch Set 4: (2 comments) Patchset: PS4: > This change can wait for now. What part of this is hard to predict? Isn't this fixing a compilation error (specifically guarded with IS_PPC) and doing so in full accordance with what's done on SPARC as well? File hwaccess.c: https://review.coreboot.org/c/flashrom/+/52470/comment/ddba8668_a1dd4b22 PS4, Line 74: __asm__ __volatile__ why is __asm__ __volatile__ used on PPC but asm volatile is used below on SPARC? -- To view, visit https://review.coreboot.org/c/flashrom/+/52470 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia84fd1362a1d39aca6269eef22ac994dee68ba4b Gerrit-Change-Number: 52470 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 09 Jul 2021 02:56:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: spi_master: Add default write_aai function to masters that have none
by Edward O'Callaghan (Code Review) 09 Jul '21

09 Jul '21

Attention is currently required from: Nico Huber, Victor Ding, Thomas Heijligen, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56102 ) Change subject: spi_master: Add default write_aai function to masters that have none ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Can we please drop these programmers, then? Potentially yes. afaik these were to support old models of chromebooks and were upstreamed to do the right thing. Victor has the context who I asked to work on these so it would be good if he can chime in. -- To view, visit https://review.coreboot.org/c/flashrom/+/56102 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I712e74e11244e1f0ab8d8e245fcd5207ce211219 Gerrit-Change-Number: 56102 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Victor Ding <victording(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Victor Ding <victording(a)google.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 09 Jul 2021 01:51:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ft2232_spi: Add FTDI search by description.
by Name of user not set (Code Review) 08 Jul '21

08 Jul '21

johnsonh(a)waymo.com has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/56164 ) Change subject: ft2232_spi: Add FTDI search by description. ...................................................................... ft2232_spi: Add FTDI search by description. This adds to the search-by-serial functionality with search-by-description (product string). This is useful when e.g. one has multiple FTDIs in a system and wants the serial numbers to reflect the system-level serial number, and the description to reflect the subcomponent names. Tested manually by running with both serial and description searches, on a machine with multiple FTDIs plugged in. Ensured that when two devices with the same vid/pid/serial number are plugged in, description can still be used to differentiate. Change-Id: Ib4be23247995710900175f5f16e38db577ef08fa Signed-off-by: Harry Johnson <johnsonh(a)waymo.com> --- M ft2232_spi.c 1 file changed, 20 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/64/56164/1 diff --git a/ft2232_spi.c b/ft2232_spi.c index d853b09..756a603 100644 --- a/ft2232_spi.c +++ b/ft2232_spi.c @@ -498,10 +498,29 @@ msg_perr("Unable to select channel (%s).\n", ftdi_get_error_string(&ftdic)); } + // Prefer search by serial if possible. arg = extract_programmer_param("serial"); - f = ftdi_usb_open_desc(&ftdic, ft2232_vid, ft2232_type, NULL, arg); + if (arg && strlen(arg)) { + f = ftdi_usb_open_desc(&ftdic, ft2232_vid, ft2232_type, NULL, arg); + free(arg); + goto usb_opened; + } free(arg); + // If serial unavailable, allow search by description. + arg = extract_programmer_param("description"); + if (arg && strlen(arg)) { + f = ftdi_usb_open_desc(&ftdic, ft2232_vid, ft2232_type, arg, NULL); + free(arg); + goto usb_opened; + } + free(arg); + + // If serial and description unavailable, search by VID/PID only. + f = ftdi_usb_open_desc(&ftdic, ft2232_vid, ft2232_type, NULL, NULL); + +usb_opened: + if (f < 0 && f != -5) { msg_perr("Unable to open FTDI device: %d (%s)\n", f, ftdi_get_error_string(&ftdic)); -- To view, visit https://review.coreboot.org/c/flashrom/+/56164 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib4be23247995710900175f5f16e38db577ef08fa Gerrit-Change-Number: 56164 Gerrit-PatchSet: 1 Gerrit-Owner: johnsonh(a)waymo.com Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops
by Michael Niewöhner (Code Review) 08 Jul '21

08 Jul '21

Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Paul Menzel, Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 ) Change subject: ite_ec: Implement support for flashing ITE ECs found on TUXEDO laptops ...................................................................... Patch Set 11: (4 comments) File ite_ec.c: https://review.coreboot.org/c/flashrom/+/55715/comment/d591fca5_bc56932d PS9, Line 176: ctx_data->control_port = EC_CONTROL; > CMD,not CONTROL Done File ite_ec.c: https://review.coreboot.org/c/flashrom/+/55715/comment/d1305832_61538c5e PS10, Line 211: 0x10 ec ram `ADP` https://review.coreboot.org/c/flashrom/+/55715/comment/3d6f5191_98dc741d PS10, Line 781: : if (!ec_write_reg(0xf9, 0x20, EC_MAX_STATUS_CHECKS) || : !ec_write_reg(0xfa, 0x02, EC_MAX_STATUS_CHECKS) || : !ec_write_reg(0xfb, 0x00, EC_MAX_STATUS_CHECKS) || : !ec_write_reg(0xf8, 0xb1, EC_MAX_STATUS_CHECKS)) { : msg_perr("Unable to initialize controller.\n"); : return 1; > how could this ever work? o.O https://review.coreboot.org/c/flashrom/+/55714/4/acpi_ec.c#95 […] Done File ite_ec.c: https://review.coreboot.org/c/flashrom/+/55715/comment/8763081d_37986571 PS11, Line 735: if (!ec_write_reg(0xf9, 0x20, EC_MAX_STATUS_CHECKS) || : !ec_write_reg(0xfa, 0x02, EC_MAX_STATUS_CHECKS) || : !ec_write_reg(0xfb, 0x00, EC_MAX_STATUS_CHECKS) || : !ec_write_reg(0xf8, 0xb1, EC_MAX_STATUS_CHECKS)) { : msg_perr("Unable to initialize controller.\n"); : return 1; : } : I found out what this does: The registers are FCMD,FDAT,FBUF,FBF1 (0xf8-0xfb) in the operation region RAM1. Wth FCMD 0xb1 one can read registers / external RAM (XDATA), code, flash (via indirect flash registers ECIN*), or IDATA/RAM depending on FBF1, where (FBF1 & 0x0f) is the length and (FBF1 & 0xf0) is the type (XDATA, code, ....). In this case this means: FBF1=0x00 reads 1 byte (yes, 0x*0 gets increased by 1) of XDATA FDAT:FBUF form the 16bit XDATA address (DPTR); 0x2002 is register CHIPVER The result gets stored in FDAT and can be read by the host, which is done here in line #157. So, the code reads CHIPVER, where the upper nibble encodes the block count / rom size. The code from lines 735++ should go to line 157 and maybe that whole rom size code should probably become a separate function. Also, please add comments what the code does, now that we know it. The error message needs to be adapted to sth like "unable to read block count / rom size". Fun fact: CHIPVER could be read from the super io cfg registers as well (register 0x22) according to the datasheet. -- To view, visit https://review.coreboot.org/c/flashrom/+/55715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0e42260155ffea38a6f60790871cd8da7b657031 Gerrit-Change-Number: 55715 Gerrit-PatchSet: 11 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 08 Jul 2021 21:31:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: board_enable.c: Add ME unlock function for TUXEDO laptops
by Michael Niewöhner (Code Review) 08 Jul '21

08 Jul '21

Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Paul Menzel, Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56023 ) Change subject: board_enable.c: Add ME unlock function for TUXEDO laptops ...................................................................... Patch Set 5: (1 comment) File board_enable.c: https://review.coreboot.org/c/flashrom/+/56023/comment/cc856c98_c96a2254 PS2, Line 2339: return 0; > If we unlock the ME successfully we return -1 so that the flashrom will not proceed with flashing an […] Sorry, I thought one had to apply a command (-r -w -v), too, but that's not the case. For me this is fine. What do others say? -- To view, visit https://review.coreboot.org/c/flashrom/+/56023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6bf1c40900aa674e3ea4f6add12dae8b73759fbb Gerrit-Change-Number: 56023 Gerrit-PatchSet: 5 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 08 Jul 2021 16:56:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: board_enable.c: Add ME unlock function for TUXEDO laptops
by Michael Niewöhner (Code Review) 08 Jul '21

08 Jul '21

Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Paul Menzel, Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56023 ) Change subject: board_enable.c: Add ME unlock function for TUXEDO laptops ...................................................................... Patch Set 5: (1 comment) File board_enable.c: https://review.coreboot.org/c/flashrom/+/56023/comment/c8abf1a5_25b68622 PS2, Line 2331: 0xda > Not naming it at all is good as well for now. […] Since bit 0 controls ACPI vs. SMI backlight control, I doubt it's "Windows Flash". Anyway, I'm fine with not naming it. A comment to have at least a reference would be great, though. (Except, when I am the only one wanting such comment. @Nico @Angel @Felix?) -- To view, visit https://review.coreboot.org/c/flashrom/+/56023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6bf1c40900aa674e3ea4f6add12dae8b73759fbb Gerrit-Change-Number: 56023 Gerrit-PatchSet: 5 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 08 Jul 2021 16:55:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: board_enable.c: Add ME unlock function for TUXEDO laptops
by Michał Żygowski (Code Review) 08 Jul '21

08 Jul '21

Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons, Michael Niewöhner. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56023 ) Change subject: board_enable.c: Add ME unlock function for TUXEDO laptops ...................................................................... Patch Set 5: (1 comment) Patchset: PS3: > Earlier it complained on some type mismatches in ich_descriptors_tool NVM I see it... BTW [213/270] Compiling C object util/ich_descriptors_tool/ich_descriptors_tool.p/ich_descriptors_tool.c.o ../util/ich_descriptors_tool/ich_descriptors_tool.c: In function 'dump_file': ../util/ich_descriptors_tool/ich_descriptors_tool.c:89:10: warning: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Wsign-compare] 89 | if (ret != file_len) { | ^~ ../util/ich_descriptors_tool/ich_descriptors_tool.c: In function 'main': ../util/ich_descriptors_tool/ich_descriptors_tool.c:262:10: warning: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Wsign-compare] 262 | if (len >= ICH_FREG_BASE(desc.region.FLREGs[3]) + 6 && pMAC[0] != 0xff) | ^~ -- To view, visit https://review.coreboot.org/c/flashrom/+/56023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6bf1c40900aa674e3ea4f6add12dae8b73759fbb Gerrit-Change-Number: 56023 Gerrit-PatchSet: 5 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Thu, 08 Jul 2021 16:40:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: board_enable.c: Add ME unlock function for TUXEDO laptops
by Michał Żygowski (Code Review) 08 Jul '21

08 Jul '21

Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons, Michael Niewöhner. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56023 ) Change subject: board_enable.c: Add ME unlock function for TUXEDO laptops ...................................................................... Patch Set 5: (1 comment) Patchset: PS3: > /usr/bin/ld: libflashrom.so.1.0.0.p/board_enable.c.o: in function `clevo_unlock_me': […] Earlier it complained on some type mismatches in ich_descriptors_tool -- To view, visit https://review.coreboot.org/c/flashrom/+/56023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6bf1c40900aa674e3ea4f6add12dae8b73759fbb Gerrit-Change-Number: 56023 Gerrit-PatchSet: 5 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Thu, 08 Jul 2021 16:38:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit July 2021