July 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: spi_master: Add default write_aai function to masters that have none
by David Hendricks (Code Review) 11 Jul '21

11 Jul '21

Attention is currently required from: Nico Huber, Victor Ding, Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56102 ) Change subject: spi_master: Add default write_aai function to masters that have none ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I think we can go ahead with this but should keep in mind that we need […] it85xx was used on mario (the original Cr-48 Chromebook), Stout (Lenovo X131e), and possibly others from that era. AFAIK all Chromebooks made since 2014 use ChromeEC, so anything using it85xx, mec1308, and ene_lpc is likely EOL'd. -- To view, visit https://review.coreboot.org/c/flashrom/+/56102 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I712e74e11244e1f0ab8d8e245fcd5207ce211219 Gerrit-Change-Number: 56102 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Victor Ding <victording(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Victor Ding <victording(a)google.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 11 Jul 2021 02:58:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Victor Ding <victording(a)google.com> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: spi_master: Use new API to register shutdown function
by Nico Huber (Code Review) 10 Jul '21

10 Jul '21

Attention is currently required from: Thomas Heijligen, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56103 ) Change subject: spi_master: Use new API to register shutdown function ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Miklós, this might need a test with ni845x. -- To view, visit https://review.coreboot.org/c/flashrom/+/56103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib60300f9ddb295a255d5ef3f8da0e07064207140 Gerrit-Change-Number: 56103 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 10 Jul 2021 12:21:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: spi_master: Use new API to register shutdown function
by Nico Huber (Code Review) 10 Jul '21

10 Jul '21

Attention is currently required from: Thomas Heijligen, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56103 ) Change subject: spi_master: Use new API to register shutdown function ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I have a message to reviewers, thank you! > 1) I don't know how to build ni845x_spi This is Miklós' arcane knowledge :) > 2) raiden_debug_spi is left for now, it has different data used in register_spi_master vs register_shutdown Oh, this one looks funny. The data free'd in the shutdown function is the master struct itself :) So what we would actually need is a field in `data` pointing back to the master. Currently it's free'd like this (where `spi_master` is currently called `spi_config` in the code): free(spi_master->data) free(spi_master) If we add a pointer to `data`, pointing to the master, we could turn it around: free(data->master) free(data) And then we could use the same `data` pointer everwhere. -- To view, visit https://review.coreboot.org/c/flashrom/+/56103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib60300f9ddb295a255d5ef3f8da0e07064207140 Gerrit-Change-Number: 56103 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 10 Jul 2021 12:19:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: spi_master: Add default write_aai function to masters that have none
by Nico Huber (Code Review) 10 Jul '21

10 Jul '21

Attention is currently required from: Victor Ding, Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56102 ) Change subject: spi_master: Add default write_aai function to masters that have none ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: > Victor, thank you, if you could get this information that would be great! […] I think we can go ahead with this but should keep in mind that we need to analyze what makes sense to upstream and what doesn't. And we have to stop upstreaming untested code (I mean just a blunt run it on the respective hardware and see if it does something; that would be a start). This is actually not the first time this happened: the `it85spi` driver was also upstreamed from chromium about a decade ago, and is not hooked up anywhere yet ;) Nobody cares about these EC drivers, nobody hooks them up correctly. Still, we maintain their code? -- To view, visit https://review.coreboot.org/c/flashrom/+/56102 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I712e74e11244e1f0ab8d8e245fcd5207ce211219 Gerrit-Change-Number: 56102 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Victor Ding <victording(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Victor Ding <victording(a)google.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 10 Jul 2021 12:04:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Victor Ding <victording(a)google.com> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: spi_master: Move shutdown function above spi_master struct
by Nico Huber (Code Review) 10 Jul '21

10 Jul '21

Attention is currently required from: Thomas Heijligen, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56101 ) Change subject: spi_master: Move shutdown function above spi_master struct ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/56101/comment/fc3cffed_a0485ba7 PS1, Line 17: binary is the same Thanks! -- To view, visit https://review.coreboot.org/c/flashrom/+/56101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I50716686552b4ddcc6089d5afadb19ef59d9f9b4 Gerrit-Change-Number: 56101 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 10 Jul 2021 11:55:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: spi_master: Add shutdown function in spi_master struct
by Nico Huber (Code Review) 10 Jul '21

10 Jul '21

Attention is currently required from: Thomas Heijligen, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55932 ) Change subject: spi_master: Add shutdown function in spi_master struct ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Patchset: PS1: > Oh and I also can see, for the masters without programmer entry, the entry does not even exist in pr […] On a gut level, "it will never be needed". Well, as you mentioned the programmer name, it seems possible that one might want such a relation for cosmetical reasons (e.g. ui output). But I don't think we'll ever need it for the flashing functionality. File spi.c: https://review.coreboot.org/c/flashrom/+/55932/comment/05cd1f87_954d30c3 PS3, Line 142: } Technically not needed, but this should have another set of braces. -- To view, visit https://review.coreboot.org/c/flashrom/+/55932 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2dc80dceca2f8204bcd0dad1f51753d7e79f1af5 Gerrit-Change-Number: 55932 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 10 Jul 2021 11:54:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: hwaccess.c: Fix PowerPC memory barrier
by Nico Huber (Code Review) 10 Jul '21

10 Jul '21

Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52470 ) Change subject: hwaccess.c: Fix PowerPC memory barrier ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > What part of this is hard to predict? If it will compile. We are outside of ISO C here. The weirdest part: ISO C lists `asm` as a common extension, however, if you enable strict ISO C conformance (which another patch tried), the `asm` keyword doesn't exist anymore because it's a valid identifier in C (strictly speaking). We don't know what compiler (version) will be used. As I said above, we can raise the bar but I think we should only do it after the release. > Isn't this fixing a compilation error (specifically guarded with IS_PPC) It is. But fixing things for one compiler/case can break them for another. -- To view, visit https://review.coreboot.org/c/flashrom/+/52470 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia84fd1362a1d39aca6269eef22ac994dee68ba4b Gerrit-Change-Number: 52470 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 10 Jul 2021 11:00:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Replace freenode references
by Angel Pons (Code Review) 09 Jul '21

09 Jul '21

Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56031 ) Change subject: Replace freenode references ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: > Sounds good. […] I can't describe how thankful I am. As usual, your suggestions are most welcome! File flashrom.8.tmpl: https://review.coreboot.org/c/flashrom/+/56031/comment/f56a5a94_b1d29300 PS1, Line 1457: Please report any bugs using one of the contact methods at > Sounds good Done File flashrom.c: https://review.coreboot.org/c/flashrom/+/56031/comment/e74b0aca_db19ef52 PS1, Line 1549: "chip. Please report this (see https://www.flashrom.org/Contact for details), thanks!\n" > Maybe just sequeeze the mailing list back in: […] I added an `at` before the mailing list address, it feels more natural. Thoughts? -- To view, visit https://review.coreboot.org/c/flashrom/+/56031 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I75e8f43c50dc4c3feede0250334a877cdaac8103 Gerrit-Change-Number: 56031 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 09 Jul 2021 17:54:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Replace freenode references
by Angel Pons (Code Review) 09 Jul '21

09 Jul '21

Attention is currently required from: Angel Pons. Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/56031 to look at the new patch set (#2). Change subject: Replace freenode references ...................................................................... Replace freenode references The flashrom project no longer uses freenode. To avoid having outdated man pages in the future, the contact methods are now listed in the wiki. Change-Id: I75e8f43c50dc4c3feede0250334a877cdaac8103 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M README M flashrom.8.tmpl M flashrom.c 3 files changed, 15 insertions(+), 30 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/56031/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/56031 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I75e8f43c50dc4c3feede0250334a877cdaac8103 Gerrit-Change-Number: 56031 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: hwaccess.c: Fix PowerPC memory barrier
by Angel Pons (Code Review) 09 Jul '21

09 Jul '21

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/52470 ) Change subject: hwaccess.c: Fix PowerPC memory barrier ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/52470 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia84fd1362a1d39aca6269eef22ac994dee68ba4b Gerrit-Change-Number: 52470 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit July 2021