June 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: Makefile: Deflate handling of unsupported programmers for DJGPP
by Angel Pons (Code Review) 28 Jun '21

28 Jun '21

Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55874 ) Change subject: Makefile: Deflate handling of unsupported programmers for DJGPP ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File Makefile: https://review.coreboot.org/c/flashrom/+/55874/comment/c65e07b1_02198aa2 PS2, Line 202: $(call mark_unsupported,CONFIG_ENE_LPC CONFIG_MEC1308) > Untested on DOS and hence disabled. Maybe we should simply disable them […] CB:55889 CB:55890 -- To view, visit https://review.coreboot.org/c/flashrom/+/55874 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I86988aa7ef1d2d4189be3d25b9aea4e7ddaec9af Gerrit-Change-Number: 55874 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Victor Ding <victording(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 28 Jun 2021 16:05:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: Add macro to disable unsupported programmers
by Angel Pons (Code Review) 28 Jun '21

28 Jun '21

Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55873 ) Change subject: Makefile: Add macro to disable unsupported programmers ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/55873 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6c9b66dfa89ec3d71675576d03fcebfdea30ce7b Gerrit-Change-Number: 55873 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 28 Jun 2021 16:04:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: Gather lists of dependencies by feature/lib
by Angel Pons (Code Review) 28 Jun '21

28 Jun '21

Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55872 ) Change subject: Makefile: Gather lists of dependencies by feature/lib ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/55872 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6929181f18213e1434cbbc7ba2d2b0b04bd46a6a Gerrit-Change-Number: 55872 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 28 Jun 2021 16:04:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: util: Name udev-rules file accordingly
by Felix Singer (Code Review) 28 Jun '21

28 Jun '21

Attention is currently required from: Nico Huber, Paul Menzel. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55866 ) Change subject: util: Name udev-rules file accordingly ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/55866/comment/3941535f_d934d6a5 PS1, Line 9: Rename `z60_flashrom.rules` to `flashrom_udev.rules`. > I’d got with `/lib/udev/rules.d/60-flashrom.rules` done by the Debian package [1]. […] If a distro uses any ordering concept (some also don't), then package maintainers _have_ to deal with that. This is their job, not ours. -- To view, visit https://review.coreboot.org/c/flashrom/+/55866 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1e7918d3121d89d3c388745e433a3a413eac0e21 Gerrit-Change-Number: 55866 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 28 Jun 2021 14:33:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Allow MEC1308 to build against DOS and libpayload
by Angel Pons (Code Review) 28 Jun '21

28 Jun '21

Attention is currently required from: Nico Huber, Victor Ding. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55890 ) Change subject: Allow MEC1308 to build against DOS and libpayload ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/55890 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic50fa2841b9e01b008ce82462e2b7120ee490a68 Gerrit-Change-Number: 55890 Gerrit-PatchSet: 1 Gerrit-Owner: Victor Ding <victording(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Victor Ding <victording(a)google.com> Gerrit-Comment-Date: Mon, 28 Jun 2021 09:53:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Allow ENE_LPC to build against DOS and libpayload
by Angel Pons (Code Review) 28 Jun '21

28 Jun '21

Attention is currently required from: Nico Huber, Victor Ding. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55889 ) Change subject: Allow ENE_LPC to build against DOS and libpayload ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/55889 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0a7e675c344a2ccac558b8c32720930c15fe92ee Gerrit-Change-Number: 55889 Gerrit-PatchSet: 1 Gerrit-Owner: Victor Ding <victording(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Victor Ding <victording(a)google.com> Gerrit-Comment-Date: Mon, 28 Jun 2021 09:53:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: dediprog: Separate shutdown from failed init cleanup
by Angel Pons (Code Review) 28 Jun '21

28 Jun '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55887 ) Change subject: dediprog: Separate shutdown from failed init cleanup ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/55887 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3273da907614a042d50090338c337dfd64695354 Gerrit-Change-Number: 55887 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 28 Jun 2021 09:44:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Allow MEC1308 to build against DOS and libpayload
by Victor Ding (Code Review) 28 Jun '21

28 Jun '21

Victor Ding has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/55890 ) Change subject: Allow MEC1308 to build against DOS and libpayload ...................................................................... Allow MEC1308 to build against DOS and libpayload MEC1308 EC driver compiles successfully against DOS and libpayload. Signed-off-by: Victor Ding <victording(a)google.com> Change-Id: Ic50fa2841b9e01b008ce82462e2b7120ee490a68 --- M Makefile 1 file changed, 0 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/90/55890/1 diff --git a/Makefile b/Makefile index 373d99d..41ba861 100644 --- a/Makefile +++ b/Makefile @@ -175,11 +175,6 @@ else override CONFIG_FT2232_SPI = no endif -ifeq ($(CONFIG_MEC1308), yes) -UNSUPPORTED_FEATURES += CONFIG_MEC1308=yes -else -override CONFIG_MEC1308 = no -endif ifeq ($(CONFIG_USBBLASTER_SPI), yes) UNSUPPORTED_FEATURES += CONFIG_USBBLASTER_SPI=yes else @@ -381,11 +376,6 @@ else override CONFIG_FT2232_SPI = no endif -ifeq ($(CONFIG_MEC1308), yes) -UNSUPPORTED_FEATURES += CONFIG_MEC1308=yes -else -override CONFIG_MEC1308 = no -endif ifeq ($(CONFIG_USBBLASTER_SPI), yes) UNSUPPORTED_FEATURES += CONFIG_USBBLASTER_SPI=yes else -- To view, visit https://review.coreboot.org/c/flashrom/+/55890 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic50fa2841b9e01b008ce82462e2b7120ee490a68 Gerrit-Change-Number: 55890 Gerrit-PatchSet: 1 Gerrit-Owner: Victor Ding <victording(a)google.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: Allow ENE_LPC to build against DOS and libpayload
by Victor Ding (Code Review) 28 Jun '21

28 Jun '21

Victor Ding has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/55889 ) Change subject: Allow ENE_LPC to build against DOS and libpayload ...................................................................... Allow ENE_LPC to build against DOS and libpayload ENE LPC interface keyboard controller driver compiles successfully against DOS and libpayload. Signed-off-by: Victor Ding <victording(a)google.com> Change-Id: I0a7e675c344a2ccac558b8c32720930c15fe92ee --- M Makefile 1 file changed, 0 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/89/55889/1 diff --git a/Makefile b/Makefile index 4d68cdb..373d99d 100644 --- a/Makefile +++ b/Makefile @@ -170,11 +170,6 @@ else override CONFIG_DEVELOPERBOX_SPI = no endif -ifeq ($(CONFIG_ENE_LPC), yes) -UNSUPPORTED_FEATURES += CONFIG_ENE_LPC=yes -else -override CONFIG_ENE_LPC = no -endif ifeq ($(CONFIG_FT2232_SPI), yes) UNSUPPORTED_FEATURES += CONFIG_FT2232_SPI=yes else @@ -381,11 +376,6 @@ else override CONFIG_DEVELOPERBOX_SPI = no endif -ifeq ($(CONFIG_ENE_LPC), yes) -UNSUPPORTED_FEATURES += CONFIG_ENE_LPC=yes -else -override CONFIG_ENE_LPC = no -endif ifeq ($(CONFIG_FT2232_SPI), yes) UNSUPPORTED_FEATURES += CONFIG_FT2232_SPI=yes else -- To view, visit https://review.coreboot.org/c/flashrom/+/55889 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0a7e675c344a2ccac558b8c32720930c15fe92ee Gerrit-Change-Number: 55889 Gerrit-PatchSet: 1 Gerrit-Owner: Victor Ding <victording(a)google.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: util: Name udev-rules file accordingly
by Paul Menzel (Code Review) 28 Jun '21

28 Jun '21

Attention is currently required from: Felix Singer, Nico Huber. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55866 ) Change subject: util: Name udev-rules file accordingly ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/55866/comment/beeaa814_f5bf2203 PS1, Line 9: Rename `z60_flashrom.rules` to `flashrom_udev.rules`. > Done I’d got with `/lib/udev/rules.d/60-flashrom.rules` done by the Debian package [1]. Not every package maintainer should have to go through the trouble to determine how to order it. [1]: https://packages.debian.org/sid/amd64/flashrom/filelist -- To view, visit https://review.coreboot.org/c/flashrom/+/55866 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1e7918d3121d89d3c388745e433a3a413eac0e21 Gerrit-Change-Number: 55866 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 28 Jun 2021 08:30:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2021