June 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: flashrom.c libflashrom.c: replace enum programmer with size_t
by Thomas Heijligen (Code Review) 08 Jun '21

08 Jun '21

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/55120 to look at the new patch set (#6). Change subject: flashrom.c libflashrom.c: replace enum programmer with size_t ...................................................................... flashrom.c libflashrom.c: replace enum programmer with size_t Using size_t since programmer_table_size uses ARRAY_SIZE which returns size_t. Change-Id: Id2ad9630fbc41e98d182768b553788e069fa5095 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M flashrom.c M libflashrom.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/20/55120/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/55120 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id2ad9630fbc41e98d182768b553788e069fa5095 Gerrit-Change-Number: 55120 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashrom.c: replace enum programmer with struct programmer_entry*
by Thomas Heijligen (Code Review) 08 Jun '21

08 Jun '21

Attention is currently required from: Thomas Heijligen. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/55119 to look at the new patch set (#5). Change subject: flashrom.c: replace enum programmer with struct programmer_entry* ...................................................................... flashrom.c: replace enum programmer with struct programmer_entry* Change-Id: I478c56354d5f482010bfe1560489700bc889717a Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M flashrom.c 1 file changed, 12 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/19/55119/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/55119 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I478c56354d5f482010bfe1560489700bc889717a Gerrit-Change-Number: 55119 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: print.c: use static string for internal programmer name
by Thomas Heijligen (Code Review) 08 Jun '21

08 Jun '21

Attention is currently required from: Thomas Heijligen. Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/55118 to look at the new patch set (#5). Change subject: print.c: use static string for internal programmer name ...................................................................... print.c: use static string for internal programmer name Change-Id: If2cf95c71425efdd864457e213dd34b929fe8805 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M print.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/18/55118/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/55118 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If2cf95c71425efdd864457e213dd34b929fe8805 Gerrit-Change-Number: 55118 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: programmer_table: replace PROGRAMMER_INVALID with programmer_table_size
by Thomas Heijligen (Code Review) 08 Jun '21

08 Jun '21

Attention is currently required from: Nico Huber, Edward O'Callaghan. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55117 ) Change subject: programmer_table: replace PROGRAMMER_INVALID with programmer_table_size ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/55117/comment/28cbbf28_f84b6012 PS3, Line 7: programmer_table: replace PROGRAMMER_INVALID to programmer_table_size in itterations > could this just be squashed into the previous patch that introduced it earlier in the serires? Seems […] I want to introduce first all necessary items before using them -- To view, visit https://review.coreboot.org/c/flashrom/+/55117 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icaaeefe001de604df9d7fdd06f05a5ed39fdbd84 Gerrit-Change-Number: 55117 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Tue, 08 Jun 2021 10:20:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer_table: move each entry to the associated programmer source
by Thomas Heijligen (Code Review) 08 Jun '21

08 Jun '21

Attention is currently required from: Nico Huber. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52946 ) Change subject: programmer_table: move each entry to the associated programmer source ...................................................................... Patch Set 5: (24 comments) File atahpt.c: https://review.coreboot.org/c/flashrom/+/52946/comment/81ab602b_00560e68 PS4, Line 34: const struct dev_entry ata_hpt[] = { > Can be `static` now? Done File atapromise.c: https://review.coreboot.org/c/flashrom/+/52946/comment/ab22918c_11749cc0 PS4, Line 49: const struct dev_entry ata_promise[] = { > Can be `static` now? Done File atavia.c: https://review.coreboot.org/c/flashrom/+/52946/comment/a1167294_8c9eeba8 PS4, Line 51: const struct dev_entry ata_via[] = { > Can be `static` now? Done File ch341a_spi.c: https://review.coreboot.org/c/flashrom/+/52946/comment/0108468e_8fbbcaf4 PS4, Line 87: const struct dev_entry devs_ch341a_spi[] = { > Can be `static` now? Done File dediprog.c: https://review.coreboot.org/c/flashrom/+/52946/comment/4d44f8a0_6ba2b706 PS4, Line 155: const struct dev_entry devs_dediprog[] = { > Can be `static` now? Done File developerbox_spi.c: https://review.coreboot.org/c/flashrom/+/52946/comment/c28250bd_de2af3dd PS4, Line 58: const struct dev_entry devs_developerbox_spi[] = { > Can be `static` now? Done File digilent_spi.c: https://review.coreboot.org/c/flashrom/+/52946/comment/d8bfe321_94c17a30 PS4, Line 56: const struct dev_entry devs_digilent_spi[] = { > Can be `static` now? Done File drkaiser.c: https://review.coreboot.org/c/flashrom/+/52946/comment/fce682c7_e1d822c7 PS4, Line 32: const struct dev_entry drkaiser_pcidev[] = { > Can be `static` now? Done File ft2232_spi.c: https://review.coreboot.org/c/flashrom/+/52946/comment/fcf14a62_f777c625 PS4, Line 62: const struct dev_entry devs_ft2232spi[] = { > Can be `static` now? Done File gfxnvidia.c: https://review.coreboot.org/c/flashrom/+/52946/comment/ba042f64_c0060063 PS4, Line 33: const struct dev_entry gfx_nvidia[] = { > Can be `static` now? Done File it8212.c: https://review.coreboot.org/c/flashrom/+/52946/comment/218fbf0e_c25ec307 PS4, Line 26: const struct dev_entry devs_it8212[] = { > Can be `static` now? Done File nic3com.c: https://review.coreboot.org/c/flashrom/+/52946/comment/4bf1e651_9d192b39 PS4, Line 36: const struct dev_entry nics_3com[] = { > Can be `static` now? Done File nicintel.c: https://review.coreboot.org/c/flashrom/+/52946/comment/c1f1a379_04201650 PS4, Line 26: const struct dev_entry nics_intel[] = { > Can be `static` now? Done File nicintel_eeprom.c: https://review.coreboot.org/c/flashrom/+/52946/comment/d6456bb9_f0c37b70 PS4, Line 84: const struct dev_entry nics_intel_ee[] = { > Can be `static` now? Done File nicintel_spi.c: https://review.coreboot.org/c/flashrom/+/52946/comment/adec7d21_9226ad18 PS4, Line 80: const struct dev_entry nics_intel_spi[] = { > Can be `static` now? Done File nicnatsemi.c: https://review.coreboot.org/c/flashrom/+/52946/comment/d306993d_dd99d31f PS4, Line 30: const struct dev_entry nics_natsemi[] = { > Can be `static` now? Done File nicrealtek.c: https://review.coreboot.org/c/flashrom/+/52946/comment/df9b5205_a15807f6 PS4, Line 30: const struct dev_entry nics_realtek[] = { > Can be `static` now? Done File ogp_spi.c: https://review.coreboot.org/c/flashrom/+/52946/comment/f3fac3d4_0e31ff21 PS4, Line 46: const struct dev_entry ogp_spi[] = { > Can be `static` now? Done File pickit2_spi.c: https://review.coreboot.org/c/flashrom/+/52946/comment/f2520e6b_b9f60ec1 PS4, Line 49: const struct dev_entry devs_pickit2_spi[] = { > Can be `static` now? Done File raiden_debug_spi.c: https://review.coreboot.org/c/flashrom/+/52946/comment/5a31cb3b_35e4cfc7 PS4, Line 352: const struct dev_entry devs_raiden[] = { > Can be `static` now? Done File satamv.c: https://review.coreboot.org/c/flashrom/+/52946/comment/6df06434_8d46a601 PS4, Line 28: const struct dev_entry satas_mv[] = { > Can be `static` now? Done File satasii.c: https://review.coreboot.org/c/flashrom/+/52946/comment/60967fd9_16495133 PS4, Line 29: const struct dev_entry satas_sii[] = { > Can be `static` now? Done File stlinkv3_spi.c: https://review.coreboot.org/c/flashrom/+/52946/comment/80250276_9b85c4e6 PS4, Line 117: const struct dev_entry devs_stlinkv3_spi[] = { > Can be `static` now? Done File usbblaster_spi.c: https://review.coreboot.org/c/flashrom/+/52946/comment/c3f1a23c_773706d9 PS4, Line 48: const struct dev_entry devs_usbblasterspi[] = { > Can be `static` now? Done -- To view, visit https://review.coreboot.org/c/flashrom/+/52946 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3d02bd789f0299e936eb86819b3b15b5ea2bb921 Gerrit-Change-Number: 52946 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 08 Jun 2021 10:17:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer_table: convert entries to pointers
by Thomas Heijligen (Code Review) 08 Jun '21

08 Jun '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52945 ) Change subject: programmer_table: convert entries to pointers ...................................................................... Patch Set 4: (2 comments) File programmer.h: https://review.coreboot.org/c/flashrom/+/52945/comment/11cb082e_978b0fb1 PS3, Line 178: *programmer_table > The pointers should be const, nobody should be allowed to change them […] Done File programmer_table.c: https://review.coreboot.org/c/flashrom/+/52945/comment/84019f34_a1a62955 PS3, Line 477: *programmer_table > *const programmer_table Done -- To view, visit https://review.coreboot.org/c/flashrom/+/52945 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifbb0ee4db5a85b1cd2afeafe4dca838579f79878 Gerrit-Change-Number: 52945 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 08 Jun 2021 10:13:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer_table: convert entries to pointers
by Thomas Heijligen (Code Review) 08 Jun '21

08 Jun '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52945 ) Change subject: programmer_table: convert entries to pointers ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/52945/comment/5ea94fbc_c151efcd PS3, Line 8: > Please mention: […] Done File flashrom.c: https://review.coreboot.org/c/flashrom/+/52945/comment/5289bbdd_a9bd8d33 PS3, Line 1721: const struct programmer_entry *p = programmer_table[i]; > Please add a check `if (p == NULL)` right here. Done -- To view, visit https://review.coreboot.org/c/flashrom/+/52945 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ifbb0ee4db5a85b1cd2afeafe4dca838579f79878 Gerrit-Change-Number: 52945 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 08 Jun 2021 10:13:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer_table: move array content to an own file
by Thomas Heijligen (Code Review) 08 Jun '21

08 Jun '21

Attention is currently required from: Nico Huber. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52944 ) Change subject: programmer_table: move array content to an own file ...................................................................... Patch Set 4: (1 comment) File programmer_table.c: PS3: > New files need a license header. Just copy the one from `flashrom.c`, but […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/52944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8e6d704e845ee4152c8676dd19dff0934fff007b Gerrit-Change-Number: 52944 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 08 Jun 2021 09:57:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer_table: add table size constant
by Thomas Heijligen (Code Review) 08 Jun '21

08 Jun '21

Attention is currently required from: Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55116 ) Change subject: programmer_table: add table size constant ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/55116/comment/1ff260d3_8352f897 PS2, Line 8: > Maybe just one sentence about the intention: […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/55116 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Idacb4b7b0dd98af8bc7cbecf567d33daafb4b24d Gerrit-Change-Number: 55116 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 08 Jun 2021 09:56:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.c libflashrom.c: replace enum programmer with size_t
by Thomas Heijligen (Code Review) 08 Jun '21

08 Jun '21

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/55120 to look at the new patch set (#5). Change subject: flashrom.c libflashrom.c: replace enum programmer with size_t ...................................................................... flashrom.c libflashrom.c: replace enum programmer with size_t Using size_t since programmer_table_size uses ARRAY_SIZE which returns size_t. Change-Id: Id2ad9630fbc41e98d182768b553788e069fa5095 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M flashrom.c M libflashrom.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/20/55120/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/55120 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id2ad9630fbc41e98d182768b553788e069fa5095 Gerrit-Change-Number: 55120 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2021