June 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: libflashrom: remove flashrom_system_info
by Angel Pons (Code Review) 09 Jun '21

09 Jun '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55351 ) Change subject: libflashrom: remove flashrom_system_info ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/55351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iad805322aeead149a8d51ad8bf0babde2a12f01f Gerrit-Change-Number: 55351 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Wed, 09 Jun 2021 12:39:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add support for MACRONIX MX66L1G45G
by Angel Pons (Code Review) 09 Jun '21

09 Jun '21

Attention is currently required from: Nico Huber, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55353 ) Change subject: flashchips: Add support for MACRONIX MX66L1G45G ...................................................................... Patch Set 1: Code-Review+1 (6 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/55353/comment/d8aa1e69_343f41ff PS1, Line 7: MACRONIX nit: `Macronix` Patchset: PS1: I didn't look at a datasheet yet File flashchips.c: https://review.coreboot.org/c/flashrom/+/55353/comment/9ed5cee8_a5f432fa PS1, Line 10075: }, nit: flashchip entries are separated by a blank line https://review.coreboot.org/c/flashrom/+/55353/comment/8cb89df5_ec24e1d0 PS1, Line 10078: MACRONIX_ Drop this prefix? https://review.coreboot.org/c/flashrom/+/55353/comment/3c8c1355_ac42d184 PS1, Line 10117: MX25L12835F Hmmmmm... Smells like copy-pasta? https://review.coreboot.org/c/flashrom/+/55353/comment/0af9b43a_cc6a5983 PS1, Line 10123: }, same here, flashchip entries are separated by a blank line -- To view, visit https://review.coreboot.org/c/flashrom/+/55353 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I554e828c97d9ec77b08489573a34e176599d2518 Gerrit-Change-Number: 55353 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 09 Jun 2021 12:17:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add support for MACRONIX MX66L1G45G
by Patrick Rudolph (Code Review) 09 Jun '21

09 Jun '21

Attention is currently required from: Patrick Rudolph. Hello Patrick Rudolph, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/55353 to review the following change. Change subject: flashchips: Add support for MACRONIX MX66L1G45G ...................................................................... flashchips: Add support for MACRONIX MX66L1G45G Tested on Dediprog SF600: Reading and writing works. Change-Id: I554e828c97d9ec77b08489573a34e176599d2518 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M flashchips.c M flashchips.h 2 files changed, 49 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/53/55353/1 diff --git a/flashchips.c b/flashchips.c index 007bcc9..b1b0ef3 100644 --- a/flashchips.c +++ b/flashchips.c @@ -10073,7 +10073,54 @@ .read = spi_chip_read, /* Fast read (0x0B) supported */ .voltage = {2700, 3600}, }, - + { + .vendor = "Macronix", + .name = "MACRONIX_MX66L1G45G", + .bustype = BUS_SPI, + .manufacture_id = MACRONIX_ID, + .model_id = MACRONIX_MX66L1G45G, + .total_size = 131072, + .page_size = 256, + /* OTP: 512B total; enter 0xB1, exit 0xC1 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 32768} }, + .block_erase = spi_block_erase_21, + }, { + .eraseblocks = { {4 * 1024, 32768} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 4096} }, + .block_erase = spi_block_erase_5c, + }, { + .eraseblocks = { {32 * 1024, 4096} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 2048} }, + .block_erase = spi_block_erase_dc, + }, { + .eraseblocks = { {64 * 1024, 2048} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {128 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {128 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + /* TODO: security register and SBLK/SBULK; MX25L12835F: configuration register */ + .printlock = spi_prettyprint_status_register_bp3_srwd, /* bit6 is quad enable */ + .unlock = spi_disable_blockprotect_bp3_srwd, + .write = spi_chip_write_256, + .read = spi_chip_read, /* Fast read (0x0B) supported */ + .voltage = {2700, 3600}, + }, /* The ST M25P05 is a bit of a problem. It has the same ID as the * ST M25P05-A in RES mode, but supports only 128 byte writes instead * of 256 byte writes. We rely heavily on the fact that probe_spi_res1 diff --git a/flashchips.h b/flashchips.h index b6b75c8..346c6bf 100644 --- a/flashchips.h +++ b/flashchips.h @@ -511,6 +511,7 @@ #define MACRONIX_MX25L1635D 0x2415 #define MACRONIX_MX25L1635E 0x2515 /* MX25L1635{E} */ #define MACRONIX_MX66L51235F 0x201a /* MX66L51235F, MX25L51245G */ +#define MACRONIX_MX66L1G45G 0x201b /* MX66L1G45G */ #define MACRONIX_MX25U8032E 0x2534 #define MACRONIX_MX25U1635E 0x2535 #define MACRONIX_MX25U3235E 0x2536 /* Same as MX25U6435F */ -- To view, visit https://review.coreboot.org/c/flashrom/+/55353 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I554e828c97d9ec77b08489573a34e176599d2518 Gerrit-Change-Number: 55353 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: tests: Do not build a test if its driver is not built
by Nico Huber (Code Review) 09 Jun '21

09 Jun '21

Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55295 ) Change subject: tests: Do not build a test if its driver is not built ...................................................................... Patch Set 2: (1 comment) File tests/init_shutdown.c: https://review.coreboot.org/c/flashrom/+/55295/comment/9870b55d_72137b69 PS1, Line 35: #if CONFIG_DUMMY == 1 : void dummy_init_and_shutdown_test_success(void **state) : { : run_lifecycle(state, PROGRAMMER_DUMMY, "bus=parallel+lpc+fwh+spi"); : } : #endif /* CONFIG_DUMMY */ > Thank you for inspiration! now this looks much better, and only one file needs to have guards. […] Hmmm, this will change with Thomas' patch series. Instead of the enums we'd have references to the programmer structs. Maybe we'd have to enable linker garbage collection*, but then a C `if` should do. (*) I wouldn't want such advanced linker features for the flashrom program yet but for tests I see no reason to avoid it. -- To view, visit https://review.coreboot.org/c/flashrom/+/55295 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic1c48e41f658045a608f46636071f478ba646f77 Gerrit-Change-Number: 55295 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 09 Jun 2021 10:29:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: [RFC] Makefile: Deflate dependency handling
by Thomas Heijligen (Code Review) 09 Jun '21

09 Jun '21

Attention is currently required from: Edward O'Callaghan, Nico Huber. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52024 ) Change subject: [RFC] Makefile: Deflate dependency handling ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: > Thomas, you can take this over if you need more work ;) I don't know if I'm the right one for this. Makefiles are still magic to me. :o -- To view, visit https://review.coreboot.org/c/flashrom/+/52024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I33049474a95d288c9a84e412633c99fbc251ac03 Gerrit-Change-Number: 52024 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <edward.ocallaghan(a)koparo.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <edward.ocallaghan(a)koparo.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 09 Jun 2021 10:04:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: libflashrom: remove flashrom_system_info
by Thomas Heijligen (Code Review) 09 Jun '21

09 Jun '21

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/55351 ) Change subject: libflashrom: remove flashrom_system_info ...................................................................... libflashrom: remove flashrom_system_info void flashrom_system_info(void) has no implementation nor any relation to existing code. Change-Id: Iad805322aeead149a8d51ad8bf0babde2a12f01f Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M libflashrom.h M libflashrom.map 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/51/55351/1 diff --git a/libflashrom.h b/libflashrom.h index f2b3e46..eab78ad 100644 --- a/libflashrom.h +++ b/libflashrom.h @@ -75,7 +75,6 @@ }; const char *flashrom_version_info(void); -void flashrom_system_info(void); struct flashrom_flashchip_info *flashrom_supported_flash_chips(void); struct flashrom_board_info *flashrom_supported_boards(void); struct flashrom_chipset_info *flashrom_supported_chipsets(void); diff --git a/libflashrom.map b/libflashrom.map index 0c28a68..feb20f8 100644 --- a/libflashrom.map +++ b/libflashrom.map @@ -24,7 +24,6 @@ flashrom_programmer_shutdown; flashrom_set_log_callback; flashrom_shutdown; - flashrom_system_info; flashrom_version_info; local: *; }; -- To view, visit https://review.coreboot.org/c/flashrom/+/55351 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iad805322aeead149a8d51ad8bf0babde2a12f01f Gerrit-Change-Number: 55351 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: libflashrom: remove flashrom_supported_programmers
by Thomas Heijligen (Code Review) 09 Jun '21

09 Jun '21

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/55350 ) Change subject: libflashrom: remove flashrom_supported_programmers ...................................................................... libflashrom: remove flashrom_supported_programmers const char **flashrom_supported_programmers(void) returns an array of strings without returning the array size or making a NULL termination. This can lead to undefined behavior when iterate over the array. Change-Id: I0157926a654e337c14d840dd398e5576471c304f Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M libflashrom.c M libflashrom.h M libflashrom.map 3 files changed, 0 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/50/55350/1 diff --git a/libflashrom.c b/libflashrom.c index 23358c9..4a3ead6 100644 --- a/libflashrom.c +++ b/libflashrom.c @@ -114,26 +114,6 @@ } /** - * @brief Returns list of supported programmers - * @return List of supported programmers, or NULL if an error occurred - */ -const char **flashrom_supported_programmers(void) -{ - enum programmer p = 0; - const char **supported_programmers = malloc((PROGRAMMER_INVALID + 1) * sizeof(char*)); - - if (supported_programmers != NULL) { - for (; p < PROGRAMMER_INVALID; ++p) { - supported_programmers[p] = programmer_table[p].name; - } - } else { - msg_gerr("Memory allocation error!\n"); - } - - return supported_programmers; -} - -/** * @brief Returns list of supported flash chips * @return List of supported flash chips, or NULL if an error occurred */ diff --git a/libflashrom.h b/libflashrom.h index d0d5826..f2b3e46 100644 --- a/libflashrom.h +++ b/libflashrom.h @@ -76,7 +76,6 @@ const char *flashrom_version_info(void); void flashrom_system_info(void); -const char **flashrom_supported_programmers(void); struct flashrom_flashchip_info *flashrom_supported_flash_chips(void); struct flashrom_board_info *flashrom_supported_boards(void); struct flashrom_chipset_info *flashrom_supported_chipsets(void); diff --git a/libflashrom.map b/libflashrom.map index d6dd24d..0c28a68 100644 --- a/libflashrom.map +++ b/libflashrom.map @@ -24,7 +24,6 @@ flashrom_programmer_shutdown; flashrom_set_log_callback; flashrom_shutdown; - flashrom_supported_programmers; flashrom_system_info; flashrom_version_info; local: *; -- To view, visit https://review.coreboot.org/c/flashrom/+/55350 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0157926a654e337c14d840dd398e5576471c304f Gerrit-Change-Number: 55350 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: nic3com.c: Refactor singleton states into reentrant pattern
by Nico Huber (Code Review) 09 Jun '21

09 Jun '21

Attention is currently required from: Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55107 ) Change subject: nic3com.c: Refactor singleton states into reentrant pattern ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Patchset: PS2: > I added init_err_cleanup_exit label, so now there is a cleanup. […] Thanks. And right, would be bad to call it with a pointer to a local struct if it would try to free that ;) We can re-visit this once common code takes care of the `data` lifecycle. -- To view, visit https://review.coreboot.org/c/flashrom/+/55107 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9834b82650cd070556cf82207796bc6bd6b31b28 Gerrit-Change-Number: 55107 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 09 Jun 2021 09:57:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer_table: move each entry to the associated programmer source
by Nico Huber (Code Review) 09 Jun '21

09 Jun '21

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52946 ) Change subject: programmer_table: move each entry to the associated programmer source ...................................................................... Patch Set 8: (1 comment) File programmer.h: https://review.coreboot.org/c/flashrom/+/52946/comment/886e5942_562e3b6b PS4, Line 402: #if CONFIG_DUMMY == 1 > I thought, with the #if it would be no error: with the #if that line of code is not included and not […] No error in this code either way. My argument is purely theoretical; trying to explain when the #if would make a difference: when the #if's and/or the selection of programmer-driver .c files are out of sync. So, these are `extern` forward declarations. For the compiler, it's not an error to see such a declaration without the definition. Let's say we tell it to compile `programmer_table.c`. It would see the forward declarations here and would have to trust that things are defined in another compilation unit. If we would remove the #if and then tell it to build without dummy support, we would have a forward declaration that is never referenced (the #if in `programmer_ table.c` takes care of that). That's also not an error. But let's assume somebody would forget to place the #if in `programmer_table.c`. Then if we would have an #if here we'd get * a compiler error; it would complain about an unknown symbol, and without an #if here * (only) a linker error; the compiler would see a forward declaration and trust that the definition is in another compilation unit. So long story short, it only makes a difference if the code is broken elsewhere. And even then a negligible difference. -- To view, visit https://review.coreboot.org/c/flashrom/+/52946 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3d02bd789f0299e936eb86819b3b15b5ea2bb921 Gerrit-Change-Number: 52946 Gerrit-PatchSet: 8 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 09 Jun 2021 08:53:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Do not build a test if its driver is not built
by Anastasia Klimchuk (Code Review) 09 Jun '21

09 Jun '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55295 ) Change subject: tests: Do not build a test if its driver is not built ...................................................................... Patch Set 2: (1 comment) File tests/init_shutdown.c: https://review.coreboot.org/c/flashrom/+/55295/comment/37d416c3_fbf16b73 PS1, Line 35: #if CONFIG_DUMMY == 1 : void dummy_init_and_shutdown_test_success(void **state) : { : run_lifecycle(state, PROGRAMMER_DUMMY, "bus=parallel+lpc+fwh+spi"); : } : #endif /* CONFIG_DUMMY */ > or […] Thank you for inspiration! now this looks much better, and only one file needs to have guards. The reason I added #if is because when for example CONFIG_MEC1308=no then PROGRAMMER_MEC1308 does not exist and does not compile (because it is guarded by CONFIG_MEC1308, it would be "error: ‘PROGRAMMER_MEC1308’ undeclared"). PROGRAMMER_MEC1308 will change to &programmer_mec1308 after CB:55121 but still guarded. I am fine with empty test which runs and does nothing, but I want everything to build even if defaults are changed. -- To view, visit https://review.coreboot.org/c/flashrom/+/55295 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic1c48e41f658045a608f46636071f478ba646f77 Gerrit-Change-Number: 55295 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 09 Jun 2021 05:27:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2021