June 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: programmer: Introduce default shutdown function
by Anastasia Klimchuk (Code Review) 22 Jun '21

22 Jun '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/54890 to look at the new patch set (#4). Change subject: programmer: Introduce default shutdown function ...................................................................... programmer: Introduce default shutdown function Default shutdown function is only freeing master data (if data exists) and not doing anything else. There are five spi masters which can use default shutdown function (all included in this patch), and a lot of par masters that can benefit from it as well. BUG=b:185191942 TEST=builds Change-Id: I8b20717ba549e12edffbc5d1643ff064a4f0c517 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M flashrom.c M mcp6x_spi.c M nicintel_spi.c M ogp_spi.c M programmer.h M rayer_spi.c M usbblaster_spi.c 7 files changed, 12 insertions(+), 35 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/90/54890/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/54890 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8b20717ba549e12edffbc5d1643ff064a4f0c517 Gerrit-Change-Number: 54890 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashchips.c: Add 'GD25LQ128E' to match C and D variants
by Anastasia Klimchuk (Code Review) 22 Jun '21

22 Jun '21

Attention is currently required from: Edward O'Callaghan. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55742 ) Change subject: flashchips.c: Add 'GD25LQ128E' to match C and D variants ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/55742/comment/f9a2fce1_b3036dbc PS1, Line 9: defined by gigadevice Does this mean there is a gigadevice doc which defines C, D and E? -- To view, visit https://review.coreboot.org/c/flashrom/+/55742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3bef9386a185a0e8c54c125af5509b63540995aa Gerrit-Change-Number: 55742 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Tue, 22 Jun 2021 06:13:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Guard sys/io.h the same as in hwaccess_x86_io.h
by Anastasia Klimchuk (Code Review) 22 Jun '21

22 Jun '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55741 ) Change subject: tests: Guard sys/io.h the same as in hwaccess_x86_io.h ...................................................................... Patch Set 3: (3 comments) File hwaccess_x86_io_unittest.h: https://review.coreboot.org/c/flashrom/+/55741/comment/65a3a591_86d40b27 PS2, Line 32: > Why the guards are different? […] I moved these guards above, as you suggested. But I don't understand why you suggested different guards, not the ones that hwaccess_x86_io.h uses. Happy to change if needed, just want to understand why. Keeping this comment unresolved. https://review.coreboot.org/c/flashrom/+/55741/comment/bb6f6910_a43ec342 PS2, Line 41: #if IS_X86 && defined(__linux__) || defined(__GLIBC__) > For the `IS_x86`, don't guard #include stmt's as it adds a lot of cyclomatic complexity to the prepr […] Thanks to your comment! I found a problem in the first version of the patch... but because I also wrote the condition wrong (forgot the parentheses), it was "working by coincidence" :\ IS_X86 macro is not visible from here, it is not defined yet at the point of time when this header is included (means is it always false). So I copied its definition from platform.h, otherwise this comment is resolved. https://review.coreboot.org/c/flashrom/+/55741/comment/3f96566f_adb5f536 PS2, Line 53: > `#endif /* __i386__ || __x86_64__ */` see my other reply -- To view, visit https://review.coreboot.org/c/flashrom/+/55741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3f2f0408be7c00f954b899031b52b2b97ef19ca3 Gerrit-Change-Number: 55741 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 22 Jun 2021 04:48:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Guard sys/io.h the same as in hwaccess_x86_io.h
by Anastasia Klimchuk (Code Review) 22 Jun '21

22 Jun '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/55741 to look at the new patch set (#3). Change subject: tests: Guard sys/io.h the same as in hwaccess_x86_io.h ...................................................................... tests: Guard sys/io.h the same as in hwaccess_x86_io.h Inclusion of this header in hwaccess_x86_io.h is guarded by `defined(__linux__) || defined(__GLIBC__)` , in addition to that inclusion of hwaccess_x86_io.h into hwaccess.h is guarded by IS_X86. Combining these two together, this patch adds the same guards for unittest header file, so that test build don't break on non-x86. This is a follow up on commit 21e22ba8a7750f1cfe5cd3323e3137695ffef0a4 which introduced hwaccess_x86_io_unittest.h BUG=b:181803212 TEST=builds and ninja test on x86 Change-Id: I3f2f0408be7c00f954b899031b52b2b97ef19ca3 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M hwaccess_x86_io_unittest.h 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/41/55741/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/55741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3f2f0408be7c00f954b899031b52b2b97ef19ca3 Gerrit-Change-Number: 55741 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: flashchips.c: Add 'GD25LQ128E' to match C and D variants
by Nikolai Artemiev (Code Review) 22 Jun '21

22 Jun '21

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55742 ) Change subject: flashchips.c: Add 'GD25LQ128E' to match C and D variants ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/55742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3bef9386a185a0e8c54c125af5509b63540995aa Gerrit-Change-Number: 55742 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 22 Jun 2021 02:57:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Guard sys/io.h the same as in hwaccess_x86_io.h
by Anastasia Klimchuk (Code Review) 22 Jun '21

22 Jun '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55741 ) Change subject: tests: Guard sys/io.h the same as in hwaccess_x86_io.h ...................................................................... Patch Set 2: (1 comment) File hwaccess_x86_io_unittest.h: https://review.coreboot.org/c/flashrom/+/55741/comment/3d6e66da_7fdd5b17 PS2, Line 32: > `#if defined(__i386__) || defined(__x86_64__)` Why the guards are different? I used `defined(__linux__) || defined(__GLIBC__)` because this is used in hwaccess_x86_io.h The other one: `defined(__i386__) || defined(__x86_64__)` is used in mec1308 and ene_lpc files. -- To view, visit https://review.coreboot.org/c/flashrom/+/55741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3f2f0408be7c00f954b899031b52b2b97ef19ca3 Gerrit-Change-Number: 55741 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 22 Jun 2021 01:56:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips.c: Add 'GD25LQ128E' to match C and D variants
by Edward O'Callaghan (Code Review) 22 Jun '21

22 Jun '21

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/55742 ) Change subject: flashchips.c: Add 'GD25LQ128E' to match C and D variants ...................................................................... flashchips.c: Add 'GD25LQ128E' to match C and D variants As defined by gigadevice. C, D and E are all meant to be the same. BUG=b:185957191 BRANCH=none TEST=builds Change-Id: I3bef9386a185a0e8c54c125af5509b63540995aa Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/42/55742/1 diff --git a/flashchips.c b/flashchips.c index 6310c12..83f0f55 100644 --- a/flashchips.c +++ b/flashchips.c @@ -6310,7 +6310,7 @@ { .vendor = "GigaDevice", - .name = "GD25LQ128C/GD25LQ128D", + .name = "GD25LQ128C/GD25LQ128D/GD25LQ128E", .bustype = BUS_SPI, .manufacture_id = GIGADEVICE_ID, .model_id = GIGADEVICE_GD25LQ128CD, -- To view, visit https://review.coreboot.org/c/flashrom/+/55742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3bef9386a185a0e8c54c125af5509b63540995aa Gerrit-Change-Number: 55742 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: tests: Move test environment header files into tests directory
by Edward O'Callaghan (Code Review) 22 Jun '21

22 Jun '21

Attention is currently required from: Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55408 ) Change subject: tests: Move test environment header files into tests directory ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/55408 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia42773b98b1eb6c65241aa559c0c8b4926bd0814 Gerrit-Change-Number: 55408 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 22 Jun 2021 01:10:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Guard sys/io.h the same as in hwaccess_x86_io.h
by Edward O'Callaghan (Code Review) 22 Jun '21

22 Jun '21

Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55741 ) Change subject: tests: Guard sys/io.h the same as in hwaccess_x86_io.h ...................................................................... Patch Set 2: (3 comments) File hwaccess_x86_io_unittest.h: https://review.coreboot.org/c/flashrom/+/55741/comment/e0186702_8b9aac89 PS2, Line 32: `#if defined(__i386__) || defined(__x86_64__)` https://review.coreboot.org/c/flashrom/+/55741/comment/b7c2e725_667515f4 PS2, Line 41: #if IS_X86 && defined(__linux__) || defined(__GLIBC__) For the `IS_x86`, don't guard #include stmt's as it adds a lot of cyclomatic complexity to the preprocessor pass. Guarding #include's for multi-platform reasons maybe unavoidable. Simply guard the whole file as this only applies on platforms with ported io (i.e., x86). It will then evaluate as a empty include file, this lets the toolchain do its job. https://review.coreboot.org/c/flashrom/+/55741/comment/5b651461_2b77d16f PS2, Line 53: `#endif /* __i386__ || __x86_64__ */` -- To view, visit https://review.coreboot.org/c/flashrom/+/55741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3f2f0408be7c00f954b899031b52b2b97ef19ca3 Gerrit-Change-Number: 55741 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 22 Jun 2021 01:09:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Do not run a test if its driver is not built
by Anastasia Klimchuk (Code Review) 22 Jun '21

22 Jun '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55295 ) Change subject: tests: Do not run a test if its driver is not built ...................................................................... Patch Set 4: (1 comment) File tests/init_shutdown.c: https://review.coreboot.org/c/flashrom/+/55295/comment/cf8ae2b0_1fe729f6 PS1, Line 35: #if CONFIG_DUMMY == 1 : void dummy_init_and_shutdown_test_success(void **state) : { : run_lifecycle(state, PROGRAMMER_DUMMY, "bus=parallel+lpc+fwh+spi"); : } : #endif /* CONFIG_DUMMY */ > "yes"/"no" is only used on the user end. Both Meson and the Makefile always use […] I returned back to #if for now. But if it comes to changing meson.build at some point later, I am happy to change code here as well. -- To view, visit https://review.coreboot.org/c/flashrom/+/55295 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic1c48e41f658045a608f46636071f478ba646f77 Gerrit-Change-Number: 55295 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 22 Jun 2021 00:49:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2021