May 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: CHROMIUM: cli_classic.c: Remove deprecated options
by Angel Pons (Code Review) 05 May '21

05 May '21

Attention is currently required from: Daniel Campello. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52890 ) Change subject: CHROMIUM: cli_classic.c: Remove deprecated options ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/52890/comment/8ace210f_1b7b7b86 PS1, Line 7: cli_classic.c This file is not changed -- To view, visit https://review.coreboot.org/c/flashrom/+/52890 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib329f3adb59ce1848d1540844d64b968f49eb22a Gerrit-Change-Number: 52890 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Comment-Date: Wed, 05 May 2021 07:31:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: CHROMIUM: cli_classic.c: Remove deprecated options
by Angel Pons (Code Review) 05 May '21

05 May '21

Attention is currently required from: Daniel Campello. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52890 ) Change subject: CHROMIUM: cli_classic.c: Remove deprecated options ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/52890/comment/24fb9490_9f355401 PS1, Line 11: implicetely typo: implicitly -- To view, visit https://review.coreboot.org/c/flashrom/+/52890 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib329f3adb59ce1848d1540844d64b968f49eb22a Gerrit-Change-Number: 52890 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Comment-Date: Wed, 05 May 2021 07:31:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: CHROMIUM: cli_classic.c: Remove deprecated options
by Peter Marheine (Code Review) 05 May '21

05 May '21

Attention is currently required from: Daniel Campello. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52890 ) Change subject: CHROMIUM: cli_classic.c: Remove deprecated options ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Wouldn't that make it hard to link the Original CL to this one? I guess I could also add a BACKPORT: […] Yeah, I don't know if there's any relevant convention or guideline. If not leaving it as-is would be okay, but maybe somebody with more context than I do has an opinion. -- To view, visit https://review.coreboot.org/c/flashrom/+/52890 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib329f3adb59ce1848d1540844d64b968f49eb22a Gerrit-Change-Number: 52890 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Comment-Date: Wed, 05 May 2021 02:48:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Daniel Campello <campello(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: pickit2_spi.c: Refactor singleton states into reentrant pattern
by Edward O'Callaghan (Code Review) 05 May '21

05 May '21

Attention is currently required from: Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52774 ) Change subject: pickit2_spi.c: Refactor singleton states into reentrant pattern ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/52774 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibacc4738bee02c371c41583d321e0337128ad18a Gerrit-Change-Number: 52774 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 05 May 2021 01:54:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: CHROMIUM: cli_classic.c: Remove deprecated options
by Daniel Campello (Code Review) 05 May '21

05 May '21

Attention is currently required from: Peter Marheine. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52890 ) Change subject: CHROMIUM: cli_classic.c: Remove deprecated options ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > It's kind of weird that this doesn't include any diff on cli_classic. […] Wouldn't that make it hard to link the Original CL to this one? I guess I could also add a BACKPORT: tag if that is the convention here. -- To view, visit https://review.coreboot.org/c/flashrom/+/52890 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib329f3adb59ce1848d1540844d64b968f49eb22a Gerrit-Change-Number: 52890 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Wed, 05 May 2021 00:45:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: CHROMIUM: cli_classic.c: Remove deprecated options
by Peter Marheine (Code Review) 05 May '21

05 May '21

Attention is currently required from: Daniel Campello. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52890 ) Change subject: CHROMIUM: cli_classic.c: Remove deprecated options ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: It's kind of weird that this doesn't include any diff on cli_classic.c when the commit message says it changes that file- I guess that's because the options were already removed or never present in this tree? Would it make sense to change the commit message? -- To view, visit https://review.coreboot.org/c/flashrom/+/52890 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib329f3adb59ce1848d1540844d64b968f49eb22a Gerrit-Change-Number: 52890 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Comment-Date: Wed, 05 May 2021 00:13:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: CHROMIUM: cli_classic.c: Remove deprecated options
by Edward O'Callaghan (Code Review) 05 May '21

05 May '21

Attention is currently required from: Daniel Campello, Peter Marheine. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52890 ) Change subject: CHROMIUM: cli_classic.c: Remove deprecated options ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/52890 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib329f3adb59ce1848d1540844d64b968f49eb22a Gerrit-Change-Number: 52890 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Wed, 05 May 2021 00:11:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: CHROMIUM: flashrom_tester: Drop nix dependency
by Edward O'Callaghan (Code Review) 05 May '21

05 May '21

Attention is currently required from: Daniel Campello. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52889 ) Change subject: CHROMIUM: flashrom_tester: Drop nix dependency ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/52889 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iea61c65efb04da9cd0bc0bd85a34fc10912ea87b Gerrit-Change-Number: 52889 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Comment-Date: Wed, 05 May 2021 00:11:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: CHROMIUM: flashrom_tester: Drop nix dependency
by Peter Marheine (Code Review) 05 May '21

05 May '21

Attention is currently required from: Edward O'Callaghan. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52889 ) Change subject: CHROMIUM: flashrom_tester: Drop nix dependency ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/52889 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iea61c65efb04da9cd0bc0bd85a34fc10912ea87b Gerrit-Change-Number: 52889 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Wed, 05 May 2021 00:10:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashrom.8.tmpl: Add man entry for --extract
by Edward O'Callaghan (Code Review) 05 May '21

05 May '21

Attention is currently required from: Angel Pons, Daniel Campello. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52892 ) Change subject: flashrom.8.tmpl: Add man entry for --extract ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/52892 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icc068f5545b6f30ac390b7b815a31e2d61bf4789 Gerrit-Change-Number: 52892 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Comment-Date: Wed, 05 May 2021 00:03:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2021