Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/52958
to look at the new patch set (#2).
Change subject: buspirate_spi.c: Refactor singleton states into reentrant pattern
......................................................................
buspirate_spi.c: Refactor singleton states into reentrant pattern
Move global singleton states into a struct and store within
the spi_master data field for the life-time of the driver.
This is one of the steps on the way to move spi_master data
memory management behind the initialisation API, for more
context see other patches under the same topic "register_master_api".
BUG=b:185191942
TEST=builds
Change-Id: I418bbfff15fb126b042fbc9be09dbf59f4d243b8
Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org>
---
M buspirate_spi.c
1 file changed, 119 insertions(+), 104 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/58/52958/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/52958
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I418bbfff15fb126b042fbc9be09dbf59f4d243b8
Gerrit-Change-Number: 52958
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Richard Hughes, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Patrick Rudolph.
Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49643 )
Change subject: libflashrom: Return progress state to the library user
......................................................................
Patch Set 7:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/49643/comment/8d558e4a_6c8952a7
PS4, Line 9: Include test for the dummy spi25 device.
> If you could elaborate more on what this commit is doing, it would be great. […]
Done
Commit Message:
https://review.coreboot.org/c/flashrom/+/49643/comment/7ae0e13b_95194deb
PS6, Line 9: Projects using libflashrom like fwupd expect the user to wait for the operation
: to complete. To avoid the user thinking the process has "hung" or "got stuck"
: report back the progress complete of the erase, write and read operations
> That's good, thank you! One thing left, limit for commit message lines is 72 chars, look like this o […]
Done
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/49643/comment/142391fb_52ee526d
PS4, Line 113: private
> private from the libflashrom API, as in "internal" to the flashrom implementation. […]
Resolving
File lspcon_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/49643/comment/7afa6a45_7abc905b
PS5, Line 355: PAGE_SIZE
> LSPCON_PAGE_SIZE ? commit cbe8a39ece4c228ffb23736da3f477ef3b82358c
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/49643
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7197572bb7f19e3bdb2bde855d70a0f50fd3854c
Gerrit-Change-Number: 49643
Gerrit-PatchSet: 7
Gerrit-Owner: Richard Hughes <richard(a)hughsie.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Richard Hughes <hughsient(a)gmail.com>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Richard Hughes <richard(a)hughsie.com>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Wed, 05 May 2021 14:50:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org>
Comment-In-Reply-To: Daniel Campello <campello(a)chromium.org>
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Peter Marheine.
Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52890 )
Change subject: CHROMIUM: flashrom_tester: Remove --ignore-fmap option
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/52890/comment/701134a2_9a123a50
PS1, Line 7: cli_classic.c
> This file is not changed
Done
https://review.coreboot.org/c/flashrom/+/52890/comment/4118f9f8_dd41a6f4
PS1, Line 11: implicetely
> typo: implicitly
Done
Patchset:
PS1:
> Yeah, I don't know if there's any relevant convention or guideline. […]
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/52890
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib329f3adb59ce1848d1540844d64b968f49eb22a
Gerrit-Change-Number: 52890
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Campello <campello(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Comment-Date: Wed, 05 May 2021 14:47:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Daniel Campello <campello(a)chromium.org>
Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Daniel Campello.
Hello build bot (Jenkins), Edward O'Callaghan, Peter Marheine,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/52890
to look at the new patch set (#2).
Change subject: CHROMIUM: flashrom_tester: Remove --ignore-fmap option
......................................................................
CHROMIUM: flashrom_tester: Remove --ignore-fmap option
This change removes --ignore-fmap as this is implicitly computed based
on other supplied options by the user.
Original-Signed-off-by: Daniel Campello <campello(a)chromium.org>
Original-Cq-Depend: chromium:2854174, chrome-internal:3789445, chromium:2854014
Original-Change-Id: I841a56d8726644cedd7d616ddfd5656b92dd7e59
Original-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/…
Original-Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org>
(cherry picked from commit 2e2a5e449229e9c9604235a98b56e5dd29bf25cf)
Change-Id: Ib329f3adb59ce1848d1540844d64b968f49eb22a
---
M util/flashrom_tester/flashrom/src/cmd.rs
M util/flashrom_tester/flashrom/src/lib.rs
2 files changed, 3 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/90/52890/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/52890
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib329f3adb59ce1848d1540844d64b968f49eb22a
Gerrit-Change-Number: 52890
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Campello <campello(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Daniel Campello <campello(a)chromium.org>
Gerrit-MessageType: newpatchset
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51925 )
Change subject: [WIP] replace programmer enum with a pointer to programmer_entry
......................................................................
Patch Set 5:
(1 comment)
This change is ready for review.
Patchset:
PS5:
Makefile:
internal.c:173:5: error: no previous prototype for 'internal_init' [-Werror=missing-prototypes]
173 | int internal_init(void)
| ^~~~~~~~~~~~~
Meson runs without errors
Maybe the init function need to be static now
--
To view, visit https://review.coreboot.org/c/flashrom/+/51925
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7435ee2bb661e4f139034bb289b84ebd41e1e9e9
Gerrit-Change-Number: 51925
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Xiang Wang <wxjstz(a)126.com>
Gerrit-Comment-Date: Wed, 05 May 2021 14:24:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Thomas Heijligen.
Hello Nico Huber, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/51925
to look at the new patch set (#5).
Change subject: [WIP] replace programmer enum with a pointer to programmer_entry
......................................................................
[WIP] replace programmer enum with a pointer to programmer_entry
enum programmer was used as index to select a programmer_entry.
By replacing it with a direct pointer to an entry in the
programmer_table we removed the problem ob syncing the enum with the
table.
[FOLLOW UP]
Abstract the available programmer enumeration.
Move the struct programmer_enty to the programmers source
Change-Id: I7435ee2bb661e4f139034bb289b84ebd41e1e9e9
Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de>
---
M cli_classic.c
M flashrom.c
M libflashrom.c
M print.c
M print_wiki.c
M programmer.h
M tests/init_shutdown.c
7 files changed, 52 insertions(+), 179 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/25/51925/5
--
To view, visit https://review.coreboot.org/c/flashrom/+/51925
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7435ee2bb661e4f139034bb289b84ebd41e1e9e9
Gerrit-Change-Number: 51925
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Xiang Wang <wxjstz(a)126.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-MessageType: newpatchset