Attention is currently required from: Daniel Campello.
Hello build bot (Jenkins), Edward O'Callaghan, Peter Marheine,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/52890
to look at the new patch set (#2).
Change subject: CHROMIUM: flashrom_tester: Remove --ignore-fmap option
......................................................................
CHROMIUM: flashrom_tester: Remove --ignore-fmap option
This change removes --ignore-fmap as this is implicitly computed based
on other supplied options by the user.
Original-Signed-off-by: Daniel Campello <campello(a)chromium.org>
Original-Cq-Depend: chromium:2854174, chrome-internal:3789445, chromium:2854014
Original-Change-Id: I841a56d8726644cedd7d616ddfd5656b92dd7e59
Original-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/…
Original-Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org>
(cherry picked from commit 2e2a5e449229e9c9604235a98b56e5dd29bf25cf)
Change-Id: Ib329f3adb59ce1848d1540844d64b968f49eb22a
---
M util/flashrom_tester/flashrom/src/cmd.rs
M util/flashrom_tester/flashrom/src/lib.rs
2 files changed, 3 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/90/52890/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/52890
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib329f3adb59ce1848d1540844d64b968f49eb22a
Gerrit-Change-Number: 52890
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Campello <campello(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Daniel Campello <campello(a)chromium.org>
Gerrit-MessageType: newpatchset
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51925 )
Change subject: [WIP] replace programmer enum with a pointer to programmer_entry
......................................................................
Patch Set 5:
(1 comment)
This change is ready for review.
Patchset:
PS5:
Makefile:
internal.c:173:5: error: no previous prototype for 'internal_init' [-Werror=missing-prototypes]
173 | int internal_init(void)
| ^~~~~~~~~~~~~
Meson runs without errors
Maybe the init function need to be static now
--
To view, visit https://review.coreboot.org/c/flashrom/+/51925
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7435ee2bb661e4f139034bb289b84ebd41e1e9e9
Gerrit-Change-Number: 51925
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Xiang Wang <wxjstz(a)126.com>
Gerrit-Comment-Date: Wed, 05 May 2021 14:24:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Thomas Heijligen.
Hello Nico Huber, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/51925
to look at the new patch set (#5).
Change subject: [WIP] replace programmer enum with a pointer to programmer_entry
......................................................................
[WIP] replace programmer enum with a pointer to programmer_entry
enum programmer was used as index to select a programmer_entry.
By replacing it with a direct pointer to an entry in the
programmer_table we removed the problem ob syncing the enum with the
table.
[FOLLOW UP]
Abstract the available programmer enumeration.
Move the struct programmer_enty to the programmers source
Change-Id: I7435ee2bb661e4f139034bb289b84ebd41e1e9e9
Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de>
---
M cli_classic.c
M flashrom.c
M libflashrom.c
M print.c
M print_wiki.c
M programmer.h
M tests/init_shutdown.c
7 files changed, 52 insertions(+), 179 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/25/51925/5
--
To view, visit https://review.coreboot.org/c/flashrom/+/51925
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7435ee2bb661e4f139034bb289b84ebd41e1e9e9
Gerrit-Change-Number: 51925
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Xiang Wang <wxjstz(a)126.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Richard Hughes, Angel Pons, Patrick Rudolph.
Hello build bot (Jenkins), Edward O'Callaghan, Daniel Campello, Angel Pons, Anastasia Klimchuk, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/49643
to look at the new patch set (#7).
Change subject: libflashrom: Return progress state to the library user
......................................................................
libflashrom: Return progress state to the library user
Projects using libflashrom like fwupd expect the user to wait for the
operation to complete. To avoid the user thinking the process has
"hung" or "got stuck" report back the progress complete of the erase,
write and read operations.
Include a test for the dummy spi25 device.
Change-Id: I7197572bb7f19e3bdb2bde855d70a0f50fd3854c
Signed-off-by: Richard Hughes <richard(a)hughsie.com>
---
M 82802ab.c
M at45db.c
M cli_classic.c
M cli_output.c
M dediprog.c
M en29lv640b.c
M flash.h
M it87spi.c
M jedec.c
M libflashrom.c
M libflashrom.h
M linux_mtd.c
M lspcon_i2c_spi.c
M realtek_mst_i2c_spi.c
M spi.c
M spi25.c
M sst28sf040.c
M tests/spi25.c
M tests/tests.c
M tests/tests.h
20 files changed, 145 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/49643/7
--
To view, visit https://review.coreboot.org/c/flashrom/+/49643
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7197572bb7f19e3bdb2bde855d70a0f50fd3854c
Gerrit-Change-Number: 49643
Gerrit-PatchSet: 7
Gerrit-Owner: Richard Hughes <richard(a)hughsie.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Richard Hughes <hughsient(a)gmail.com>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Richard Hughes <richard(a)hughsie.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Daniel Campello.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52890 )
Change subject: CHROMIUM: cli_classic.c: Remove deprecated options
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/52890/comment/8ace210f_1b7b7b86
PS1, Line 7: cli_classic.c
This file is not changed
--
To view, visit https://review.coreboot.org/c/flashrom/+/52890
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib329f3adb59ce1848d1540844d64b968f49eb22a
Gerrit-Change-Number: 52890
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Campello <campello(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Daniel Campello <campello(a)chromium.org>
Gerrit-Comment-Date: Wed, 05 May 2021 07:31:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Daniel Campello.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52890 )
Change subject: CHROMIUM: cli_classic.c: Remove deprecated options
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Wouldn't that make it hard to link the Original CL to this one? I guess I could also add a BACKPORT: […]
Yeah, I don't know if there's any relevant convention or guideline. If not leaving it as-is would be okay, but maybe somebody with more context than I do has an opinion.
--
To view, visit https://review.coreboot.org/c/flashrom/+/52890
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib329f3adb59ce1848d1540844d64b968f49eb22a
Gerrit-Change-Number: 52890
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Campello <campello(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Daniel Campello <campello(a)chromium.org>
Gerrit-Comment-Date: Wed, 05 May 2021 02:48:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daniel Campello <campello(a)chromium.org>
Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-MessageType: comment