May 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: i2c_helper_linux: Clean up whitespace a bit
by Edward O'Callaghan (Code Review) 08 May '21

08 May '21

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/52828 ) Change subject: i2c_helper_linux: Clean up whitespace a bit ...................................................................... i2c_helper_linux: Clean up whitespace a bit Use tabs to indent code and drop an unnecessary newline. Change-Id: I8fe4a8b9213677e0d0bee9681abf94726c934cc6 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/52828 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M i2c_helper_linux.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved Anastasia Klimchuk: Looks good to me, but someone else must approve diff --git a/i2c_helper_linux.c b/i2c_helper_linux.c index 7744505..963c399 100644 --- a/i2c_helper_linux.c +++ b/i2c_helper_linux.c @@ -50,13 +50,12 @@ if (ret < 0) { msg_perr("Unable to set I2C slave address to 0x%02x: %s.\n", addr, strerror(errno)); i2c_close(fd); - return ret; + return ret; } return fd; } - int i2c_open(int bus, uint16_t addr, int force) { char dev[sizeof(I2C_DEV_PREFIX)] = {0}; -- To view, visit https://review.coreboot.org/c/flashrom/+/52828 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8fe4a8b9213677e0d0bee9681abf94726c934cc6 Gerrit-Change-Number: 52828 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: realtek_mst_i2c_spi: Add missing braces
by Edward O'Callaghan (Code Review) 08 May '21

08 May '21

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/52827 ) Change subject: realtek_mst_i2c_spi: Add missing braces ...................................................................... realtek_mst_i2c_spi: Add missing braces As per the coding style, if one branch of a conditional statement needs braces, all other branches need to have braces as well. Change-Id: I69b762391165177857e9331f79f54b01149cf339 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/52827 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> --- M realtek_mst_i2c_spi.c 1 file changed, 10 insertions(+), 8 deletions(-) Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved Peter Marheine: Looks good to me, but someone else must approve Anastasia Klimchuk: Looks good to me, but someone else must approve diff --git a/realtek_mst_i2c_spi.c b/realtek_mst_i2c_spi.c index ae79fdd..27bcb4a 100644 --- a/realtek_mst_i2c_spi.c +++ b/realtek_mst_i2c_spi.c @@ -476,30 +476,32 @@ reset_str = extract_programmer_param("reset-mcu"); if (reset_str) { - if (reset_str[0] == '1') + if (reset_str[0] == '1') { *reset = 1; - else if (reset_str[0] == '0') + } else if (reset_str[0] == '0') { *reset = 0; - else { + } else { msg_perr("%s: Incorrect param format, reset-mcu=1 or 0.\n", __func__); ret = SPI_GENERIC_ERROR; } - } else + } else { *reset = 0; /* Default behaviour is no MCU reset on tear-down. */ + } free(reset_str); isp_str = extract_programmer_param("enter-isp"); if (isp_str) { - if (isp_str[0] == '1') + if (isp_str[0] == '1') { *enter_isp = 1; - else if (isp_str[0] == '0') + } else if (isp_str[0] == '0') { *enter_isp = 0; - else { + } else { msg_perr("%s: Incorrect param format, enter-isp=1 or 0.\n", __func__); ret = SPI_GENERIC_ERROR; } - } else + } else { *enter_isp = 1; /* Default behaviour is enter ISP on setup. */ + } free(isp_str); _get_params_failed: -- To view, visit https://review.coreboot.org/c/flashrom/+/52827 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I69b762391165177857e9331f79f54b01149cf339 Gerrit-Change-Number: 52827 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: linux_mtd: move global state into programmer data field
by Nikolai Artemiev (Code Review) 08 May '21

08 May '21

Attention is currently required from: Anastasia Klimchuk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/53947 ) Change subject: linux_mtd: move global state into programmer data field ...................................................................... Patch Set 3: (1 comment) File linux_mtd.c: https://review.coreboot.org/c/flashrom/+/53947/comment/4b8dd90d_d3509340 PS2, Line 39: mtd_ > As a follow up patch the `mtd_` prefix could be dropped. https://review.coreboot.org/c/flashrom/+/53953 -- To view, visit https://review.coreboot.org/c/flashrom/+/53947 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5ce6900e4892ed5687cfddb245dfe5461a3e2e84 Gerrit-Change-Number: 53947 Gerrit-PatchSet: 3 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 09 May 2021 01:42:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: linux_mtd: drop 'mtd_' prefix from programmer data fields
by Nikolai Artemiev (Code Review) 08 May '21

08 May '21

Nikolai Artemiev has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/53953 ) Change subject: linux_mtd: drop 'mtd_' prefix from programmer data fields ...................................................................... linux_mtd: drop 'mtd_' prefix from programmer data fields BUG=b:161951062 BRANCH=none TEST=builds Change-Id: I2503c98e9111d1fecd911473f65eeea7031cfdc3 Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> --- M linux_mtd.c 1 file changed, 27 insertions(+), 27 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/53/53953/1 diff --git a/linux_mtd.c b/linux_mtd.c index cb2ddda..f92036f 100644 --- a/linux_mtd.c +++ b/linux_mtd.c @@ -33,13 +33,13 @@ struct linux_mtd_data { FILE *dev_fp; - int mtd_device_is_writeable; - int mtd_no_erase; + int device_is_writeable; + int no_erase; /* Size info is presented in bytes in sysfs. */ - unsigned long int mtd_total_size; - unsigned long int mtd_numeraseregions; + unsigned long int total_size; + unsigned long int numeraseregions; /* only valid if numeraseregions is 0 */ - unsigned long int mtd_erasesize; + unsigned long int erasesize; }; /* read a string from a sysfs file and sanitize it */ @@ -123,51 +123,51 @@ static int get_mtd_info(const char *sysfs_path, struct linux_mtd_data *data) { unsigned long int tmp; - char mtd_device_name[32]; + char device_name[32]; /* Flags */ if (read_sysfs_int(sysfs_path, "flags", &tmp)) return 1; if (tmp & MTD_WRITEABLE) { /* cache for later use by write function */ - data->mtd_device_is_writeable = 1; + data->device_is_writeable = 1; } if (tmp & MTD_NO_ERASE) { - data->mtd_no_erase = 1; + data->no_erase = 1; } /* Device name */ - if (read_sysfs_string(sysfs_path, "name", mtd_device_name, sizeof(mtd_device_name))) + if (read_sysfs_string(sysfs_path, "name", device_name, sizeof(device_name))) return 1; /* Total size */ - if (read_sysfs_int(sysfs_path, "size", &data->mtd_total_size)) + if (read_sysfs_int(sysfs_path, "size", &data->total_size)) return 1; - if (popcnt(data->mtd_total_size) != 1) { + if (popcnt(data->total_size) != 1) { msg_perr("MTD size is not a power of 2\n"); return 1; } /* Erase size */ - if (read_sysfs_int(sysfs_path, "erasesize", &data->mtd_erasesize)) + if (read_sysfs_int(sysfs_path, "erasesize", &data->erasesize)) return 1; - if (popcnt(data->mtd_erasesize) != 1) { + if (popcnt(data->erasesize) != 1) { msg_perr("MTD erase size is not a power of 2\n"); return 1; } /* Erase regions */ - if (read_sysfs_int(sysfs_path, "numeraseregions", &data->mtd_numeraseregions)) + if (read_sysfs_int(sysfs_path, "numeraseregions", &data->numeraseregions)) return 1; - if (data->mtd_numeraseregions != 0) { + if (data->numeraseregions != 0) { msg_perr("Non-uniform eraseblock size is unsupported.\n"); return 1; } msg_pdbg("%s: device_name: \"%s\", is_writeable: %d, " "numeraseregions: %lu, total_size: %lu, erasesize: %lu\n", - __func__, mtd_device_name, data->mtd_device_is_writeable, - data->mtd_numeraseregions, data->mtd_total_size, data->mtd_erasesize); + __func__, device_name, data->device_is_writeable, + data->numeraseregions, data->total_size, data->erasesize); return 0; } @@ -176,13 +176,13 @@ { struct linux_mtd_data *data = flash->mst->opaque.data; - if (data->mtd_no_erase) + if (data->no_erase) flash->chip->feature_bits |= FEATURE_NO_ERASE; flash->chip->tested = TEST_OK_PREW; - flash->chip->total_size = data->mtd_total_size / 1024; /* bytes -> kB */ - flash->chip->block_erasers[0].eraseblocks[0].size = data->mtd_erasesize; + flash->chip->total_size = data->total_size / 1024; /* bytes -> kB */ + flash->chip->block_erasers[0].eraseblocks[0].size = data->erasesize; flash->chip->block_erasers[0].eraseblocks[0].count = - data->mtd_total_size / data->mtd_erasesize; + data->total_size / data->erasesize; return 1; } @@ -227,7 +227,7 @@ unsigned int chunksize = flash->chip->block_erasers[0].eraseblocks[0].size; unsigned int i; - if (!data->mtd_device_is_writeable) + if (!data->device_is_writeable) return 1; if (fseek(data->dev_fp, start, SEEK_SET) != 0) { @@ -267,23 +267,23 @@ struct linux_mtd_data *data = flash->mst->opaque.data; uint32_t u; - if (data->mtd_no_erase) { + if (data->no_erase) { msg_perr("%s: device does not support erasing. Please file a " "bug report at flashrom(a)flashrom.org\n", __func__); return 1; } - if (data->mtd_numeraseregions != 0) { + if (data->numeraseregions != 0) { /* TODO: Support non-uniform eraseblock size using use MEMGETREGIONCOUNT/MEMGETREGIONINFO ioctls */ - msg_perr("%s: mtd_numeraseregions must be 0\n", __func__); + msg_perr("%s: numeraseregions must be 0\n", __func__); return 1; } - for (u = 0; u < len; u += data->mtd_erasesize) { + for (u = 0; u < len; u += data->erasesize) { struct erase_info_user erase_info = { .start = start + u, - .length = data->mtd_erasesize, + .length = data->erasesize, }; if (ioctl(fileno(data->dev_fp), MEMERASE, &erase_info) == -1) { -- To view, visit https://review.coreboot.org/c/flashrom/+/53953 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2503c98e9111d1fecd911473f65eeea7031cfdc3 Gerrit-Change-Number: 53953 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: linux_mtd: move global state into programmer data field
by Nikolai Artemiev (Code Review) 08 May '21

08 May '21

Attention is currently required from: Nikolai Artemiev, Anastasia Klimchuk. Hello build bot (Jenkins), Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/53947 to look at the new patch set (#3). Change subject: linux_mtd: move global state into programmer data field ...................................................................... linux_mtd: move global state into programmer data field BUG=b:161951062 BRANCH=none TEST=builds, reading /dev/mtd0 on Oak succeeds Change-Id: I5ce6900e4892ed5687cfddb245dfe5461a3e2e84 Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> --- M linux_mtd.c 1 file changed, 65 insertions(+), 45 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/53947/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/53947 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5ce6900e4892ed5687cfddb245dfe5461a3e2e84 Gerrit-Change-Number: 53947 Gerrit-PatchSet: 3 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: WIP: Allow opaque programmers to provide status register access
by Angel Pons (Code Review) 08 May '21

08 May '21

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/53948 ) Change subject: WIP: Allow opaque programmers to provide status register access ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/53948/comment/b6fa4ec8_8e585a00 PS1, Line 11: Currently used by ichspi in cros flashrom. It would be nice to see how this interface gets used. As the change says WIP, I imagine there's follow-ups to be pushed. -- To view, visit https://review.coreboot.org/c/flashrom/+/53948 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I11a03c84363ec68a8edcbb9b10c7ca115e222fe0 Gerrit-Change-Number: 53948 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Sat, 08 May 2021 12:23:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: linux_mtd: move global state into programmer data field
by Edward O'Callaghan (Code Review) 08 May '21

08 May '21

Attention is currently required from: Nikolai Artemiev, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/53947 ) Change subject: linux_mtd: move global state into programmer data field ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File linux_mtd.c: https://review.coreboot.org/c/flashrom/+/53947/comment/f61dde2b_81878930 PS2, Line 39: mtd_ As a follow up patch the `mtd_` prefix could be dropped. -- To view, visit https://review.coreboot.org/c/flashrom/+/53947 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5ce6900e4892ed5687cfddb245dfe5461a3e2e84 Gerrit-Change-Number: 53947 Gerrit-PatchSet: 2 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 08 May 2021 12:22:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: WIP: Allow opaque programmers to provide status register access
by Nikolai Artemiev (Code Review) 08 May '21

08 May '21

Nikolai Artemiev has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/53948 ) Change subject: WIP: Allow opaque programmers to provide status register access ...................................................................... WIP: Allow opaque programmers to provide status register access This framework allows opaque programmers to expose read/write access to the status register and a function for checking if accesses to a given ranges are valid. Currently used by ichspi in cros flashrom. Change-Id: I11a03c84363ec68a8edcbb9b10c7ca115e222fe0 Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> --- M chipdrivers.h M flash.h M flashchips.c M opaque.c M programmer.h 5 files changed, 32 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/48/53948/1 diff --git a/chipdrivers.h b/chipdrivers.h index e1d6aa9..ccab841 100644 --- a/chipdrivers.h +++ b/chipdrivers.h @@ -113,6 +113,9 @@ int read_opaque(struct flashctx *flash, uint8_t *buf, unsigned int start, unsigned int len); int write_opaque(struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len); int erase_opaque(struct flashctx *flash, unsigned int blockaddr, unsigned int blocklen); +uint8_t read_status_opaque(const struct flashctx *flash); +int write_status_opaque(const struct flashctx *flash, int status); +int check_access_opaque(const struct flashctx *flash, unsigned int start, unsigned int len, int read); /* at45db.c */ int probe_spi_at45db(struct flashctx *flash); diff --git a/flash.h b/flash.h index dd8e156..99f3cd1 100644 --- a/flash.h +++ b/flash.h @@ -238,6 +238,7 @@ int (*read) (struct flashctx *flash, uint8_t *buf, unsigned int start, unsigned int len); uint8_t (*read_status) (const struct flashctx *flash); int (*write_status) (const struct flashctx *flash, int status); + int (*check_access) (const struct flashctx *flash, unsigned int start, unsigned int len, int read); struct voltage { uint16_t min; uint16_t max; diff --git a/flashchips.c b/flashchips.c index 6482f67..fa5da48 100644 --- a/flashchips.c +++ b/flashchips.c @@ -19424,6 +19424,10 @@ }, .write = write_opaque, .read = read_opaque, + .read_status = read_status_opaque, + .write_status = write_status_opaque, + .check_access = check_access_opaque, + .unlock = &spi_disable_blockprotect, }, { diff --git a/opaque.c b/opaque.c index e3103c8..7a19512 100644 --- a/opaque.c +++ b/opaque.c @@ -46,6 +46,27 @@ return flash->mst->opaque.erase(flash, blockaddr, blocklen); } +uint8_t read_status_opaque(const struct flashctx *flash) +{ + if (flash->mst->opaque.read_status) + return flash->mst->opaque.read_status(flash); + return 1; +} + +int write_status_opaque(const struct flashctx *flash, int status) +{ + if (flash->mst->opaque.write_status) + return flash->mst->opaque.write_status(flash, status); + return 1; +} + +int check_access_opaque(const struct flashctx *flash, unsigned int start, unsigned int len, int rw) +{ + if (flash->mst->opaque.check_access) + return flash->mst->opaque.check_access(flash, start, len, rw); + return 0; +} + int register_opaque_master(const struct opaque_master *mst) { struct registered_master rmst = {0}; diff --git a/programmer.h b/programmer.h index 675a259..2e56766 100644 --- a/programmer.h +++ b/programmer.h @@ -722,6 +722,9 @@ int (*read) (struct flashctx *flash, uint8_t *buf, unsigned int start, unsigned int len); int (*write) (struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len); int (*erase) (struct flashctx *flash, unsigned int blockaddr, unsigned int blocklen); + uint8_t (*read_status) (const struct flashctx *flash); + int (*write_status) (const struct flashctx *flash, int status); + int (*check_access) (const struct flashctx *flash, unsigned int start, unsigned int len, int read); void *data; }; int register_opaque_master(const struct opaque_master *mst); -- To view, visit https://review.coreboot.org/c/flashrom/+/53948 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I11a03c84363ec68a8edcbb9b10c7ca115e222fe0 Gerrit-Change-Number: 53948 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: linux_mtd: move global state into programmer data field
by Angel Pons (Code Review) 08 May '21

08 May '21

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/53947 ) Change subject: linux_mtd: move global state into programmer data field ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/53947 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5ce6900e4892ed5687cfddb245dfe5461a3e2e84 Gerrit-Change-Number: 53947 Gerrit-PatchSet: 2 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 08 May 2021 12:00:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: linux_mtd: move global state into programmer data field
by Nikolai Artemiev (Code Review) 08 May '21

08 May '21

Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/53947 ) Change subject: linux_mtd: move global state into programmer data field ...................................................................... Patch Set 2: (1 comment) File linux_mtd.c: https://review.coreboot.org/c/flashrom/+/53947/comment/c464c8ae_76e843f7 PS1, Line 411: if > missing a space between `if` and opening brace Done -- To view, visit https://review.coreboot.org/c/flashrom/+/53947 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5ce6900e4892ed5687cfddb245dfe5461a3e2e84 Gerrit-Change-Number: 53947 Gerrit-PatchSet: 2 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 08 May 2021 11:46:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2021