May 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: realtek_mst_i2c_spi.c: Rename `PAGE_SIZE` macro
by Angel Pons (Code Review) 10 May '21

10 May '21

Attention is currently required from: Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/53998 ) Change subject: realtek_mst_i2c_spi.c: Rename `PAGE_SIZE` macro ...................................................................... Patch Set 2: (1 comment) File realtek_mst_i2c_spi.c: https://review.coreboot.org/c/flashrom/+/53998/comment/6395cf2c_99949527 PS1, Line 31: REALTEK > Can we use RTK? They didn't like their name in the source.. Huh, sure -- To view, visit https://review.coreboot.org/c/flashrom/+/53998 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I043e3d8c2d2498e94b5e7577a7378c8c3e0e6c81 Gerrit-Change-Number: 53998 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Mon, 10 May 2021 08:16:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: linux_mtd: drop 'mtd_' prefix from variable/field names
by Angel Pons (Code Review) 10 May '21

10 May '21

Attention is currently required from: Nikolai Artemiev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/53953 ) Change subject: linux_mtd: drop 'mtd_' prefix from variable/field names ...................................................................... Patch Set 3: (1 comment) File linux_mtd.c: https://review.coreboot.org/c/flashrom/+/53953/comment/aa90091a_ab2575f1 PS1, Line 126: device_name > I actually noticed it at the time but thought it was similar enough to include with the other change […] Sounds good to me -- To view, visit https://review.coreboot.org/c/flashrom/+/53953 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2503c98e9111d1fecd911473f65eeea7031cfdc3 Gerrit-Change-Number: 53953 Gerrit-PatchSet: 3 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 10 May 2021 08:07:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: linux_mtd: move global state into programmer data field
by Angel Pons (Code Review) 10 May '21

10 May '21

Attention is currently required from: Nikolai Artemiev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/53947 ) Change subject: linux_mtd: move global state into programmer data field ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/53947 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5ce6900e4892ed5687cfddb245dfe5461a3e2e84 Gerrit-Change-Number: 53947 Gerrit-PatchSet: 4 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 10 May 2021 08:06:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips.c: add support for W25Q32JW..IM
by Angel Pons (Code Review) 10 May '21

10 May '21

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/53946 ) Change subject: flashchips.c: add support for W25Q32JW..IM ...................................................................... Patch Set 4: Code-Review+2 (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/53946/comment/89727a93_6b042a0b PS1, Line 17583: ..IM > This only works with `..IM` chips; there are other variants such as `W25Q32JW.. […] Ah, I see the datasheet now. Looks like IQ variants operate in Quad SPI mode by default: https://imgur.com/Xf4FLIv.png ID 0x6016 is already supported, but I'm worried now: it seems to be shared between V (3.3V) and W (1.8V) parts. This can be a problem if someone relies on voltage values in flashchips entries. -- To view, visit https://review.coreboot.org/c/flashrom/+/53946 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7425e12658dd69c4ec8d3309dd591d09a935bb4d Gerrit-Change-Number: 53946 Gerrit-PatchSet: 4 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 10 May 2021 08:03:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: linux_mtd: drop 'mtd_' prefix from variable/field names
by Nikolai Artemiev (Code Review) 10 May '21

10 May '21

Attention is currently required from: Angel Pons. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/53953 ) Change subject: linux_mtd: drop 'mtd_' prefix from variable/field names ...................................................................... Patch Set 3: (1 comment) File linux_mtd.c: https://review.coreboot.org/c/flashrom/+/53953/comment/25961418_56366771 PS1, Line 126: device_name > agree, probably shouldn't be conflated in this change. […] I actually noticed it at the time but thought it was similar enough to include with the other changes. I forgot to write a sufficiently generic commit message though; I've changed it now. -- To view, visit https://review.coreboot.org/c/flashrom/+/53953 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2503c98e9111d1fecd911473f65eeea7031cfdc3 Gerrit-Change-Number: 53953 Gerrit-PatchSet: 3 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 10 May 2021 07:04:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: linux_mtd: drop 'mtd_' prefix from variable/field names
by Nikolai Artemiev (Code Review) 10 May '21

10 May '21

Attention is currently required from: Angel Pons, Nikolai Artemiev. Hello build bot (Jenkins), Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/53953 to look at the new patch set (#3). Change subject: linux_mtd: drop 'mtd_' prefix from variable/field names ...................................................................... linux_mtd: drop 'mtd_' prefix from variable/field names BUG=b:161951062 BRANCH=none TEST=builds Change-Id: I2503c98e9111d1fecd911473f65eeea7031cfdc3 Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> --- M linux_mtd.c 1 file changed, 27 insertions(+), 27 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/53/53953/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/53953 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2503c98e9111d1fecd911473f65eeea7031cfdc3 Gerrit-Change-Number: 53953 Gerrit-PatchSet: 3 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: linux_mtd: drop 'mtd_' prefix from variable names
by Nikolai Artemiev (Code Review) 10 May '21

10 May '21

Attention is currently required from: Angel Pons, Nikolai Artemiev. Hello build bot (Jenkins), Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/53953 to look at the new patch set (#2). Change subject: linux_mtd: drop 'mtd_' prefix from variable names ...................................................................... linux_mtd: drop 'mtd_' prefix from variable names BUG=b:161951062 BRANCH=none TEST=builds Change-Id: I2503c98e9111d1fecd911473f65eeea7031cfdc3 Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> --- M linux_mtd.c 1 file changed, 27 insertions(+), 27 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/53/53953/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/53953 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2503c98e9111d1fecd911473f65eeea7031cfdc3 Gerrit-Change-Number: 53953 Gerrit-PatchSet: 2 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: realtek_mst_i2c_spi.c: Rename `PAGE_SIZE` macro
by Edward O'Callaghan (Code Review) 09 May '21

09 May '21

Attention is currently required from: Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/53998 ) Change subject: realtek_mst_i2c_spi.c: Rename `PAGE_SIZE` macro ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/53998 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I043e3d8c2d2498e94b5e7577a7378c8c3e0e6c81 Gerrit-Change-Number: 53998 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 10 May 2021 04:03:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: linux_mtd: drop 'mtd_' prefix from programmer data fields
by Edward O'Callaghan (Code Review) 09 May '21

09 May '21

Attention is currently required from: Angel Pons, Nikolai Artemiev. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/53953 ) Change subject: linux_mtd: drop 'mtd_' prefix from programmer data fields ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File linux_mtd.c: https://review.coreboot.org/c/flashrom/+/53953/comment/b9369dd9_7e42eb09 PS1, Line 126: device_name > Strictly speaking, this isn't a programmer data field. I don't really care, though. agree, probably shouldn't be conflated in this change. I suspect you ran a s/mtd_//g across the file and missed this one? Not a huge deal either way. -- To view, visit https://review.coreboot.org/c/flashrom/+/53953 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2503c98e9111d1fecd911473f65eeea7031cfdc3 Gerrit-Change-Number: 53953 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Mon, 10 May 2021 03:41:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: realtek_mst_i2c_spi.c: Rename `PAGE_SIZE` macro
by Edward O'Callaghan (Code Review) 09 May '21

09 May '21

Attention is currently required from: Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/53998 ) Change subject: realtek_mst_i2c_spi.c: Rename `PAGE_SIZE` macro ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File realtek_mst_i2c_spi.c: https://review.coreboot.org/c/flashrom/+/53998/comment/fc706d2d_6d1962d7 PS1, Line 31: REALTEK Can we use RTK? They didn't like their name in the source.. -- To view, visit https://review.coreboot.org/c/flashrom/+/53998 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I043e3d8c2d2498e94b5e7577a7378c8c3e0e6c81 Gerrit-Change-Number: 53998 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 10 May 2021 03:35:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2021