May 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: stlinkv3_spi.c: Cleanup properly on all init error paths
by Anastasia Klimchuk (Code Review) 12 May '21

12 May '21

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/54190 ) Change subject: stlinkv3_spi.c: Cleanup properly on all init error paths ...................................................................... stlinkv3_spi.c: Cleanup properly on all init error paths Do a cleanup: close handle and exit usb context in cases when init fails. If register_spi_master() fails, going to err_exit cleanup is not needed because at that point shutdown function has already been registered and it does the job. BUG=b:185191942 TEST=builds Change-Id: I9fabf48068635593bc86006c9642d8569eee8447 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M stlinkv3_spi.c 1 file changed, 7 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/90/54190/1 diff --git a/stlinkv3_spi.c b/stlinkv3_spi.c index 7e8336e..110e97c 100644 --- a/stlinkv3_spi.c +++ b/stlinkv3_spi.c @@ -464,6 +464,7 @@ char *speed_str = NULL; char *serialno = NULL; char *endptr = NULL; + int ret = 1; libusb_init(&usb_ctx); if (!usb_ctx) { @@ -498,7 +499,8 @@ msg_perr("Please pass the parameter " "with a simple non-zero number in kHz\n"); free(speed_str); - return -1; + ret = -1; + goto err_exit; } free(speed_str); } @@ -510,11 +512,13 @@ goto err_exit; if (register_spi_master(&spi_programmer_stlinkv3)) - goto err_exit; + return 1; /* shutdown function does cleanup */ return 0; err_exit: + if (stlinkv3_handle) + libusb_close(stlinkv3_handle); libusb_exit(usb_ctx); - return 1; + return ret; } -- To view, visit https://review.coreboot.org/c/flashrom/+/54190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9fabf48068635593bc86006c9642d8569eee8447 Gerrit-Change-Number: 54190 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: programmer: Smoothen register_opaque_master() API
by Anastasia Klimchuk (Code Review) 12 May '21

12 May '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54170 ) Change subject: programmer: Smoothen register_opaque_master() API ...................................................................... Patch Set 1: (1 comment) File nicintel_eeprom.c: https://review.coreboot.org/c/flashrom/+/54170/comment/f6061d13_08916697 PS1, Line 489: return register_opaque_master(&opaque_master_nicintel_ee_82580, NULL); My comment here: this has a piece of data (eecp), but the data was only passed to register_shutdown, and was not passed to register_opaque_master via opaque_master struct. Opaque master struct was const, and it stays const. -- To view, visit https://review.coreboot.org/c/flashrom/+/54170 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id3adb4cf04ae04dbe87ddb96f30871cb5f7c8ff0 Gerrit-Change-Number: 54170 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 13 May 2021 03:29:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer: Smoothen register_par_master API
by Anastasia Klimchuk (Code Review) 12 May '21

12 May '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54169 ) Change subject: programmer: Smoothen register_par_master API ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This needs to wait for CB:54066 chain to be submitted first. -- To view, visit https://review.coreboot.org/c/flashrom/+/54169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I95bc92f6c54c5bcdac1c522ca87054aaffed0f40 Gerrit-Change-Number: 54169 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 13 May 2021 03:24:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer: Make use of new register_par_master() API
by Anastasia Klimchuk (Code Review) 12 May '21

12 May '21

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/54172 ) Change subject: programmer: Make use of new register_par_master() API ...................................................................... programmer: Make use of new register_par_master() API Pass pointers to dynamically allocated data to register_par_master(). This way we can avoid some mutable globals. BUG=b:185191942 TEST=builds Change-Id: I76572e43d01f8a5e1aa73b1b9e8a187465ed8fef Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M dummyflasher.c 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/72/54172/1 diff --git a/dummyflasher.c b/dummyflasher.c index 1455d30..c9c68d0 100644 --- a/dummyflasher.c +++ b/dummyflasher.c @@ -622,7 +622,7 @@ .write_aai = default_spi_write_aai, }; -static struct par_master par_master_dummy = { +static const struct par_master par_master_dummy = { .chip_readb = dummy_chip_readb, .chip_readw = dummy_chip_readw, .chip_readl = dummy_chip_readl, @@ -675,7 +675,6 @@ data->emu_chip = EMULATE_NONE; data->delay_us = 0; spi_master_dummyflasher.data = data; - par_master_dummy.data = data; msg_pspew("%s\n", __func__); @@ -1029,7 +1028,7 @@ if (dummy_buses_supported & (BUS_PARALLEL | BUS_LPC | BUS_FWH)) register_par_master(&par_master_dummy, dummy_buses_supported & (BUS_PARALLEL | BUS_LPC | BUS_FWH), - NULL); + data); if (dummy_buses_supported & BUS_SPI) register_spi_master(&spi_master_dummyflasher); -- To view, visit https://review.coreboot.org/c/flashrom/+/54172 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I76572e43d01f8a5e1aa73b1b9e8a187465ed8fef Gerrit-Change-Number: 54172 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: programmer: Make use of new register_opaque_master() API
by Anastasia Klimchuk (Code Review) 12 May '21

12 May '21

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/54171 ) Change subject: programmer: Make use of new register_opaque_master() API ...................................................................... programmer: Make use of new register_opaque_master() API Pass pointers to dynamically allocated data to register_opaque_master(). This way we can avoid some mutable globals. BUG=b:185191942 TEST=builds Change-Id: I160810cd67f782131962e96fc6d20e2987fb0390 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M linux_mtd.c 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/71/54171/1 diff --git a/linux_mtd.c b/linux_mtd.c index aeaecce..a1af069 100644 --- a/linux_mtd.c +++ b/linux_mtd.c @@ -295,7 +295,7 @@ return 0; } -static struct opaque_master programmer_linux_mtd = { +static const struct opaque_master programmer_linux_mtd = { /* max_data_{read,write} don't have any effect for this programmer */ .max_data_read = MAX_DATA_UNSPECIFIED, .max_data_write = MAX_DATA_UNSPECIFIED, @@ -418,13 +418,12 @@ goto linux_mtd_init_exit; } - programmer_linux_mtd.data = data; if (register_shutdown(linux_mtd_shutdown, (void *)data)) { free(data); goto linux_mtd_init_exit; } - register_opaque_master(&programmer_linux_mtd, NULL); + register_opaque_master(&programmer_linux_mtd, data); ret = 0; linux_mtd_init_exit: -- To view, visit https://review.coreboot.org/c/flashrom/+/54171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I160810cd67f782131962e96fc6d20e2987fb0390 Gerrit-Change-Number: 54171 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: programmer: Smoothen register_opaque_master() API
by Anastasia Klimchuk (Code Review) 12 May '21

12 May '21

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/54170 ) Change subject: programmer: Smoothen register_opaque_master() API ...................................................................... programmer: Smoothen register_opaque_master() API It was impossible to register a const struct opaque_master that would point to dynamically allocated `data`. Fix that so that we won't have to create more mutable globals. BUG=b:185191942 TEST=builds Change-Id: Id3adb4cf04ae04dbe87ddb96f30871cb5f7c8ff0 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M ichspi.c M linux_mtd.c M nicintel_eeprom.c M opaque.c M programmer.h 5 files changed, 8 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/70/54170/1 diff --git a/ichspi.c b/ichspi.c index e45b39a..2583962 100644 --- a/ichspi.c +++ b/ichspi.c @@ -2039,7 +2039,7 @@ } hwseq_data.size_comp1 = tmpi; - register_opaque_master(&opaque_master_ich_hwseq); + register_opaque_master(&opaque_master_ich_hwseq, NULL); } else { register_spi_master(&spi_master_ich9); } diff --git a/linux_mtd.c b/linux_mtd.c index 0f7ac7e..aeaecce 100644 --- a/linux_mtd.c +++ b/linux_mtd.c @@ -424,7 +424,7 @@ goto linux_mtd_init_exit; } - register_opaque_master(&programmer_linux_mtd); + register_opaque_master(&programmer_linux_mtd, NULL); ret = 0; linux_mtd_init_exit: diff --git a/nicintel_eeprom.c b/nicintel_eeprom.c index 4d45f79..4055ffc 100644 --- a/nicintel_eeprom.c +++ b/nicintel_eeprom.c @@ -486,7 +486,7 @@ return 1; } - return register_opaque_master(&opaque_master_nicintel_ee_82580); + return register_opaque_master(&opaque_master_nicintel_ee_82580, NULL); } else { nicintel_eebar = rphysmap("Intel i210 NIC w/ emulated EEPROM", io_base_addr + 0x12000, MEMMAP_SIZE); @@ -496,7 +496,7 @@ if (register_shutdown(nicintel_ee_shutdown_i210, NULL)) return 1; - return register_opaque_master(&opaque_master_nicintel_ee_i210); + return register_opaque_master(&opaque_master_nicintel_ee_i210, NULL); } return 1; diff --git a/opaque.c b/opaque.c index e3103c8..f098ffc 100644 --- a/opaque.c +++ b/opaque.c @@ -46,7 +46,7 @@ return flash->mst->opaque.erase(flash, blockaddr, blocklen); } -int register_opaque_master(const struct opaque_master *mst) +int register_opaque_master(const struct opaque_master *mst, void *data) { struct registered_master rmst = {0}; @@ -58,5 +58,7 @@ } rmst.buses_supported = BUS_PROG; rmst.opaque = *mst; + if (data) + rmst.opaque.data = data; return register_master(&rmst); } diff --git a/programmer.h b/programmer.h index 9d701b7..d2e93ee 100644 --- a/programmer.h +++ b/programmer.h @@ -724,7 +724,7 @@ int (*erase) (struct flashctx *flash, unsigned int blockaddr, unsigned int blocklen); void *data; }; -int register_opaque_master(const struct opaque_master *mst); +int register_opaque_master(const struct opaque_master *mst, void *data); /* programmer.c */ void *fallback_map(const char *descr, uintptr_t phys_addr, size_t len); -- To view, visit https://review.coreboot.org/c/flashrom/+/54170 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id3adb4cf04ae04dbe87ddb96f30871cb5f7c8ff0 Gerrit-Change-Number: 54170 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: programmer: Smoothen register_par_master API
by Anastasia Klimchuk (Code Review) 12 May '21

12 May '21

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/54169 ) Change subject: programmer: Smoothen register_par_master API ...................................................................... programmer: Smoothen register_par_master API It was impossible to register a const struct par_master that would point to dynamically allocated `data`. Fix that so that we won't have to create more mutable globals. BUG=b:185191942 TEST=builds Change-Id: I95bc92f6c54c5bcdac1c522ca87054aaffed0f40 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M atahpt.c M atapromise.c M atavia.c M drkaiser.c M dummyflasher.c M gfxnvidia.c M internal.c M it8212.c M nic3com.c M nicintel.c M nicnatsemi.c M nicrealtek.c M programmer.c M programmer.h M satamv.c M satasii.c M serprog.c 17 files changed, 21 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/69/54169/1 diff --git a/atahpt.c b/atahpt.c index dae0222..620e894 100644 --- a/atahpt.c +++ b/atahpt.c @@ -75,7 +75,7 @@ reg32 |= (1 << 24); rpci_write_long(dev, REG_FLASH_ACCESS, reg32); - register_par_master(&par_master_atahpt, BUS_PARALLEL); + register_par_master(&par_master_atahpt, BUS_PARALLEL, NULL); return 0; } diff --git a/atapromise.c b/atapromise.c index ab34a1e..f32bdb4 100644 --- a/atapromise.c +++ b/atapromise.c @@ -140,7 +140,7 @@ } max_rom_decode.parallel = rom_size; - register_par_master(&par_master_atapromise, BUS_PARALLEL); + register_par_master(&par_master_atapromise, BUS_PARALLEL, NULL); msg_pwarn("Do not use this device as a generic programmer. It will leave anything outside\n" "the first %zu kB of the flash chip in an undefined state. It works fine for the\n" diff --git a/atavia.c b/atavia.c index b407a30..e04950a 100644 --- a/atavia.c +++ b/atavia.c @@ -160,7 +160,7 @@ return 1; } - register_par_master(&lpc_master_atavia, BUS_LPC); + register_par_master(&lpc_master_atavia, BUS_LPC, NULL); return 0; } diff --git a/drkaiser.c b/drkaiser.c index ac49df3..fa562b4 100644 --- a/drkaiser.c +++ b/drkaiser.c @@ -77,7 +77,7 @@ return 1; max_rom_decode.parallel = 128 * 1024; - register_par_master(&par_master_drkaiser, BUS_PARALLEL); + register_par_master(&par_master_drkaiser, BUS_PARALLEL, NULL); return 0; } diff --git a/dummyflasher.c b/dummyflasher.c index ec5060d..1455d30 100644 --- a/dummyflasher.c +++ b/dummyflasher.c @@ -1028,7 +1028,8 @@ } if (dummy_buses_supported & (BUS_PARALLEL | BUS_LPC | BUS_FWH)) register_par_master(&par_master_dummy, - dummy_buses_supported & (BUS_PARALLEL | BUS_LPC | BUS_FWH)); + dummy_buses_supported & (BUS_PARALLEL | BUS_LPC | BUS_FWH), + NULL); if (dummy_buses_supported & BUS_SPI) register_spi_master(&spi_master_dummyflasher); diff --git a/gfxnvidia.c b/gfxnvidia.c index d8ea4d6..fe6f982 100644 --- a/gfxnvidia.c +++ b/gfxnvidia.c @@ -103,7 +103,7 @@ /* Write/erase doesn't work. */ programmer_may_write = 0; - register_par_master(&par_master_gfxnvidia, BUS_PARALLEL); + register_par_master(&par_master_gfxnvidia, BUS_PARALLEL, NULL); return 0; } diff --git a/internal.c b/internal.c index bdbe32d..bb32435 100644 --- a/internal.c +++ b/internal.c @@ -335,7 +335,7 @@ #endif /* IS_X86 */ if (internal_buses_supported & BUS_NONSPI) - register_par_master(&par_master_internal, internal_buses_supported); + register_par_master(&par_master_internal, internal_buses_supported, NULL); /* Report if a non-whitelisted laptop is detected that likely uses a legacy bus. */ if (is_laptop && !laptop_ok) { diff --git a/it8212.c b/it8212.c index ac53a6f..2f2d43e 100644 --- a/it8212.c +++ b/it8212.c @@ -67,7 +67,7 @@ rpci_write_long(dev, PCI_ROM_ADDRESS, io_base_addr | 0x01); max_rom_decode.parallel = IT8212_MEMMAP_SIZE; - register_par_master(&par_master_it8212, BUS_PARALLEL); + register_par_master(&par_master_it8212, BUS_PARALLEL, NULL); return 0; } diff --git a/nic3com.c b/nic3com.c index b7b967a..6ff91e7 100644 --- a/nic3com.c +++ b/nic3com.c @@ -120,7 +120,7 @@ return 1; max_rom_decode.parallel = 128 * 1024; - register_par_master(&par_master_nic3com, BUS_PARALLEL); + register_par_master(&par_master_nic3com, BUS_PARALLEL, NULL); return 0; } diff --git a/nicintel.c b/nicintel.c index 4672890..afd2682 100644 --- a/nicintel.c +++ b/nicintel.c @@ -99,7 +99,7 @@ pci_rmmio_writew(0x0001, nicintel_control_bar + CSR_FCR); max_rom_decode.parallel = NICINTEL_MEMMAP_SIZE; - register_par_master(&par_master_nicintel, BUS_PARALLEL); + register_par_master(&par_master_nicintel, BUS_PARALLEL, NULL); return 0; } diff --git a/nicnatsemi.c b/nicnatsemi.c index 085768d..77b5440 100644 --- a/nicnatsemi.c +++ b/nicnatsemi.c @@ -71,7 +71,7 @@ * functions below wants to be 0x0000FFFF. */ max_rom_decode.parallel = 131072; - register_par_master(&par_master_nicnatsemi, BUS_PARALLEL); + register_par_master(&par_master_nicnatsemi, BUS_PARALLEL, NULL); return 0; } diff --git a/nicrealtek.c b/nicrealtek.c index 5454b63..2208179 100644 --- a/nicrealtek.c +++ b/nicrealtek.c @@ -86,7 +86,7 @@ if (register_shutdown(nicrealtek_shutdown, NULL)) return 1; - register_par_master(&par_master_nicrealtek, BUS_PARALLEL); + register_par_master(&par_master_nicrealtek, BUS_PARALLEL, NULL); return 0; } diff --git a/programmer.c b/programmer.c index 42ea2e3..c276a69 100644 --- a/programmer.c +++ b/programmer.c @@ -81,7 +81,8 @@ } int register_par_master(const struct par_master *mst, - const enum chipbustype buses) + const enum chipbustype buses, + void *data) { struct registered_master rmst = {0}; @@ -96,6 +97,8 @@ rmst.buses_supported = buses; rmst.par = *mst; + if (data) + rmst.par.data = data; return register_master(&rmst); } diff --git a/programmer.h b/programmer.h index 675a259..9d701b7 100644 --- a/programmer.h +++ b/programmer.h @@ -746,7 +746,7 @@ void (*chip_readn) (const struct flashctx *flash, uint8_t *buf, const chipaddr addr, size_t len); void *data; }; -int register_par_master(const struct par_master *mst, const enum chipbustype buses); +int register_par_master(const struct par_master *mst, const enum chipbustype buses, void *data); struct registered_master { enum chipbustype buses_supported; struct { diff --git a/satamv.c b/satamv.c index 31265ea..2640b78 100644 --- a/satamv.c +++ b/satamv.c @@ -148,7 +148,7 @@ /* 512 kByte with two 8-bit latches, and * 4 MByte with additional 3-bit latch. */ max_rom_decode.parallel = 4 * 1024 * 1024; - register_par_master(&par_master_satamv, BUS_PARALLEL); + register_par_master(&par_master_satamv, BUS_PARALLEL, NULL); return 0; } diff --git a/satasii.c b/satasii.c index 8a0938d..c9dfdad 100644 --- a/satasii.c +++ b/satasii.c @@ -100,7 +100,7 @@ if ((id != 0x0680) && (!(pci_mmio_readl(sii_bar) & (1 << 26)))) msg_pwarn("Warning: Flash seems unconnected.\n"); - register_par_master(&par_master_satasii, BUS_PARALLEL); + register_par_master(&par_master_satasii, BUS_PARALLEL, NULL); return 0; } diff --git a/serprog.c b/serprog.c index d583a40..e21f48b 100644 --- a/serprog.c +++ b/serprog.c @@ -885,7 +885,7 @@ if (serprog_buses_supported & BUS_SPI) register_spi_master(&spi_master_serprog); if (serprog_buses_supported & BUS_NONSPI) - register_par_master(&par_master_serprog, serprog_buses_supported & BUS_NONSPI); + register_par_master(&par_master_serprog, serprog_buses_supported & BUS_NONSPI, NULL); return 0; } -- To view, visit https://review.coreboot.org/c/flashrom/+/54169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I95bc92f6c54c5bcdac1c522ca87054aaffed0f40 Gerrit-Change-Number: 54169 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: libflashrom: clear layout on flashrom_layout_release
by Peter Marheine (Code Review) 12 May '21

12 May '21

Attention is currently required from: Daniel Campello. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54147 ) Change subject: libflashrom: clear layout on flashrom_layout_release ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/54147/comment/3c6aae79_221ea60e PS2, Line 10: (as is currently always : the case) > Not --layout As below, AFAICT you'll always get the global layout unless using IFD. Revised to reflect that. https://review.coreboot.org/c/flashrom/+/54147/comment/53130542_e57a093c PS2, Line 14: it's always the global layout > how can user do this on libflashrom? I think the global layout is only used by cli_classic Both flashrom_layout_read_fmap_* functions return a pointer to the global layout, so you'll only not get the global layout if you use IFD (as far as the libflashrom.h API goes). -- To view, visit https://review.coreboot.org/c/flashrom/+/54147 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8ba4b356f2a40ccbfd4e91f81af01d5f6a6de515 Gerrit-Change-Number: 54147 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Comment-Date: Thu, 13 May 2021 03:03:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Daniel Campello <campello(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: libflashrom: clear layout on flashrom_layout_release
by Peter Marheine (Code Review) 12 May '21

12 May '21

Attention is currently required from: Peter Marheine. Hello build bot (Jenkins), Edward O'Callaghan, Daniel Campello, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/54147 to look at the new patch set (#3). Change subject: libflashrom: clear layout on flashrom_layout_release ...................................................................... libflashrom: clear layout on flashrom_layout_release This changes the behavior of flashrom_layout_release to always clear the provided layout, even if it is the global layout (as is currently always the case unless using layout from IFD). Not clearing it causes confusing behavior where a user may release a layout and create a new one, but if that was the global layout which wasn't cleared there will be stale information in the "new" layout. This can easily lead to writing unexpected flash regions because the API provides no way to stop including regions, and makes it effectively impossible to stop including a region without completely tearing down the library. Change-Id: I8ba4b356f2a40ccbfd4e91f81af01d5f6a6de515 Signed-off-by: Peter Marheine <pmarheine(a)chromium.org> --- M cli_classic.c M flash.h M layout.c 3 files changed, 8 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/54147/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/54147 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8ba4b356f2a40ccbfd4e91f81af01d5f6a6de515 Gerrit-Change-Number: 54147 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: libflashrom: clear layout on flashrom_layout_release
by Daniel Campello (Code Review) 12 May '21

12 May '21

Attention is currently required from: Peter Marheine. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54147 ) Change subject: libflashrom: clear layout on flashrom_layout_release ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/54147/comment/2df3888b_cb66ad81 PS2, Line 10: (as is currently always : the case) > Not always the case... […] Not --layout -- To view, visit https://review.coreboot.org/c/flashrom/+/54147 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8ba4b356f2a40ccbfd4e91f81af01d5f6a6de515 Gerrit-Change-Number: 54147 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Thu, 13 May 2021 02:36:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Daniel Campello <campello(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2021