April 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: flashchips: Adapt IDs for Boya Microelectronics
by Nico Huber (Code Review) 22 Apr '21

22 Apr '21

Attention is currently required from: Jack Olsen, David Hendricks, Edward O'Callaghan, Angel Pons, coreboot(a)kudera.at. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52550 ) Change subject: flashchips: Adapt IDs for Boya Microelectronics ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/52550 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8d6951797daeeecca6af200c995297c0394adefd Gerrit-Change-Number: 52550 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jack Olsen <omegasec(a)tutanota.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jack Olsen <omegasec(a)tutanota.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: coreboot(a)kudera.at Gerrit-Comment-Date: Thu, 22 Apr 2021 15:38:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: hwaccess.c: Fix PowerPC memory barrier
by Nico Huber (Code Review) 22 Apr '21

22 Apr '21

Attention is currently required from: Stefan Reinauer, Edward O'Callaghan, Angel Pons, Arthur Heymans. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52470 ) Change subject: hwaccess.c: Fix PowerPC memory barrier ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/52470/comment/919b1eca_51ba6857 PS1, Line 10: rotten link. > That seems extremely likely Angel, good spot! It is very unfortunate the toolchain defaults of a giv […] If you know any alternative to papering over the deficiencies of all the environments flashrom supports, I'd be happy to listen. Just stating that the current practice isn't ideal doesn't fix anything. For sparc we got one emulation target working: CB:52485. The infrastructure to build test flashrom on many targets exists since the 1.0 release. That you chose to ignore it over the last years is very unfortunate. -- To view, visit https://review.coreboot.org/c/flashrom/+/52470 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia84fd1362a1d39aca6269eef22ac994dee68ba4b Gerrit-Change-Number: 52470 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 22 Apr 2021 15:27:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: Turn x86-arch comments into `if`
by Nico Huber (Code Review) 22 Apr '21

22 Apr '21

Nico Huber has removed a vote from this change. ( https://review.coreboot.org/c/flashrom/+/52486 ) Change subject: Makefile: Turn x86-arch comments into `if` ...................................................................... Removed Code-Review+2 by Nico Huber <nico.h(a)gmx.de> -- To view, visit https://review.coreboot.org/c/flashrom/+/52486 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I440919c12e54ca4371e21bc8d1b5ab64692fb4b8 Gerrit-Change-Number: 52486 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: deleteVote

1 0

Change in flashrom[master]: Makefile: Turn x86-arch comments into `if`
by Nico Huber (Code Review) 22 Apr '21

22 Apr '21

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52486 ) Change subject: Makefile: Turn x86-arch comments into `if` ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/52486 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I440919c12e54ca4371e21bc8d1b5ab64692fb4b8 Gerrit-Change-Number: 52486 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 22 Apr 2021 15:17:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: manibuilder: Add more NetBSD targets
by Nico Huber (Code Review) 22 Apr '21

22 Apr '21

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/52485 ) Change subject: manibuilder: Add more NetBSD targets ...................................................................... manibuilder: Add more NetBSD targets Looks like these build fine. Add all the 9.1 targets to the default run. Change-Id: Ic323ced43132921d9f6f2c0d5fcf9c581afec0c7 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/52485 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M util/manibuilder/Makefile.anita M util/manibuilder/Makefile.targets 2 files changed, 31 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/util/manibuilder/Makefile.anita b/util/manibuilder/Makefile.anita index 21cad8c..ba8c82d 100644 --- a/util/manibuilder/Makefile.anita +++ b/util/manibuilder/Makefile.anita @@ -1,12 +1,36 @@ PKGSRC_MIRROR = http://cdn.netbsd.org/ NETBSD_MIRROR = http://ftp.de.netbsd.org/ +anita\:9.1-sparc64-build: PKGSRC_PATH=pub/pkgsrc/packages/NetBSD/sparc64/9.1/All +anita\:9.1-sparc64-build: NETBSD_IMAGE=pub/NetBSD/iso/9.1/NetBSD-9.1-sparc64.iso +anita\:9.1-sparc64-build: QEMU_DISK_SIZE=2G +anita\:9.1-sparc64-build: QEMU_INSTALL_MEM=192M +anita\:9.1-sparc64-build: QEMU_RUNTIME_MEM=512M + +anita\:9.1-amd64-build: PKGSRC_PATH=pub/pkgsrc/packages/NetBSD/amd64/9.1/All +anita\:9.1-amd64-build: NETBSD_IMAGE=pub/NetBSD/NetBSD-9.1/amd64/ +anita\:9.1-amd64-build: QEMU_DISK_SIZE=2G +anita\:9.1-amd64-build: QEMU_INSTALL_MEM=192M +anita\:9.1-amd64-build: QEMU_RUNTIME_MEM=512M + +anita\:9.1-i386-build: PKGSRC_PATH=pub/pkgsrc/packages/NetBSD/i386/9.1/All +anita\:9.1-i386-build: NETBSD_IMAGE=pub/NetBSD/NetBSD-9.1/i386/ +anita\:9.1-i386-build: QEMU_DISK_SIZE=2G +anita\:9.1-i386-build: QEMU_INSTALL_MEM=128M +anita\:9.1-i386-build: QEMU_RUNTIME_MEM=256M + anita\:8.2-amd64-build: PKGSRC_PATH=pub/pkgsrc/packages/NetBSD/amd64/8.2/All anita\:8.2-amd64-build: NETBSD_IMAGE=pub/NetBSD/NetBSD-8.2/amd64/ anita\:8.2-amd64-build: QEMU_DISK_SIZE=2G anita\:8.2-amd64-build: QEMU_INSTALL_MEM=192M anita\:8.2-amd64-build: QEMU_RUNTIME_MEM=512M +anita\:8.2-i386-build: PKGSRC_PATH=pub/pkgsrc/packages/NetBSD/i386/8.2/All +anita\:8.2-i386-build: NETBSD_IMAGE=pub/NetBSD/NetBSD-8.2/i386/ +anita\:8.2-i386-build: QEMU_DISK_SIZE=2G +anita\:8.2-i386-build: QEMU_INSTALL_MEM=128M +anita\:8.2-i386-build: QEMU_RUNTIME_MEM=256M + anita\:7.1-amd64-build: PKGSRC_PATH=pub/pkgsrc/packages/NetBSD/amd64/7.1/All anita\:7.1-amd64-build: NETBSD_IMAGE=pub/NetBSD/NetBSD-7.1/amd64/ anita\:7.1-amd64-build: QEMU_DISK_SIZE=1G diff --git a/util/manibuilder/Makefile.targets b/util/manibuilder/Makefile.targets index 0fe9026..13b0503 100644 --- a/util/manibuilder/Makefile.targets +++ b/util/manibuilder/Makefile.targets @@ -1,4 +1,7 @@ -ANITA_TAGS := anita\:8.2-amd64 anita\:7.1-amd64 anita\:7.1-i386 +ANITA_TAGS := \ + anita\:9.1-amd64 anita\:9.1-i386 anita\:9.1-sparc64 \ + anita\:8.2-amd64 anita\:8.2-i386 \ + anita\:7.1-amd64 anita\:7.1-i386 \ MULTIARCH_TAGS := \ centos\:7.6-armhfp-clean centos\:7.6-amd64-clean \ @@ -43,6 +46,9 @@ # rather arbitrary selection of images that seem to work (focus on amd64) DEFAULT_TAGS := \ + anita\:9.1-sparc64 \ + anita\:9.1-amd64 \ + anita\:9.1-i386 \ anita\:8.2-amd64 \ djgpp\:6.1.0 \ fedora\:30-aarch64 \ -- To view, visit https://review.coreboot.org/c/flashrom/+/52485 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic323ced43132921d9f6f2c0d5fcf9c581afec0c7 Gerrit-Change-Number: 52485 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: manibuilder/anita: Always provide reasonable --memory-size
by Nico Huber (Code Review) 22 Apr '21

22 Apr '21

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/52484 ) Change subject: manibuilder/anita: Always provide reasonable --memory-size ...................................................................... manibuilder/anita: Always provide reasonable --memory-size It turned out that the `--memory-size` given at install time is not persistent. All later anita runs use an arch-dependent default (32M for i386, so this might explain why it was never stable). Assuming most machines have >1GiB RAM per processor core available, we can also increase the runtime size further (better to waste some RAM than to wait very long because it starts swapping things out). We choose 512MiB for 64-bit targets and 256MiB for 32-bit ones. However, we don't need that much for the initial installation step and it also decides the size of the swap partition. So we use a smaller size initially that's just enough to get us through the installation quickly enough (192MiB & 128MiB). Change-Id: I255c41aeb92cda29ed23a236017472982e839530 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/52484 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M util/manibuilder/Dockerfile.anita M util/manibuilder/Makefile.anita M util/manibuilder/anita-wrapper.sh 3 files changed, 19 insertions(+), 11 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/util/manibuilder/Dockerfile.anita b/util/manibuilder/Dockerfile.anita index dd6f4dd..f4b1309 100644 --- a/util/manibuilder/Dockerfile.anita +++ b/util/manibuilder/Dockerfile.anita @@ -3,7 +3,7 @@ ARG PKG_PATH=http://cdn.netbsd.org/pub/pkgsrc/packages/NetBSD/amd64/7.1/All ARG INST_IMG=http://ftp.de.netbsd.org/pub/NetBSD/NetBSD-7.1/amd64/ ARG DISK_SIZE=1G -ARG MEM_SIZE=128M +ARG INSTALL_MEM=128M ARG EXTRA_PKG="" RUN \ @@ -20,11 +20,12 @@ USER mani RUN cd && mkdir .ccache && chown mani:mani .ccache && \ anita --sets kern-GENERIC,modules,base,etc,comp \ - --disk-size ${DISK_SIZE} --memory-size=${MEM_SIZE} \ + --disk-size ${DISK_SIZE} --memory-size=${INSTALL_MEM} \ install ${INST_IMG} && \ rm -rf work-*/download -RUN cd && anita --persist --run \ +ARG RUNTIME_MEM=128M +RUN cd && anita --persist --memory-size=${RUNTIME_MEM} --run \ "echo 'dhcpcd' >init && \ echo 'export PKG_PATH=${PKG_PATH}' >>init && \ . ./init && \ @@ -35,7 +36,8 @@ boot ${INST_IMG} RUN cd && dd if=/dev/zero bs=1M count=64 of=cache.img && \ - anita --vmm-args '-hdb cache.img' --persist --run \ + anita --vmm-args '-hdb cache.img' --persist \ + --memory-size=${RUNTIME_MEM} --run \ "if [ \$(uname -m) = i386 -o \$(uname -m) = amd64 ]; then \ bdev=wd1d; \ else \ @@ -59,4 +61,5 @@ COPY anita-wrapper.sh /home/mani/mani-wrapper.sh ENV INST_IMG ${INST_IMG} +ENV MEM_SIZE ${RUNTIME_MEM} ENTRYPOINT ["/bin/sh", "/home/mani/mani-wrapper.sh"] diff --git a/util/manibuilder/Makefile.anita b/util/manibuilder/Makefile.anita index e795194..21cad8c 100644 --- a/util/manibuilder/Makefile.anita +++ b/util/manibuilder/Makefile.anita @@ -4,21 +4,25 @@ anita\:8.2-amd64-build: PKGSRC_PATH=pub/pkgsrc/packages/NetBSD/amd64/8.2/All anita\:8.2-amd64-build: NETBSD_IMAGE=pub/NetBSD/NetBSD-8.2/amd64/ anita\:8.2-amd64-build: QEMU_DISK_SIZE=2G -anita\:8.2-amd64-build: QEMU_MEM_SIZE=256M +anita\:8.2-amd64-build: QEMU_INSTALL_MEM=192M +anita\:8.2-amd64-build: QEMU_RUNTIME_MEM=512M anita\:7.1-amd64-build: PKGSRC_PATH=pub/pkgsrc/packages/NetBSD/amd64/7.1/All anita\:7.1-amd64-build: NETBSD_IMAGE=pub/NetBSD/NetBSD-7.1/amd64/ anita\:7.1-amd64-build: QEMU_DISK_SIZE=1G -anita\:7.1-amd64-build: QEMU_MEM_SIZE=128M +anita\:7.1-amd64-build: QEMU_INSTALL_MEM=192M +anita\:7.1-amd64-build: QEMU_RUNTIME_MEM=512M anita\:7.1-i386-build: PKGSRC_PATH=pub/pkgsrc/packages/NetBSD/i386/7.1/All anita\:7.1-i386-build: NETBSD_IMAGE=pub/NetBSD/NetBSD-7.1/i386/ anita\:7.1-i386-build: QEMU_DISK_SIZE=1G -anita\:7.1-i386-build: QEMU_MEM_SIZE=128M +anita\:7.1-i386-build: QEMU_INSTALL_MEM=128M +anita\:7.1-i386-build: QEMU_RUNTIME_MEM=256M $(addsuffix -build,$(ANITA_TAGS)): %-build: Dockerfile.anita anita-wrapper.sh $(QUIET_SETUP)docker build . -f $< -t mani/$* \ --build-arg PKG_PATH=$(PKGSRC_MIRROR)$(PKGSRC_PATH) \ --build-arg INST_IMG=$(NETBSD_MIRROR)$(NETBSD_IMAGE) \ --build-arg DISK_SIZE=$(QEMU_DISK_SIZE) \ - --build-arg MEM_SIZE=$(QEMU_MEM_SIZE) + --build-arg INSTALL_MEM=$(QEMU_INSTALL_MEM) \ + --build-arg RUNTIME_MEM=$(QEMU_RUNTIME_MEM) diff --git a/util/manibuilder/anita-wrapper.sh b/util/manibuilder/anita-wrapper.sh index 617e17f..3ff9ee1 100644 --- a/util/manibuilder/anita-wrapper.sh +++ b/util/manibuilder/anita-wrapper.sh @@ -9,9 +9,10 @@ [ -f ${CCACHE} ] || zcat cache.img.gz >${CCACHE} if [ $# -eq 0 ]; then - exec anita --vmm-args "-hdb ${CCACHE}" interact ${INST_IMG} + exec anita --vmm-args "-hdb ${CCACHE}" --memory-size=${MEM_SIZE} \ + interact ${INST_IMG} else - exec anita --vmm-args "-hdb ${CCACHE}" --persist \ - --run ". ./init && manitest \"$*\"" \ + exec anita --vmm-args "-hdb ${CCACHE}" --memory-size=${MEM_SIZE} \ + --persist --run ". ./init && manitest \"$*\"" \ boot ${INST_IMG} fi -- To view, visit https://review.coreboot.org/c/flashrom/+/52484 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I255c41aeb92cda29ed23a236017472982e839530 Gerrit-Change-Number: 52484 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: manibuilder/anita: Fix ccache image for non-x86
by Nico Huber (Code Review) 22 Apr '21

22 Apr '21

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/52482 ) Change subject: manibuilder/anita: Fix ccache image for non-x86 ...................................................................... manibuilder/anita: Fix ccache image for non-x86 There is no disk label `a` on non-x86 (at least not on Sparc64). Instead, we use the whole disk which is `d` on x86 and `c` else- where. `newfs` and `fsck` needs a little help in this scenario. Change-Id: Ib298d9cbf5d49ff38a898f4ce3ad54bb6af98d86 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/52482 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M util/manibuilder/Dockerfile.anita 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/util/manibuilder/Dockerfile.anita b/util/manibuilder/Dockerfile.anita index 5fba6cc..dd6f4dd 100644 --- a/util/manibuilder/Dockerfile.anita +++ b/util/manibuilder/Dockerfile.anita @@ -36,15 +36,19 @@ RUN cd && dd if=/dev/zero bs=1M count=64 of=cache.img && \ anita --vmm-args '-hdb cache.img' --persist --run \ -"echo fdisk -0 -s 169/63/131009 -f -u wd1 && \ - newfs wd1a && \ +"if [ \$(uname -m) = i386 -o \$(uname -m) = amd64 ]; then \ + bdev=wd1d; \ + else \ + bdev=wd1c; \ + fi; \ + newfs -I \${bdev} && \ mkdir .ccache && \ - mount /dev/wd1a .ccache && \ + mount /dev/\${bdev} .ccache && \ ccache -M 60M && \ umount .ccache && \ echo 'manitest() {' >>init && \ - echo ' fsck -y /dev/wd1a' >>init && \ - echo ' mount /dev/wd1a ~/.ccache' >>init && \ + echo ' fsck -y -t ffs /dev/'\${bdev} >>init && \ + echo ' mount /dev/'\${bdev}' ~/.ccache' >>init && \ echo ' (cd ~/flashrom && eval \" \$*\")' >>init && \ echo ' ret=\$?' >>init && \ echo ' umount ~/.ccache' >>init && \ -- To view, visit https://review.coreboot.org/c/flashrom/+/52482 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib298d9cbf5d49ff38a898f4ce3ad54bb6af98d86 Gerrit-Change-Number: 52482 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: chipset_enable.c: Add IDs for H310C and B365 PCHs
by Angel Pons (Code Review) 22 Apr '21

22 Apr '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/52605 ) Change subject: chipset_enable.c: Add IDs for H310C and B365 PCHs ...................................................................... chipset_enable.c: Add IDs for H310C and B365 PCHs Change-Id: If9f0a49a0f1821e5592213e07962ee48654cdc07 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M chipset_enable.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/05/52605/1 diff --git a/chipset_enable.c b/chipset_enable.c index d5c10c4..bb3ab74 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -2071,6 +2071,8 @@ {0x8086, 0xa2c7, B_S, NT, "Intel", "Q250", enable_flash_pch100}, {0x8086, 0xa2c8, B_S, NT, "Intel", "B250", enable_flash_pch100}, {0x8086, 0xa2c9, B_S, NT, "Intel", "Z370", enable_flash_pch100}, + {0x8086, 0xa2ca, B_S, NT, "Intel", "H310C", enable_flash_pch100}, + {0x8086, 0xa2cc, B_S, NT, "Intel", "B365", enable_flash_pch100}, {0x8086, 0xa2d2, B_S, NT, "Intel", "X299", enable_flash_pch100}, {0x8086, 0x5ae8, B_S, DEP, "Intel", "Apollo Lake", enable_flash_apl}, {0x8086, 0x5af0, B_S, DEP, "Intel", "Apollo Lake", enable_flash_apl}, -- To view, visit https://review.coreboot.org/c/flashrom/+/52605 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If9f0a49a0f1821e5592213e07962ee48654cdc07 Gerrit-Change-Number: 52605 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: manibuilder/anita: Factor things out into Makefile.anita
by Nico Huber (Code Review) 22 Apr '21

22 Apr '21

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/52483 ) Change subject: manibuilder/anita: Factor things out into Makefile.anita ...................................................................... manibuilder/anita: Factor things out into Makefile.anita The anita-based NetBSD targets need noisy, per-target handling. Factor it out into another Makefile. Change-Id: I0a3ca751b42f1ca8c05d93eb9740bb0ee5cc6d09 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/52483 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M util/manibuilder/Makefile A util/manibuilder/Makefile.anita 2 files changed, 25 insertions(+), 24 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/util/manibuilder/Makefile b/util/manibuilder/Makefile index c0d1eff..5b58b05 100644 --- a/util/manibuilder/Makefile +++ b/util/manibuilder/Makefile @@ -12,30 +12,7 @@ stem = $(word 1,$(subst :,$(spc),$(subst \:,$(spc),$(1)))) ident = $(subst :,_,$(subst \:,_,$(1))) -PKGSRC_MIRROR = http://cdn.netbsd.org/ -NETBSD_MIRROR = http://ftp.de.netbsd.org/ - -anita\:8.2-amd64-build: PKGSRC_PATH=pub/pkgsrc/packages/NetBSD/amd64/8.2/All -anita\:8.2-amd64-build: NETBSD_IMAGE=pub/NetBSD/NetBSD-8.2/amd64/ -anita\:8.2-amd64-build: QEMU_DISK_SIZE=2G -anita\:8.2-amd64-build: QEMU_MEM_SIZE=256M - -anita\:7.1-amd64-build: PKGSRC_PATH=pub/pkgsrc/packages/NetBSD/amd64/7.1/All -anita\:7.1-amd64-build: NETBSD_IMAGE=pub/NetBSD/NetBSD-7.1/amd64/ -anita\:7.1-amd64-build: QEMU_DISK_SIZE=1G -anita\:7.1-amd64-build: QEMU_MEM_SIZE=128M - -anita\:7.1-i386-build: PKGSRC_PATH=pub/pkgsrc/packages/NetBSD/i386/7.1/All -anita\:7.1-i386-build: NETBSD_IMAGE=pub/NetBSD/NetBSD-7.1/i386/ -anita\:7.1-i386-build: QEMU_DISK_SIZE=1G -anita\:7.1-i386-build: QEMU_MEM_SIZE=128M - -$(addsuffix -build,$(ANITA_TAGS)): %-build: Dockerfile.anita anita-wrapper.sh - $(QUIET_SETUP)docker build . -f $< -t mani/$* \ - --build-arg PKG_PATH=$(PKGSRC_MIRROR)$(PKGSRC_PATH) \ - --build-arg INST_IMG=$(NETBSD_MIRROR)$(NETBSD_IMAGE) \ - --build-arg DISK_SIZE=$(QEMU_DISK_SIZE) \ - --build-arg MEM_SIZE=$(QEMU_MEM_SIZE) +include Makefile.anita define build_template Dockerfile.$(call ident,$(1)): Dockerfile.$(call stem,$(1)) mani-wrapper.sh diff --git a/util/manibuilder/Makefile.anita b/util/manibuilder/Makefile.anita new file mode 100644 index 0000000..e795194 --- /dev/null +++ b/util/manibuilder/Makefile.anita @@ -0,0 +1,24 @@ +PKGSRC_MIRROR = http://cdn.netbsd.org/ +NETBSD_MIRROR = http://ftp.de.netbsd.org/ + +anita\:8.2-amd64-build: PKGSRC_PATH=pub/pkgsrc/packages/NetBSD/amd64/8.2/All +anita\:8.2-amd64-build: NETBSD_IMAGE=pub/NetBSD/NetBSD-8.2/amd64/ +anita\:8.2-amd64-build: QEMU_DISK_SIZE=2G +anita\:8.2-amd64-build: QEMU_MEM_SIZE=256M + +anita\:7.1-amd64-build: PKGSRC_PATH=pub/pkgsrc/packages/NetBSD/amd64/7.1/All +anita\:7.1-amd64-build: NETBSD_IMAGE=pub/NetBSD/NetBSD-7.1/amd64/ +anita\:7.1-amd64-build: QEMU_DISK_SIZE=1G +anita\:7.1-amd64-build: QEMU_MEM_SIZE=128M + +anita\:7.1-i386-build: PKGSRC_PATH=pub/pkgsrc/packages/NetBSD/i386/7.1/All +anita\:7.1-i386-build: NETBSD_IMAGE=pub/NetBSD/NetBSD-7.1/i386/ +anita\:7.1-i386-build: QEMU_DISK_SIZE=1G +anita\:7.1-i386-build: QEMU_MEM_SIZE=128M + +$(addsuffix -build,$(ANITA_TAGS)): %-build: Dockerfile.anita anita-wrapper.sh + $(QUIET_SETUP)docker build . -f $< -t mani/$* \ + --build-arg PKG_PATH=$(PKGSRC_MIRROR)$(PKGSRC_PATH) \ + --build-arg INST_IMG=$(NETBSD_MIRROR)$(NETBSD_IMAGE) \ + --build-arg DISK_SIZE=$(QEMU_DISK_SIZE) \ + --build-arg MEM_SIZE=$(QEMU_MEM_SIZE) -- To view, visit https://review.coreboot.org/c/flashrom/+/52483 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0a3ca751b42f1ca8c05d93eb9740bb0ee5cc6d09 Gerrit-Change-Number: 52483 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: ft2232_spi.c: Implement spi_send_multicommand()
by Nico Huber (Code Review) 22 Apr '21

22 Apr '21

Attention is currently required from: Simon Buhrow, Alan Green, Edward O'Callaghan, Samir Ibradžić. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40477 ) Change subject: ft2232_spi.c: Implement spi_send_multicommand() ...................................................................... Patch Set 28: (1 comment) File ft2232_spi.c: https://review.coreboot.org/c/flashrom/+/40477/comment/552edac2_99c14e29 PS25, Line 189: ft2232_spi_send_command > Regarding this idea. […] As mentioned earlier, this is already implemented: default_spi_send_command(). There is no need for two local functions. Once the multicommand version is implemented, the other can be dropped. -- To view, visit https://review.coreboot.org/c/flashrom/+/40477 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie4a07499ec5ef0af23818593f45dc427285a9e8a Gerrit-Change-Number: 40477 Gerrit-PatchSet: 28 Gerrit-Owner: Simon Buhrow Gerrit-Reviewer: Alan Green <avg(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Samir Ibradžić <sibradzic(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Buhrow Gerrit-Attention: Alan Green <avg(a)google.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Samir Ibradžić <sibradzic(a)gmail.com> Gerrit-Comment-Date: Thu, 22 Apr 2021 14:36:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Alan Green <avg(a)google.com> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2021