April 2021 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: flashchips: Add MX25L3233F
by Nico Huber (Code Review) 25 Apr '21

25 Apr '21

Attention is currently required from: Pavel Sayekat. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52570 ) Change subject: flashchips: Add MX25L3233F ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > root@raspberrypi:~# flashrom -p linux_spi:dev=/dev/spidev0.0,spispeed=16000 […] Thanks! Actually, I already got your confirmation on IRC, not sure what I was still waiting for :) -- To view, visit https://review.coreboot.org/c/flashrom/+/52570 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I73402dddedf360ab84caed4c019efe27b477d4c2 Gerrit-Change-Number: 52570 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Pavel Sayekat Gerrit-Attention: Pavel Sayekat Gerrit-Comment-Date: Sun, 25 Apr 2021 13:38:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Pavel Sayekat Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Correct OTP comment for MX25L3273E
by Nico Huber (Code Review) 25 Apr '21

25 Apr '21

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/52569 ) Change subject: flashchips: Correct OTP comment for MX25L3273E ...................................................................... flashchips: Correct OTP comment for MX25L3273E The datasheet says 4K bits, maybe just a copy-paste error. Change-Id: I42b10aa09c969e5c5e7102b1e8ab496f52bd27bb Signed-off-by: Nico Huber <nico.huber(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/52569 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 8bf2cd9..b569d97 100644 --- a/flashchips.c +++ b/flashchips.c @@ -8819,7 +8819,7 @@ .model_id = MACRONIX_MX25L3205, .total_size = 4096, .page_size = 256, - /* OTP: 64B total; enter 0xB1, exit 0xC1 */ + /* OTP: 512B total; enter 0xB1, exit 0xC1 */ .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, .tested = TEST_OK_PREW, .probe = probe_spi_rdid, -- To view, visit https://review.coreboot.org/c/flashrom/+/52569 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I42b10aa09c969e5c5e7102b1e8ab496f52bd27bb Gerrit-Change-Number: 52569 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: chipset_enable.c: Add IDs for H310C and B365 PCHs
by Angel Pons (Code Review) 25 Apr '21

25 Apr '21

Attention is currently required from: Timofey Komarov, Nico Huber, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52605 ) Change subject: chipset_enable.c: Add IDs for H310C and B365 PCHs ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > LOL […] Like coreboot, flashrom doesn't handle pull requests. Which PCHs have you tested? Both H310C and B365, or just H310C? -- To view, visit https://review.coreboot.org/c/flashrom/+/52605 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If9f0a49a0f1821e5592213e07962ee48654cdc07 Gerrit-Change-Number: 52605 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 25 Apr 2021 08:19:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: chipset_enable.c: Add IDs for H310C and B365 PCHs
by Timofey Komarov (Code Review) 24 Apr '21

24 Apr '21

Attention is currently required from: Nico Huber, Angel Pons, Arthur Heymans. Timofey Komarov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52605 ) Change subject: chipset_enable.c: Add IDs for H310C and B365 PCHs ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: LOL https://github.com/flashrom/flashrom/pull/166/files Already tested it. It's ok, -- To view, visit https://review.coreboot.org/c/flashrom/+/52605 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: If9f0a49a0f1821e5592213e07962ee48654cdc07 Gerrit-Change-Number: 52605 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 24 Apr 2021 23:51:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips: Add support for Boya/BoHong Microelectronics B_25D16A
by Angel Pons (Code Review) 24 Apr '21

24 Apr '21

Angel Pons has submitted this change. ( https://review.coreboot.org/c/flashrom/+/52555 ) Change subject: flashchips: Add support for Boya/BoHong Microelectronics B_25D16A ...................................................................... flashchips: Add support for Boya/BoHong Microelectronics B_25D16A Read tested on CH341A Change-Id: I25b776204affda94cc7e753e7671ef9d3d9508f1 Signed-off-by: Christian Kudera <coreboot(a)kudera.at> Reviewed-on: https://review.coreboot.org/c/flashrom/+/52555 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c M flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 7a8e857..8bf2cd9 100644 --- a/flashchips.c +++ b/flashchips.c @@ -3482,6 +3482,44 @@ { .vendor = "Boya/BoHong Microelectronics", + .name = "B.25D16A", + .bustype = BUS_SPI, + .manufacture_id = BOYA_BOHONG_ID, + .model_id = BOYA_BOHONG_B_25D16A, + .total_size = 2048, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_OK_PR, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 512} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 64} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 32} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_bp2_srwd, + .unlock = spi_disable_blockprotect_bp2_srwd, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, + + { + .vendor = "Boya/BoHong Microelectronics", .name = "B.25Q128AS", .bustype = BUS_SPI, .manufacture_id = BOYA_BOHONG_ID, diff --git a/flashchips.h b/flashchips.h index 4e155d3..12e7143 100644 --- a/flashchips.h +++ b/flashchips.h @@ -210,6 +210,7 @@ /* Boya/BoHong Microelectronics Inc. */ #define BOYA_BOHONG_ID 0x68 +#define BOYA_BOHONG_B_25D16A 0x4015 #define BOYA_BOHONG_B_25Q128AS 0x4018 /* Bright Microelectronics has the same manufacturer ID as Hyundai... */ -- To view, visit https://review.coreboot.org/c/flashrom/+/52555 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I25b776204affda94cc7e753e7671ef9d3d9508f1 Gerrit-Change-Number: 52555 Gerrit-PatchSet: 2 Gerrit-Owner: coreboot(a)kudera.at Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: flashchips: Adapt IDs for Boya Microelectronics
by Angel Pons (Code Review) 24 Apr '21

24 Apr '21

Angel Pons has submitted this change. ( https://review.coreboot.org/c/flashrom/+/52550 ) Change subject: flashchips: Adapt IDs for Boya Microelectronics ...................................................................... flashchips: Adapt IDs for Boya Microelectronics Looks like BoHong Microelectronics has the same vendor ID and makes very similar chips. For instance, Boya BY25Q128AS and BoHong BH25Q128AS have the same specifications and their datasheets are mostly identical. Change-Id: I8d6951797daeeecca6af200c995297c0394adefd Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/52550 Reviewed-by: Nico Huber <nico.h(a)gmx.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M flashchips.c M flashchips.h 2 files changed, 7 insertions(+), 7 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 5b328f8..7a8e857 100644 --- a/flashchips.c +++ b/flashchips.c @@ -3481,11 +3481,11 @@ }, { - .vendor = "Boya Microelectronics", - .name = "BY25Q128AS", + .vendor = "Boya/BoHong Microelectronics", + .name = "B.25Q128AS", .bustype = BUS_SPI, - .manufacture_id = BOYA_ID, - .model_id = BOYA_BY25Q128AS, + .manufacture_id = BOYA_BOHONG_ID, + .model_id = BOYA_BOHONG_B_25Q128AS, .total_size = 16384, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, diff --git a/flashchips.h b/flashchips.h index 2ad09df..4e155d3 100644 --- a/flashchips.h +++ b/flashchips.h @@ -208,9 +208,9 @@ #define ATMEL_AT49F080 0x23 #define ATMEL_AT49F080T 0x27 -/* Boya Microelectronics Inc.*/ -#define BOYA_ID 0x68 -#define BOYA_BY25Q128AS 0x4018 +/* Boya/BoHong Microelectronics Inc. */ +#define BOYA_BOHONG_ID 0x68 +#define BOYA_BOHONG_B_25Q128AS 0x4018 /* Bright Microelectronics has the same manufacturer ID as Hyundai... */ #define BRIGHT_ID 0xAD /* Bright Microelectronics */ -- To view, visit https://review.coreboot.org/c/flashrom/+/52550 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8d6951797daeeecca6af200c995297c0394adefd Gerrit-Change-Number: 52550 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Jack Olsen <omegasec(a)tutanota.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: s25f.c: Fix mismatched function definitions
by Angel Pons (Code Review) 24 Apr '21

24 Apr '21

Angel Pons has submitted this change. ( https://review.coreboot.org/c/flashrom/+/52473 ) Change subject: s25f.c: Fix mismatched function definitions ...................................................................... s25f.c: Fix mismatched function definitions This was missed because `uint32_t` is `unsigned int` in most cases. However, it is not the case for DJGPP 6.1.0 for some reason. Tested with manibuilder, solves some build errors on the DJGPP target. Change-Id: I656a72b85d4c70b57f6ff9268186a4a60933f8a9 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/52473 Reviewed-by: Nico Huber <nico.h(a)gmx.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M s25f.c 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/s25f.c b/s25f.c index 32af53e..2fba6bc 100644 --- a/s25f.c +++ b/s25f.c @@ -237,8 +237,7 @@ return ret; } -int s25fs_block_erase_d8(struct flashctx *flash, - uint32_t addr, uint32_t blocklen) +int s25fs_block_erase_d8(struct flashctx *flash, unsigned int addr, unsigned int blocklen) { static int cr3nv_checked = 0; @@ -301,8 +300,7 @@ return s25f_poll_status(flash); } -int s25fl_block_erase(struct flashctx *flash, - uint32_t addr, uint32_t blocklen) +int s25fl_block_erase(struct flashctx *flash, unsigned int addr, unsigned int blocklen) { struct spi_command erase_cmds[] = { { -- To view, visit https://review.coreboot.org/c/flashrom/+/52473 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I656a72b85d4c70b57f6ff9268186a4a60933f8a9 Gerrit-Change-Number: 52473 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: s25f.c: Fix mismatched function definitions
by Angel Pons (Code Review) 24 Apr '21

24 Apr '21

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Angel Pons has removed a vote from this change. ( https://review.coreboot.org/c/flashrom/+/52473 ) Change subject: s25f.c: Fix mismatched function definitions ...................................................................... Removed Code-Review-2 by Edward O'Callaghan <quasisec(a)chromium.org> -- To view, visit https://review.coreboot.org/c/flashrom/+/52473 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I656a72b85d4c70b57f6ff9268186a4a60933f8a9 Gerrit-Change-Number: 52473 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: deleteVote

1 0

Change in flashrom[master]: s25f.c: Fix mismatched function definitions
by Angel Pons (Code Review) 24 Apr '21

24 Apr '21

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52473 ) Change subject: s25f.c: Fix mismatched function definitions ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/52473/comment/914c64e6_47d245a0 PS1, Line 8: : This was missed because `uint32_t` is `unsigned int` in most cases. : However, it is not the case for DJGPP 6.1.0 for some reason. > Edward, any updates? Got no response after several days, marking as resolved. -- To view, visit https://review.coreboot.org/c/flashrom/+/52473 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I656a72b85d4c70b57f6ff9268186a4a60933f8a9 Gerrit-Change-Number: 52473 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 24 Apr 2021 11:23:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[refs/meta/config]: Allow merging content when submitting
by Angel Pons (Code Review) 24 Apr '21

24 Apr '21

Attention is currently required from: Nico Huber, David Hendricks. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52427 ) Change subject: Allow merging content when submitting ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/52427/comment/ebda4224_b289dd84 PS5, Line 10: file show up in Gerrit as conflicing with each other (Merge Conflict). Since flashrom doesn't require approval from non-uploaders, one can simply click "Rebase" on Gerrit before submitting. -- To view, visit https://review.coreboot.org/c/flashrom/+/52427 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: Iace6052fb7ff20ea7b9d93635e04e56a24799bbd Gerrit-Change-Number: 52427 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Comment-Date: Sat, 24 Apr 2021 11:15:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2021