October 2021 - flashrom-gerrit

Change in flashrom[master]: ene: Move contents of programmer specific headers into C file
by Nico Huber (Code Review) 14 Oct '21

14 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58299 ) Change subject: ene: Move contents of programmer specific headers into C file ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > What are the differences between EDI and ENE? EDI is another vendor? AFAIR, EDI is the debug interface, ENE the vendor. The interface can be used for multiple things, accessing an embedded flash is one application. Wrt. the definitions, I guess, EDI_ is generic, and the ENE_ things are chip-/ application-specific. -- To view, visit https://review.coreboot.org/c/flashrom/+/58299 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id22b6c8f4ecb727f759f020e3bef690301eb211b Gerrit-Change-Number: 58299 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Kocialkowski <contact(a)paulk.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Thu, 14 Oct 2021 13:46:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: ene: Move contents of programmer specific headers into C file
by Felix Singer (Code Review) 14 Oct '21

14 Oct '21

Attention is currently required from: Nico Huber, Thomas Heijligen. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58299 ) Change subject: ene: Move contents of programmer specific headers into C file ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > Hmmm, looks a bit too mixed, IMO. Would it be worth to split "edi" […] What are the differences between EDI and ENE? EDI is another vendor? -- To view, visit https://review.coreboot.org/c/flashrom/+/58299 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id22b6c8f4ecb727f759f020e3bef690301eb211b Gerrit-Change-Number: 58299 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Thu, 14 Oct 2021 13:23:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: buildsystem: evaluate the USE_IOPL, USE_DEV_IO, USE_IOPERM macros
by Thomas Heijligen (Code Review) 14 Oct '21

14 Oct '21

Attention is currently required from: Felix Singer, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58278 ) Change subject: buildsystem: evaluate the USE_IOPL, USE_DEV_IO, USE_IOPERM macros ...................................................................... Patch Set 7: (4 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58278/comment/36c4b536_f0eaa847 PS2, Line 9: Determinate > `Determine` Done https://review.coreboot.org/c/flashrom/+/58278/comment/38b9148e_1a30d373 PS2, Line 9: sytem > `system` Done https://review.coreboot.org/c/flashrom/+/58278/comment/61d4d9eb_ad593237 PS2, Line 9: been > `be` Done https://review.coreboot.org/c/flashrom/+/58278/comment/ff53e9f3_af1fade7 PS2, Line 9: with > `which` Done -- To view, visit https://review.coreboot.org/c/flashrom/+/58278 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic41ea025e35feb93f07ce7a94c0d15e6e84f38b9 Gerrit-Change-Number: 58278 Gerrit-PatchSet: 7 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 14 Oct 2021 12:47:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: hwaccess: replace flashrom specific macros by compiler defines
by Thomas Heijligen (Code Review) 14 Oct '21

14 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons. Hello Felix Singer, build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58280 to look at the new patch set (#7). Change subject: hwaccess: replace flashrom specific macros by compiler defines ...................................................................... hwaccess: replace flashrom specific macros by compiler defines Replace the remaining IS_* macros with the associated compiler defines Change-Id: Ia0f022d12390722816066d292e1878824adc613c Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M dediprog.c M developerbox_spi.c M dmi.c M flash.h M hwaccess.c M hwaccess.h M internal.c M pickit2_spi.c D platform.h M serial.c M serprog.c 11 files changed, 20 insertions(+), 113 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/80/58280/7 -- To view, visit https://review.coreboot.org/c/flashrom/+/58280 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia0f022d12390722816066d292e1878824adc613c Gerrit-Change-Number: 58280 Gerrit-PatchSet: 7 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: buildsystem: evaluate the USE_IOPL, USE_DEV_IO, USE_IOPERM macros
by Thomas Heijligen (Code Review) 14 Oct '21

14 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons. Hello Felix Singer, build bot (Jenkins), Nico Huber, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/58278 to look at the new patch set (#7). Change subject: buildsystem: evaluate the USE_IOPL, USE_DEV_IO, USE_IOPERM macros ...................................................................... buildsystem: evaluate the USE_IOPL, USE_DEV_IO, USE_IOPERM macros Determine which macro has to be set for the target system. Do this in the buildsystem instead of using preprocessor macros. Change-Id: Ic41ea025e35feb93f07ce7a94c0d15e6e84f38b9 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> --- M Makefile M hwaccess.c M meson.build 3 files changed, 37 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/58278/7 -- To view, visit https://review.coreboot.org/c/flashrom/+/58278 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic41ea025e35feb93f07ce7a94c0d15e6e84f38b9 Gerrit-Change-Number: 58278 Gerrit-PatchSet: 7 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makefile: summarize systems with the same CPPFLAGS and LDFLAGS
by Nico Huber (Code Review) 14 Oct '21

14 Oct '21

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/58247 ) Change subject: Makefile: summarize systems with the same CPPFLAGS and LDFLAGS ...................................................................... Makefile: summarize systems with the same CPPFLAGS and LDFLAGS Change-Id: I067430e52eb41bf0af4f08246bbe59117bc09bdb Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de> Reviewed-on: https://review.coreboot.org/c/flashrom/+/58247 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M Makefile 1 file changed, 5 insertions(+), 15 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Felix Singer: Looks good to me, but someone else must approve diff --git a/Makefile b/Makefile index 29d1020..bc0047f 100644 --- a/Makefile +++ b/Makefile @@ -165,31 +165,21 @@ override TARGET_OS := $(strip $(call debug_shell,$(CC) $(CPPFLAGS) -E os.h 2>/dev/null \ | tail -1 | cut -f 2 -d'"')) +ifeq ($(TARGET_OS), $(filter $(TARGET_OS), FreeBSD OpenBSD DragonFlyBSD)) +override CPPFLAGS += -I/usr/local/include +override LDFLAGS += -L/usr/local/lib +endif + ifeq ($(TARGET_OS), Darwin) override CPPFLAGS += -I/opt/local/include -I/usr/local/include override LDFLAGS += -L/opt/local/lib -L/usr/local/lib endif -ifeq ($(TARGET_OS), FreeBSD) -override CPPFLAGS += -I/usr/local/include -override LDFLAGS += -L/usr/local/lib -endif - -ifeq ($(TARGET_OS), OpenBSD) -override CPPFLAGS += -I/usr/local/include -override LDFLAGS += -L/usr/local/lib -endif - ifeq ($(TARGET_OS), NetBSD) override CPPFLAGS += -I/usr/pkg/include override LDFLAGS += -L/usr/pkg/lib endif -ifeq ($(TARGET_OS), DragonFlyBSD) -override CPPFLAGS += -I/usr/local/include -override LDFLAGS += -L/usr/local/lib -endif - ifeq ($(TARGET_OS), DOS) EXEC_SUFFIX := .exe # DJGPP has odd uint*_t definitions which cause lots of format string warnings. 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/flashrom/+/58247 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I067430e52eb41bf0af4f08246bbe59117bc09bdb Gerrit-Change-Number: 58247 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in flashrom[master]: Makefile: copy determination test for the endian to Makefile.d
by Thomas Heijligen (Code Review) 14 Oct '21

14 Oct '21

Attention is currently required from: Felix Singer, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58270 ) Change subject: Makefile: copy determination test for the endian to Makefile.d ...................................................................... Patch Set 6: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58270/comment/0edce1a5_d64b3c8d PS5, Line 7: in > `to` or `into` Done https://review.coreboot.org/c/flashrom/+/58270/comment/2e8599ad_d3074d7f PS5, Line 7: move > It's more a copy. Together with the follow-up commit, it's a move. Maybe just […] I want to keep them separated. This is just the buildsystem, the next changes code behavior https://review.coreboot.org/c/flashrom/+/58270/comment/ee9487a3_a9e67606 PS5, Line 9: a > `an` Done -- To view, visit https://review.coreboot.org/c/flashrom/+/58270 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0c2420fd60d7d6a23c94c9962b06bfd7f3c86ad8 Gerrit-Change-Number: 58270 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 14 Oct 2021 12:44:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: copy determination test for the endian to Makefile.d
by Nico Huber (Code Review) 14 Oct '21

14 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58270 ) Change subject: Makefile: copy determination test for the endian to Makefile.d ...................................................................... Patch Set 6: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/58270/comment/bae81734_82a332a0 PS5, Line 7: in > `to` or `into` Done https://review.coreboot.org/c/flashrom/+/58270/comment/003c67a9_5bdca6d2 PS5, Line 9: a > `an` Done -- To view, visit https://review.coreboot.org/c/flashrom/+/58270 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0c2420fd60d7d6a23c94c9962b06bfd7f3c86ad8 Gerrit-Change-Number: 58270 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 14 Oct 2021 12:43:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: move determination test for the architecture to Makefile.d
by Nico Huber (Code Review) 14 Oct '21

14 Oct '21

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58269 ) Change subject: Makefile: move determination test for the architecture to Makefile.d ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/58269 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I29ce73be9c5cbe259a2471f8eea2f8745b68cdfa Gerrit-Change-Number: 58269 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 14 Oct 2021 12:43:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: move determination test for the architecture to Makefile.d
by Thomas Heijligen (Code Review) 14 Oct '21

14 Oct '21

Attention is currently required from: Felix Singer, Nico Huber, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58269 ) Change subject: Makefile: move determination test for the architecture to Makefile.d ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/58269/comment/6b9b12a1_41701528 PS5, Line 9: directorz > `director*y*` Done -- To view, visit https://review.coreboot.org/c/flashrom/+/58269 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I29ce73be9c5cbe259a2471f8eea2f8745b68cdfa Gerrit-Change-Number: 58269 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 14 Oct 2021 12:42:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2021