September 2019 - flashrom-gerrit

Change in flashrom[master]: flashchips.c: Identify MX25L25645G part
by Alan Green (Code Review) 17 Sep '19

17 Sep '19

Alan Green has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/35091 ) Change subject: flashchips.c: Identify MX25L25645G part ...................................................................... flashchips.c: Identify MX25L25645G part Apply downstream patch d978051c2e7da88088ec4ef19827c04873a5479d, "flashrom: Identify MX25L25645G part" from chris_zhou(a)compal.corp-partner.google.com 2019-04-13. Change description was: MX25L25635F and MX25L25645G have the same chips identify. Add MX25L25645G to the name of the part so that it doesn't confused people. Signed-off-by: Alan Green <avg(a)google.com> Change-Id: I317345b4753cfc46fdca8f673a0591e33b62138b --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/35091/1 diff --git a/flashchips.c b/flashchips.c index 1c67887..f84f1cc 100644 --- a/flashchips.c +++ b/flashchips.c @@ -8109,7 +8109,7 @@ { .vendor = "Macronix", - .name = "MX25L25635F", + .name = "MX25L25635F/MX25L25645G", .bustype = BUS_SPI, .manufacture_id = MACRONIX_ID, .model_id = MACRONIX_MX25L25635F, -- To view, visit https://review.coreboot.org/c/flashrom/+/35091 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I317345b4753cfc46fdca8f673a0591e33b62138b Gerrit-Change-Number: 35091 Gerrit-PatchSet: 1 Gerrit-Owner: Alan Green <avg(a)google.com> Gerrit-MessageType: newchange

3 5

Change in flashrom[master]: flashchips: Add GD25Q127C name to the GD25Q128C entry
by Alan Green (Code Review) 17 Sep '19

17 Sep '19

Alan Green has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/35089 ) Change subject: flashchips: Add GD25Q127C name to the GD25Q128C entry ...................................................................... flashchips: Add GD25Q127C name to the GD25Q128C entry Renamed GigaDevice GD25Q128 to GD25Q127C/GD25Q128. According to downstream (ChromiumOS) change 4216ba3d0fbd1804a71002b9c17e0b04029a03f1 "flashchips: Add GD25Q127C name to the GD25Q128C entry", the 127C chip is replacement for the 128C chip. I have confirmed that 127C is newer and that 128C does not appear to be documented on Gigadevice's website or available from Digikey. TEST=Ran flashrom -L Signed-off-by: Alan Green <avg(a)google.com> Change-Id: I3366e5904eff2443fda90552f7f5e31a8785d8b3 --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/89/35089/1 diff --git a/flashchips.c b/flashchips.c index 9b686c1..1c67887 100644 --- a/flashchips.c +++ b/flashchips.c @@ -6158,7 +6158,7 @@ { .vendor = "GigaDevice", - .name = "GD25Q128C", + .name = "GD25Q127C/GD25Q128C", .bustype = BUS_SPI, .manufacture_id = GIGADEVICE_ID, .model_id = GIGADEVICE_GD25Q128, -- To view, visit https://review.coreboot.org/c/flashrom/+/35089 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3366e5904eff2443fda90552f7f5e31a8785d8b3 Gerrit-Change-Number: 35089 Gerrit-PatchSet: 1 Gerrit-Owner: Alan Green <avg(a)google.com> Gerrit-MessageType: newchange

3 3

Change in flashrom[master]: flashchips.c: Put SFDP-capable chip back into position
by Alan Green (Code Review) 17 Sep '19

17 Sep '19

Alan Green has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/35037 ) Change subject: flashchips.c: Put SFDP-capable chip back into position ...................................................................... flashchips.c: Put SFDP-capable chip back into position Put entry for Unknown SFDP-capable chip back into place at end of file. SHA 1f9cc7d89992114c70f7a0545ad9f98701bebe56 reordered many entries in flashchips.c, including this one. However, the entry for Unknown, SFDP-capable chip should not have been moved before any specific chip entries. As reported by Angel Pons <th3fanbus(a)gmail.com> at https://review.coreboot.org/c/flashrom/+/33931: """ Oops, this introduced a bug: the SFDP entry is no longer at the end of flashchips.c, so probing on a SFDP-capable Winbond chip results in added noise (flashrom says things about an unknown chip, and then has two definitions for the same chip). """ Signed-off-by: Alan Green <avg(a)google.com> Change-Id: I5955020456dbcd5e7db280a459b668a743e464dc --- M flashchips.c 1 file changed, 22 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/37/35037/1 diff --git a/flashchips.c b/flashchips.c index c6f9517..9b686c1 100644 --- a/flashchips.c +++ b/flashchips.c @@ -15612,28 +15612,6 @@ }, { - .vendor = "Unknown", - .name = "SFDP-capable chip", - .bustype = BUS_SPI, - .manufacture_id = GENERIC_MANUF_ID, - .model_id = SFDP_DEVICE_ID, - .total_size = 0, /* set by probing function */ - .page_size = 0, /* set by probing function */ - .feature_bits = 0, /* set by probing function */ - /* We present our own "report this" text hence we do not */ - /* want the default "This flash part has status UNTESTED..." */ - /* text to be printed. */ - .tested = TEST_OK_PREW, - .probe = probe_spi_sfdp, - .block_erasers = {}, /* set by probing function */ - .unlock = spi_disable_blockprotect, /* is this safe? */ - .write = NULL, /* set by probing function */ - .read = spi_chip_read, - /* FIXME: some vendor extensions define this */ - .voltage = {0}, - }, - - { .vendor = "Winbond", .name = "W25P16", .bustype = BUS_SPI, @@ -17576,6 +17554,28 @@ }, { + .vendor = "Unknown", + .name = "SFDP-capable chip", + .bustype = BUS_SPI, + .manufacture_id = GENERIC_MANUF_ID, + .model_id = SFDP_DEVICE_ID, + .total_size = 0, /* set by probing function */ + .page_size = 0, /* set by probing function */ + .feature_bits = 0, /* set by probing function */ + /* We present our own "report this" text hence we do not */ + /* want the default "This flash part has status UNTESTED..." */ + /* text to be printed. */ + .tested = TEST_OK_PREW, + .probe = probe_spi_sfdp, + .block_erasers = {}, /* set by probing function */ + .unlock = spi_disable_blockprotect, /* is this safe? */ + .write = NULL, /* set by probing function */ + .read = spi_chip_read, + /* FIXME: some vendor extensions define this */ + .voltage = {0}, + }, + + { .vendor = "Programmer", .name = "Opaque flash chip", .bustype = BUS_PROG, -- To view, visit https://review.coreboot.org/c/flashrom/+/35037 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5955020456dbcd5e7db280a459b668a743e464dc Gerrit-Change-Number: 35037 Gerrit-PatchSet: 1 Gerrit-Owner: Alan Green <avg(a)google.com> Gerrit-MessageType: newchange

3 9

Change in flashrom[staging]: spi: add opcodes for fast read and 4BA direct read
by David Hendricks (Code Review) 07 Sep '19

07 Sep '19

David Hendricks has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/19857 ) Change subject: spi: add opcodes for fast read and 4BA direct read ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/19857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Change-Id: Ic6dfab2dc48379b9b9c0d0a7551f9d294ce0a23a Gerrit-Change-Number: 19857 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in flashrom[staging]: dediprog: 4BA support
by David Hendricks (Code Review) 07 Sep '19

07 Sep '19

David Hendricks has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/19858 ) Change subject: dediprog: 4BA support ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/19858 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Change-Id: Ia7a27c97bc736e6f3dc9a5c3b44b52270f638a8f Gerrit-Change-Number: 19858 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in flashrom[stable]: Initial MX25L25635F support
by David Hendricks (Code Review) 07 Sep '19

07 Sep '19

David Hendricks has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/19528 ) Change subject: Initial MX25L25635F support ...................................................................... Abandoned Moved to a different branch and merged: https://review.coreboot.org/c/flashrom/+/19855/ -- To view, visit https://review.coreboot.org/c/flashrom/+/19528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-Change-Id: I292e12d92cdf3961b8d47492a1d5679ff1ea21ce Gerrit-Change-Number: 19528 Gerrit-PatchSet: 1 Gerrit-Owner: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in flashrom[stable]: Mark Spansion S25FL128P(0) tested for PREW
by David Hendricks (Code Review) 07 Sep '19

07 Sep '19

David Hendricks has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/19531 ) Change subject: Mark Spansion S25FL128P(0) tested for PREW ...................................................................... Abandoned Merged as https://review.coreboot.org/c/flashrom/+/28866 -- To view, visit https://review.coreboot.org/c/flashrom/+/19531 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-Change-Id: I4b4e3673f7019f38a3b6ab2f7002bbe56dc6de07 Gerrit-Change-Number: 19531 Gerrit-PatchSet: 3 Gerrit-Owner: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in flashrom[stable]: 4ba patches
by David Hendricks (Code Review) 07 Sep '19

07 Sep '19

David Hendricks has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/19525 ) Change subject: 4ba patches ...................................................................... Abandoned Obsolete; 4BA support has been merged -- To view, visit https://review.coreboot.org/c/flashrom/+/19525 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-Change-Id: I2b69a7a537726349742edc3a00054c39b732ac36 Gerrit-Change-Number: 19525 Gerrit-PatchSet: 1 Gerrit-Owner: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in flashrom[stable]: Initial MX66L51235F support
by David Hendricks (Code Review) 07 Sep '19

07 Sep '19

David Hendricks has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/19529 ) Change subject: Initial MX66L51235F support ...................................................................... Abandoned Moved to a different branch and merged: https://review.coreboot.org/c/flashrom/+/19856/ -- To view, visit https://review.coreboot.org/c/flashrom/+/19529 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-Change-Id: I94bee2832469d2df399a09e2f535a107edaec3e7 Gerrit-Change-Number: 19529 Gerrit-PatchSet: 1 Gerrit-Owner: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in flashrom[master]: improve termios settings on some OSes
by David Hendricks (Code Review) 07 Sep '19

07 Sep '19

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/23693 ) Change subject: improve termios settings on some OSes ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Need to figure out what to do with ECHOCTL and ECHOKE. https://review.coreboot.org/c/flashrom/+/23693/2/serial.c File serial.c: https://review.coreboot.org/c/flashrom/+/23693/2/serial.c@215 PS2, Line 215: wanted.c_lflag &= ~(ECHOCTL | ECHOKE); According to the Open Group [1] these two flags should generally be avoided for portability. Also, the GNU libc manual [2] notes that there are BSD extensions and exist "only in BSD systems and GNU/Linux and GNU/Hurd systems." So I guess if this line is included, we should wrap it with a #if for the BSDs and GNU? Or '#if !defined( _POSIX_SOURCE)'? [1] https://pubs.opengroup.org/onlinepubs/7908799/xsh/termios.h.html [2] https://www.gnu.org/software/libc/manual/html_node/Local-Modes.html -- To view, visit https://review.coreboot.org/c/flashrom/+/23693 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5da80f541e02c3b8e676e47a45388bfb115b4762 Gerrit-Change-Number: 23693 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jonathan A. Kollasch <jakllsch(a)kollasch.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 07 Sep 2019 23:15:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2019