June 2019 - flashrom-gerrit - mail.coreboot.org

Change in ...flashrom[master]: [NOTFORMERGE] Do not try to map SPI flash chips
by Nico Huber (Code Review) 20 Jun '19

20 Jun '19

Nico Huber has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/23344 ) Change subject: [NOTFORMERGE] Do not try to map SPI flash chips ...................................................................... Abandoned Mapping should be handled at programmer level. -- To view, visit https://review.coreboot.org/c/flashrom/+/23344 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I57350f65211b4c0ae2a285ee1b1151a6e6bfa031 Gerrit-Change-Number: 23344 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...flashrom[staging]: util/getrevision.sh: Change version string
by Nico Huber (Code Review) 20 Jun '19

20 Jun '19

Nico Huber has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/20263 ) Change subject: util/getrevision.sh: Change version string ...................................................................... Abandoned Owner said "No longer needed." -- To view, visit https://review.coreboot.org/c/flashrom/+/20263 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Change-Id: Id6de60be4c751c070d4da648825a7e7b70e4a759 Gerrit-Change-Number: 20263 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...flashrom[staging]: spi: Drop spi_controller type
by Nico Huber (Code Review) 20 Jun '19

20 Jun '19

Nico Huber has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/19421 ) Change subject: spi: Drop spi_controller type ...................................................................... Abandoned Cherry picked to master. -- To view, visit https://review.coreboot.org/c/flashrom/+/19421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Change-Id: I8eda93b429e3ebaef79e22aba76be62987e496f4 Gerrit-Change-Number: 19421 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...flashrom[staging]: spi25: Fix layering violation in probe_spi_rdid4()
by Nico Huber (Code Review) 20 Jun '19

20 Jun '19

Nico Huber has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/19420 ) Change subject: spi25: Fix layering violation in probe_spi_rdid4() ...................................................................... Abandoned Cherry picked to master. -- To view, visit https://review.coreboot.org/c/flashrom/+/19420 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Change-Id: Idd21d20465cb214f3ff5bf3267b9014f8beee3f3 Gerrit-Change-Number: 19420 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...flashrom[staging]: spi25: Fix layering violation in default_spi_write_aai()
by Nico Huber (Code Review) 20 Jun '19

20 Jun '19

Nico Huber has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/19419 ) Change subject: spi25: Fix layering violation in default_spi_write_aai() ...................................................................... Abandoned Cherry picked to master. -- To view, visit https://review.coreboot.org/c/flashrom/+/19419 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Change-Id: I8aa3e2992f64906edc669060936f9522d32637fb Gerrit-Change-Number: 19419 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...flashrom[master]: print: Update Asus URLs to use more secure HTTPS
by Nico Huber (Code Review) 20 Jun '19

20 Jun '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/21874 ) Change subject: print: Update Asus URLs to use more secure HTTPS ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/21874 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I62319bfbf39c73f98ed3f865a11f4fe870befee4 Gerrit-Change-Number: 21874 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 20 Jun 2019 18:23:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...flashrom[staging]: print: Update Asus URLs to use more secure HTTPS
by Paul Menzel (Code Review) 20 Jun '19

20 Jun '19

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/22354 ) Change subject: print: Update Asus URLs to use more secure HTTPS ...................................................................... Patch Set 3: Can be abandoned in favor of https://review.coreboot.org/c/flashrom/+/21874 . -- To view, visit https://review.coreboot.org/c/flashrom/+/22354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Change-Id: I62319bfbf39c73f98ed3f865a11f4fe870befee4 Gerrit-Change-Number: 22354 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Thu, 20 Jun 2019 15:47:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...flashrom[master]: print: Update Asus URLs to use more secure HTTPS
by Paul Menzel (Code Review) 20 Jun '19

20 Jun '19

Hello Stefan Tauner, David Hendricks, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/21874 to look at the new patch set (#3). Change subject: print: Update Asus URLs to use more secure HTTPS ...................................................................... print: Update Asus URLs to use more secure HTTPS Asus set up HTTPS for their site, and redirects to that by default. So, use this by default, which also saves one redirect. ``` $ curl -I http://www.asus.com/ HTTP/1.1 301 Moved Permanently Content-Length: 0 Location: https://www.asus.com/ Date: Wed, 04 Oct 2017 11:15:14 GMT Connection: keep-alive X-Akamai-Device-Characteristics: desktop X-Akamai-Device-Model: ; ; cURL; cURL ``` Use the command below to change the occurrences. ``` sed -i 's,http://www.asus.com,https://www.asus.com,g' print.c ``` Change-Id: I62319bfbf39c73f98ed3f865a11f4fe870befee4 Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- M print.c 1 file changed, 113 insertions(+), 113 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/74/21874/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/21874 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I62319bfbf39c73f98ed3f865a11f4fe870befee4 Gerrit-Change-Number: 21874 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...flashrom[master]: print: Update Asus URLs to use more secure HTTPS
by Paul Menzel (Code Review) 20 Jun '19

20 Jun '19

Paul Menzel has restored this change. ( https://review.coreboot.org/c/flashrom/+/21874 ) Change subject: print: Update Asus URLs to use more secure HTTPS ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/flashrom/+/21874 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I62319bfbf39c73f98ed3f865a11f4fe870befee4 Gerrit-Change-Number: 21874 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: restore

1 0

Change in ...flashrom[staging]: bitbang_spi: Drop bitbang_spi_master_type
by Nico Huber (Code Review) 20 Jun '19

20 Jun '19

Nico Huber has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/19417 ) Change subject: bitbang_spi: Drop bitbang_spi_master_type ...................................................................... Abandoned Cherry-picked for master branch. -- To view, visit https://review.coreboot.org/c/flashrom/+/19417 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Change-Id: I7a3b5d9ff1e99d2d4f873c6f19fb318f93762037 Gerrit-Change-Number: 19417 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2019