flashrom-gerrit May 2019

flashrom-gerrit@flashrom.org

1 participants
24 discussions

Change in ...flashrom[master]: usbdev: Only match requested USB devices
by Patrick Rudolph (Code Review) 27 May '19

27 May '19

Hello Patrick Rudolph, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/32891 to review the following change. Change subject: usbdev: Only match requested USB devices ...................................................................... usbdev: Only match requested USB devices Don't use a device that has the same vendor ID, but a different than requested product ID. Fixes broken dediprog detection with TOMU in use. Change-Id: I08c1c363ce2d6603e46efecc61d3910e02314fca Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M usbdev.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/32891/1 diff --git a/usbdev.c b/usbdev.c index d793b65..764ac04 100644 --- a/usbdev.c +++ b/usbdev.c @@ -54,7 +54,7 @@ continue; } - if ((desc.idVendor != vid) && (desc.idProduct != pid)) + if ((desc.idVendor != vid) || (desc.idProduct != pid)) continue; msg_pdbg("Found USB device %04"PRIx16":%04"PRIx16" at address %d-%d.\n", -- To view, visit https://review.coreboot.org/c/flashrom/+/32891 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I08c1c363ce2d6603e46efecc61d3910e02314fca Gerrit-Change-Number: 32891 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newchange

4 3

Change in ...flashrom[1.1.x]: usbdev: Only match requested USB devices
by Nico Huber (Code Review) 20 May '19

20 May '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/32892 ) Change subject: usbdev: Only match requested USB devices ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/32892 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.1.x Gerrit-Change-Id: I08c1c363ce2d6603e46efecc61d3910e02314fca Gerrit-Change-Number: 32892 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Mon, 20 May 2019 10:30:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...flashrom[staging]: Initial ISSI IS25LP256/IS25WP256 support
by David Hendricks (Code Review) 20 May '19

20 May '19

David Hendricks has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/20514 ) Change subject: Initial ISSI IS25LP256/IS25WP256 support ...................................................................... Abandoned Merged in master branch: https://review.coreboot.org/c/flashrom/+/29306 -- To view, visit https://review.coreboot.org/c/flashrom/+/20514 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Change-Id: I529e6cd3553a0ea0fdc62fd55796485e326f1458 Gerrit-Change-Number: 20514 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...flashrom[master]: ich_descriptors_tool: Fix -Wmissing-braces warning
by Alex James (Code Review) 11 May '19

11 May '19

Alex James has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/31973 Change subject: ich_descriptors_tool: Fix -Wmissing-braces warning ...................................................................... ich_descriptors_tool: Fix -Wmissing-braces warning This fix is needed for Clang. Change-Id: I3cbf6bb6bdc34b812c2321c6674051af991362b4 Signed-off-by: Alex James <theracermaster(a)gmail.com> --- M util/ich_descriptors_tool/ich_descriptors_tool.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/73/31973/1 diff --git a/util/ich_descriptors_tool/ich_descriptors_tool.c b/util/ich_descriptors_tool/ich_descriptors_tool.c index aa857c8..c71ef79 100644 --- a/util/ich_descriptors_tool/ich_descriptors_tool.c +++ b/util/ich_descriptors_tool/ich_descriptors_tool.c @@ -150,7 +150,7 @@ const char *fn = NULL; const char *csn = NULL; enum ich_chipset cs = CHIPSET_ICH_UNKNOWN; - struct ich_descriptors desc = { 0 }; + struct ich_descriptors desc = {{0}}; while ((opt = getopt(argc, argv, "df:c:")) != -1) { switch (opt) { -- To view, visit https://review.coreboot.org/c/flashrom/+/31973 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3cbf6bb6bdc34b812c2321c6674051af991362b4 Gerrit-Change-Number: 31973 Gerrit-PatchSet: 1 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-MessageType: newchange

4 6

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2019